h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 16:50:21 +08:00
Code Issues Releases Wiki Activity

Add some lenience around mod customisation expanding overlay

Browse Source 
It was quite easy to dismiss by accident. I've added some positional and
time based lenience with numbers that feel good to me. Open to
discussion on whether both are required and if the numbers feel good.

Going forward, at some point, we'll likely want to standardise this
across to other expand-on-hover elements (like player load overlays).

Addresses https://github.com/ppy/osu/discussions/32368.
This commit is contained in:
Dean Herbert
2025-03-19 12:45:27 +09:00
Unverified
parent c9c60424a1
commit 52dad654f7
1 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Overlays/Mods/ModCustomisationPanel.cs
+17 -4
View File
@@ -223,15 +223,28 @@ namespace osu.Game.Overlays.Mods
inputManager = GetContainingInputManager()!;
}
private double timeUntilCollapse;
private const double collapse_grace_time = 180;
private const float collapse_grace_position = 40;
protected override void Update()
{
base.Update();
if (ExpandedState.Value == ModCustomisationPanelState.Expanded
&& !ReceivePositionalInputAt(inputManager.CurrentState.Mouse.Position)
&& inputManager.DraggedDrawable == null)
if (ExpandedState.Value == ModCustomisationPanelState.Expanded)
{
ExpandedState.Value = ModCustomisationPanelState.Collapsed;
bool canCollapse = !DrawRectangle.Inflate(new Vector2(collapse_grace_position)).Contains(ToLocalSpace(inputManager.CurrentState.Mouse.Position))
&& inputManager.DraggedDrawable == null;
if (canCollapse)
{
if (timeUntilCollapse <= 0)
ExpandedState.Value = ModCustomisationPanelState.Collapsed;
timeUntilCollapse -= Time.Elapsed;
}
else
timeUntilCollapse = collapse_grace_time;
}
}
}