63481 Commits

This Branch

This Branch

All Branches

• Fix background crash on a beatmap with no storyboard
  Salman Ahmed · 2023-11-09 22:57:20 +03:00
  768a31b2f5
• Unload beatmap storyboard background when no longer present
  Salman Ahmed · 2023-11-09 17:20:11 +03:00
  bd8409219f
• Add failing test case
  Salman Ahmed · 2023-11-09 17:20:10 +03:00
  d4722a3988
• Merge pull request #25364 from frenzibyte/fix-resume-cursor-following-settings

  Fix resume cursor following gameplay cursor scale setting

  Dean Herbert · 2023-11-07 21:57:00 +09:00
  34219c1103
• Move static method to end of file
  Dean Herbert · 2023-11-07 21:08:49 +09:00
  7bedf7cf16
• Add failing test coverage
  Dean Herbert · 2023-11-07 19:54:21 +09:00
  38c9a98e67
• Merge pull request #25377 from bdach/system-mod-better-colours
  Dean Herbert · 2023-11-07 05:08:47 +09:00
  ed02335e3e
• Just use yellow for system mods
  Bartłomiej Dach · 2023-11-06 16:40:57 +01:00
  a136f272cf
• Allow tinkering with cursor-related settings in resume overlay test scene
  Salman Ahmed · 2023-11-06 18:35:46 +03:00
  073249dafb
• Update existing test coverage
  Salman Ahmed · 2023-11-06 18:35:30 +03:00
  e12ee29a94
• Move cursor scale application within OsuCursor

  Doing so takes down two birds with one stone.
   1. `ResumeOverlay` having to manually apply cursor scale to its "resume
  cursor".
   2. Resume cursor input handling scaling up with the gameplay setting. Now, only the sprite itself gets scaled.

  Salman Ahmed · 2023-11-06 18:30:55 +03:00
  75fbbb35ad
• Revert gameplay cursor scale changes
  Salman Ahmed · 2023-11-06 17:37:32 +03:00
  915feeffb0
• Merge pull request #25376 from peppy/verify-screen-refresh-on-enter

  Automatically refresh the verify screen's issue list on re-entering it

  Bartłomiej Dach · 2023-11-06 12:40:11 +01:00
  9f6304b9ab
• Fix unused variable
  Bartłomiej Dach · 2023-11-06 12:18:02 +01:00
  4bc36a6c90
• Use better colours for system mods
  Bartłomiej Dach · 2023-11-06 11:41:23 +01:00
  6deac9a5a4
• Automatically refresh the verify screen's issue list on re-entering it

  Addresses https://github.com/ppy/osu/discussions/25365.

  Dean Herbert · 2023-11-06 19:34:36 +09:00
  51c891e2e4
• Merge pull request #25375 from peppy/reset-rotation-skin-editor

  Add skin editor dropdown items to reset rotation and scale

  Bartłomiej Dach · 2023-11-06 09:38:48 +01:00
  408ae84111
• Merge pull request #25374 from peppy/add-skinnable-player-name

  Add player name skin component

  Bartłomiej Dach · 2023-11-06 09:34:11 +01:00
  41cd9a4db6
• Merge pull request #25349 from Joehuu/argon-key-counter-upright

  Keep `ArgonKeyCounterDisplay` text upright

  Bartłomiej Dach · 2023-11-06 09:19:49 +01:00
  5ef8500d2a
• Add test coverage for player name skin component
  Bartłomiej Dach · 2023-11-06 08:51:31 +01:00
  69d6feb5a8
• Use left aligned text for non-rotate key counter
  Dean Herbert · 2023-11-06 16:32:12 +09:00
  0915ac8891
• Add skin editor dropdown items to reset rotation and scale
  Dean Herbert · 2023-11-06 16:18:33 +09:00
  1f0b914251
• Add player name skin component

  3 minute implementation.
  
  Addresses https://github.com/ppy/osu/discussions/25340.

  Dean Herbert · 2023-11-06 15:24:16 +09:00
  e2b07628fb
• Rename container
  Salman Ahmed · 2023-11-05 06:34:09 +03:00
  9cb331641c
• Tidy up resume overlay test scene
  Salman Ahmed · 2023-11-05 06:28:51 +03:00
  99405a2bbd
• Fix resume cursor following gameplay cursor scale setting
  Salman Ahmed · 2023-11-05 06:28:10 +03:00
  48a75f6152
• Add 100 and 1000 key press step to test overflow
  Joseph Madamba · 2023-11-02 20:49:01 -07:00
  3f8baf913b
• Fix test overflowing on widescreen + add default (triangles) key counter testing
  Joseph Madamba · 2023-11-02 20:42:28 -07:00
  e3b3ce6c84
• Fix text positioning
  Joseph Madamba · 2023-11-02 20:42:28 -07:00
  16731ff85f
• Fix UprightAspectMaintainingContainer not being centred
  Joseph Madamba · 2023-11-02 20:42:28 -07:00
  b3dfe19472
• Apply peppy's upright key counter attempt diff

  Co-Authored-By: Dean Herbert <pe@ppy.sh>

  Joseph Madamba · 2023-11-02 20:42:23 -07:00
  090601b485
• Merge pull request #25341 from peppy/slider-combo-matching

  Rename and invert flags for slider classic behaviours

  Dan Balasescu · 2023-11-03 11:27:22 +09:00
  bc9cdb4ce0
• Update xmldoc to match flipped flag semantics
  Bartłomiej Dach · 2023-11-02 18:58:14 +01:00
  a0757ce13f
• Clean up comment
  Bartłomiej Dach · 2023-11-02 18:52:47 +01:00
  86ede717cb
• Remove nested ternary
  Dean Herbert · 2023-11-02 23:42:52 +09:00
  ac6fb386d1
• Merge pull request #25336 from peppy/mania-key-expand-mobile

  Add support for "argon" default skin to expand columns when on mobile devices

  Bartłomiej Dach · 2023-11-02 12:40:57 +01:00
  efb4458061
• Merge branch 'master' into mania-key-expand-mobile
  Bartłomiej Dach · 2023-11-02 11:59:01 +01:00
  998d709331
• Adjust sizing slightly to ensure we stay within 1366 limits
  Dean Herbert · 2023-11-02 11:44:36 +01:00
  704f5a6de3
• Merge pull request #25338 from peppy/mania-mod-ordering

  Change osu!mania conversion mod ordering to be more appeasing

  Bartłomiej Dach · 2023-11-02 10:46:32 +01:00
  e18d0b64de
• Simplify classic behaviour flag to only need to be specified on the slider itself
  Dean Herbert · 2023-11-02 18:31:29 +09:00
  bf9f20705f
• Add better commenting around DrawableSliderHead logic
  Dean Herbert · 2023-11-02 18:31:28 +09:00
  a7705284e7
• Remove redundant passing of Scale to nested objects
  Dean Herbert · 2023-11-02 17:52:10 +09:00
  9af2a5930c
• Rename and invert flags for slider classic behaviours
  Dean Herbert · 2023-11-02 17:43:21 +09:00
  9c1f4b552e
• Merge pull request #25334 from peppy/fix-bubble-crash-again

  Fix another potential crash in bubbles mod

  Bartłomiej Dach · 2023-11-02 09:32:09 +01:00
  64feea80db
• Merge pull request #25333 from peppy/fix-spinner-performance

  Fix all spinner ticks being alive and causing performance degradation

  Bartłomiej Dach · 2023-11-02 09:07:44 +01:00
  b7ab886848
• Trim redundant comments
  Bartłomiej Dach · 2023-11-02 08:18:37 +01:00
  ad82ada030
• Change osu!mania conversion mod ordering to be more appeasing
  Dean Herbert · 2023-11-02 15:49:10 +09:00
  c83589cb74
• Add support for "argon" default skin to expand columns when on mobile device

  Should ease those looking to play the game on mobile until we
  (potentially) have a better solution in the future.
  
  If this works out well, we can consider rolling it out to other skins.
  
  Closes https://github.com/ppy/osu/issues/23377.

  Dean Herbert · 2023-11-02 15:13:44 +09:00
  6dab5ee4cf
• Fix another potential crash in bubbles mod

  Storing `DrawableHitObject` for later use is not safe – especially
  when accessing `HitObject` – as it's a pooled class. In the case here,
  it's important to note that `PrepareForUse` can be called a frame or
  more later in execution, which made this unsafe.
  
  Closes https://github.com/ppy/osu/issues/24444.

  Dean Herbert · 2023-11-02 02:43:51 +09:00
  48bdeaeff1
• Fix all spinner ticks being alive and causing performance degradation

  Regressed in https://github.com/ppy/osu/pull/25216.
  
  The new logic will ensure at least one tick is ready for judgement.
  There shouldn't be a case where more than one is needed in a single
  frame.

  Dean Herbert · 2023-11-01 18:28:07 +09:00
  c2de03aa44