63670 Commits

This Branch

This Branch

All Branches

• Move song select touch detector to solo implementation

  It should not run in multiplayer. Even if we wanted to allow touch-only
  playlist items at some point, the current behaviour of multiplayer song
  selects with respect to touch device mod is currently just broken.

  Bartłomiej Dach · 2023-11-14 16:35:16 +09:00
  70d2de5669
• Fix touch device mod declared valid for multiplayer

  Mostly matters for web, so that it doesn't permit creation of playlist
  items with touch device inside.

  Bartłomiej Dach · 2023-11-14 16:30:10 +09:00
  69c2c0e427
• Merge pull request #25411 from peppy/fix-key-counter-sizing-woes

  Refactor `KeyCounterDisplay` to use autosize

  Bartłomiej Dach · 2023-11-12 20:47:55 +09:00
  2023.1114.0 bb2f38d189
• Increase size and adjust positioning of max combo display in argon skin
  Dean Herbert · 2023-11-12 17:28:15 +09:00
  469b9e2546
• Merge branch 'master' into fix-key-counter-sizing-woes
  Bartłomiej Dach · 2023-11-12 17:23:31 +09:00
  7d26de723a
• Disable new rider EAP inspection in test class
  Dean Herbert · 2023-11-12 17:21:17 +09:00
  31feeb5ddc
• Refactor KeyCounterDisplay to use autosize

  A previous attempt at this was unsuccessful due to a partially
  off-screen elements not getting the correct size early enough (see
  https://github.com/ppy/osu/issues/14793). This can be accounted for by
  setting `AlwaysPresent` when visibility is expected.
  
  This fixes [test failures](https://github.com/ppy/osu/actions/runs/6838444698/job/18595535795)
  due to the newly added `Width` / `Height` being persisted with
  floating-point errors (by not persisting the values in the first place,
  via `AutoSize.Both`).

  Dean Herbert · 2023-11-12 17:19:25 +09:00
  798e677c09
• Merge pull request #25226 from frenzibyte/gameplay-hud-redesign/counters
  Dean Herbert · 2023-11-12 12:14:26 +09:00
  b995c96dca
• Fix one more reference to removed setting
  Bartłomiej Dach · 2023-11-12 07:42:41 +09:00
  3e8c89e282
• Merge branch 'master' into gameplay-hud-redesign/counters
  Bartłomiej Dach · 2023-11-12 07:33:50 +09:00
  c3201d5944
• Merge pull request #25402 from peppy/skin-size-editing

  Add support for adjusting size of skin elements

  Bartłomiej Dach · 2023-11-12 07:31:51 +09:00
  ccfdf1ffd6
• Merge branch 'master' into gameplay-hud-redesign/counters
  Dean Herbert · 2023-11-11 22:38:39 +09:00
  04a16b3596
• Merge pull request #25408 from peppy/skin-editor-export

  Add "export" item to skin editor menu

  Bartłomiej Dach · 2023-11-11 21:48:21 +09:00
  c5bbd5ac8a
• Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
  Bartłomiej Dach · 2023-11-11 21:28:29 +09:00
  ea556abad8
• Fix song progress bars not sizing vertically properly
  Bartłomiej Dach · 2023-11-11 21:28:04 +09:00
  50789d2e18
• Use barely better assertion fail message in test
  Bartłomiej Dach · 2023-11-11 20:56:05 +09:00
  ee56b4d205
• Fix argon health display not handling invalidation correctly
  Bartłomiej Dach · 2023-11-11 20:42:45 +09:00
  870e4ce27e
• Add "export" item to skin editor menu
  Dean Herbert · 2023-11-11 20:34:35 +09:00
  b0aa4a4257
• Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
  Bartłomiej Dach · 2023-11-11 20:16:14 +09:00
  b7972e3c84
• Merge pull request #25407 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-11-11 20:15:07 +09:00
  ed59a379f1
• Merge branch 'master' into skin-size-editing
  Bartłomiej Dach · 2023-11-11 19:56:09 +09:00
  8d7539ab70
• Merge pull request #25406 from bdach/skin-editor-bad

  Fix skin editor not clearing undo history on skin change

  Bartłomiej Dach · 2023-11-11 19:55:04 +09:00
  4b3fd1716a
• Update framework
  Dean Herbert · 2023-11-11 19:48:56 +09:00
  61d336521d
• Revert test changes

  They were broken because `SerialisedDrawableInfo` is a reference type
  and as such equality checks will use reference equality rather than
  member equality.

  Bartłomiej Dach · 2023-11-11 19:32:46 +09:00
  b247b94ecb
• Fix editor not clearing undo history on skin change
  Bartłomiej Dach · 2023-11-11 18:49:44 +09:00
  2428a97d44
• Remove unused using directive
  Bartłomiej Dach · 2023-11-11 15:52:24 +09:00
  21e1d68b15
• Improve test comparison logic

  Doesn't really help that much with nunit output,
  but at least you can breakpoint and see the json kinda.

  Dean Herbert · 2023-11-10 20:00:51 +09:00
  2e48569982
• Flip comparison to allow non-composite drawables to still get resized
  Dean Herbert · 2023-11-10 20:00:20 +09:00
  57cd5194ce
• Only store width/height of serialised drawable if it isn't automatically computed
  Bartłomiej Dach · 2023-11-10 19:12:26 +09:00
  b7acbde719
• Remove another reference to bar length
  Bartłomiej Dach · 2023-11-10 18:26:08 +09:00
  ec2200d54f
• Remove unused using directive
  Bartłomiej Dach · 2023-11-10 18:25:39 +09:00
  26eae0bdee
• Fix typo
  Bartłomiej Dach · 2023-11-10 18:20:14 +09:00
  43a4b34295
• Merge branch 'master' into skin-size-editing
  Bartłomiej Dach · 2023-11-10 18:19:27 +09:00
  c522a703eb
• Remove argon health display bar length setting

  It is no longer needed.
  
  Intentionally not doing backwards migration to simplify things; users
  can fix their skins.

  Bartłomiej Dach · 2023-11-10 18:18:58 +09:00
  374e13b496
• Fix test failures due to fluctuations in needlessly-serialised automatic sizings
  Bartłomiej Dach · 2023-11-10 18:13:36 +09:00
  2c1f304f3b
• Merge pull request #25348 from bdach/less-basic-touchscreen-detection

  Implement basic touchscreen detection

  Dean Herbert · 2023-11-10 18:01:40 +09:00
  1c63f1f89d
• Rename diagonal scale variable and update xmldoc
  Dean Herbert · 2023-11-10 17:55:02 +09:00
  35e11c7c63
• Check X/Y sizing available separately to fix weird edge cases
  Dean Herbert · 2023-11-10 17:54:43 +09:00
  f25489cc7b
• Add comment explaining AutoSize change in LegacySongProgress
  Dean Herbert · 2023-11-10 17:53:52 +09:00
  46a219e010
• Merge pull request #25403 from smoogipoo/attempt-fix-diffcalc-quotes

  Attempt to support quotes in handling of GH comment body

  Dean Herbert · 2023-11-10 16:59:17 +09:00
  74ccb0873e
• Adjust combo animation slightly
  Dean Herbert · 2023-11-10 16:53:16 +09:00
  a02aeed50a
• Remove ArgonScoreWedge and use ArgonWedgePiece directly
  Dean Herbert · 2023-11-10 16:53:16 +09:00
  67312a2db9
• Remove width/height bindables from ArgonWedgePiece
  Dean Herbert · 2023-11-10 16:53:15 +09:00
  b4ec62473e
• Update deserialising test
  Dean Herbert · 2023-11-10 16:53:15 +09:00
  fa5921862f
• Make sure test is in a break

  ...because apparently it may take a while to update the flag.

  Bartłomiej Dach · 2023-11-10 16:30:44 +09:00
  b7938e78a0
• Merge pull request #25399 from Susko3/mobile-touch-settings

  Show touch input settings on mobile

  Dean Herbert · 2023-11-10 16:25:01 +09:00
  7c4e9506da
• Update resources
  Dean Herbert · 2023-11-10 16:20:05 +09:00
  7db14baed7
• Rename RoundedLine to BoxElement and make more generically useful
  Dean Herbert · 2023-11-10 16:20:05 +09:00
  60df2722ab
• Fix compose select box test failures
  Bartłomiej Dach · 2023-11-10 16:08:45 +09:00
  8690b08769
• Rewrite tests to not rely on realtime clock

  Definitely faster, hopefully more reliable too.

  Bartłomiej Dach · 2023-11-10 15:53:25 +09:00
  1818a84034