Salman Ahmed
d4aedaf22d
Always show search bar in skin dropdown for visibility
2023-12-05 22:53:48 +03:00
Salman Ahmed
d92db8059e
Add new dropdown properties to SettingsDropdown
2023-12-05 22:53:48 +03:00
Dean Herbert
51de98f341
Use Logger.Storage rather than locally querying
2023-11-28 17:59:21 +09:00
Dean Herbert
4c2819dbc2
Update button text and make localisable
2023-11-28 17:59:05 +09:00
Dean Herbert
11f1f44237
Add button to compress log files for bug submission
2023-11-27 17:13:11 +09:00
Dean Herbert
ff18f80559
Apply NRT to UpdateSettings
2023-11-27 16:56:11 +09:00
Susko3
51cf85a9ab
Add touch input settings to android
...
Also updates touch settings so the touch handler can't be disabled on mobile.
2023-11-09 14:52:15 +01:00
Dean Herbert
3e257f1e6c
Remove unused using statements
2023-11-07 23:21:51 +09:00
Susko3
fcd73e62d2
Remove mobile specific changes
...
Will be added back in a separate PR
2023-11-07 13:06:14 +01:00
Susko3
05d9418718
Rename setting to TouchDisableGameplayTaps for better visibility when searching
2023-11-07 00:13:46 +01:00
Susko3
f8b5ecc92a
Update UI to use the new setting
2023-11-06 21:07:15 +01:00
Susko3
fa1d1df594
Rename mouse button string to Disable clicks during gameplay
2023-11-05 12:43:14 +01:00
Susko3
86fb33cb90
Add disable taps checkbox to touch input settings
2023-11-05 12:40:06 +01:00
Bartłomiej Dach
9f5a280bc2
Fix key binding row fire-and-forgetting writes
...
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129
This is what happens if you carelessly fire and forget.
The working theory (that I'm not sure I have the tools to conclusively
confirm) is that the async write from the key binding changing could
fire _after_ the section is reset.
I briefly considered having the test wait for the change, but given that
the entirety of the surrounding flow is using sync operations, this just
looks like a bug to me. And there's no real sane way to inject async
into that flow due to dependence on `OsuButton.Action`.
2023-10-31 12:25:09 +01:00
Jamie Taylor
fbf8f52f7d
Add audio feedback for when keys are pressed during key binding
2023-10-20 21:01:37 +09:00
Jamie Taylor
6b28f85615
Change RevertToDefaultButton and BackButton to use Default sampleset instead
2023-10-20 21:01:36 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now
2023-10-17 17:48:45 +09:00
Dean Herbert
67a8a51ec7
Merge branch 'master' into generic-error-sfx
2023-10-14 03:56:41 +09:00
Jamie Taylor
d97b618d02
Use new generic-error sample in appropriate places
2023-10-13 21:06:50 +09:00
Dean Herbert
3d5736188e
Merge pull request #25112 from bdach/dangerous-button-shades
...
Fix dangerous buttons using different shades of pink
2023-10-13 20:43:24 +09:00
Bartłomiej Dach
af89d69fc4
Fix dangerous buttons using different shades of pink
2023-10-13 13:16:24 +02:00
Bartłomiej Dach
a88779e588
Use dimmed placeholder text instead of empty box on cleared bindings
2023-10-13 13:10:04 +02:00
Bartłomiej Dach
a1c68b66f2
Rename KeyBindingRow parts to appease CodeFileSanity
2023-10-13 12:06:25 +02:00
Dean Herbert
17b6ebbfbf
Avoid using a bindable in KeyBindingConflictPopover where data is never mutated
2023-10-13 18:40:21 +09:00
Dean Herbert
9b0c4acdef
Split KeyBindingRow out into partial pieces
2023-10-13 18:29:06 +09:00
Dean Herbert
8e609b6f1d
Switch records to classes for sanity
...
I don't have anything against records except for the capitalisation when
including the paramter names in a constructor.
ie. `new Record(This: 1);`
2023-10-13 18:19:12 +09:00
Dean Herbert
d7a06059f2
Rename string properties to give more hinting to localisers
2023-10-13 17:49:48 +09:00
Bartłomiej Dach
61b8d035fe
Use dangerous colour for "apply new" button
2023-10-13 09:08:13 +02:00
Bartłomiej Dach
f083309e64
Move type back next to exposing class
2023-10-12 20:26:01 +02:00
Bartłomiej Dach
f1c1ffbdfd
Add localisation support
2023-10-12 20:26:01 +02:00
Bartłomiej Dach
08bdea0036
Reformat code
2023-10-12 20:26:01 +02:00
Bartłomiej Dach
991e425b9a
Refactor conflict handling flow to be less back-and-forth
2023-10-12 20:25:59 +02:00
Bartłomiej Dach
9468371556
Fix min width not really working as intended
2023-10-12 16:04:46 +02:00
Bartłomiej Dach
b09252a8f8
Fix restore-to-default button for entire section triggering conflicts
2023-10-12 16:04:46 +02:00
Bartłomiej Dach
f5a6781e5a
Integrate key binding conflict popover into keybindings panel
2023-10-12 16:04:46 +02:00
Bartłomiej Dach
7b6563116a
Implement visual appearance of key binding conflict popover
2023-10-12 16:01:51 +02:00
Bartłomiej Dach
aa8dbd742e
Hoist database update to subsection level
...
The end goal here is to be able to better coordinate deconfliction of
bindings at the subsection level rather than try to jam that logic into
individual rows somehow.
The flipside is that this is going to require a flow to update the
individual rows after the subsection's intervention, but that's what the
previous commit was for.
2023-10-12 16:01:51 +02:00
Bartłomiej Dach
5f0b1d69a5
Prepare KeyBindingRow for accepting external changes
2023-10-12 16:00:20 +02:00
Bartłomiej Dach
c2e92cbb70
Refactor key binding panel leveraging new helper methods
2023-10-12 15:03:29 +02:00
Bartłomiej Dach
1c784c9abe
Add API for retrieving global key bindings per section
2023-10-12 14:24:21 +02:00
Bartłomiej Dach
712564ea4f
Enable NRT in KeyBindingsSubsection
2023-10-11 20:03:31 +02:00
Bartłomiej Dach
797109c05c
Enable NRT in KeyBindingRow
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
0b2b065383
Add xmldoc
2023-10-11 08:50:00 +02:00
Bartłomiej Dach
7ac874d17a
Use init-only properties where applicable
2023-10-11 08:49:58 +02:00
Bartłomiej Dach
1acc02405e
Reorder KeyBindingRow members
2023-10-11 08:18:59 +02:00
NiceAesth
83bf1efc1c
Add color search alias for colour settings
2023-09-27 16:29:29 +03:00
Bartłomiej Dach
3bddf4bf9a
Rename spectator-specific settings to more generic (with backwards migration)
2023-09-18 14:56:06 +02:00
Dean Herbert
d146da9546
Fix rate adjust mods not showing "x" prefix on customisation slider's tooltip
2023-09-13 16:43:48 +09:00
Joseph Madamba
73604d171a
Make "general" a common string
2023-09-05 23:00:07 -07:00
Bartłomiej Dach
7e61a10524
Merge pull request #24314 from peppy/reduce-settings-item-spacing
...
Reduce spacing in settings items
2023-07-22 13:15:19 +02:00
Dean Herbert
b5c3231feb
Fix SettingsNumberBox having additional margin
2023-07-21 15:46:28 +09:00
Dean Herbert
741c3b8d21
Reduce spacing in settings items
2023-07-21 15:39:40 +09:00
Dean Herbert
1bfe5a18cb
Rename RestoreDefaultValueButton to RevertToDefaultButton
...
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Bartłomiej Dach
ae2896ba7e
Sprinkle some more null-forgiving operators
2023-07-06 22:08:48 +02:00
Dean Herbert
a98a36872e
Bring realm library up-to-date
2023-07-06 13:37:43 +09:00
Dean Herbert
95a9b532df
Remember state of replay settings visibility
2023-07-06 00:53:37 +09:00
Bartłomiej Dach
a7202721ff
Merge branch 'master' into no-confirmation-on-update-restart
2023-06-25 13:35:21 +02:00
Bartłomiej Dach
354e85a2e1
Trim redundant BDL nullability spec
2023-06-24 14:35:23 +02:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dean Herbert
c3f772f0da
Add method to queue a restart after app is exited (when supported)
2023-06-21 19:06:28 +09:00
Dean Herbert
4cdd4561c4
Add a few more search keywords for offset settings
...
https://github.com/ppy/osu/discussions/23898#discussioncomment-6159206
2023-06-13 14:17:32 +09:00
Salman Ahmed
d523785bfc
Fix LanguageSettings requiring OsuGame as dependency
2023-06-08 03:27:23 +03:00
Salman Ahmed
1a90f71540
Centralise game language update logic
2023-06-08 02:59:34 +03:00
Dean Herbert
b3527b92b6
Handle case in tests where current display becomes null
2023-05-22 09:25:44 +09:00
Susko3
fec47fa690
Merge branch 'master' into use-atomic-ReplaceRange
...
This reverts 0dcf1b540e
2023-05-17 06:56:54 +02:00
Susko3
2d7fe68311
Prevent feedback by using atomic .ReplaceRange()
...
`display.NewValue` will never be null, checked on SDL + osuTK/Android.
On Android it's a 0x0 display, importantly not null.
2023-05-16 21:57:31 +02:00
Bartłomiej Dach
0dcf1b540e
Attempt to preserve old resolution when switching displays
2023-05-16 21:14:09 +02:00
Bartłomiej Dach
88ce627c8e
Avoid bindable/event feedback when changing resolution
2023-05-16 21:02:23 +02:00
Dean Herbert
c0f869e685
Fix some tablet settings being hidden when searching using "area" keyword
...
As discussed in https://github.com/ppy/osu/discussions/23504 .
2023-05-12 14:57:56 +09:00
tsrk
2d45d602a5
feat(settings): more keyword for first run setup
2023-05-11 15:03:42 +01:00
tsrk
c1a85658b7
feat(settings): add "import" as keywords for first run setup
2023-05-11 14:58:17 +01:00
Dan Balasescu
d2380bd840
Remove usages of [ExcludeFromDynamicCompile]
2023-05-08 18:12:56 +09:00
cdwcgt
4549a865d9
Merge branch 'master' into export
2023-05-04 00:18:01 +09:00
Dean Herbert
ab4f66fad3
Minor readability refactors
2023-05-02 14:31:39 +09:00
Dean Herbert
7a840e1d82
Remove unnecessary TransferValue spec
2023-05-02 14:29:26 +09:00
Dean Herbert
7efaa299bd
Merge branch 'master' into scale-background-dim
2023-05-02 14:24:54 +09:00
Dean Herbert
6929be49b7
Change condition for exclusive fullscreen notice to only show when using the correct renderer
...
This avoids the notice showing when running on windows, but using the
newer renderers (where the underlying logic hasn't been tested properly
and can result in false-positives).
Supersedes https://github.com/ppy/osu-framework/pull/5759 as a more
correct implementation.
2023-04-28 22:36:30 +09:00
cdwcgt
ce6a87b4a3
Merge remote-tracking branch 'upstream/master' into export
2023-04-09 15:02:47 +09:00
cdwcgt
de21b4a2f7
use Live<TModel>
...
Use RealmAccess only when needed
2023-04-09 22:21:15 +09:00
Susko3
c3a6a58169
Fix window mode dropdown not showing
2023-04-02 19:23:18 +02:00
Dean Herbert
cf5acbf66e
Update usage of SupportedWindowModes
2023-04-02 20:16:14 +09:00
cdwcgt
5d395e6d37
move to ctor
2023-03-29 22:59:54 +09:00
cdwcgt
e85c28031e
change weird name
2023-03-29 22:55:25 +09:00
cdwcgt
46ede27869
add feature to adjust ScalingContainer background dim
2023-03-28 22:41:24 +09:00
Dean Herbert
898717231b
Hide vulkan renderer option for now
...
We'll bring it back when it's more stable.
2023-03-27 02:00:10 +09:00
Bartłomiej Dach
292486c25a
Use more resilient restore method
2023-03-26 14:35:00 +02:00
Bartłomiej Dach
f3c174a7f2
Fix test errors due to missing dependencies
2023-03-26 13:52:26 +02:00
Dean Herbert
bab93bed17
Fix string interpolation and use GetDescription on renderer value
2023-03-26 20:43:28 +09:00
Dean Herbert
ba078e8357
Show "automatic" resolved renderer inline in dropdown instead
2023-03-26 20:29:30 +09:00
Dean Herbert
764361b3d3
Add special case to hide definitely non-working renderers on android
2023-03-26 20:14:33 +09:00
Dean Herbert
e346b02ebf
Add display of current renderer
2023-03-26 20:09:35 +09:00
Dean Herbert
ab6cfea5c7
Revert old value instead of always using default
...
Co-authored-by: cdwcgt <loginchen@outlook.com>
2023-03-23 11:27:05 +09:00
Dean Herbert
3050a16bf8
Don't require a restart when selecting Automatic and startup setting was also automatic
2023-03-22 16:56:36 +09:00
Dean Herbert
aabe86dc26
Limit renderers to those available for the current platform
2023-03-22 16:49:29 +09:00
Dean Herbert
956fabb445
Show restart notice when changing renderer
2023-03-22 16:49:29 +09:00
Dean Herbert
13be709718
Add basic renderer selection
2023-03-22 16:49:29 +09:00
Bartłomiej Dach
5213bfa5c9
Merge branch 'master' into make_skin_reset_dangerous
2023-03-07 21:06:44 +01:00
Bartłomiej Dach
7ade525eef
Display corner radius setting as percentage
2023-03-07 19:43:52 +01:00
mk56-spn
908651cc11
make ResetConfirmDialog properly utilise its parent's logic
...
Adjust name of `DeleteAction` to `DangerousAction`
2023-03-05 20:57:26 +01:00
