1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 22:37:26 +08:00
Commit Graph

69986 Commits

Author SHA1 Message Date
Bartłomiej Dach
938c3d78ce
Fix argon song progress bar tooltip showing during active gameplay
Closes https://github.com/ppy/osu/issues/30197.

Pretty bad one, might be worth a hotfix...
2024-10-10 14:36:28 +02:00
Bartłomiej Dach
687bdad389
Remove no-longer-required cache-over hack
This is now removable after `AdvancedStats` has been weaned off the
global mods bindable. I think this is a win all things considered?
2024-10-10 14:22:20 +02:00
Bartłomiej Dach
f1842d781e
Decouple AdvancedStats from global mods
Closes https://github.com/ppy/osu/issues/30163.

If I'm to be blunt, the decoupled stuff in song select makes my head
spin. I spent a solid 20 minutes thinking how I was going to fix this
one but then finally realised that generally most of the cause there
was the fact that `AdvancedStats` was seeing the new rulesets *before*
the "ensure global selected mods are valid for current ruleset" logic,
and so decided to just _delay_ that until the decoupled transfer
thingamajig happens.

I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
`Mods` into one property on `AdvancedStats`. I figured I'd rather not
push my luck and try the baseline version first, but I honestly think
that direction is going to be required at some point to properly corral
all of the decoupled madness taking place in song select.
2024-10-10 14:22:16 +02:00
Bartłomiej Dach
a7fcfd5f0d
Fix discord RPC complaining yet again if given a single space character as activity state / details
Closes https://github.com/ppy/osu/issues/30178.

Really, discord?
2024-10-10 13:59:18 +02:00
Bartłomiej Dach
cab97a96ab
Merge pull request #30189 from OliBomby/fix-splittable
Fix split control point context menu option not showing up on newly created control points
2024-10-10 11:37:24 +02:00
OliBomby
9936ec579f Fix isSplittable depending on unreliable order of path control point pieces 2024-10-09 23:31:12 +02:00
Dean Herbert
a6f56036a2
Merge pull request #30164 from bdach/am-i-fired-this-time
Fix game deadlocking on startup when set to single thread mode
2024-10-09 19:55:01 +09:00
Bartłomiej Dach
baa64d1486
Migrate MusicController to Live<T> to fix broken migrations instead 2024-10-09 11:59:04 +02:00
Bartłomiej Dach
081d87fe6d
Revert 'Fix any and all migration attempts dying on MusicController'
This reverts commit 310eec69fc.

Way to try and "fix" stuff and screw stuff up even harder instead, me.
Great job, well done.
2024-10-09 11:55:59 +02:00
Dean Herbert
270c4c4f12
Merge pull request #30151 from bdach/migration-is-completely-fucked
Fix several breakages with migration operation
2024-10-09 14:24:34 +09:00
Dean Herbert
d836dba982
Rename and xmldoc RealmResetEmptySet 2024-10-09 14:18:34 +09:00
Dean Herbert
48dacd1c15
Remove unused property 2024-10-09 13:45:35 +09:00
Dean Herbert
7ccb770009
Update framework 2024-10-09 12:36:51 +09:00
Dean Herbert
68ebf64b2d
Fix dependabot line endings 2024-10-09 12:36:44 +09:00
Dean Herbert
4a84c6e778
Merge pull request #30153 from ppy/dependabot/nuget/osu.Desktop/System.IO.Packaging-8.0.1
Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop
2024-10-09 12:13:56 +09:00
dependabot[bot]
6a754222e4
Bump System.IO.Packaging from 8.0.0 to 8.0.1 in /osu.Desktop
Bumps [System.IO.Packaging](https://github.com/dotnet/runtime) from 8.0.0 to 8.0.1.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/compare/v8.0.0...v8.0.1)

---
updated-dependencies:
- dependency-name: System.IO.Packaging
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-09 01:30:23 +00:00
Bartłomiej Dach
b811b9baf6
Fix DetachedBeatmapStore special condition for detecting resets from blocking all operations failing on empty databases
See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244.
2024-10-08 23:16:17 +02:00
Bartłomiej Dach
1633cbdb66
Fix OsuGameBase.Migrate() eating exception messages for breakfast
Whomst've thought this was an ok thing to do? How did this pass review?
Let's leave these as rhetorical questions right now. Huge chances are
I'd implicate myself with at least one of them.
2024-10-08 23:16:17 +02:00
Bartłomiej Dach
310eec69fc
Fix any and all migration attempts dying on MusicController
I'm not sure why this was "fine" for as long as it apparently was,
but what `MusicController` was doing was completely incorrect and
playing with fire (accessing raw managed realm objects), which went
wrong somewhere around - admittedly -
https://github.com/ppy/osu/pull/29917, likely because that one started
*storing* these raw managed realm objects to fields, and you know what
will happen to those after you do a migration and recycle realms.

To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead.
Which does necessitate moving it to `OsuGameBase`, but it's the simplest
way out I can see. I guess the alternative would be to faff around with
`Live<T>` but it's ugly and I'm attempting to fix this relatively quick
right now.
2024-10-08 23:16:10 +02:00
Bartłomiej Dach
1744566def
Clarify xmldoc 2024-10-08 14:46:53 +02:00
Bartłomiej Dach
5104f3e7ac
Switch multiplayer away from using UserLookupCache
After switching `UserLookupCache` to `GET /users/lookup` from `GET
/users`, multiplayer sort of breaks, since the former endpoint does not
return `ruleset_statistics`, which are used in multiplayer to show
users' ranks. Therefore, switch multiplayer to use the appropriate
request type directly.
2024-10-08 14:46:50 +02:00
WitherFlower
b58576f31b Add slash and dot as valid separators in dates. 2024-10-08 14:13:27 +02:00
Bartłomiej Dach
17bc5ce5a9
Use lookup request in user lookup cache
Doing this alleviates https://github.com/ppy/osu/issues/29982, as the
currently online display utilises the user lookup cache, and currently
is hitting rate limits due to the amount of data retrieved from the `GET
/users` endpoint. Switching to `GET /users/lookup` reduces the chance of
this happening.
2024-10-08 14:05:27 +02:00
Bartłomiej Dach
3d06d67fec
Add GET /users/lookup request type 2024-10-08 14:05:09 +02:00
WitherFlower
2369e98cfc Implement ranked and submitted date filtering 2024-10-08 13:56:55 +02:00
WitherFlower
f8e43fd8d3 Add tests for ranked and submitted date filtering 2024-10-08 13:46:39 +02:00
Dean Herbert
bfad281f62
Merge pull request #26313 from OliBomby/grids-4
Add grid placement tool
2024-10-08 19:16:52 +09:00
OliBomby
de2f9dec39 Let right-click reset grid to default values 2024-10-08 10:51:35 +02:00
OliBomby
e794862da5 update comment 2024-10-08 10:46:10 +02:00
Dean Herbert
b1be31cd6a
Switch back to last tool after using grid tool, rather than always select tool 2024-10-08 17:34:51 +09:00
Dean Herbert
682023e130
Merge branch 'master' into grids-4 2024-10-08 16:26:42 +09:00
Dean Herbert
b658d9a681
Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2
Avoid updates (and update notifications) from appearing in more gameplay cases
2024-10-08 15:17:09 +09:00
Dan Balasescu
105008672d
Merge pull request #30139 from bdach/bump-diffcalc-versions
Bump difficulty calculator versions
2024-10-08 15:00:28 +09:00
OliBomby
dc267733d1 Use FA icon instead 2024-10-07 19:09:21 +02:00
OliBomby
66459c50de Rename to 'Grid' 2024-10-07 19:09:09 +02:00
OliBomby
076c8dec5a Revert "Use new place grid icon"
This reverts commit db10202642.
2024-10-07 19:06:32 +02:00
Dean Herbert
a02cda6528
Update resources 2024-10-08 01:51:56 +09:00
OliBomby
db10202642 Use new place grid icon 2024-10-07 16:51:53 +02:00
OliBomby
533ed609fb Fix crash on placing circular grid 2024-10-07 16:19:01 +02:00
Bartłomiej Dach
1af464d5ae
Bump difficulty calculator versions
In order for the new star difficulty to be shown to users on the next
release.

catch's difficulty calculator version is not bumped because the only
catch change pending deploy is https://github.com/ppy/osu/pull/28353 and
that affects performance points only.
2024-10-07 15:38:41 +02:00
Bartłomiej Dach
6608d0527e
Merge pull request #20963 from Natelytle/taikostatacc
Statistical accuracy PP and difficulty scaling for the osu!taiko ruleset
2024-10-07 15:34:42 +02:00
Bartłomiej Dach
84d6467e48
Merge branch 'master' into taikostatacc 2024-10-07 14:15:29 +02:00
Bartłomiej Dach
6d3eec3563
Merge pull request #16280 from apollo-dw/no-combo-scaling
Remove combo scaling from Aim and Speed from osu! performance calculation
2024-10-07 14:09:30 +02:00
Bartłomiej Dach
ec5f5a2336
Send mods in spectator frame headers 2024-10-07 13:45:34 +02:00
Dan Balasescu
c3f2c82b10
Remove unused parameter 2024-10-07 19:48:57 +09:00
Dan Balasescu
7cc6fe3819
Return true while in gameplay
A `false` value marks the user as being on the latest release, and
notifies them as such when clicking the button in settings. In reality,
we don't know whether this is the case yet - we're just deferring the
check.

Somewhat minor change because the chance of a user manually going into
settings and clicking the button is very small.
2024-10-07 19:35:09 +09:00
OliBomby
a755ae70a3 fix warning 2024-10-07 12:13:56 +02:00
Bartłomiej Dach
6596d30fb9
Merge pull request #30135 from smoogipoo/diffcalc-workflow-state-at-comment
Save `master` state when running diffcalc workflow
2024-10-07 12:11:28 +02:00
OliBomby
7b998219d7 move grid placement tool to left toolbox 2024-10-07 12:04:14 +02:00
Dan Balasescu
aee5f0ebf5
Fix incorrect condition 2024-10-07 19:01:25 +09:00