Bartłomiej Dach
4c6116e6e7
Fix compilation failure in Android test project
2020-06-04 23:50:58 +02:00
Bartłomiej Dach
c4cae006aa
Correctly slice node sample list when converting
2020-06-04 22:47:39 +02:00
Bartłomiej Dach
ac019bddd6
Only play samples at start of hold note in mania maps
2020-06-04 22:33:34 +02:00
Bartłomiej Dach
35544ede50
Add failing test cases
2020-06-04 22:33:30 +02:00
Bartłomiej Dach
6b88141e58
Add mania sample conversion test
2020-06-04 21:53:37 +02:00
Dean Herbert
5d1770dec8
Merge pull request #9212 from smoogipoo/fix-scorepanel-input
...
Fix score panel not receiving input in some places
2020-06-05 00:26:02 +09:00
Dean Herbert
bd2e4c50dd
Merge pull request #9211 from smoogipoo/change-date-format
...
Change format of date on score panel
2020-06-04 23:31:28 +09:00
Dean Herbert
2ec7059ac4
Merge pull request #9213 from smoogipoo/fix-keybinding-crash
...
Fix crash when double-clicking clear binding button
2020-06-04 23:31:02 +09:00
smoogipoo
9c1542f897
Fix crash when pressing clear button twice
2020-06-04 22:17:00 +09:00
smoogipoo
afcefe01bf
Fix score panel not receiving input in some places
2020-06-04 21:48:55 +09:00
smoogipoo
5d7bb8cb4e
Change format of date on score panel
2020-06-04 21:33:38 +09:00
Dean Herbert
9920911390
Fix tournament displayed beatmap potentially being out of order on quick changes
2020-06-04 17:20:08 +09:00
Shivam
7e5db5e933
Apply review suggestions
2020-06-03 23:49:06 +02:00
Salman Ahmed
741fa20149
Use CreateRuleset() for editor test scenes as well
2020-06-04 00:47:10 +03:00
Salman Ahmed
c72592c52c
Remove bindable-disabling logic and don't tie immediately to CreateRuleset()
2020-06-04 00:44:28 +03:00
Bartłomiej Dach
af3daaaeaf
Add reference to contributing guidelines in README
2020-06-03 23:44:02 +02:00
Bartłomiej Dach
ddf5282d0e
Move items from README.md to contributing guidelines
2020-06-03 23:44:02 +02:00
Bartłomiej Dach
c2fd2b8616
Add notes about draft PRs & pushing
2020-06-03 23:43:32 +02:00
Salman Ahmed
bbad70c3f0
Fix mod perfect test scenes failing due to null ruleset provided
...
Just a workaround for now, a better fix may be to put the test data creation in an action that is guaranteed to be invoked after the test scene has fully loaded (all dependencies would've been resolved by then).
2020-06-04 00:43:11 +03:00
Salman Ahmed
136e10086a
Set the ruleset bindable value at the BDL for its subclasses usages
...
There are test scenes using current value of ruleset bindable on their BDL (example in TestSceneSliderSnaking's BDL)
2020-06-04 00:37:06 +03:00
Bartłomiej Dach
8529486a5c
Merge branch 'master' into contributing-guidelines
2020-06-03 23:09:35 +02:00
Salman Ahmed
11da045d8c
Reorder declaration position of ruleset-creation methods
...
Should be recognized as a normal protected method in its declaring class.
2020-06-03 23:43:18 +03:00
Salman Ahmed
611f64fd36
Add base ready-made abstract scene for osu! mod tests
2020-06-03 23:24:00 +03:00
Salman Ahmed
84b40ea2c6
Merge remote-tracking branch 'upstream/master' into test-scene-create-ruleset
...
# Conflicts:
# osu.Game.Rulesets.Catch.Tests/TestSceneBananaShower.cs
# osu.Game.Rulesets.Catch.Tests/TestSceneHyperDash.cs
# osu.Game/Tests/Visual/ModTestScene.cs
# osu.Game/Tests/Visual/OsuTestScene.cs
2020-06-03 22:00:02 +03:00
Dean Herbert
66ec2afe5c
Remove broken import test
2020-06-03 23:38:40 +09:00
Dean Herbert
5ed3cd205f
Simplify reuse check using FileInfo IDs
2020-06-03 23:35:56 +09:00
Dan Balasescu
c4698e61ec
Merge pull request #9195 from peppy/fix-multi-chat-history
...
Fix chat history not being loaded for multiplayer matches
2020-06-03 22:49:27 +09:00
Dean Herbert
f6d9f0597b
Add implicit join logic for multiplayer rooms
2020-06-03 21:28:29 +09:00
Dean Herbert
25160dc220
Fix test name
2020-06-03 19:15:52 +09:00
smoogipoo
6133c7d747
Change suggestion to warning
2020-06-03 18:51:02 +09:00
Dean Herbert
012933545e
Add test coverage
2020-06-03 18:33:41 +09:00
Dean Herbert
c155ab8339
Check filenames and timestamps before reusing an already imported model
2020-06-03 18:03:10 +09:00
Dean Herbert
3c7e5a5b42
Fix ChannelManager not being loaded in tests
2020-06-03 18:00:31 +09:00
smoogipoo
c0881e14ab
Add "struct can be made readonly" inspection
2020-06-03 17:44:14 +09:00
smoogipoo
092f5b6521
Fix incorrect reference + simplify
2020-06-03 17:41:05 +09:00
Dean Herbert
1ba3f0ac14
Fix chat history not being loaded for multiplayer matches
2020-06-03 17:31:55 +09:00
smoogipoo
8aa8d2c880
Resolve NREs
2020-06-03 16:59:37 +09:00
smoogipoo
f3b5149648
Move some suggestions to warnings, resolve issues
2020-06-03 16:48:44 +09:00
Dan Balasescu
73467410ab
Merge pull request #9192 from peppy/fix-redundant-override
...
Fix redundant override showing up in build warnings
2020-06-03 16:15:33 +09:00
Dean Herbert
86926050e9
Merge pull request #9190 from swoolcock/fix-results-crash
...
Fix results screen crashing for beatmaps with no online ID
2020-06-03 16:00:47 +09:00
smoogipoo
3c07defa1a
Push to main multiplayer screen instead
2020-06-03 15:57:01 +09:00
Dean Herbert
5f1d44a2be
Update inspectcode / CodeFileSanity versions used in CI
2020-06-03 15:52:57 +09:00
Dean Herbert
1992a3db54
Fix redundant override showing up in build warnings
2020-06-03 15:50:00 +09:00
Dan Balasescu
8131137fea
Merge branch 'master' into fix-results-crash
2020-06-03 15:19:30 +09:00
Bartłomiej Dach
74875f9b62
Apply review suggestions & other cleanups
2020-06-03 06:47:10 +02:00
smoogipoo
22f4e9012c
Remove temporary code
2020-06-03 12:54:16 +09:00
smoogipoo
13622eff1f
Fix response value
2020-06-03 12:54:07 +09:00
Dean Herbert
5740fc2bd0
Merge pull request #9168 from Game4all/fix-ruleset-no-autoplay
...
Fix crash after using Ctrl+Enter when current ruleset doesn't have an autoplay mod
2020-06-03 12:50:57 +09:00
Shane Woolcock
b174daa94a
Remove unused using
2020-06-03 11:58:56 +09:30
Shane Woolcock
0d5a2cf96d
Add unit tests
2020-06-03 11:36:59 +09:30
