62934 Commits

This Branch

This Branch

All Branches

• Merge remote-tracking branch 'upstream/master' into pr/22237
  Joseph Madamba · 2023-10-11 09:53:26 -07:00
  6a9f17d97c
• Fix date not aligning with flag
  Joseph Madamba · 2023-10-11 09:41:02 -07:00
  52be580f28
• Remove alternative total score display (colour gradient) for now

  For simplicity and a future consideration for when the skinning portion is implemented.

  Joseph Madamba · 2023-10-11 09:41:02 -07:00
  f6741514aa
• Remove unused field
  Joseph Madamba · 2023-10-11 09:41:02 -07:00
  42d41add41
• Move invalidation issue todo to tests
  Joseph Madamba · 2023-10-10 22:29:43 -07:00
  e32be36d92
• Fix statistics container showing for a brief moment on lower widths
  Joseph Madamba · 2023-10-10 22:17:31 -07:00
  f2aff628b2
• Add set up steps to reinit drawables with a different relative width
  Joseph Madamba · 2023-10-10 20:47:15 -07:00
  ba62498478
• Add experimental collapse content logic based on width
  Joseph Madamba · 2023-10-10 20:47:15 -07:00
  e4f1eab6ad
• Update right content to latest design

  - Add more scenarios to test
  - Future-proof mods display to not overflow

  Joseph Madamba · 2023-10-10 20:24:25 -07:00
  e049a072f8
• Fix user cover having shear
  Joseph Madamba · 2023-10-10 20:24:25 -07:00
  3c1d15d9b7
• Reduce indents of private container methods
  Joseph Madamba · 2023-10-10 18:39:35 -07:00
  3ad5a7c661
• Fix rank label tooltip area
  Joseph Madamba · 2023-10-10 18:26:00 -07:00
  e0c6c1bc66
• Rename createRightSideContent() to createRightContent()
  Joseph Madamba · 2023-10-10 18:26:00 -07:00
  837437ac57
• Truncate name label and clean up positioning code

  Also adds a test score with a long username.

  Joseph Madamba · 2023-10-10 18:26:00 -07:00
  bb3f426b93
• Use grid container for centre content
  Joseph Madamba · 2023-10-10 18:26:00 -07:00
  6087c12d85
• Add draw width statistic to test
  Joseph Madamba · 2023-10-10 16:47:33 -07:00
  43c8d51d02
• Move test scores to a method and add TestResources.CreateTestScoreInfo()
  Joseph Madamba · 2023-10-10 16:47:33 -07:00
  39b008b070
• Use AutoSizeAxes instead of hardcoded Size
  Joseph Madamba · 2023-10-10 16:47:33 -07:00
  668e083ddc
• Fix leaderboard score caching colour provider
  Joseph Madamba · 2023-10-10 16:47:33 -07:00
  dad03778b7
• Populate dates and add show animation on test
  Joseph Madamba · 2023-10-10 16:47:33 -07:00
  c0b8b3509f
• Remove weird yellow background override on mods

  To who's reading, don't follow figma designs all the time. In most cases, follow what other places are doing.

  Joseph Madamba · 2023-10-10 16:47:33 -07:00
  5bea5415be
• Merge pull request #25081 from peppy/song-bar-less-black

  Reduce black fill of song bar in tournament UI back to reasonable levels

  Bartłomiej Dach · 2023-10-10 22:28:50 +02:00
  eeb5409733
• Merge pull request #25074 from peppy/fix-argon-health-bar-flash

  Fix argon health bar not completing flash animation correctly

  Bartłomiej Dach · 2023-10-10 22:28:30 +02:00
  969c1b0812
• Merge branch 'master' into fix-argon-health-bar-flash
  Bartłomiej Dach · 2023-10-10 20:03:20 +02:00
  6f5f3a1ef4
• Merge pull request #25083 from peppy/fix-preview-point-incorrect

  Fix default preview point being incorrect on old beatmaps

  Bartłomiej Dach · 2023-10-10 19:54:14 +02:00
  66c12e5269
• Merge branch 'master' into fix-argon-health-bar-flash
  Dean Herbert · 2023-10-11 00:20:08 +09:00
  b9dbc8139b
• Merge pull request #25076 from peppy/fix-argon-health-bar-perf

  Ensure health displays don't pile up transforms when off-screen

  Bartłomiej Dach · 2023-10-10 16:33:32 +02:00
  d701e88a08
• Merge pull request #25079 from peppy/fix-player-startup-stop

  Fix multiplayer not correctly pausing the track on initialisation

  Bartłomiej Dach · 2023-10-10 16:30:35 +02:00
  0c64fe7eaa
• Adjust comment to match current behaviour

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-10-10 22:54:19 +09:00
  b9dadc52b7
• Remove comment regarding inlined delegate
  Dean Herbert · 2023-10-10 22:12:20 +09:00
  e2e28ef0ca
• Remove JudgementResult from Miss/Flash as it is not used
  Dean Herbert · 2023-10-10 22:10:44 +09:00
  682aa06acf
• Fix beatmaps with no preview point set getting incorrect default

  Note that this will require a re-import to fix existing beatmaps
  becuse.. it's stored to realm. Probably not worth worrying about for
  now.

  Dean Herbert · 2023-10-10 19:13:16 +09:00
  2781846147
• Add failing test coverage of incorrect default preview time
  Dean Herbert · 2023-10-10 19:13:16 +09:00
  7220ca34f7
• Reduce black fill of song bar

  Closes https://github.com/ppy/osu/issues/24993.

  Dean Herbert · 2023-10-10 18:47:20 +09:00
  97e521acad
• Change GameplayClockContainer.Reset to directly call GameplayClock.Stop

  The reasoning is explained in the inline comment, but basically this was
  getting blocked by `isPaused` being in an initial `true` state (as it is
  on construction), while the source clock was still `IsRunning`.
  
  There's no real guarantee of sync between the source and the `isPaused`
  bindable right now. Maybe there should be in the future, but to restore
  sanity, let's ensure that a call to `Reset` can at least stop the track
  as we expect.

  Dean Herbert · 2023-10-10 18:16:14 +09:00
  f0bd975393
• Fix MultiplayerPlayer never calling Reset on GameplayClockContainer

  This call is responsible for ensuring the clock is in a stopped state.

  Dean Herbert · 2023-10-10 17:58:37 +09:00
  100c0cf533
• Reduce severity of clock running check to avoid production crashes
  Dean Herbert · 2023-10-10 17:58:11 +09:00
  eee7dc02da
• Add failing test coverage of player not pausing track correctly
  Dean Herbert · 2023-10-10 17:55:35 +09:00
  4319b22db8
• Merge pull request #25077 from bdach/fix-guest-score-lookup

  Fix score importer looking up guest user by username online

  Dean Herbert · 2023-10-10 17:35:15 +09:00
  1388f7240e
• Merge pull request #25070 from frenzibyte/fix-legacy-catcher-layout

  Adjust legacy catcher display to match 1:1 with osu!(stable)

  Dean Herbert · 2023-10-10 17:31:10 +09:00
  a0bd91f3bb
• Merge pull request #25067 from bdach/approach-circle-cutoff

  Adjust approach circle maximum size limits for backwards compatibility

  Dean Herbert · 2023-10-10 17:05:16 +09:00
  0ca05d986d
• Fix cross-test interference

  `TestLastPlayedUpdated` was implicitly relying on running first.
  `TestGuestScoreIsStoredAsGuest` showing up changed test ordering,
  causing the former test to fail if it didn't get to run first.

  Bartłomiej Dach · 2023-10-10 09:30:51 +02:00
  ea400a9db7
• Fix score importer looking up guest user by username online
  Bartłomiej Dach · 2023-10-10 09:28:01 +02:00
  24956588e9
• Add failing test case for guest user being looked up in API
  Bartłomiej Dach · 2023-10-10 09:18:57 +02:00
  08b1a3cbe2
• Fix Scheduler.AddOnce not working in one location
  Dean Herbert · 2023-10-10 16:17:34 +09:00
  4674f63655
• Avoid running finishInitialAnimation when already finished
  Dean Herbert · 2023-10-10 15:59:48 +09:00
  7e68b64526
• Also debounce updatePathVertices to reduce overhead
  Dean Herbert · 2023-10-10 15:50:42 +09:00
  1eb6c93916
• Add TODO mentioning that ArgonHealthDisplay is doing lerp wrong
  Dean Herbert · 2023-10-10 15:24:54 +09:00
  6c346874d3
• Ensure health displays don't pile up transforms when off-screen
  Dean Herbert · 2023-10-10 15:24:54 +09:00
  57f588fa86
• Merge pull request #25073 from peppy/mania-beat-snap-grid-fix

  Fix osu!mania beat snap grid sometimes not displaying correctly

  Bartłomiej Dach · 2023-10-10 08:21:43 +02:00
  6b38600010