Dean Herbert
6974c2d255
Remove weird panelIsComplete flag and replace LINQ with simple foreach
2022-02-03 19:00:03 +09:00
Dean Herbert
df9d99f5aa
Merge branch 'master' into extended-statistics-without-replay
2022-02-03 18:59:48 +09:00
Henry Lin
a27d0572ed
Add test cases for manual testing
2022-02-03 17:00:40 +08:00
Dan Balasescu
46d180eeb5
Merge pull request #16760 from peppy/force-relayout-on-score-mode-change
...
Trigger a re-layout of HUD components when scoring mode is changed
2022-02-03 17:06:38 +09:00
Dan Balasescu
d3e6eac02e
Merge pull request #16762 from peppy/fix-carousel-ruleset-filter-test-local-database
...
Fix `TestSelectingFilteredRuleset` failing under visual tests due to using local database
2022-02-03 16:59:45 +09:00
Dean Herbert
41aa4b8cca
Fix TestSelectingFilteredRuleset failing under visual tests due to using local database
2022-02-03 16:04:05 +09:00
Dan Balasescu
cd806711f8
Merge pull request #16761 from peppy/more-dialog-overlay-wait
...
Wait for `DialogOverlay` load in more tests
2022-02-03 16:01:32 +09:00
Dean Herbert
6355ac6663
Wait for DialogOverlay load in more tests
...
Apparently the previous fix was not enough as this can still be seen
failing
(https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true ).
This change is copying from what other tests use seemingly reliably,
such as `TestScenePerformFromScreen`)
2022-02-03 15:10:08 +09:00
Dean Herbert
c8ce00b26a
Trigger a re-layout of HUD components when scoring mode is changed
...
This is a simple way of fixing the layout of scoring elements
overlapping due to different score display width requirements of
different scoring modes. It will only resolve the case where a user
hasn't customsied the layout of the default skins, but as this is a very
simple / low effort implementation for the most common scenario, I think
it makes sense.
Closes https://github.com/ppy/osu/issues/16067 .
2022-02-03 14:50:41 +09:00
Dean Herbert
867586f7f5
Merge pull request #16758 from smoogipoo/fix-incomplete-requests-offline
...
Fix API requests not completing when offline
2022-02-03 14:34:24 +09:00
Dean Herbert
a69c7a9de6
Split exceptions back out to give better messaging
2022-02-03 14:09:27 +09:00
Dean Herbert
62fa915193
Standardise exception messages for local-user-logged-out flows
2022-02-03 13:58:55 +09:00
Dan Balasescu
d9a43b4c4c
Fix API requests not completing when offline
2022-02-03 13:16:54 +09:00
Henry Lin
aff36d4e16
Refactor populateStatistics to avoid disposing
2022-02-03 11:52:37 +08:00
Dean Herbert
2731d8e3c2
Merge pull request #16701 from LeNitrous/mod-alternate-osu
...
Add "Alternate" mod for osu! ruleset
2022-02-03 10:41:23 +09:00
Dean Herbert
be9df2ca11
Merge pull request #5774 from MaxOhn/aimassist-mod
...
Add "Aim Assist" mod
2022-02-03 10:40:43 +09:00
Dean Herbert
9bca597a8a
Merge pull request #16751 from bdach/flashlight-decimals-display
2022-02-03 10:34:09 +09:00
Bartłomiej Dach
82f9ad63f5
Fix flashlight size multiplier printing with too many decimal digits
2022-02-02 20:41:25 +01:00
Bartłomiej Dach
fb353d5d45
Merge branch 'master' into aimassist-mod
2022-02-02 19:37:34 +01:00
Bartłomiej Dach
7463744407
Fix osu! autoplay-like mods not declaring incompatibility with AimAssist
2022-02-02 19:17:33 +01:00
Dean Herbert
3a5099cf06
Merge pull request #16748 from frenzibyte/explicit-diffadjust-keyboard-step
...
Use `0.1` keyboard step for "Difficulty Adjust" sliders
2022-02-03 00:22:23 +09:00
Salman Ahmed
074a691635
Set keyboard step to 0.1 for difficulty adjust sliders
2022-02-02 17:43:08 +03:00
Dean Herbert
19eb9ad8a7
Reorder StatisticsItem constructor to make a touch more sense
2022-02-02 23:02:38 +09:00
Henry Lin
3c2a6fe208
Don't prompt for a replay if no item requires hit events
2022-02-02 19:07:14 +08:00
Henry Lin
1e19c7046a
Use spacing instead of bottom margin
2022-02-02 19:02:29 +08:00
Henry Lin
b0023b9809
Also dispose rows
2022-02-02 19:00:46 +08:00
Dean Herbert
f777347aaf
Merge pull request #16742 from smoogipoo/fix-multi-swap-mod-crash
...
Fix crash when selecting non-osu! ruleset mods as freemod
2022-02-02 19:14:10 +09:00
Dan Balasescu
b5fb3b7dae
Fix crash when selecting swap mod as freemod
2022-02-02 18:42:22 +09:00
Henry Lin
36bfef4f54
Dispose container before replacing
2022-02-02 17:32:16 +08:00
Henry Lin
042574660c
Rename "Content" to "CreateContent"
2022-02-02 17:29:03 +08:00
Henry Lin
90e30bc9e8
Remove useless null checks
2022-02-02 17:26:17 +08:00
Henry Lin
6a482827fe
Fix weird line breaking
2022-02-02 17:23:03 +08:00
Henry Lin
5e3d124eef
Add scrolling to the extended statistics panel
2022-02-02 17:20:22 +08:00
Dan Balasescu
db0f3b7f5e
Merge pull request #16738 from peppy/fix-ruleset-incorrectly-loading
...
Fix rulesets potentially being marked `Available` even when methods are missing
2022-02-02 18:03:04 +09:00
Dean Herbert
6260c5fc13
Merge pull request #16739 from nekodex/cursor-tap
...
Add cursor 'tap' audio feedback
2022-02-02 17:02:33 +09:00
Dean Herbert
cb31ce812c
Merge branch 'master' into cursor-tap
2022-02-02 16:34:34 +09:00
Dean Herbert
4758de226b
Update resources
2022-02-02 16:27:59 +09:00
Dean Herbert
6e41a6e704
Tidy up code into a presentable state
2022-02-02 16:27:16 +09:00
Dean Herbert
2e46404fe5
Remove spinner support for now
2022-02-02 16:26:00 +09:00
Dean Herbert
987aa5a21c
Add testing of different strengths
2022-02-02 16:26:00 +09:00
Dean Herbert
f07502ac5f
Use simple damp easing rather than transforms
2022-02-02 16:15:06 +09:00
Dean Herbert
334ed2c9c4
Fix sliders moving before they are actually hit
2022-02-02 15:36:09 +09:00
Dean Herbert
6b31e7e9db
Merge branch 'master' into aimassist-mod
2022-02-02 15:18:48 +09:00
Dean Herbert
104256a054
Add test coverage
2022-02-02 15:18:44 +09:00
Dean Herbert
e7d72f1823
Revert recent changes
2022-02-02 15:18:44 +09:00
Dean Herbert
0c5da9370a
Fix rulesets potentially being marked Available even when methods are missing
...
Came up when running the game after the recent breaking changes
(https://github.com/ppy/osu/pull/16722 ), where two template rulesets I
had loaded were erroring on startup but still being marked as available,
allowing them to crash the game on attempting to initiate relpay logic.
These cases are already handled for first-time ruleset loading via the
`GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
consistency checking already present rulesets the only runtime
validation being done was `ruleset.CreateInstance()`, which does not
handle missing types or methods.
2022-02-02 14:52:01 +09:00
Jamie Taylor
6e60e68b80
Change from click to mousedown+mouseup and only play when cursor is visible
2022-02-02 14:44:06 +09:00
Henry Lin
3ba5d88914
Update statistics item display logic
2022-02-02 13:41:51 +08:00
Dean Herbert
a2affefb0a
Avoid checking gameplay clock time in Update method
2022-02-02 14:33:17 +09:00
Henry Lin
c5c4c85006
Lazily create content of StatisticItem
2022-02-02 13:29:18 +08:00
