57160 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	675e32df57	Add test steps for testing combo reset to 0	2022-11-22 20:43:22 +01:00
Bartłomiej Dach	ce7af0df63	Always use current timing point for circle piece animation ... Using `LifetimeStart` seemed arbitrary and wrong not only in a compatibility-with-stable sense, but also in a general sanity sense (why would each object potentially be using a different timing point to animate?)	2022-11-22 20:39:22 +01:00
Bartłomiej Dach	38f2a27f53	Split animation logic to its own method ... Also add a guard, to bypass all of it if the foreground layer is not in fact animatable.	2022-11-22 20:39:05 +01:00
Bartłomiej Dach	8ac0a759f0	Set combo immediately rather than via repeat steps ... Doesn't help anyone to be waiting literal minutes for combo to hit 50 or 150 in a test scene supposed to quickly visually demonstrate a component. Doesn't help for CI runtime, either.	2022-11-22 20:30:27 +01:00
Bartłomiej Dach	5a5b0ed4ef	Restructure tests not to call each other ... Bit weird to have tests call other tests. Private helper methods is better, if unavoidable.	2022-11-22 20:28:41 +01:00
Joppe27	db34fa99b1	Add tests and clean up inefficient code	2022-11-22 17:22:34 +01:00
Joppe27	5343f6922c	Add legacy circle piece animations based on combo	2022-11-22 17:22:00 +01:00
Dan Balasescu	2e4dc7c467	Merge pull request #21371 from peppy/fix-mania-hold-note-stuck ... Fix osu!mania hold notes occasionally getting in a visually incorrect hit state	2022-11-22 17:14:39 +09:00
Dean Herbert	57723107dd	Fix osu!mania hold notes occasionally getting in a visually incorrect hit state ... To correctly end a mania hold note, `endHold()` needs to be called. This was not happening in a very specific scenario: - The hold note's head is not hit - The user pressed the column's key within the hold note's tail's window, but does so to hit the next object (a note in proximity to the hold note's tail). - The hit policy forces a miss on the hold note, but `endHold()` is not called - `CheckForResult` is not called after this point due to `Judged` being `true`. Closes #21311.	2022-11-22 16:15:34 +09:00
Dan Balasescu	6b75f529c7	Merge pull request #21366 from bdach/broken-rank-graph-test ... Fix broken rank graph test	2022-11-22 14:35:14 +09:00
Dan Balasescu	985781bc3b	Merge pull request #21356 from peppy/standardise-broken-storyboard-paths ... Add support for storyboards with incorrect path specifications (`\\` instead of `\`)	2022-11-22 14:33:51 +09:00
Bartłomiej Dach	cd43e83494	Merge pull request #21344 from peppy/tablet-settings-test-scene ... Fix `TestSceneTabletSettings` falling off the bottom of the screen	2022-11-21 21:46:15 +01:00
Bartłomiej Dach	41039340cf	Fix rank graphs not showing in test due to unset IsRanked	2022-11-21 21:00:06 +01:00
Bartłomiej Dach	1777a60136	Add failing assertions	2022-11-21 20:58:52 +01:00
Bartłomiej Dach	735cac3104	Rewrite rank graph test to use more modern style	2022-11-21 20:56:38 +01:00
Bartłomiej Dach	f36ccab84e	Merge branch 'master' into tablet-settings-test-scene	2022-11-21 20:42:04 +01:00
Bartłomiej Dach	4490504104	Merge pull request #21346 from peppy/higher-aspect-ratio-max ... Increase maximum aspect ratio for tablet settings to 23:9 / 2.55	2022-11-21 20:41:47 +01:00
Bartłomiej Dach	8dbe31a172	Merge branch 'master' into higher-aspect-ratio-max	2022-11-21 19:51:39 +01:00
Bartłomiej Dach	f75353d8f4	Merge pull request #21350 from peppy/hide-no-spin-bonus ... Hide spinner ticks / bonus from results screen when not applicable to score	2022-11-21 19:50:56 +01:00
Bartłomiej Dach	ff5cb116f0	Fix weird scroll container sizing	2022-11-21 19:27:06 +01:00
Bartłomiej Dach	c0f65d83b3	Merge branch 'master' into hide-no-spin-bonus	2022-11-21 19:14:54 +01:00
Bartłomiej Dach	c79841dad2	Merge pull request #21360 from peppy/mania-argon-hold-better ... Realign white line on argon hold note ends to match hit target	2022-11-21 18:53:05 +01:00
Bartłomiej Dach	c805eb330a	Merge branch 'master' into mania-argon-hold-better	2022-11-21 18:17:35 +01:00
Bartłomiej Dach	d5e9cb2477	Merge pull request #21352 from peppy/avoid-null-audio-device-name-crahs ... Avoid crashing when a system audio device provides a `null` name	2022-11-21 17:16:30 +01:00
Bartłomiej Dach	206aece77b	Merge branch 'master' into avoid-null-audio-device-name-crahs	2022-11-21 16:37:13 +01:00
Bartłomiej Dach	7944d9cefa	Merge pull request #21304 from EVAST9919/beatmap-bar ... Rework BarGraph to use Quads	2022-11-21 16:24:18 +01:00
Dean Herbert	b404b87f68	Realign white line on argon hold note ends to match hit target	2022-11-21 18:26:53 +09:00
Dean Herbert	2774c1ea49	Merge pull request #21215 from jai-x/triangles-bundled-beatmap ... Add winner of Triangles mapping competition as a bundled beatmap	2022-11-21 16:22:23 +09:00
Dean Herbert	3da21e596a	Add support for storyboards with incorrect path specifications (\\ instead of \) ... Closes https://github.com/ppy/osu/issues/21204.	2022-11-21 16:12:01 +09:00
Dean Herbert	981264b011	Avoid crashing when a system audio device provides a null name	2022-11-21 14:51:41 +09:00
Dean Herbert	93a189603a	Hide spinner ticks / bonus from results screen when not applicable to score	2022-11-21 14:20:36 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter ... Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
Dean Herbert	dfa92b3de9	Merge pull request #21326 from bdach/fix-phantom-beatmap-sets ... Fix phantom beatmap sets appearing on carousel after delete/update	2022-11-21 13:25:14 +09:00
Dean Herbert	c7ae837687	Increase maximum aspect ratio for tablet settings to 23:9 / 2.55	2022-11-21 12:45:54 +09:00
Dean Herbert	92aea22cd3	Merge pull request #21340 from vegguid/MetadataLanguage-FirstSetup ... Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-21 12:16:56 +09:00
Dean Herbert	d0ff5be7e6	Fix TestSceneTabletSettings falling off the bottom of the screen	2022-11-21 12:15:43 +09:00
Dean Herbert	85167d8de6	Merge pull request #21343 from goodtrailer/nonsquare-smoke ... Add support for nonsquare smoke textures	2022-11-21 12:06:49 +09:00
Alden Wu	815cd56f13	Add support for nonsquare smoke textures	2022-11-20 16:50:15 -08:00
vegguid	a431b793b9	Added PreferOriginalMetadataLanguage to FirstRunSetup	2022-11-20 23:18:19 +01:00
Andrei Zavatski	18c79dfda3	Move all the logic into BarsInfo class	2022-11-20 23:00:13 +03:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	1269afd0c5	Merge pull request #21307 from frenzibyte/disable-scroll-speed-on-osu ... Hide scroll speed control from effects section on rulesets which don't support it	2022-11-20 16:17:55 +01:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Salman Ahmed	793d5b117e	Fix timing screen test scene not creating editor beatmap properly	2022-11-20 15:20:35 +03:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
Bartłomiej Dach	b3667821eb	Add failing test case	2022-11-20 10:07:32 +01:00
Andrei Zavatski	36141cb2a4	Make BarsInfo a class	2022-11-20 05:14:07 +03:00
Salman Ahmed	4b0ba86bd0	Identify scrolling rulesets using temporary DrawableRuleset instances	2022-11-20 04:12:52 +03:00