36339 Commits

This Branch

This Branch

All Branches

• Unschedule cancellation
  smoogipoo · 2021-02-03 20:50:22 +09:00
  65d45ec74c
• Don't part room if join task was cancelled
  Bartłomiej Dach · 2021-01-30 23:39:01 +01:00
  90ba8ae234
• Set canceled result in scheduleAsync

  Was holding up the task completion source, and in consequence,
  potentially the entire task chain.

  Bartłomiej Dach · 2021-01-30 16:13:50 +01:00
  c3ba92f057
• Merge branch 'master' into fix-leave-room-race-2
  Bartłomiej Dach · 2021-01-30 13:41:04 +01:00
  9ab1ad25eb
• Merge pull request #11500 from peppy/fix-skin-dropdown-update-crash
  Bartłomiej Dach · 2021-01-30 13:34:00 +01:00
  fec3bd898e
• Merge branch 'master' into fix-skin-dropdown-update-crash
  Bartłomiej Dach · 2021-01-30 13:01:52 +01:00
  6a1387191a
• Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure

  Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present

  Bartłomiej Dach · 2021-01-29 18:58:00 +01:00
  44e88f09e5
• Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present

  It turns out the SQLite API isn't smart enough to handle nullables
  directly, so we need to help it out a bit.
  
  Stops the following from being thrown:
  
  ```
  System.InvalidOperationException: Value must be set.
     at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt) = 3
  at
     at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt
  stmt) = 3 at
     at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior
  behavior)
     at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader()
     at
  osu.Game.Beatmaps.BeatmapManager.BeatmapOnlineLookupQueue.checkLocalCache(BeatmapSetInfo
  set, BeatmapInfo beatmap) in
  /Users/dean/Projects/osu/osu.Game/Beatmaps/BeatmapManager_BeatmapOnlineLookupQueue.cs:line
  166 = 166
  ```

  Dean Herbert · 2021-01-29 19:53:57 +09:00
  16f3d1815f
• Merge pull request #11622 from peppy/remove-unobserved-exception-handling

  Remove all usage of CatchUnobservedExceptions

  Dan Balasescu · 2021-01-29 19:31:07 +09:00
  cd8ef5373d
• Merge pull request #11623 from Firmatorenio/apply-sv-to-taiko-diffadjust

  Add scroll speed adjustment to taiko's DifficultyAdjust mod

  Dean Herbert · 2021-01-29 19:25:17 +09:00
  d52376cc17
• Ensure the item is present before trying to select it
  Dean Herbert · 2021-01-29 19:17:12 +09:00
  18e6afbec0
• Merge branch 'master' into fix-skin-dropdown-update-crash
  Dean Herbert · 2021-01-29 19:16:20 +09:00
  1ce383fc20
• rename SliderVelocity to ScrollSpeed
  Firmatorenio · 2021-01-29 15:04:55 +06:00
  37ef5c7072
• Remove all usage of CatchUnobservedExceptions

  This should no longer be required with the recent framework side change
  that stops a game from crashing on unobserved exceptions
  (https://github.com/ppy/osu-framework/pull/4171).

  Dean Herbert · 2021-01-29 16:32:29 +09:00
  a61444690e
• Revert test changes to test original class/scope

  Importantly, this removes the call to CatchUnobservedExceptions(), which was
  outright incorrect (awaiting on the wrong task as a result) in the
  original test code.

  Dean Herbert · 2021-01-29 16:20:26 +09:00
  c3aec3bfe4
• Update TaskChain to use ContinueWithSequential internally

  It turns out we may still want to use TaskChain for its locking
  behaviour, so I've made it internally use the refactored version I
  implemented, while keeping the general structure.

  Dean Herbert · 2021-01-29 16:19:46 +09:00
  1ec305e10d
• add SV multiplier adjustment to TaikoModDifficultyAdjust
  Firmatorenio · 2021-01-29 11:48:51 +06:00
  449f883be1
• Merge pull request #11618 from vltspr/catch-auto-fix

  Fix Catch autoplay rewinding on instantaneous hits

  Dan Balasescu · 2021-01-29 12:17:46 +09:00
  4c4770bf4b
• Formatting
  Corentin PALLARD · 2021-01-29 03:03:23 +01:00
  d168de0ae3
• Fix the ctb auto mod speedup in some occasions
  Corentin PALLARD · 2021-01-29 02:53:26 +01:00
  da4c207a73
• Merge pull request #11615 from peppy/ios-signalr-use-json
  Bartłomiej Dach · 2021-01-29 00:04:16 +01:00
  1d76cfe585
• Merge branch 'master' into ios-signalr-use-json
  Bartłomiej Dach · 2021-01-28 23:28:49 +01:00
  0f1d72e073
• Merge pull request #11616 from peppy/fix-ios-beatmap-cache-lookups

  Avoid using Dapper to fix iOS compatibility of beatmap lookup cache

  Bartłomiej Dach · 2021-01-28 23:17:54 +01:00
  c592c80a07
• Fix typos in comments
  Bartłomiej Dach · 2021-01-28 22:36:07 +01:00
  386f9f7842
• Merge branch 'master' into fix-ios-beatmap-cache-lookups
  Bartłomiej Dach · 2021-01-28 22:33:58 +01:00
  8afd1bce21
• Merge pull request #11613 from bdach/order-attribute-move

  Remove game-local enum `[Order]` attribute

  Dean Herbert · 2021-01-29 00:41:43 +09:00
  2021.129.0 34f8e4b672
• Merge pull request #11611 from frenzibyte/fix-package-downgrade

  Fix dotnet run/publish with runtime specified not working again

  Dean Herbert · 2021-01-29 00:18:27 +09:00
  87e23d22cf
• Update framework
  Dean Herbert · 2021-01-28 23:55:03 +09:00
  a616688a47
• Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
  Dean Herbert · 2021-01-28 16:53:56 +09:00
  c3d4044017
• Fallback to using json for signalr communication if JIT is unavailable
  Dean Herbert · 2021-01-28 16:20:19 +09:00
  90a82f986b
• Remove game-local enum [Order] attribute

  In favour of the newly-added framework one.

  Bartłomiej Dach · 2021-01-27 22:29:52 +01:00
  2c08ce05fa
• Fix dotnet run/publish with runtime specified not working again
  Salman Ahmed · 2021-01-27 20:45:52 +03:00
  63f057a525
• Merge pull request #11610 from peppy/update-framework

  Update framework

  Dean Herbert · 2021-01-27 23:56:08 +09:00
  2021.127.0 15e455231e
• Update framework
  Dean Herbert · 2021-01-27 23:00:14 +09:00
  45395cb5e8
• Comment and add xmldoc
  Dean Herbert · 2021-01-27 20:01:21 +09:00
  a30aecbafe
• Proposal to use extension method instead of TaskChain class
  Dean Herbert · 2021-01-27 19:50:16 +09:00
  fcfb0d52c2
• Merge pull request #11607 from peppy/add-messagepack

  Switch spectator and multiplayer to use more efficient MessagePack protocol

  Dean Herbert · 2021-01-27 13:50:45 +09:00
  3b6c82bb03
• Merge branch 'master' into add-messagepack
  Dan Balasescu · 2021-01-27 13:00:46 +09:00
  7d06af916c
• wip
  smoogipoo · 2021-01-27 01:20:50 +09:00
  248989b3eb
• Make threading even more thread safe
  smoogipoo · 2021-01-26 22:49:01 +09:00
  085115cba5
• Fix TaskChain performing the action in-line, add test
  smoogipoo · 2021-01-26 22:47:37 +09:00
  8c3b0a3167
• Merge pull request #11589 from MiraiSubject/osu-mod-icon-fallbacks

  Allow tournament client to use default mod icons if custom icons are not present

  Dean Herbert · 2021-01-26 19:57:21 +09:00
  67014018fc
• Tidy up nesting
  Dean Herbert · 2021-01-26 19:16:38 +09:00
  81ab82fafe
• Rename class and add xmldoc
  Dean Herbert · 2021-01-26 19:15:19 +09:00
  64a3c712aa
• Avoid tooltip display
  Dean Herbert · 2021-01-26 19:11:19 +09:00
  a5f3418e56
• Merge pull request #11572 from EVAST9919/comment-pill

  Make VotePill background transparent for own comments

  Dean Herbert · 2021-01-26 18:57:00 +09:00
  fedcbf79fa
• Merge pull request #11605 from frenzibyte/fix-beatmap-listing-2

  Fix beatmap listing placeholder disappearing on second time display

  Dean Herbert · 2021-01-26 18:28:42 +09:00
  bd86b535db
• Remove unused usings
  Dean Herbert · 2021-01-26 18:07:43 +09:00
  15885c17af
• Merge branch 'master' into fix-beatmap-listing-2
  Dean Herbert · 2021-01-26 17:56:37 +09:00
  468dfbecbe
• Merge pull request #11604 from frenzibyte/fix-beatmap-listing

  Fix beatmap listing placeholder potentially getting disposed

  Dean Herbert · 2021-01-26 17:56:19 +09:00
  fcf4d4ee18