1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-24 13:22:55 +08:00
Commit Graph

68245 Commits

Author SHA1 Message Date
Caiyi Shyu
5fb364cad6 remove redundant code added accidentally 2024-07-31 16:56:25 +08:00
Caiyi Shyu
5b46597d56 fix click to expand on touch devices 2024-07-31 16:54:32 +08:00
Caiyi Shyu
77d64e0c3d replace with ReceivePositionalInputAt 2024-07-27 17:59:38 +08:00
Caiyi Shyu
fc842868a9 fix code quality 2024-07-27 16:24:20 +08:00
Caiyi Shyu
b97d96fcb0 Fix panel collapse when hovering dropdown menu 2024-07-27 15:15:14 +08:00
Caiyi Shyu
bd017aea38
fix TestPreexistingSelection failing 2024-07-26 23:58:52 +08:00
Caiyi Shyu
aed81d9758 make code inspector happy 2024-07-26 22:56:07 +08:00
Caiyi Shyu
a3576a55c2 add test for hovering ModCustomisationPanel 2024-07-26 22:45:12 +08:00
Caiyi Shyu
0cc6818b21 allow hover to expand ModCustomisationPanel 2024-07-26 22:44:50 +08:00
Dean Herbert
c90e04092a
Merge pull request #29068 from bdach/results-statistics-toggle-crash
Fix crash when toggling extended statistics visibility during results load
2024-07-25 22:49:41 +09:00
Dean Herbert
6cc3e8aab8
Merge pull request #29067 from bdach/report-daily-challenge
Fix not being able to send chat reports on daily challenge screen
2024-07-25 22:33:41 +09:00
Dean Herbert
12f237abca
Merge pull request #29070 from Cai1Hsu/cursor-trail-disconnect
Fix cursor trail disconnect from cursor when settings or notification overlay is opened
2024-07-25 22:32:09 +09:00
Dean Herbert
75e9f97633
Merge pull request #29071 from bdach/wow-this-is-really-missing-question-mark
Fix several missing properties on `MultiplayerScore`
2024-07-25 21:26:40 +09:00
Bartłomiej Dach
3bb30d7ff9
Fix several missing properties on MultiplayerScore
You wouldn't think this would be an actual thing that can happen to us,
but it is. The most important one by far is `MaximumStatistics`; that
is the root cause behind why stuff like spinner ticks or slider tails
wasn't showing.

On a better day we should probably do cleanup to unify these models
better, but today is not that day.
2024-07-25 13:15:45 +02:00
Caiyi Shyu
e564b1dc9e Fix cursor trail alignment issue with UI panels
- Convert cursor trail coordinates to local space before storing.
- Apply necessary transformations to align with other UI elements.
- Ensure cursor trail remains connected during UI panel movements.
2024-07-25 18:23:01 +08:00
Bartłomiej Dach
8dbd4d70ff
Fix crash when toggling extended statistics visibility during results load
Closes https://github.com/ppy/osu/issues/29066.

Initially I fixed this at where the assert is right now:

	9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333)

but because of the weird way that visible state management is done in
this screen that made it possible for the extended statistics to be
visible *behind* the score panels, without the score panels making way
for it. So this is in a way safer, because it prevents the visibility
state of the extended statistics from changing in the first place if
there is no score selected (yet).

This can be also seen in playlists, at least.
2024-07-25 11:45:17 +02:00
Bartłomiej Dach
8d89557ab8
Fix not being able to send chat reports on daily challenge screen
Something something some people cannot be trusted with a textbox.
2024-07-25 11:11:54 +02:00
Bartłomiej Dach
9790c5a574
Merge pull request #29058 from frenzibyte/daily-challenge-fix-score-selection
Fix daily challenge abruptly discarding score selection when opening results screen
2024-07-25 10:46:32 +02:00
Salman Ahmed
9d5fbb8b4f Fix target score selection abruptly discarded after opening results screen 2024-07-25 09:01:43 +03:00
Dan Balasescu
542cb12059
Merge pull request #28995 from bdach/swell-editor-test-play
Fix swells not being correctly treated in editor gameplay test
2024-07-25 14:39:49 +09:00
Bartłomiej Dach
ccef98d24e
Merge pull request #29054 from peppy/fix-leaderboard-refreshing
Fix excessive leaderboard refreshes in daily challenge screen
2024-07-25 07:15:17 +02:00
Dean Herbert
aac98ab6b2
Debounce leaderboard refetches to stop excessive operations after returning from gameplay 2024-07-25 12:58:35 +09:00
Dean Herbert
9ec687caab
Avoid reloading the daily challenge leaderboard when already requested 2024-07-25 12:55:45 +09:00
Dan Balasescu
a696e3c261
Add reference to android project 2024-07-25 10:44:44 +09:00
Dan Balasescu
c5814e0869
Merge pull request #29047 from RealCyGuy/good-first-issues
Fix link to good first issues in CONTRIBUTING.md
2024-07-25 10:38:23 +09:00
Cyrus Yip
d63335082e
fix link to good first issues 2024-07-24 18:24:52 -07:00
Dan Balasescu
3dd7db5499
Merge pull request #29046 from peppy/disable-macos-runs
Disable macOS test runs for now
2024-07-25 09:49:00 +09:00
Dean Herbert
4cc07badbd
Disable macOS test runs for now
We are seeing update frames run as little as [once per
second](aa4d16bdb8/osu.Game/Overlays/BeatmapListingOverlay.cs (L141)).
Until we can ascertain why this is happening, let's reduce developer
stress by not running macOS tests for now.
2024-07-25 09:05:58 +09:00
Dan Balasescu
d057bee4fb
Merge pull request #29044 from frenzibyte/fix-drag-overwritten-by-focus
Fix dragging number boxes no longer working correctly
2024-07-25 08:36:39 +09:00
Salman Ahmed
b3e3bf7cec Add lenience to avoid floating point errors 2024-07-24 23:26:23 +03:00
Salman Ahmed
6645dac71d Fix dragging number boxes overwritten by select-all-on-focus feature 2024-07-24 23:19:04 +03:00
Dean Herbert
4983e5f33e
Merge pull request #29039 from bdach/multiple-selection-sample-popover
Make sample popover change properties of all samples in multiple selection
2024-07-24 22:49:20 +09:00
Bartłomiej Dach
1ed7e4b075
Make sample popover change properties of all samples in multiple selection
Closes https://github.com/ppy/osu/issues/28916.

The previous behaviour *may* have been intended, but it was honestly
quite baffling. This seems like a saner variant.
2024-07-24 12:15:12 +02:00
Bartłomiej Dach
55382a4ba6
Add test coverage for expected sample popover behaviour 2024-07-24 12:08:13 +02:00
Dean Herbert
6e4625609d
Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard
Fill daily challenge top 50 position numbers client-side
2024-07-24 17:49:51 +09:00
Dean Herbert
65fcef1929
Merge pull request #29037 from bdach/daily-challenge-exit-when-offline
Exit daily challenge screen when going offline
2024-07-24 17:48:07 +09:00
Bartłomiej Dach
788b70469d
Exit daily challenge screen when going offline
This sort of thing is bound to happen when rewriting screens from
scratch without invoking abstract eldritch entities sometimes. Damned if
you do, damned if you don't...
2024-07-24 09:15:32 +02:00
Bartłomiej Dach
bf4bf4d39e
Fill daily challenge top 50 position numbers client-side
Only doing this client-side, because doing this server-side is
expensive:

	https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285
2024-07-24 08:57:11 +02:00
Dean Herbert
aded31bd07
Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt
Respect pre-empt time when auto-generating breaks
2024-07-24 15:21:12 +09:00
Dean Herbert
a9ccb50b98
Merge pull request #29020 from bdach/drag-selection-tolerance
Add tolerance when drag-scrolling editor timeline
2024-07-23 22:28:29 +09:00
Dean Herbert
aed7ba9508
Change order of application to avoid bias to side with more room to drag
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-07-23 20:56:21 +09:00
Bartłomiej Dach
c3062f96ee
Fix autogenerated breaks not invalidating on change to pre-empt time 2024-07-23 13:38:50 +02:00
Bartłomiej Dach
c2fa30bf81
Add test coverage for break generation respecting pre-empt time 2024-07-23 13:38:25 +02:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
Closes https://github.com/ppy/osu/issues/28703.
2024-07-23 13:30:13 +02:00
Bartłomiej Dach
25d63ac6a5
Move editor beatmap processor test cases off of OsuHitObjects
Most of them are about to become obsolete once consideration for
`TimePreempt` is re-added.
2024-07-23 13:28:49 +02:00
Dean Herbert
40b171f544
Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued
Fix duration fluctuations and one-frame jitters when editing juice streams
2024-07-23 19:02:30 +09:00
Dean Herbert
cc4ed0ff3f
Use non-screen-space coordinates and add time-based drag ramping for better control 2024-07-23 18:59:22 +09:00
Bartłomiej Dach
38fc6f70f6
Add tolerance when drag-scrolling editor timeline
Closes https://github.com/ppy/osu/issues/28983.

While the direct cause of this is most likely mouse confine in
full-screen, it shouldn't/can't really be disabled just for this,
and I also get this on linux in *windowed* mode.

In checking other apps, adding some tolerance to this sort of
drag-scroll behaviour seems like a sane UX improvement anyways.
2024-07-23 11:10:18 +02:00
Dean Herbert
aba05a21aa
Merge branch 'master' into catch-juice-stream-editing-weirdness-continued 2024-07-23 17:05:40 +09:00
Dean Herbert
5911c42116
Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness
Fix various shortcomings in juice stream selection blueprint
2024-07-23 16:43:39 +09:00