h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-19 04:35:03 +08:00
Code Issues Releases Wiki Activity
57,604 Commits 3 Branches 657 Tags 364 MiB
5fb2a83f12
Commit Graph

274 Commits

Author SHA1 Message Date
Andrei Zavatski
be36a4b768 Make ctor protected 2020-07-12 12:39:48 +03:00
Andrei Zavatski
c3524cbe57 Make icon private but expose a protected method 2020-07-12 12:32:26 +03:00
Andrei Zavatski
da40f29b44 Make button text a property 2020-07-12 12:27:26 +03:00
Andrei Zavatski
0e5b375c9a Merge master with conflicts resolved 2020-07-12 02:20:54 +03:00
Andrei Zavatski
024ccc75ee Adjust margins/paddings 2020-07-11 09:03:03 +03:00
Andrei Zavatski
84392d0d13 Add loading spinner 2020-07-11 08:50:35 +03:00
Andrei Zavatski
b1b2e961bc Update arrow colour on hover 2020-07-11 08:13:11 +03:00
Andrei Zavatski
42d3288f17 Update old buttons usage 2020-07-11 08:01:11 +03:00
Andrei Zavatski
0861ee0c8e Make Icon rotate when clicking ShowRepliesButton 2020-07-11 07:54:37 +03:00
Andrei Zavatski
da249abd19 Implement CommentRepliesButton 2020-07-11 07:47:17 +03:00
Andrei Zavatski
789c921af1 Move replies button to a new line 2020-07-11 06:47:52 +03:00
Bartłomiej Dach
aab606b237 Cancel scheduled asynchronous load of comments 2020-06-13 13:00:05 +02:00
Dean Herbert
cbcd915ec8 Fix crash on switching comments page at an inopportune time 2020-04-24 18:18:10 +09:00
Joehu
3903423a37 Fix textbox characters not animating when typing/backspacing 2020-03-08 19:43:53 -07:00
Andrei Zavatski
e2c495e8c2 Move drawables loading to AppendComments() 2020-02-27 20:00:41 +03:00
Andrei Zavatski
62b4fa602f Merge remote-tracking branch 'refs/remotes/ppy/master' into remove-comments-page 2020-02-27 19:30:48 +03:00
Andrei Zavatski
32dc4501c1 Fix incorrect RepliesButton presentation 2020-02-27 14:16:35 +03:00
Andrei Zavatski
ddb494efb3 Add back regression test 2020-02-27 01:38:21 +03:00
Andrei Zavatski
54d83eff94 Use OverlayColourProfider for VotePill component 2020-02-26 19:35:20 +03:00
Andrei Zavatski
638d060145 Fix incorrect character on RepliesButton 2020-02-26 18:55:43 +03:00
Andrei Zavatski
1166d3d696 CI fixes 2020-02-26 18:52:58 +03:00
Andrei Zavatski
de10e50278 Add test scene to test local comment bundles 2020-02-26 18:31:01 +03:00
Andrei Zavatski
ae4f5cdf37 Add async loading support 2020-02-26 18:00:48 +03:00
Andrei Zavatski
56c41a614a Remove CommentsPage component 2020-02-26 17:38:50 +03:00
Dan Balasescu
37e9c2a683
Merge branch 'master' into user-list-toolbar 2020-02-26 10:11:21 +09:00
Andrei Zavatski
c1455be855 Add tests 2020-02-25 10:29:03 +03:00
Andrei Zavatski
d8413c558b Use fully qualified name for enum item description in CommentsHeader 2020-02-24 23:41:34 +03:00
Bartłomiej Dach
4cbb2a2f59 Move comment to more pertinent place 2020-02-24 21:30:27 +01:00
Andrei Zavatski
fe1f2858c1 Refactor to avoid duplicated code 2020-02-24 23:10:37 +03:00
Andrei Zavatski
b0b52146ea Fix crash when clicking on ShowMore button 2020-02-24 05:53:33 +03:00
Andrei Zavatski
0cfe1ac823 Implement UserSortTabControl component 2020-02-24 05:47:21 +03:00
smoogipoo
7fd71d9b6c Adjust conditional 2020-02-21 19:50:16 +09:00
smoogipoo
4c083e0e7e Add back orphaning as a fail-safe 2020-02-21 19:41:25 +09:00
smoogipoo
05ff4de944 Remove the concept of orphaning and refactor 2020-02-21 19:30:51 +09:00
smoogipoo
4c3468f40e Reorder file 2020-02-21 19:30:45 +09:00
smoogipoo
4fd420e61d Rename method 2020-02-21 19:30:39 +09:00
smoogipoo
a7b5117d88 Fix attempting to add parent comments twice 2020-02-21 19:30:33 +09:00
smoogipoo
1cd84754c8 Add back parent-child linking 2020-02-21 19:27:32 +09:00
smoogipoo
db78b95228 Remove duplicated api request 2020-02-21 19:27:25 +09:00
smoogipoo
41c6d2f2e7 Merge remote-tracking branch 'origin/master' into subcomments-alter-new 2020-02-21 17:02:58 +09:00
smoogipoo
37e295e4be Refactor orphaning to better follow osu-web specification 2020-02-21 17:02:48 +09:00
smoogipoo
5acaf9b371 Privatise setter 2020-02-21 12:33:49 +09:00
smoogipoo
2cb218c9c4 Merge remote-tracking branch 'origin/master' into comment-editor 2020-02-21 12:27:34 +09:00
Andrei Zavatski
c7d64d0015 Update BindableList usage in DrawableComment 2020-02-18 13:37:59 +03:00
Andrei Zavatski
3bf3becdd6 Merge remote-tracking branch 'refs/remotes/ppy/master' into subcomments-alter-new 2020-02-18 13:27:08 +03:00
Andrei Zavatski
a9f366fda3 Implement OverlaySortTabControl component 2020-02-17 02:20:53 +03:00
Bartłomiej Dach
0f25864fae Textbox -> TextBox rename pass 2020-02-13 21:04:53 +01:00
Andrei Zavatski
b1b2e4a041 Simplify parent comment assignment 2020-02-13 04:50:04 +03:00
Andrei Zavatski
c391a464a5 Add tests 2020-02-13 04:06:34 +03:00
Andrei Zavatski
483bbac6fd Simplify CommentsPage.onCommentRepliesReceived 2020-02-13 03:13:56 +03:00
Andrei Zavatski
b0db155565 Make replies addition more consistent 2020-02-13 02:47:13 +03:00
Andrei Zavatski
c6f8e157fd Make loadedReplies dictionary private 2020-02-13 02:37:41 +03:00
Andrei Zavatski
5201c1c87b Use new algorithm for comments tree creation 2020-02-13 02:21:13 +03:00
Andrei Zavatski
e2b3494352 Remove dependency on load state for DrawableComment.AddReplies 2020-02-13 00:19:21 +03:00
Andrei Zavatski
62051c036b Small CommitButton improvements 2020-02-12 13:43:56 +03:00
Andrei Zavatski
ab7adb3a97 Adjust button colours 2020-02-12 13:28:49 +03:00
Andrei Zavatski
9ac6c271ac Naming adjustments 2020-02-12 02:05:45 +03:00
Andrei Zavatski
53a2b65dbd Create dependency between textbox and commit button 2020-02-12 01:35:08 +03:00
Andrei Zavatski
5a3daf1bd7 Implement CommitButton 2020-02-12 00:57:06 +03:00
Andrei Zavatski
c022cf72b5 Implement CancellableCommentEditor 2020-02-11 20:47:51 +03:00
Andrei Zavatski
730c115f49 Fix some size values 2020-02-11 20:11:22 +03:00
Andrei Zavatski
829152c8e8 Implement EditorTextbox 2020-02-11 20:08:24 +03:00
Andrei Zavatski
482f622c94 CommentEditor basic implementation 2020-02-11 18:46:49 +03:00
Andrei Zavatski
15b4e3386f Fix incorrect algorithm for comment tree creation 
Can cause one comment to be redrawn multiple times
 2020-02-10 23:57:48 +03:00
Andrei Zavatski
d20a860879 CI fix 2020-02-10 16:08:58 +03:00
Andrei Zavatski
8239f21cad Remove whitespace 2020-02-10 15:52:12 +03:00
Andrei Zavatski
26afe0f31e Add ability to load long comment trees in CommentsContainer 2020-02-10 15:43:11 +03:00
Andrei Zavatski
5946ad7d80 Fix possible memory leak and better user change test support 2020-02-06 16:54:02 +03:00
Andrei Zavatski
a84068448a refetch comments on user change 2020-02-04 19:19:49 +03:00
Andrei Zavatski
5e369534b6 Allow guests to view comments 2020-02-04 19:15:23 +03:00
Andrei Zavatski
3b5b799d60 Adjust height of ShowMore button 2020-01-31 09:51:56 +03:00
Andrei Zavatski
4a444face1 Change ShowMoreButton hide logic 2020-01-31 09:46:35 +03:00
Andrei Zavatski
a8578c1526 Merge master with conflicts resolved 2020-01-30 10:08:02 +03:00
Dean Herbert
ebdb425c50 Rename and tidy up DeletedCommentsCounter 2020-01-30 11:17:26 +09:00
Andrei Zavatski
5fcda01346 Cleanup pass 2020-01-29 06:58:53 +03:00
Andrei Zavatski
dc10e58b4f Add tests for CommentsPage 2020-01-29 06:44:39 +03:00
Andrei Zavatski
e7964023ae Implement CommentsPage class 2020-01-29 06:22:08 +03:00
Andrei Zavatski
c5e0c77bca Refactor NoCommentsPlaceholder 2020-01-29 06:08:11 +03:00
Andrei Zavatski
b947e89a6b Add placeholder for no comments case in CommentsContainer 2020-01-28 16:53:22 +03:00
Andrei Zavatski
5a2fd18bdd Allow better async support for CommentsContainer 2020-01-28 10:21:27 +03:00
Andrei Zavatski
ce95b4a106 TotalCommentsCounter improvements 2020-01-28 05:57:45 +03:00
Andrei Zavatski
100532845b Recolour CommentsContainer 2020-01-27 15:07:24 +03:00
Andrei Zavatski
68503bf771 Recolour CommentsShowMoreButton 2020-01-27 15:00:56 +03:00
Andrei Zavatski
12ca28ea6d Recolour CommentsHeader 2020-01-27 14:58:27 +03:00
Andrei Zavatski
ed2737e027 Recolour TotalCommentCounter 2020-01-27 14:47:47 +03:00
Dean Herbert
5863576ce4 Add comment as to why counter is zeroes only in Show method 2020-01-24 11:42:33 +09:00
Andrei Zavatski
6493f24547 Add TotalCommentsCounter to CommentsContainer 2020-01-23 15:56:01 +03:00
Andrei Zavatski
0c3120d965 Fix possible crash due to not loaded api 2020-01-23 12:59:53 +03:00
Andrei Zavatski
667fdb907c Call the method directly rather that trigger a bindable 2020-01-23 12:21:16 +03:00
Andrei Zavatski
7dc03a1335 resetComments -> refetchComments 2020-01-07 12:30:06 +03:00
Andrei Zavatski
6adf5ba381 Use nullable long type for id value 2020-01-07 12:29:21 +03:00
Andrei Zavatski
e0f66928e6 Allow CommentsContainer refetch comments using a method 2020-01-07 01:07:50 +03:00
Andrei Zavatski
031bed15da Fix comments async loading wasn't really async 2020-01-06 20:56:32 +03:00
Dean Herbert
b85189f855 Merge remote-tracking branch 'upstream/master' into fix-spritetext-usage 2019-11-25 11:31:12 +09:00
Dean Herbert
45514ff660 Apply fixes 2019-11-25 11:30:55 +09:00
Dean Herbert
c2e85a2057 Apply CornerExponent fixes 2019-11-22 19:49:20 +09:00
Andrei Zavatski
509440ea14 TotalCommentsCounter implementation 2019-11-16 18:02:34 +03:00
Huo Yaoyuan
ccc8aa6fa4 Apply brace style. 2019-11-11 20:13:13 +08:00
Dean Herbert
5c47641608
Reorder conditional 2019-11-09 16:23:22 +09:00
Andrei Zavatski
4330507da8 Use api.IsLoggedIn 2019-11-06 12:46:25 +03:00
Andrei Zavatski
4730453083 Apply suggestions 2019-10-31 02:10:00 +03:00
Andrei Zavatski
8ad5ccda68 Test steps rearrangement and condition fix 2019-10-30 04:16:14 +03:00
Andrei Zavatski
2c31492bbe Fix comment can be voted if user is null 2019-10-30 03:27:06 +03:00
Andrei Zavatski
1502a6c631 Cleanups 2019-10-30 03:09:14 +03:00
Andrei Zavatski
092d16bb64 Dont use binding to set disabled value 2019-10-29 23:43:16 +03:00
Andrei Zavatski
30d9b21b86 Condition simplification 2019-10-29 21:57:20 +03:00
Andrei Zavatski
e287dae64b Fix VotePill can be activated by the comment sender 2019-10-29 21:25:48 +03:00
Andrei Zavatski
85769982a0 Refactor LoadingButton 2019-10-24 17:49:34 +03:00
Andrei Zavatski
b310fd9d44 Adjust naming inside the LoadingButton 2019-10-23 13:39:42 +03:00
Andrei Zavatski
9daafb4636 Simplify hover/unhover logic 2019-10-18 03:06:01 +03:00
Andrei Zavatski
22511e41e2 Use received data to set isVoted bindable 2019-10-17 23:20:01 +03:00
Andrei Zavatski
9ee63a8c1a Apply suggested changes 2019-10-17 16:28:32 +03:00
Andrei Zavatski
a858e713f8 Fix multiple spaces 2019-10-17 15:40:09 +03:00
Andrei Zavatski
6b196a6ce7 CI fixes 2019-10-17 15:24:51 +03:00
Andrei Zavatski
42cd4107a0 Implement CommentVoteRequest and adjust UI 2019-10-17 15:04:30 +03:00
Andrei Zavatski
a437ff74cc Move VotePill to it's own file 2019-10-17 14:18:31 +03:00
Andrei Zavatski
1f28c00594 UI implementation 2019-10-17 13:10:28 +03:00
Andrei Zavatski
38dcd42d08 Parse voted comments 2019-10-17 12:35:12 +03:00
Andrei Zavatski
2543de22bd Simplify DeletedChildrenPlaceholder behavior 2019-10-15 12:47:35 +03:00
Andrei Zavatski
7ba15df0c0 Convert to method group 2019-10-15 12:27:32 +03:00
Andrei Zavatski
d321794ef5 Make loadedTopLevelComments a local filed 2019-10-15 12:26:16 +03:00
Andrei Zavatski
96e31b9cca Add support for deleted comments with message 2019-10-15 12:07:01 +03:00
Andrei Zavatski
213f00556d Remove onShowDeletedChanged function 2019-10-15 11:30:50 +03:00
Andrei Zavatski
b2885e7b13 Move load() under the ctor 2019-10-15 11:26:58 +03:00
Andrei Zavatski
eb5dad08aa Remove initial filed 2019-10-15 11:25:58 +03:00
Andrei Zavatski
3c714dc013 APICommentsController -> CommentBundle 2019-10-15 11:20:06 +03:00
Andrei Zavatski
ad32d66365 CI fix 2019-10-15 01:10:23 +03:00
Andrei Zavatski
0fd6b0c852 Use linq expression to count deleted comments 2019-10-15 00:55:33 +03:00
Andrei Zavatski
b84c9dfd84 Use Humanizer.ToQuantity instead of manual parsing 2019-10-15 00:35:44 +03:00
Andrei Zavatski
09621f066e Childs -> Children 2019-10-15 00:32:21 +03:00
Andrei Zavatski
d4843285db CI fixes 2019-10-14 17:33:14 +03:00
Andrei Zavatski
139170cdc8 Fix incorrect padding for nested comments 2019-10-14 17:26:12 +03:00
Andrei Zavatski
b53fb0d228 Remove empty line 2019-10-14 17:07:50 +03:00
Andrei Zavatski
a81d5cd819 Handle links in message 2019-10-14 16:56:07 +03:00
Andrei Zavatski
7cd3f5656d Cleanups 2019-10-14 16:43:43 +03:00
Andrei Zavatski
7ac87494e0 Merge remote-tracking branch 'refs/remotes/ppy/master' into comments_api 2019-10-14 16:21:34 +03:00
Dean Herbert
f0e9700349 Inline delegate event 2019-10-14 21:49:02 +09:00
Dean Herbert
b7ddf160b4 OnClick should actually handle the event 2019-10-14 21:48:12 +09:00
Dean Herbert
4e6ab1dad3 Tidy up state management via bindable usage 2019-10-14 21:42:07 +09:00
Dean Herbert
7794457550 Remove more constants 2019-10-14 21:36:10 +09:00
Dean Herbert
4822496c13 Fix more naming 2019-10-14 21:34:16 +09:00
Dean Herbert
89f270a19a SortSelector -> SortTabControl 2019-10-14 21:32:41 +09:00
Dean Herbert
e191c2c50e Tidy up constants and method naming 2019-10-14 21:32:16 +09:00
Andrei Zavatski
328b4d6863 Cancel request on dispose 2019-10-13 16:22:10 +03:00
Andrei Zavatski
a44cc2e70b Implement CommentsShowMoreButton 2019-10-13 14:43:30 +03:00
Andrei Zavatski
60954f969d DeletedChildsPlaceholder refactor 2019-10-13 12:38:50 +03:00
Andrei Zavatski
795ce81468 Use async loading for comment pages 2019-10-13 12:10:01 +03:00
Andrei Zavatski
4d971e49ff Colours update 2019-10-13 11:50:27 +03:00
Andrei Zavatski
27e3ffd293 Update dependencies 2019-10-13 11:23:49 +03:00
Andrei Zavatski
b45e7246b8 Rename SortCommentsBy to CommentsSortCriteria 2019-10-10 15:56:08 +03:00