42060 Commits

This Branch

This Branch

All Branches

• Merge pull request #13860 from smoogipoo/fix-bindable-ctor

  Fix DifficultyBindable not binding correctly and not having default ctor

  Dean Herbert · 2021-07-13 13:42:44 +09:00
  5cff379cd9
• Merge branch 'master' into fix-bindable-ctor
  Dean Herbert · 2021-07-13 12:46:01 +09:00
  5af2190246
• Update framework
  Dean Herbert · 2021-07-13 12:35:25 +09:00
  ac15dae930
• Merge pull request #13823 from ekrctb/catch-editor-tests

  Add some tests for catch editor blueprints

  Dan Balasescu · 2021-07-13 08:27:41 +09:00
  351a46b379
• Merge pull request #13856 from peppy/fix-line-break

  Fix one new incorrect formatting inspection from EAP6

  Dan Balasescu · 2021-07-13 07:46:39 +09:00
  ba5d884ab0
• Change to alternative formatting
  Dean Herbert · 2021-07-12 18:08:19 +09:00
  78c74e97d1
• Merge pull request #13842 from peppy/fix-multiple-update-pompts

  Limit update notifications to once per startup

  Dan Balasescu · 2021-07-12 17:40:28 +09:00
  d85fc08d12
• Implement UnbindFrom()
  smoogipoo · 2021-07-12 17:33:29 +09:00
  4b393209ec
• Fix incorrect DifficultyBindable binding implementation
  smoogipoo · 2021-07-12 17:09:09 +09:00
  242982730f
• Merge pull request #13859 from peppy/update-realm-win-81-fix

  Update realm libraries to fix windows 8.1 incompatibility

  Dan Balasescu · 2021-07-12 16:40:35 +09:00
  36dd2c36de
• Force a re-check on any exception being thrown
  Dean Herbert · 2021-07-12 14:55:09 +09:00
  47a593ad7d
• Merge pull request #13701 from frenzibyte/consume-bindable-current-factory

  Fix `RestoreDefaultValueButton` not behaving correctly on number types

  Dean Herbert · 2021-07-12 14:49:00 +09:00
  d5d7dd0e74
• Update mobile projects' local references to older realm
  Dean Herbert · 2021-07-12 14:36:28 +09:00
  37dac1a775
• Update realm libraries to fix windows 8.1 incompatibility
  Dean Herbert · 2021-07-12 14:07:17 +09:00
  f548ba4f69
• Fix one new incorrect formatting inspection from EAP6
  Dean Herbert · 2021-07-12 12:35:40 +09:00
  3642febbb6
• Merge pull request #13824 from peppy/da-mod-refactor

  Refactor `ModDifficultyAdjust` to more elegantly track user override status

  Dan Balasescu · 2021-07-12 12:03:45 +09:00
  0c52b26d23
• Merge pull request #13839 from peppy/fix-migration-test-failure

  Fix migration target having left over files potentially causing test failures

  Dan Balasescu · 2021-07-12 11:47:18 +09:00
  ffa60479c9
• Make CurrentNumber internal
  Dean Herbert · 2021-07-12 11:26:30 +09:00
  a6258d705e
• Adjust test case slightly
  Bartłomiej Dach · 2021-07-11 17:26:00 +02:00
  9e70136100
• Do not store direct references to original bindable

  `DifficultyAdjustSettingsControl` and its inner `SliderControl` were
  holding different references to `DifficultyBindable`s from the
  difficulty adjust mod, therefore leading to bindings being lost to the
  framework-side automatic unbind logic if the mod was toggled off and
  back on in rapid succession.
  
  Resolve by adding a shadowed implementation of `GetBoundCopy()` and
  using it to isolate the controls from the mod bindable.

  Bartłomiej Dach · 2021-07-11 15:28:13 +02:00
  32b4f5fbd6
• Merge pull request #13853 from frenzibyte/disallow-custom-ruleset-score-submission

  Disallow custom rulesets from attempting to submit scores

  Dean Herbert · 2021-07-11 15:21:38 +09:00
  e0b2356bb0
• Add missing osu!catch difficulty adjust attributes
  Dean Herbert · 2021-07-11 10:14:42 +09:00
  79d546afa2
• Update player test scene Ruleset bindable from creation method
  Salman Ahmed · 2021-07-11 03:46:19 +03:00
  f21ea3b790
• Add test coverage for excluded cases in score submission
  Salman Ahmed · 2021-07-11 03:35:35 +03:00
  6b8de2a10b
• Disallow custom rulesets from score submission
  Salman Ahmed · 2021-07-11 03:34:57 +03:00
  07ede7a147
• Add simple test cases
  Salman Ahmed · 2021-07-10 19:56:44 +03:00
  a1f3adc320
• Add back LoadComplete override
  Salman Ahmed · 2021-07-10 17:57:52 +03:00
  c44558e3c8
• Merge pull request #13840 from peppy/fix-run-from-screen-test-failures

  Ensure run-from-screen song select reaches correct point in execution

  Bartłomiej Dach · 2021-07-10 14:13:21 +02:00
  236e8019cc
• Merge branch 'master' into fix-run-from-screen-test-failures
  Bartłomiej Dach · 2021-07-10 13:37:20 +02:00
  08cd17435c
• Merge pull request #13838 from peppy/fix-access-denied-test-failures

  Fix test failures due to logger pollution

  Bartłomiej Dach · 2021-07-10 13:36:33 +02:00
  94406d77de
• Merge branch 'master' into fix-access-denied-test-failures
  Bartłomiej Dach · 2021-07-10 13:00:27 +02:00
  1bd5b1a8b9
• Merge pull request #13828 from ekrctb/catch-editor-selection-confine

  Don't move selected objects outside the playfield in catch editor

  Dean Herbert · 2021-07-10 19:30:32 +09:00
  c64fe06bf6
• Update test to match expectations after refactor
  Bartłomiej Dach · 2021-07-10 11:44:32 +02:00
  b705213ea9
• Merge branch 'master' into da-mod-refactor
  Bartłomiej Dach · 2021-07-10 11:41:54 +02:00
  6f89f8e572
• Invert strangely negated condition
  Bartłomiej Dach · 2021-07-10 11:23:38 +02:00
  c5011865fc
• Fix up English in comment
  Bartłomiej Dach · 2021-07-10 11:22:54 +02:00
  494089e402
• Merge pull request #13841 from peppy/update-song-progress-keyboard-handling

  Move handling of replay seek operations out of progress bar

  Bartłomiej Dach · 2021-07-10 11:17:40 +02:00
  e8005e3bfb
• Limit update notifications to once per startup

  This logic was intentionally designed to continue to prompt the user to
  update if they haven't, but that seems pretty anti-user. The change will
  stop the update prompts from showing more than once per game startup,
  unless manually invoked by the user a second time.
  
  Closes https://github.com/ppy/osu/issues/13821.

  Dean Herbert · 2021-07-09 18:23:30 +09:00
  a9250a0d98
• Remove previous seek testing logic from common test scene
  Dean Herbert · 2021-07-09 16:52:03 +09:00
  6ae631b03a
• Modify comment
  ekrctb · 2021-07-09 15:13:54 +09:00
  995ef953c6
• Add test coverage of seeking and pausing
  Dean Herbert · 2021-07-09 14:47:11 +09:00
  9083b28114
• Move handling of replay seek operations out of progress bar

  This is in order to avoid using the now obsoleted property
  `SliderBar.AllowKeyboardInputWhenNotHovered`
  (see https://github.com/ppy/osu-framework/pull/4579).

  Dean Herbert · 2021-07-09 14:28:59 +09:00
  6a5f0e8237
• Simplify bindable update methods
  Dean Herbert · 2021-07-09 13:58:44 +09:00
  741062a6da
• Refactor DifficultyAdjustSettingsControl to help with readability
  Dean Herbert · 2021-07-09 13:50:07 +09:00
  e0277763d0
• Update override matching test to match expectations
  Dean Herbert · 2021-07-09 13:30:14 +09:00
  51bd83b3f4
• Allow null values for ReadCurrentFromDifficulty

  As long as this isn't a constructor parameter it feels best to
  gracefully handle omission. Realistically having it in the ctor is the
  best move, but it doesn't feel great in line with the other parameters
  passed in via object initalisers.

  Dean Herbert · 2021-07-09 13:26:01 +09:00
  f9cd7f10d8
• Standardise variables
  Dean Herbert · 2021-07-09 13:24:26 +09:00
  90326f8864
• Fix storage wrapping logic setting logger too early in startup sequence
  Dean Herbert · 2021-07-09 13:18:49 +09:00
  df4bd86cfc
• Fix storage wrapping logic setting logger too early in startup sequence
  Dean Herbert · 2021-07-09 13:17:25 +09:00
  f3b68a4fbf
• Expand the selection movement limiting code with detailed comments
  ekrctb · 2021-07-09 12:58:08 +09:00
  7e14679606