123 Commits

• Prevent scores being calculated twice
  Dan Balasescu · 2022-03-30 13:15:41 +09:00
  4df63a4900
• Fix scores sometimes shown with incorrect scoring mode
  Dan Balasescu · 2022-03-30 13:03:12 +09:00
  bd9c0076df
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Add note about null return value
  Salman Ahmed · 2022-03-20 16:24:30 +03:00
  aef40da8d4
• GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync
  Salman Ahmed · 2022-03-20 16:18:53 +03:00
  2a78042038
• Introduce method for computing maximum achievable combo properly
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  d36f32a9c9
• Merge branch 'master' into scoreprocessor-rework
  Dean Herbert · 2022-03-09 23:04:18 +09:00
  94ff6a338f
• Rework GetScore() method signatures + implementations

  Rename legacy-facing overload to mention as much

  Dan Balasescu · 2022-03-08 22:30:44 +09:00
  f1c40bd9ed
• Fix scores not being recalculated in beatmap listing
  Dan Balasescu · 2022-03-08 19:07:39 +09:00
  f5cd967635
• Scale classic score by hitobject count
  Dan Balasescu · 2022-02-21 13:31:03 +09:00
  c3b365cf6b
• Remove IIpcHost param from ScoreManager

  No longer used since 3e3b9bc963.

  Bartłomiej Dach · 2022-02-01 21:35:40 +01:00
  16e0cc6a2b
• Fix delete local scores crashing the game
  Dean Herbert · 2022-01-28 15:54:53 +09:00
  0d3ac4fd9c
• Remove ILive<> interface (and use abstract Live<> instead)
  Dean Herbert · 2022-01-26 13:38:56 +09:00
  cd71ec0edd
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Update all usages of CreateContext to use either Run or Write
  Dean Herbert · 2022-01-21 17:27:08 +09:00
  114c9e8c1f
• Fix playlist aggregate scores not displaying (again)
  Dean Herbert · 2022-01-18 11:57:38 +09:00
  ebc9d3a613
• Remove incorrect IsManaged check in ScoreManager
  Dean Herbert · 2022-01-17 13:37:42 +09:00
  d27ee2c9fb
• Add back null beatmap allowance to GetTotalScore flow to fix playlist aggregate scores
  Dean Herbert · 2022-01-17 13:11:43 +09:00
  a3806f44a5
• Replace compatibility properties with direct references
  Dean Herbert · 2022-01-12 18:13:14 +09:00
  eb70a1eeb7
• Move manager Update methods to be explicit to where they are still used by legacy code

  Also fixes skin hash repopulation being completely broken.

  Dean Herbert · 2022-01-12 17:49:11 +09:00
  a4de0f93fa
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• Remove updated/removed flow method mapping
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  fe8a5e867d
• Update ToLive usages in line with recent changes
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  1f9318265e
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• Reimplement all query methods
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  4f6a05ce3d
• more fixes (almost compiles, except ruleset and manager)
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  53792811b2
• Update many score-related classes to move closer to being able to persist to realm
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  2a4bee61dd
• Use RealmContextFactory instead of EF
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  89d6ffa7f3
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Update continuation usages to use GetCompletedResult
  Dean Herbert · 2022-01-06 22:53:07 +09:00
  3ea7588a91
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Use OnlineID instead of legacy IDs for equality and lookups
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  bf1418bafc
• Merge pull request #15795 from peppy/realm-integration/separate-download-flow

  Split out download logic from main manager classes

  Dan Balasescu · 2021-11-25 20:59:23 +09:00
  f712aeee01
• Remove unused using
  Dan Balasescu · 2021-11-25 19:36:06 +09:00
  8baf00c023
• Merge branch 'master' into realm-integration/stable-export-flow
  Dan Balasescu · 2021-11-25 19:06:18 +09:00
  d3a4890c31
• Move score download logic out of ScoreManager
  Dean Herbert · 2021-11-25 17:33:04 +09:00
  a2ab9f457d
• Split out legacy model export logic into LegacyModelExporter classes
  Dean Herbert · 2021-11-25 16:41:12 +09:00
  cc1b91e4bd
• Merge branch 'master' into realm-integration/stable-import-flow
  Dan Balasescu · 2021-11-25 16:36:02 +09:00
  6d60725b31
• Move stable import handling into its own class
  Dean Herbert · 2021-11-25 15:36:58 +09:00
  6cab7b877d
• Reduce interface exposure of ScoreManager
  Dean Herbert · 2021-11-25 14:34:13 +09:00
  60b207f20a
• Change difficulty cache storage type to nullable

  The recent changes related to adding support for working beatmap load
  cancellation exposed a flaw in the beatmap difficulty cache. With the
  way the difficulty computation logic was written, any error in the
  calculation process (including beatmap load timeout, or cancellation)
  would result in a 0.00 star rating being permanently cached in memory
  for the given beatmap.
  
  To resolve, change the difficulty cache's return type to nullable.
  In failure scenarios, `null` is returned, rather than
  `default(StarDifficulty)` as done previously.

  Bartłomiej Dach · 2021-11-20 17:00:50 +01:00
  15feb17da8
• Fix incorrectly specified events
  Dean Herbert · 2021-11-06 22:31:49 +09:00
  89cc2523ef
• Merge branch 'master' into remove-stupid-weak-reference-bindable-events
  Dean Herbert · 2021-11-06 14:08:39 +09:00
  2881ce0f5a
• Revert weird event flow in model manager/importers
  Dean Herbert · 2021-11-05 19:12:49 +09:00
  54f72d68ca
• Move second generic to abstract model downloader rather than interface type
  Dean Herbert · 2021-11-05 17:37:05 +09:00
  6c385ccd29
• Remove importer inheritance from IModelManager

  Now only exists in legacy implementations, to reduce inheritance
  complexity of interfaces which are going to be used going forwards.

  Dean Herbert · 2021-11-05 16:45:38 +09:00
  b90f44493c
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Update usages of OnlineID
  Dean Herbert · 2021-10-18 16:16:36 +09:00
  b3219bb592