Dean Herbert
cd8dc9b17b
Rename "Target" to "Target Practice"
2022-11-01 19:47:20 +09:00
Dean Herbert
f014acfc8d
Fix DrawableHitObject.AccentColour
not being updated if object entry is not attached
2022-11-01 19:34:53 +09:00
Dean Herbert
ff60eebe21
Fix large transform retention when adjusting accent colour of hitobject during pause
2022-11-01 19:12:59 +09:00
Dean Herbert
c179f0bb52
Fix argon hit circle outer gradient getting smaller each state application
2022-11-01 18:31:30 +09:00
Dean Herbert
ddb3d8326e
Merge pull request #21054 from smoogipoo/adjust-mod-multipliers
...
Adjust target and hold off mod multipliers
2022-11-01 18:12:56 +09:00
Dan Balasescu
37407293aa
Adjust target and hold off mod multipliers
2022-11-01 17:57:20 +09:00
Dean Herbert
27af91003b
Merge branch 'master' into combo-colour-brightness-limit
2022-11-01 17:50:26 +09:00
Dean Herbert
978d15955c
Fix control points not being cloned when running beatmap conversion
...
Closes #20994 .
I haven't considered how this affects performance of difficulty
calculation or otherwise. Seems like a sane initial fix which we can
iterate on going forward.
I've tested using the scenario in the linked issue.
I'm not going to add test coverage because
[BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs )
should correctly cover this scenario once we are serialising control
points as well.
2022-11-01 17:42:09 +09:00
Dean Herbert
17b435db35
Merge pull request #21050 from peppy/fix-safe-area-initial-state
...
Fix notch toggle not applying correctly after restart
2022-11-01 17:20:17 +09:00
Dean Herbert
29bc653d24
Remove incorrect double multiplication and add missing test coverage
2022-11-01 17:17:54 +09:00
Dean Herbert
d15585153d
Fix breadcrumb display in directory selector overlapping new "show hidden" button
...
Closes #21034 .
2022-11-01 17:07:59 +09:00
Dean Herbert
8280605e92
Fix notch toggle not applying correctly after restart
2022-11-01 16:31:09 +09:00
Dean Herbert
d807d9d822
Add failing test covering snap calculations with SV applied
2022-11-01 16:22:48 +09:00
Dean Herbert
e8b7914295
Add test coverage of new parameter
2022-11-01 15:13:05 +09:00
Dean Herbert
2a88409dfe
Fix time snap of sliders not matching when SV is not 1.0x
...
This regressed with https://github.com/ppy/osu/pull/20850 because the
function was used in other places which expect it to factor slider
velocity into the equation.
Rather than reverting, I've added a new argument, as based on the method
naming alone it was hard to discern whether SV should actually be
considered.
The reason for the change in #20850 was to avoid the SV coming in from a
reference object which may not have a correct SV in the first place. In
such cases, passing `false` to the function will give the expected
behaviour.
2022-11-01 15:12:58 +09:00
Dan Balasescu
00bd77ce76
Merge pull request #21045 from peppy/improve-ruleset-load-fail-message
...
Improve messaging when ruleset load fails
2022-11-01 14:36:40 +09:00
Dean Herbert
706adfb28c
Improve messaging when ruleset load fails
2022-11-01 13:57:34 +09:00
Dan Balasescu
9065cb0526
Merge branch 'master' into stamina-available-fingers
2022-11-01 13:05:25 +09:00
Dan Balasescu
720d6b5996
Merge branch 'master' into stamina-available-fingers
2022-11-01 13:01:31 +09:00
OliBomby
0461303895
Change return type to List
2022-10-31 11:39:41 +01:00
OliBomby
414e21c657
Added xmldoc to public methods
2022-10-31 11:39:14 +01:00
Dean Herbert
17f482bfc3
Merge branch 'master' into websocket-chat-2
2022-10-31 16:11:58 +09:00
Dean Herbert
8a37649097
Merge branch 'master' into socket-client
2022-10-31 16:00:14 +09:00
Dean Herbert
e38ba5e4c6
Apply nullability to new test scene
2022-10-31 15:46:57 +09:00
Dean Herbert
94dd4045f1
Remove borrowed framework code
2022-10-31 15:42:17 +09:00
Dean Herbert
31ba77e378
Merge branch 'master' into bezier-convert
2022-10-31 15:41:08 +09:00
Dean Herbert
4213abfc46
Adjust testflight cleanup interval to 30 days
...
Been using this for a while but haven't committed it.
2022-10-31 12:55:23 +09:00
Dean Herbert
3f17c206d2
Update fastlane
and dependencies
2022-10-31 12:49:50 +09:00
Dean Herbert
9ea2bd84bd
Merge pull request #21018 from andy840119/reuse-the-function-in-timeline-class
...
Reuse function in the timeline class
2022-10-30 23:49:02 +09:00
Bartłomiej Dach
93c3bc6550
Merge pull request #21020 from peppy/fix-pause-button-interaction
...
Fix hold to pause button not working when HUD is hidden
2022-10-30 14:23:18 +01:00
Dean Herbert
1035b5fb19
Fix hold to pause button not working when HUD is hidden
2022-10-30 21:38:45 +09:00
Dean Herbert
8399261c77
Add failing test showing hold for menu not working when HUD is hidden
2022-10-30 21:38:31 +09:00
Dean Herbert
f5e11343c2
Apply nullability to HUD test scene
2022-10-30 21:25:31 +09:00
Dean Herbert
aa9604c49e
Merge pull request #21014 from Joehuu/fix-toolbar-clock-visual-bug
...
Fix toolbar visual bug when toggling clock displays
2022-10-30 18:32:14 +09:00
andy840119
a753369d3e
Reuse function TimeAtPosition()
and PositionAtTime()
.
2022-10-30 17:21:50 +08:00
andy840119
c8c76f2351
Use AsNonNull() because the type does not accept the null case.
2022-10-30 17:03:54 +08:00
andy840119
500bf90a34
Mark as accept the nullable stream.
2022-10-30 17:03:54 +08:00
andy840119
6ce3841686
Remove nullable disable annotation in the test case.
2022-10-30 17:03:54 +08:00
andy840119
4c9c65856c
Remove the nullable disable annotation in the testing beatmap and mark some of the properties as nullable.
...
This class will be used in some check test cases.
2022-10-30 17:03:54 +08:00
andy840119
a1a9238bd1
Use empty string instead of null because issue template not accept null.
2022-10-30 16:31:07 +08:00
andy840119
505ec800da
File name should be nullable.
2022-10-30 16:29:54 +08:00
andy840119
db48a57fa7
Remove nullable disable annotation in some checks class.
2022-10-30 16:28:49 +08:00
andy840119
24c27e62f6
Remove nullable disable annotation in the issue and issue template-related class.
2022-10-30 16:25:15 +08:00
Joseph Madamba
d56786b5ff
Fix toolbar visual bug when toggling clock displays
2022-10-29 15:25:16 -07:00
Bartłomiej Dach
933d1d549b
Merge pull request #20983 from peppy/safe-area-toggle
...
Add setting to allow forcing the game to draw over notches / cameras
2022-10-29 13:49:17 +02:00
Bartłomiej Dach
71d87489ab
Merge branch 'master' into safe-area-toggle
2022-10-29 13:19:44 +02:00
Bartłomiej Dach
96436b065a
Merge pull request #20948 from nullium21/fix-filename-char-filtering
...
Only use alphanumeric + some special characters in filenames
2022-10-29 13:19:27 +02:00
Bartłomiej Dach
f775741d65
Merge branch 'master' into fix-filename-char-filtering
2022-10-29 12:42:10 +02:00
Bartłomiej Dach
09b676ec20
Merge pull request #20993 from peppy/improve-argon-bananas
...
Improve osu!catch "argon" skin bananas
2022-10-29 12:41:53 +02:00
Bartłomiej Dach
87fc5be562
Merge branch 'master' into improve-argon-bananas
2022-10-29 12:09:24 +02:00