Dean Herbert
58217b6839
Fix weird conditional
2022-09-27 20:09:21 +09:00
Dean Herbert
a9088d9231
Add assert/log output when too many ticks are being displayed
2022-09-27 17:18:46 +09:00
Dean Herbert
e227519b09
Don't attempt to render timeline ticks until DrawWidth is above zero
2022-09-27 17:18:46 +09:00
Dean Herbert
ccae721af2
Ensure ZoomableScrollContainer content isn't shown until zoom is set
2022-09-27 17:07:11 +09:00
Dean Herbert
9dc0eb7fd0
Remove unused static
2022-09-27 17:04:56 +09:00
Dan Balasescu
aa3956cfbb
Merge pull request #20495 from Feodor0090/playlist-overflow-fix
...
Fix playlist overlay overflowing at high UI scales
2022-09-27 13:53:14 +09:00
Dan Balasescu
3d57e30c35
Merge pull request #20498 from peppy/fix-rank-history-serialisation-order
...
Fix `rank_history` serialisation order dependence
2022-09-27 13:44:03 +09:00
Dean Herbert
de6709d12c
Fix rank_history serialisation order dependence
...
```csharp
[network] 2022-09-26 18:18:39 [verbose]: Processing response from https://dev.ppy.sh/api/v2/me/ failed with Newtonsoft.Json.JsonSerializationException: Error setting value to 'rankHistory' on 'osu.Game.Online.API.Requests.Responses.APIUser'.
[network] 2022-09-26 18:18:39 [verbose]: ---> System.NullReferenceException: Object reference not set to an instance of an object.
[network] 2022-09-26 18:18:39 [verbose]: at osu.Game.Online.API.Requests.Responses.APIUser.set_rankHistory(APIRankHistory
value) in /tmp/osu/osu.Game/Online/API/Requests/Responses/APIUser.cs:line 231
```
2022-09-27 12:46:17 +09:00
Dean Herbert
f177b43034
Merge pull request #20497 from frenzibyte/fix-skinnable-test-scene-sizing
...
Fix `SkinnableTestScene` sizing logic potentially failing to work
2022-09-27 12:16:30 +09:00
Salman Ahmed
8aff856c79
Fix SkinnableTestScene sizing logic potentially failing to work
2022-09-27 05:18:17 +03:00
Dan Balasescu
785d53ad9b
Merge pull request #20477 from peppy/fix-slider-ticks-appearing-too-late
...
Fix osu! slider ticks appearing too late
2022-09-26 18:55:55 +09:00
Dan Balasescu
836da6a5e6
Merge pull request #20485 from peppy/leaderboard-nrt
...
Apply NRT to leaderboard hierarchy
2022-09-26 18:53:37 +09:00
Dan Balasescu
e5894ccd6f
Merge pull request #20478 from peppy/fix-progress-notification-fling
...
Fix progress notifications being able to be flung (and cancelled)
2022-09-26 18:21:12 +09:00
Dan Balasescu
d2669762ab
Merge branch 'master' into fix-slider-ticks-appearing-too-late
2022-09-26 18:21:08 +09:00
Dan Balasescu
f2eed881bd
Merge pull request #20480 from peppy/fix-drawable-mutation-tablet-settings
...
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 18:16:52 +09:00
Dan Balasescu
525de8c140
Merge pull request #20479 from peppy/fix-drawable-mutation-misc
...
Fix potential crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 18:02:28 +09:00
Dean Herbert
0f18bef3f3
Fix incorrect test assumptions
2022-09-26 17:59:39 +09:00
Dan Balasescu
987294f294
Merge pull request #20483 from peppy/music-controller-thread-safety
...
Move `MusicController` binds to `LoadComplete` for added thread safety
2022-09-26 17:59:02 +09:00
Dan Balasescu
c969afcb71
Merge branch 'master' into leaderboard-nrt
2022-09-26 17:12:19 +09:00
Dan Balasescu
28470bd5c0
Merge pull request #20486 from peppy/gameplay-leaderboard-nrt
...
Apply NRT to `GameplayLeaderboard` hierarchy
2022-09-26 17:11:51 +09:00
Dan Balasescu
426ab176d6
Merge pull request #20418 from peppy/fix-leaderboard-crash
...
Fix intermittent leaderboard crash due to request finishing after drawable is disposed
2022-09-26 17:10:32 +09:00
Dean Herbert
20da1051d9
Apply NRT to GameplayLeaderboard hierarchy
...
Just some cleanup work that I wanted to do as part of my last changes.
2022-09-26 16:21:24 +09:00
Dean Herbert
5fc836d1f0
Apply NRT to BeatmapLeaderboard / MatchLeaderboard
2022-09-26 16:17:28 +09:00
Dean Herbert
a1297af441
Apply NRT to base Leaderboard classes
2022-09-26 16:12:47 +09:00
Dean Herbert
32d56fe3a9
Use request cancellation and IsDisposed guard instead of more Schedule
2022-09-26 16:02:33 +09:00
Dean Herbert
4e9b25d8b0
Move MusicController binds to LoadComplete for added thread safety
2022-09-26 15:42:37 +09:00
Dean Herbert
43c16cb613
Fix potential crash from incorrect drawable mutation in tablet settings display
2022-09-26 15:10:02 +09:00
Dean Herbert
c4887269f7
Avoid performing a realm write if there are no changes pending in RulesetConfigManager
2022-09-26 14:55:23 +09:00
Dean Herbert
4bd96108c0
Fix crash on game exit due to incorrect scheduling of realm change handler
2022-09-26 14:45:17 +09:00
Dean Herbert
b6dd8168d2
Fix progress notifications being able to be flung
2022-09-26 14:33:12 +09:00
Dean Herbert
82d4689716
Add failing test showing progress notifications can be flung and cancelled
2022-09-26 14:33:12 +09:00
Dean Herbert
a7449380cd
Fix osu! slider ticks appearing too late
2022-09-26 14:11:59 +09:00
Dean Herbert
1eaaf80b99
Merge pull request #20468 from sashashura/patch-1
...
GitHub Workflows security hardening
2022-09-26 09:48:32 +09:00
Dean Herbert
f6b635a8fe
Merge pull request #20472 from o-dasher/cleanup-bindings
...
Cleanup bindings instantiation
2022-09-26 09:46:31 +09:00
o-dasher
ced7212660
Fixes syntax error
2022-09-25 16:33:39 -04:00
o-dasher
a9318e5c04
Fixes small oversight
...
was applying a value when it wasn't supposed to be applied.
2022-09-25 16:32:16 -04:00
o-dasher
578f1e1e6c
Fixes SizeMultiplier binding
2022-09-25 16:28:03 -04:00
o-dasher
feadac1f79
Cleanup all other leftover binding instantiation
2022-09-25 16:02:40 -04:00
o-dasher
537796c3a1
Cleanup mod bindings
2022-09-25 15:49:22 -04:00
Alex
68f62ca9cd
build: harden sentry-release.yml permissions
...
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-25 18:04:27 +02:00
Alex
90dd3c3020
build: harden report-nunit.yml permissions
...
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-25 18:03:13 +02:00
Alex
38f0524e88
build: harden ci.yml permissions
...
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-25 18:00:28 +02:00
ansel
5d0b2d34c9
Make playlist to always be in screen bounds
2022-09-24 23:35:06 +03:00
ansel
6c8e587344
Move margin value to constant
2022-09-24 21:52:16 +03:00
Dean Herbert
96bcfea26f
Merge pull request #20424 from peppy/fix-argon-slider-point-colour
...
Fix slider tick colour not being applied properly
2022-09-24 02:10:03 +09:00
Dean Herbert
7bacd36825
Merge pull request #20417 from peppy/fix-main-menu-storyboard-crash
...
Fix crash when storyboard attempts to play at main menu
2022-09-24 02:09:46 +09:00
Salman Ahmed
ddbbd594c6
Merge branch 'master' into fix-main-menu-storyboard-crash
2022-09-23 18:56:17 +03:00
Salman Ahmed
f88ef39659
Merge pull request #20419 from peppy/fix-drawable-mutation-batch
...
Fix off-thread drawable mutation in multiplayer settings overlay when an error occurs
2022-09-23 18:13:06 +03:00
Salman Ahmed
835cae3087
Remove null conditional
2022-09-23 17:06:55 +03:00
Dean Herbert
965d0603ce
Fix slider tick colour not being applied properly
2022-09-23 21:11:25 +09:00
