1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 18:52:56 +08:00
Commit Graph

6539 Commits

Author SHA1 Message Date
Bartłomiej Dach
237c063015
Fix typo in multipleIncrementMods variable name 2021-10-09 14:26:32 +02:00
Dean Herbert
42d3fe8f02 Merge branch 'master' into fix-SettingsTextBox-using-null-as-default 2021-10-08 13:37:28 +09:00
Dan Balasescu
f8e50731b7
Merge pull request #14991 from peppy/intro-tests-no-menu-load
Allow intro screens to be created without loading a `MainMenu`
2021-10-07 20:48:54 +09:00
Dean Herbert
ba84da6ef8 Tidy up test scene 2021-10-07 20:08:28 +09:00
Dean Herbert
b88d4f1913 Fix weird edge case in TestSceneIntroWelcome 2021-10-07 19:58:34 +09:00
Dean Herbert
ef64c64f0b
Merge branch 'master' into popup-filter-effect 2021-10-07 18:56:07 +09:00
Dean Herbert
e578046b20 Rename Filter -> AudioFilter 2021-10-07 18:50:08 +09:00
Dean Herbert
0348c6c7e5 Apply some renaming and code quality fixes 2021-10-07 18:49:22 +09:00
Dan Balasescu
bece807857
Merge pull request #14980 from peppy/difficulty-move-to-beatmap
Copy `BaseDifficulty` to `Beatmap<T>` and move the majority of write operations across
2021-10-07 18:43:44 +09:00
Dean Herbert
f98dd1b811
Merge branch 'master' into popup-filter-effect 2021-10-07 18:40:21 +09:00
Dean Herbert
189358240d Fix intro tests and move steps out of constructor 2021-10-07 18:39:48 +09:00
Dan Balasescu
7074021d1f
Merge branch 'master' into test-scene-osu-game-fix-async-disposal-contention 2021-10-07 17:47:11 +09:00
smoogipoo
e586fee091 Remove unused usings 2021-10-07 17:46:30 +09:00
Dan Balasescu
0e0779e45b
Merge pull request #14988 from peppy/remove-gameplay-mod-bindable-storage
Remove local overridden storage of `Mods` in `Player`
2021-10-07 17:36:23 +09:00
Dan Balasescu
d50443fdf2
Merge branch 'master' into difficulty-move-to-beatmap 2021-10-07 16:50:10 +09:00
Dean Herbert
7e0379441c Change TestSceneOsuGame to use OsuGameTestScene to avoid async disposal deadlock
The original implementation was done so in a way that the nested `OsuGame` would be disposed via the async queue, causing a deadlock for 10-20s during test runs. `OsuGameTestScene` was already fixed to avoid this, so consuming it here seems like the easy fix.
2021-10-07 16:18:48 +09:00
Dean Herbert
0bd5136a29 Fix TestOverlayClosing occasionally failing due to running too fast 2021-10-07 15:55:29 +09:00
Dean Herbert
697f53c445 Fix test failure due to reference of Player.Mods 2021-10-07 15:00:47 +09:00
Jamie Taylor
fc0c3e8758
Attach filters at load time 2021-10-06 17:32:28 +09:00
smoogipoo
456cfd62bf Fix intermittent score panel test failure 2021-10-06 16:46:27 +09:00
Dean Herbert
4ca97bc60a
Merge branch 'master' into difficulty-move-to-beatmap 2021-10-06 16:14:21 +09:00
Dean Herbert
b339c149d8 Copy BaseDifficulty to Beatmap<T> and move all write operations across 2021-10-06 15:10:45 +09:00
Dan Balasescu
80c8612630
Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation
Fix changes not being reflected immediately after exiting the editor
2021-10-06 13:51:21 +09:00
Dean Herbert
6e797ddcac Add test coverage of creating, saving and loading a new beatmap 2021-10-06 12:55:04 +09:00
Dan Balasescu
4bbff2ebf7
Merge branch 'master' into new-interfaces 2021-10-06 11:38:17 +09:00
Dan Balasescu
9491e5a547
Merge pull request #14954 from peppy/rename-result-response
Rename `APIRequest.Result` to `Response`
2021-10-06 10:52:33 +09:00
Dan Balasescu
007e5f174c
Merge pull request #14959 from peppy/add-screen-test-debug
Add various logging output in an atttempt to figure multiplayer test failure
2021-10-06 10:11:50 +09:00
Dan Balasescu
4e13af6524
Merge pull request #14957 from peppy/fix-song-select-test-failure
Fix `TestDifficultyIconSelectingForDifferentRuleset` potentially failing due to async load
2021-10-06 10:10:57 +09:00
Dan Balasescu
23f9b7a740
Merge pull request #14958 from peppy/fix-delete-local-score-test-failure
Fix delete local score test not waiting for "fetch" to complete
2021-10-06 10:09:26 +09:00
Dean Herbert
d6f25e07cc Add assert coverage of non-downloadable states 2021-10-06 05:49:18 +09:00
Dean Herbert
31c0c7a888 Remove pointless (and incorrect) click step 2021-10-06 05:49:04 +09:00
Dean Herbert
1a784b788d
Fix incorrect load state check
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-10-06 05:31:07 +09:00
Dean Herbert
777763a550 Add more comprehensive (and failing) test coverage of replay download button 2021-10-06 05:29:00 +09:00
Bartłomiej Dach
12da27cde7
Add test coverage for loading process on channel join 2021-10-05 20:52:40 +02:00
Dean Herbert
6f7b8293af
Merge pull request #14919 from smoogipoo/realtime-pp-display
Implement real-time PP counter
2021-10-05 20:50:03 +09:00
Dean Herbert
98fef6ece2 Handle judgement reverts with actual display updates 2021-10-05 19:08:30 +09:00
Dean Herbert
e6efdae7c9 Add various logging output in an atttempt to figure multiplayer test failure 2021-10-05 18:53:20 +09:00
Dean Herbert
5d708b612d Fix delete local score test not waiting for "fetch" to complete
Even though this is a completely local operation in this case, there's
still a level of asynchronous operation which was recent introduced with
the score ordering:

853cf6feaa/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs (L159)

This means there is a brief period where the `Scores` property is null,
after `Reset()` is called in the re-fetch procedure.
2021-10-05 18:17:22 +09:00
Dean Herbert
94153e8bba Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load 2021-10-05 18:06:24 +09:00
Dean Herbert
0859c336de Also dim counter during initial calculation phase 2021-10-05 17:24:36 +09:00
Dean Herbert
04538a69e4 Add assert tests 2021-10-05 17:10:24 +09:00
Dean Herbert
eeb5f3d519 Add basic test scene 2021-10-05 16:51:43 +09:00
Dean Herbert
d3b9660148 Move common interface implementations to extension methods 2021-10-05 14:41:14 +09:00
Dean Herbert
b41fa41c85 Rename APIRequest.Result to Response 2021-10-05 14:28:56 +09:00
smoogipoo
86df4919f7 Fix skin fallbacks test 2021-10-05 11:06:26 +09:00
Dean Herbert
15ec315ec6 Fix test runs hanging due to missing ConfigureAwait 2021-10-05 02:07:00 +09:00
Dean Herbert
57c5be39d3 Merge branch 'master' into remove-local-realm-thread-switch-handling 2021-10-04 20:52:44 +09:00
smoogipoo
031c5a441e Merge branch 'master' into realtime-pp-display 2021-10-04 20:19:37 +09:00
Dan Balasescu
4bd1083388
Merge pull request #14903 from peppy/importer-returns-live
Add `ILive<T>` and use as return type of `Import` methods
2021-10-04 20:16:32 +09:00
smoogipoo
4871db2f86 Merge branch 'master' into importer-returns-live 2021-10-04 19:42:36 +09:00