1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-30 21:13:22 +08:00
Commit Graph

29121 Commits

Author SHA1 Message Date
Salman Ahmed
eb5e7402c3 Remove obsolete method in ModAutoplay 2021-11-07 16:15:57 +03:00
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null 2021-11-06 15:36:15 +01:00
Bartłomiej Dach
c40f887492
Remove unnecessary local variable 2021-11-06 15:20:29 +01:00
Salman Ahmed
34c8e53e94
Merge branch 'master' into update-cached-buffered-container-usage 2021-11-06 09:38:55 +03:00
Dean Herbert
2b3907db4b Update framework 2021-11-06 14:33:45 +09:00
Salman Ahmed
51e7b9950e Define local current bindable to bind value change instead 2021-11-05 18:07:14 +03:00
Dean Herbert
6c385ccd29 Move second generic to abstract model downloader rather than interface type 2021-11-05 17:37:05 +09:00
Dean Herbert
99df37f32d Add input generic type to IModelDownloader 2021-11-05 17:02:45 +09:00
Dean Herbert
1fe9bca819 Change ModelDownloader's requirement to an IModelImporter rather than IModelManager 2021-11-05 16:47:18 +09:00
Dean Herbert
b90f44493c Remove importer inheritance from IModelManager
Now only exists in legacy implementations, to reduce inheritance
complexity of interfaces which are going to be used going forwards.
2021-11-05 16:45:38 +09:00
Salman Ahmed
f013a1e37f Move CreateContent() to BDL 2021-11-05 10:13:42 +03:00
Dean Herbert
6399c695e8 Update usages of BufferedContainer in line with framework changes 2021-11-05 15:54:49 +09:00
Salman Ahmed
3a3ec1436b Re-enable possible null refernece exception inspections and move code 2021-11-05 09:14:50 +03:00
Dean Herbert
9f9ef570ee Also propagate Status in temporary BeatmapInfo usage 2021-11-05 14:44:58 +09:00
Dan Balasescu
9e2c33d908
Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 13:16:32 +09:00
Dan Balasescu
9b5ed791b5
Merge pull request #15459 from peppy/beatmap-refactor/remove-online-info
Remove `IOnlineInfo` implementations from database models
2021-11-05 13:16:21 +09:00
Dean Herbert
5721f1b2f3
Merge pull request #15479 from jaswon/skinnable-diagonal-scale
Fix scaling of skin components being too sensitive after rotation
2021-11-05 13:11:11 +09:00
Dan Balasescu
acb06d4a99
Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 12:46:02 +09:00
Salman Ahmed
f528488aa2 Mark as non-null and move current bind to BDL instead 2021-11-05 05:42:19 +03:00
Salman Ahmed
2764ad90ea
Merge branch 'master' into fix-more-null 2021-11-05 05:14:22 +03:00
Salman Ahmed
4245af28e1 Disable other false-positive null inspections with comment 2021-11-05 04:50:58 +03:00
Salman Ahmed
36d99a2e34 Move action to private named method to avoid null inspection 2021-11-05 03:51:08 +03:00
Jason Won
9e7d559f55 fix aspect locked scaling of skin components 2021-11-04 17:10:41 -04:00
Bartłomiej Dach
4c8d6a77be
Fix labelled drawable descriptions not showing 2021-11-04 21:44:08 +01:00
Dean Herbert
630d63101d Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:42 +09:00
Dean Herbert
7049d0de66 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 01:16:11 +09:00
Salman Ahmed
aa2711e6ec
Merge branch 'master' into update-framework 2021-11-04 13:51:57 +03:00
Dean Herbert
28e9b9a25f Update framework 2021-11-04 19:01:39 +09:00
Dan Balasescu
45dcf187b9
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
Dean Herbert
df3c3a32ce Fix unintentionally broken background update logic 2021-11-04 18:07:39 +09:00
Dean Herbert
b80c02b757 Fix crash on gameplay startup if beatmap has no background 2021-11-04 17:24:40 +09:00
Dean Herbert
eb17d897a3 Finally, remove the To* methods as they have no usages 2021-11-04 17:09:53 +09:00
Dean Herbert
08d94f864f Update ScoresContainer to not use ToBeatmapInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
7bab487621 Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
d2831b1152 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:50 +09:00
Dean Herbert
5a078da4d9 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:50:14 +09:00
Dean Herbert
c820d445ad
Merge pull request #15461 from peppy/fix-more-computationally-expensive
Fix a few more "maybe null" inspections
2021-11-04 16:49:38 +09:00
Dean Herbert
8f459e6ce8 Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues 2021-11-04 16:44:17 +09:00
Dean Herbert
317506d4d7 Fix a few more "maybe null" inspections 2021-11-04 16:11:23 +09:00
Dean Herbert
09701d0af1 Use explicit primitive type specification 2021-11-04 16:02:37 +09:00
Dean Herbert
0f4f1349db Merge branch 'master' into editor-context-menu-on-select 2021-11-04 15:59:06 +09:00
Dean Herbert
a5a7181915 Fix unintentionally broken background update logic 2021-11-04 15:35:32 +09:00
Dean Herbert
4b1b92cde6 Stop BeatmapInfo from implementing IBeatmapOnlineInfo and remove all usages 2021-11-04 15:23:04 +09:00
Dean Herbert
9c926e5514 Remove BeatmapSetInfo.OnlineInfo and all usages 2021-11-04 15:23:04 +09:00
Dean Herbert
66f4516eee Allow creating sample API models without specifying a ruleset 2021-11-04 15:23:04 +09:00
Dean Herbert
e3a9fbecfe Add method to create sample APIBeatmap (with BeatmapSet populated) 2021-11-04 15:23:04 +09:00
Dean Herbert
0d0eab90bc Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/remove-online-info 2021-11-04 15:23:02 +09:00
Dean Herbert
84d36cbae7 Add fallback for cases where BeatmapSet may be null
Seems to only happen in tests, but better safe than sorry.
2021-11-04 15:22:33 +09:00
Dean Herbert
e43d91ad5d Fix another case of incorrect null checking in editor verification processing 2021-11-04 15:18:10 +09:00
Dean Herbert
d1e6d1cb98 Update some other missed incorrect null/empty usages 2021-11-04 14:50:43 +09:00