267 Commits

• Fix non-default mod settings allowing for duplicate freestyle mod selection in multiplayer (#37646)

  Fixes a bug that allowed for selecting the same mod twice in multiplayer
  if the playlist entry has non-default settings for a required mod.
  This happens due to a strict equality mod check in the mod set
  compatibility check function, which only considers mods duplicates if
  their settings are exactly the same. Replacing with a more lenient
  `Type` check fixes this.
  
  Adds a regression test for this behavior
  
  Fixes https://github.com/ppy/osu/issues/37625.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  triacontakai · 2026-05-07 08:59:54 +02:00
  3f5c113394
• Disable sentry during test runs

  Exposed to be running by 48434dd683 which
  caused test failures.
  
  You'd think that the `IsDeployedBuild` check would catch it but it
  doesn't. `IsDeployedBuild` is `AssemblyVersion.Major > 0`, and the
  assembly version is taken from the entry assembly. In tests the entry
  assembly is either resharper or nunit.

  Bartłomiej Dach · 2026-04-20 13:37:53 +02:00
  16bbfbb4e2
• Remove sentry DSN from repo

  People doing stupid shit submitting stupid errors we don't care about.

  Dean Herbert · 2026-04-20 17:16:41 +09:00
  48434dd683
• Update lots of packages (#36996)

  It's been a while.
  
  Notes:
  
  - `SharpCompress` usages changed a bit. Manually adjusted these, mostly
  just renames or adjusted parameters.
  - nUnit 3 -> 4 migrated using
  https://gist.github.com/peppy/07994386d793a117350cb5f24b156585. there's
  a mode in this script to update to the newer `Assert.That` syntax but it
  requires fixes and couldn't really be bothered.
  - DeepEqual nuked as the only usage was on a disabled test. The reason
  it's disabled has been merged upstream, but it's failing for other
  (realm) reasons which I don't think is worthwhile to investigate for
  now.
  - This bumps Moq. I think the author is back in a sensible headspace and
  the new version has the stupid shit removed, so probably okay? Nice to
  be on a level playing field with packages for once in a long time.
  - Automapper is silly, but we've discussed this elsewhere.
  - `TestRealmKeyBindingStore` failures are a wildcard, but fixed by using
  a more standardised testing method. Dunno why, don't care.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-17 03:58:02 +09:00
  a996261304
• Apply more sanity checks when handling files from archives
  Bartłomiej Dach · 2026-03-02 13:11:01 +01:00
  9c8dfaf386
• Fix unobserved timeouts still showing to user

  As reported in https://osu.ppy.sh/community/forums/topics/2174881?n=1.

  Dean Herbert · 2026-01-30 15:37:01 +09:00
  cf09ed3e0d
• Add envvar to disble error reporting

  https://github.com/ppy/osu/discussions/31832#discussioncomment-15555080

  Dean Herbert · 2026-01-22 18:12:27 +09:00
  6693307064
• Fix broken date formatting in some languages on several overlays

  Fixes https://osu.ppy.sh/community/forums/topics/2169438?n=1.

  Bartłomiej Dach · 2026-01-12 09:34:53 +01:00
  ae284fcf05
• Log version hash to sentry

  This is the counterpart to
  https://github.com/ppy/osu-server-spectator/pull/413. The goal is to
  log the value which is seemingly failing to work correctly client-side
  as well.
  
  The reason for doing that is two-fold:
  
  - To eliminate possibility of freakazoid issues wherein some computers
    miscalculate the version hash somehow
  - To eliminate possibility of the version hash somehow getting lost in
    transit (e.g. present client-side but no longer present server-side).

  Bartłomiej Dach · 2026-01-07 13:03:20 +01:00
  48de70e719
• Fix replay files potentially getting misclassified as zip archives

  Resolves https://github.com/ppy/osu/discussions/36107.
  
  The replay linked in the aforementioned discussion happens to contain
  the magic sequence for ZIP headers in the binary stream (50 4b 05 06)
  which led to it getting classified as a ZIP with no entries and
  completely bogus everything in the header at
  
  	https://github.com/ppy/osu/blob/c8b18acd4dd1d98170a069240b6666cea3d5da07/osu.Game/Database/ImportTask.cs#L51-L56
  
  and then finally dying of
  
  	2025-12-23 07:26:45 [error]: [?????] Model creation of replay-osu_2040232_4828629841.osr failed.
  	2025-12-23 07:26:45 [error]: System.InvalidOperationException: Sequence contains no matching element
  	2025-12-23 07:26:45 [error]: at System.Linq.ThrowHelper.ThrowNoMatchException()
  	2025-12-23 07:26:45 [error]: at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
  	2025-12-23 07:26:45 [error]: at osu.Game.Scoring.ScoreImporter.CreateModel(ArchiveReader archive, ImportParameters parameters)
  	2025-12-23 07:26:45 [error]: at osu.Game.Database.RealmArchiveModelImporter`1.importFromArchive(ArchiveReader archive, ImportParameters parameters, CancellationToken cancellationToken)
  
  at
  
  	https://github.com/ppy/osu/blob/554961036e23615b35eb6b66b341b10924664c4d/osu.Game/Scoring/ScoreImporter.cs#L46

  Bartłomiej Dach · 2025-12-23 08:23:23 +01:00
  95233fc638
• Filter out more exceptions from being sent to sentry

  More or less covers the first page of client sentry issues sorted by
  volume, all of which is pretty much useless for anything because it's
  client-specific-failure noise.

  Bartłomiej Dach · 2025-12-09 09:54:46 +01:00
  8bb885a0dc
• Fix certain slider shapes incorrectly registering as a horizontal/vertical only slider.
  AeroKoder · 2025-09-17 15:34:18 -07:00
  6dc3432735
• Merge pull request #33679 from bdach/truncate-sr

  Floor star rating to 2 decimal places rather than rounding

  Dan Balasescu · 2025-06-24 19:04:56 +09:00
  6057c6c4d4
• Adjust rank formatting logic to avoid getting cut in score
  Salman Alshamrani · 2025-06-18 01:52:26 +03:00
  1ceb59d78e
• Add support for reading release stream from assembly version
  Dean Herbert · 2025-06-13 18:52:22 +09:00
  3291a4cb7b
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Floor star rating to 2 decimal places rather than rounding

  Rounding semi-regularly confuses users who aim for star rating pass / FC
  medals and then feel they have been cheated out of a medal because they
  passed an "X-star beatmap", but the actual star rating of the beatmap is
  slightly under X.
  
  The latest instance of this can be found at
  https://osu.ppy.sh/community/forums/topics/2091333?n=2. The relevant
  beatmap there is https://osu.ppy.sh/beatmapsets/2162554#osu/4746232,
  whose raw star rating is 6.9976070253117344.
  
  The other direction would be to fix the star rating medals instead, but
  I think this is more reasonable given we already do similar things to
  accuracy displays.

  Bartłomiej Dach · 2025-06-13 09:11:06 +02:00
  4fd2a488b7
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Remove pre-rate rounding in BPM display
  Salman Alshamrani · 2025-04-30 02:23:28 +03:00
  901c1b2650
• Simplify taglib interactions further
  Dean Herbert · 2025-04-28 15:52:31 +09:00
  40faa3fc99
• Add manual MIME type resolution for TagLib file creation
  Stedoss · 2025-04-28 13:38:38 +09:00
  c2efda20d7
• Reorder function parameters, hopefully improve documentation
  Dan Balasescu · 2025-04-17 19:12:13 +09:00
  f0a8ddd513
• Adjust method name
  Dan Balasescu · 2025-04-17 02:36:55 +09:00
  2a09572d09
• Apply changes from reviews
  Dan Balasescu · 2025-04-17 02:19:31 +09:00
  64aafa4e4c
• Adjust logic to properly list selectable mods
  Dan Balasescu · 2025-04-14 20:23:00 +09:00
  3dcd1a9e74
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Only apply freestyle validation to required mods
  Dan Balasescu · 2025-04-14 19:34:21 +09:00
  b4c7d7f498
• Merge mod validity checks to closer match osu!web
  Dan Balasescu · 2025-04-10 13:02:25 +09:00
  05e70cd938
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-17 11:59:14 +09:00
  ab88ccb081
• Merge branch 'master' into freestyle-mods
  Dean Herbert · 2025-02-12 18:32:01 +09:00
  bc94ffe21e
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 21:47:56 +09:00
  b07d7e8177
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 14:09:25 +09:00
  6c069b3373
• Add helper for testing mod/freemod validity
  Dan Balasescu · 2025-02-05 16:44:52 +09:00
  7f8f528ae2
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Remove OrientationManager and the entire mobile namespace
  Salman Alshamrani · 2025-01-25 20:01:18 -05:00
  c18128e974
• Enable sentry caching to avoid sentry writing outside of game directory

  See https://github.com/ppy/osu/discussions/31412. Probably safe enough.

  Dean Herbert · 2025-01-20 23:45:39 +09:00
  6b524aba60
• Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils (#31520)

  * Move error function implementation to osu.Game.Rulesets.Difficulty.Utils
  
  * Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

  Natelytle · 2025-01-17 19:37:34 +00:00
  5b4ba9225d
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Merge branch 'master' into netcore-analyzer
  Huo Yaoyuan · 2024-12-05 17:18:56 +08:00
  d92ea910cf
• Move rate-changing TODO to a common place in CalculateRateWithMods
  Tim Schumacher · 2024-12-02 23:49:51 +01:00
  e920cfa187
• Merge branch 'master'
  Huo Yaoyuan · 2024-11-30 01:07:08 +08:00
  fa3c95c296
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Enable recommended rules for maintainability
  Huo Yaoyuan · 2024-11-28 20:41:41 +08:00
  13d7c6a2d8
• Merge branch 'master' into taikostatacc
  Bartłomiej Dach · 2024-10-07 14:15:29 +02:00
  84d6467e48
• Merge branch 'master' into selection-center
  Bartłomiej Dach · 2024-09-27 09:30:36 +02:00
  fa90b43233
• Fix code quality naming issue
  Bartłomiej Dach · 2024-09-27 09:26:08 +02:00
  21796900e2
• Inline condition
  Dan Balasescu · 2024-09-25 22:47:37 +09:00
  2fe229d620
• Fix similar Bindable-related crashes
  Dan Balasescu · 2024-09-25 20:59:35 +09:00
  fd4891cf31