22 Commits

• Refactor TestSceneScreenFooter to test entire OsuScreens (#36718)

  Part of the `ScreenFooter` refactor, which intends to move the footer
  content handling to `OsuScreen`. This commit updates the `ScreenFooter`
  test to operate on entire `OsuScreen`s, in order to better test the
  entire flow of pushing a screen, and having it create and add its own
  content to the footer.
  
  This should be 80-90% identical to the original test case structure
  wise, just that instead of manually manipulating the footer with
  `SetButtons()`, various screens with the appropriate buttons are being
  moved around the screen stack.
  
  Additionally this adds some more tests handling common use cases, as
  well as removes `TestLoadOverlayAfterFooterIsDisplayed()`, since as far
  as I understand the behaviour described in it doesn't actually happen in
  production code. From what I can see, Screens instantiate their overlays
  in `load()`, and then register them in `LoadComplete()`. There seems to
  be no case where a `ShearedOverlayContainer` is created in the middle of
  a screen's lifecycle.

  Krzysztof Gutkowski · 2026-03-01 22:36:07 +09:00
  b88cba0829
• Migrate sheared overlay tests to ScreenTestScene (#36736)

  Part of the screen footer refactor.
  
  Once footer content is being managed by `OsuScreen`, the current tests
  which simply create the tested overlay and `ScreenFooter` in a container
  will no longer work.
  
  This PR refactors them to use `ScreenTestScene` with the setup being
  creating a dedicated testing `OsuScreen` which does the bare minimum to
  create the tested overlay and necessary components (eg.
  `FooterButtonFreeModsV2` for `TestSceneFreeModsOverlay`).
  
  Most of the changes here can be described as
  `%s/<...>Overlay/screen.Overlay/g`, with some minor touchups as
  necessary, given that we're now testing a more complete flow which
  checks more things that were previously not handled by the tests.
  
  ## [Move footer to front in
  ScreenTestScene](https://github.com/ppy/osu/commit/f8740e0403b3c0badd60d394c737f2aa912a9ed6)
  
  Self-explanatory. Without it the footer would show below the actual
  overlay, breaking tests depending on manual input. For the sake of tests
  not breaking in CI, both #36718 and this have this included - would
  prefer the former to be merged first since it was already reviewed
  there.
  
  ## `TestSceneModSelectOverlay`
  
  There were a few tests (`TestColumnHidingOnIsValidChange`,
  `TestColumnHidingOnTextFilterChange`, and
  `TestHidingOverlayClearsTextSearch`) that would create a custom overlay
  instance instead of the globally provided one. I've tested both and the
  tests run fine with the default overlay, so they're now using that
  instead.
  
  ## `TestSceneFreeModSelectOverlay`
  
  Updated to use footer v2.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-02-28 04:22:58 +09:00
  105342e5bf
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  4be29425a0
• Move footer to ScreenTestScene
  Dan Balasescu · 2025-08-29 17:49:48 +09:00
  04ba5aa575
• Add screen footer to ScreenTestScene
  Salman Ahmed · 2024-07-11 15:30:07 +03:00
  7a5624fd0e
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Implement IOverlayManager in ScreenTestScene
  Bartłomiej Dach · 2022-05-05 22:16:55 +02:00
  fdb21fedab
• Split out IDialogOverlay to allow for easier testing
  Dean Herbert · 2022-04-18 18:36:26 +09:00
  e315313266
• Avoid adding "exit all screens" step when running tests interactively
  Dean Herbert · 2022-01-24 16:40:16 +09:00
  1e483ece32
• Name some screen stacks for better logging context
  Dean Herbert · 2021-12-20 18:24:14 +09:00
  6907a9a3cc
• Remove unused using statement

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-06 05:30:49 +09:00
  1f6a31355c
• Add various logging output in an atttempt to figure multiplayer test failure
  Dean Herbert · 2021-10-05 18:53:20 +09:00
  e6efdae7c9
• Add multiplayer leave navigation tests
  Joseph Madamba · 2021-06-22 19:30:40 -07:00
  49000b9501
• Rename base test class to help avoid incorrect reference
  Dean Herbert · 2020-03-23 10:01:33 +09:00
  0b728f483f
• Move to using test methods for better separation
  smoogipoo · 2020-03-02 12:20:25 +09:00
  ce7cbf29ca
• Consume TearDownSteps
  Dean Herbert · 2020-01-31 22:09:39 +09:00
  c4331f34d5
• Centralise screen exit logic to ScreenTestScene
  Dean Herbert · 2020-01-31 14:19:29 +09:00
  5f48affcba
• Fix song select filters not reapplied if in a child screen

  Closes https://github.com/ppy/osu/issues/6980.

  Dean Herbert · 2019-12-10 02:30:23 +09:00
  cdde5d1d69
• Rename test cases to test scenes inline with the framework change
  Roman Kapustin · 2019-05-14 22:37:25 +03:00
  459a285cd8