59 Commits

• Fix mania hold notes dimming unexpectedly (#37008)

  Fixes https://github.com/ppy/osu/issues/29223
  
  This fixes several issues around hold note dimming.
  
  Notice in the following video:
  - The tail piece of the first note not getting dimmed.
  - The body of the second note not responding to dimming at all.
  
  
  https://github.com/user-attachments/assets/8e51053d-8d88-4e48-909b-79218d65917b
  
  Then, notice in the following video:
  - The body piece of the second note is dimmed from the very beginning.
  
  
  https://github.com/user-attachments/assets/a514c630-5c72-4ba5-96d5-472bae1058b3
  
  This requires a specific setup whereby the hold note and its components
  must be reused from the pool. In particular:
  1. The hold note must be long. So long that by the time the tail becomes
  on screen, the body will already have dimmed.
  2. The hold note must be re-used from the pool. We can induce this by
  setting the pool sizes to 1 in
  [`Column.cs`](https://github.com/ppy/osu/blob/780ce2666099c22d1e0673cafab544418b5d14b0/osu.Game.Rulesets.Mania/UI/Column.cs#L121-L123).
  3. The second hold note should be placed far enough in the timeline that
  the first hold note dies by the time it becomes visible.
    4. Scroll speed should be adjusted to fit the above constraints.
  
  I haven't done a full deep dive into exactly _why_ this is happening, so
  the fix here is hand-wavy. That said, just by looking at the old code in
  `LegacyBodyPiece` you'll get a feeling that something's bound to go
  wrong;
  - It never resets the `missingFadeTime` state.
  - It never resets the colours back to `Color4.White`.
  - It applies transforms onto external components.
  - It jumps through hoops to figure out how to set `missingFadeTime`.
  
  My hope is that these changes first bring some sanity in the process,
  and if it breaks again I'll consider doing a more proper root cause
  (I've had this issue in the back of my mind for about 1 year).
  
  With this PR, they now behave as expected:
  
  
  https://github.com/user-attachments/assets/140b37c5-cf84-44ba-b797-86ac6d8130c8
  
  
  https://github.com/user-attachments/assets/6f2342a4-6a9a-4941-a55a-24a357f27c25

  Dan Balasescu · 2026-03-23 08:33:23 +01:00
  d4a4acd3f4
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Fix osu!mania hold notes playing a sound at their tail in the editor

  Closes #29584.

  Dean Herbert · 2024-08-27 14:06:02 +09:00
  9840a07eaf
• Rewrite no release mod

  Per the request of spaceman_atlas, the No Release mod is rewritten to
  avoid modifications to DrawableHoldNoteTail. The approach is based
  on that of the Strict Tracking mod for the osu!(standard) ruleset,
  injecting the mod behavior by replacing the normal hold note with
  the mod's variant. The variant inherits most bevaior from the normal
  hold note, but when creating nested hitobjects, it creates its own
  hold note tail variant instead, which in turn is used to instantiate
  the mod's variant of DrawableHoldNoteTail with a new behavior.
  
  The time a judgement is awarded is changed from the end of its
  Perfect window to the time of the tail itself.

  Nathan Du · 2024-07-01 20:29:30 +08:00
  1eb10e029c
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Remove mania hold note ticks
  Dan Balasescu · 2023-08-31 17:30:27 +09:00
  c60f13dd92
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Change IHasRepeats.NodeSamples to IList from List
  goodtrailer · 2021-10-23 01:59:07 -07:00
  4440b9ca11
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Initial implementation of DHO pooling
  smoogipoo · 2021-05-12 16:35:05 +09:00
  5692cecaa4
• Implement mania invert mod
  smoogipoo · 2020-08-18 01:40:55 +09:00
  583760100a
• Rename to IHasDuration
  Dean Herbert · 2020-05-27 12:38:39 +09:00
  cbd563e80b
• Actually use the cancellation token
  smoogipoo · 2020-05-15 18:17:39 +09:00
  4719fcc291
• Add cancellation token support to CreateNestedHitObjects()
  smoogipoo · 2020-05-15 18:07:41 +09:00
  98125102a7
• Use the last node sample for the tail note
  smoogipoo · 2020-04-22 09:06:04 +09:00
  6da0872ae5
• Cleanup handling of mania samples
  smoogipoo · 2020-04-22 09:06:04 +09:00
  d957614fc9
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Make EndTime and RepeatCount settable
  Dean Herbert · 2020-02-05 17:52:51 +09:00
  cd6902a312
• Use empty hitwindows instead of null
  Dean Herbert · 2019-10-09 19:08:31 +09:00
  51bf600ea7
• Refactor HitWindows for legibility
  Dean Herbert · 2019-09-06 15:24:14 +09:00
  f925e781a9
• Return null hitwindows for non-time-based objects
  smoogipoo · 2019-09-02 16:10:30 +09:00
  f3656475de
• Merge branch 'master' into more-inspections
  Dean Herbert · 2019-02-28 14:32:57 +09:00
  0788a7e9f1
• Use expression body for property get/set where possible
  Dean Herbert · 2019-02-28 13:58:19 +09:00
  42be7857d1
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Fix hold note head/tails not being nested hitobjects
  smoogipoo · 2018-08-16 10:45:06 +09:00
  74a79bfcfa
• Make HitObject not store the judgement
  smoogipoo · 2018-08-06 11:50:18 +09:00
  3a7488767c
• Make hitobjects only have one judgement + result
  smoogipoo · 2018-08-03 15:38:48 +09:00
  2a4994e5ce
• Make Rulesets.Mania use the new judgement result structure
  smoogipoo · 2018-08-02 20:36:54 +09:00
  807794d512
• Migrate Rulesets.Mania to the new judgement system
  smoogipoo · 2018-08-02 16:44:01 +09:00
  cd70e5e30b
• Fix hold note hitwindow lenience
  smoogipoo · 2018-05-17 13:59:04 +09:00
  43cdbec0a3
• Add todo because TailNote shouldn't hardcore lenience
  smoogipoo · 2018-05-11 15:32:13 +09:00
  0cdd39b8b8
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• remove unnecessary empty lines

  codefactor.io \(o.o)/
  also one unnecessary semicolon

  Aergwyn · 2018-01-12 19:30:34 +01:00
  ae1adfd2f2
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Make HitObjects construct nested hit objects
  smoogipoo · 2017-12-22 21:42:54 +09:00
  6a29f6020a
• Fix possible nullref exceptions
  smoogipoo · 2017-12-21 23:02:46 +09:00
  ac1d27e925
• Determine SampleInfo defaults in DrawableHitObject
  smoogipoo · 2017-12-21 16:02:33 +09:00
  cb7e192aff
• Make tick explosions white and lower scale.
  smoogipooo · 2017-09-11 14:37:34 +09:00
  e8efdcf188
• Add explosions.
  smoogipooo · 2017-09-11 13:44:39 +09:00
  3026675f35
• Reshuffle namespaces
  Dean Herbert · 2017-07-26 13:22:46 +09:00
  fce580d717
• Merge branch 'master' into mania-judgements
  Dean Herbert · 2017-05-29 21:31:48 +09:00
  476526714d
• Fix mania-specific beatmaps not setting samples correctly.
  smoogipooo · 2017-05-29 16:18:01 +09:00
  e529ced131
• Update HoldNote.cs
  Dan Balasescu · 2017-05-29 15:35:50 +09:00
  0327adcba8
• Store tick count locally, remove HoldNote TickCount.
  smoogipooo · 2017-05-29 14:47:51 +09:00
  44f1d906ea
• Add basic score calculations.
  smoogipooo · 2017-05-26 19:56:50 +09:00
  ab5e1bfc89
• Fix tick construction loop.
  smoogipooo · 2017-05-26 16:28:39 +09:00
  47e1b7b389
• Remove late initialization of head + tail, keep them updated with start time and end time.
  smoogipooo · 2017-05-26 15:53:49 +09:00
  c2d3b6c05a
• General cleanup + more xmldocs.
  smoogipooo · 2017-05-24 21:57:38 +09:00
  946cd4bfa3