Bartłomiej Dach
33fe843ba9
Move value change bindings to LoadComplete()
...
Also removes a redundant one from the setter of `Current`. If the set to
current comes with an associated value change, the bind-unbind flow that
`BindableWithCurrent` implements will handle that change anyway.
2021-05-17 20:46:30 +02:00
Bartłomiej Dach
2bf62b86ea
Merge branch 'master' into add-overlay-link-colours
2021-05-17 20:11:27 +02:00
Lucas A
e2018f81f3
Use equality check for nullable types.
2021-05-17 19:54:21 +02:00
Bartłomiej Dach
400984457c
Fix weird behaviour in test scene
...
Due to a callback set up in another place, clicking away from the 2022
year after launching the test scene would remove the 2022 button
(because the callback was returning metadata without it). For simplicity
just trim the 2022 year to make sure both test scenes use the same
consistent set of years.
2021-05-17 19:16:30 +02:00
Bartłomiej Dach
d614a47614
Rename variable to better explain purpose
2021-05-17 18:54:17 +02:00
Bartłomiej Dach
7befcf74ff
Split value change callbacks out to separate methods
2021-05-17 18:53:09 +02:00
Lucas A
97952bc3f0
Fix backwards stable install resolution logic.
2021-05-17 18:39:04 +02:00
Lucas A
6110a847aa
Simplify import ordering logic by making beatmapImportTask non-nullable.
2021-05-17 16:30:13 +02:00
Dean Herbert
ff6ec45a70
Merge pull request #12840 from smoogipoo/fix-hitpoint-brightness
...
Fix accuracy heatmap points changing colour
2021-05-17 22:13:39 +09:00
Lucas A
5ca4fd5ab4
Block overlays to prevent getting into a bad state.
2021-05-17 13:28:59 +02:00
Dan Balasescu
ea4dfd3374
Merge pull request #12842 from peppy/song-progress-skinnable
...
Add layout customisation support for `SongProgress`
2021-05-17 20:15:01 +09:00
Lucas A
a38fc1a2e0
Override text header.
2021-05-17 13:04:49 +02:00
Lucas A
db255e6814
Mark StableImportManager as potentially null in tests.
...
(StableImportManager is added to the DI in OsuGame and not in the OsuGameBase)
2021-05-17 12:55:59 +02:00
Lucas A
ed4c025c7e
Fix other tests and move TestPlaySongSelect class declaration.
2021-05-17 12:55:59 +02:00
Lucas A
fe11426238
Disable appearance of the stable import prompt waiting for user interaction in tests, which caused them to fail.
2021-05-17 12:55:59 +02:00
Lucas A
41fafdf643
Remove now unreachable code paths.
2021-05-17 12:55:59 +02:00
Lucas A
bec06cfac7
Reword StableDirectoryLocationDialog header
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2021-05-17 12:55:58 +02:00
Lucas A
f60dbbfbbd
Reword import dialogs.
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-17 12:55:58 +02:00
Lucas A
e15e8068d3
Reword StableDirectoryLocationDialog.
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2021-05-17 12:55:58 +02:00
Lucas A
dabe8bd4c7
Fix code inspections and remove now unused code.
2021-05-17 12:55:58 +02:00
Lucas A
a7b740fd1d
Reword ImportFromStablePopup and display the popup regardless of whether a stable install is detected.
2021-05-17 12:55:58 +02:00
Lucas A
8ba50b1854
Bring back injected dependency incorrectly marked as unused.
2021-05-17 12:55:58 +02:00
Lucas A
481b0a0125
Add StableDirectoryLocationDialog
2021-05-17 12:55:57 +02:00
Lucas A
325a689d65
Order imports depending on beatmap imports if any is running.
2021-05-17 12:55:57 +02:00
Lucas A
851e33fd15
Hook up StableImportManager.
2021-05-17 12:55:57 +02:00
Lucas A
5d5b1e1f0e
Add StableImportManager
2021-05-17 12:55:56 +02:00
Dean Herbert
7137315fa7
Remove HitErrorDisplay container and hook up data
2021-05-17 19:46:50 +09:00
Dean Herbert
42d2711dc6
Use ShouldBeConsideredForInput instead of ReceivePositionalInputAtSubTree
2021-05-17 19:29:59 +09:00
Dean Herbert
83b4515d5c
Merge pull request #12841 from smoogipoo/skin-editor-exclude-interfaces
...
Exclude interfaces from skinnable types
2021-05-17 19:11:58 +09:00
Dean Herbert
60f3e628bc
Fix song progress being interactable inside toolbox button
2021-05-17 19:05:22 +09:00
Dean Herbert
ecf70c1707
Remove unnecessary container
2021-05-17 18:55:18 +09:00
Dean Herbert
b80768b44a
Hook up seeking flow
2021-05-17 18:52:56 +09:00
Dean Herbert
0c433cda86
Update HUDOverlay logic to add automatic layout for bottom-aligned components
2021-05-17 18:52:56 +09:00
Dean Herbert
da0913ca2d
Make SongProgress a skinnable component
2021-05-17 18:52:56 +09:00
Dan Balasescu
4151f18f74
Merge pull request #12804 from peppy/fix-autoplay-load-fail-nullref
...
Fix a potential nullref when starting `Player` with autoplay disabled and beatmap fails to load
2021-05-17 18:40:05 +09:00
Dean Herbert
1f3ae901ce
Expose DrawableRuleset for consupmtion by HUD components
2021-05-17 18:23:01 +09:00
smoogipoo
0d7a349500
Exclude interfaces from skinnable types
2021-05-17 18:16:09 +09:00
smoogipoo
0989aa3364
Fix accuracy heatmap points changing colour
2021-05-17 18:07:50 +09:00
Andrei Zavatski
555e3e2db3
Delete NewsSideBar.cs
2021-05-17 12:02:33 +03:00
Andrei Zavatski
fc6e65b7db
Delete TestSceneNewsSideBar.cs
2021-05-17 12:02:06 +03:00
Andrei Zavatski
01090de1fd
Fix filenames does not match contained type
2021-05-17 11:55:55 +03:00
Andrei Zavatski
586c5c7365
Emulate year changes in the test scene
2021-05-17 11:36:53 +03:00
Andrei Zavatski
ab16c32bb1
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-17 11:36:41 +03:00
Dean Herbert
7921930a92
Merge pull request #12781 from Game4all/directory-select-screen
...
Implement a directory selection screen
2021-05-17 17:23:00 +09:00
Dan Balasescu
d75ef160e8
Merge branch 'master' into directory-select-screen
2021-05-17 17:22:03 +09:00
Andrei Zavatski
c0cfbd11dd
Add tooltip and action for PostButton in MonthSection
2021-05-17 11:20:31 +03:00
Andrei Zavatski
5059bfaef9
Use FillFlowContainer in YearsPanel
2021-05-17 11:17:02 +03:00
smoogipoo
e3b8d8ee18
Add support for overlay-coloured links
2021-05-17 16:58:54 +09:00
Andrei Zavatski
e754d2e590
Simplify YearButton
2021-05-17 10:54:45 +03:00
Andrei Zavatski
6db291fe84
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
2021-05-17 10:51:56 +03:00
