PercyDan54
4fe1497f63
Add comment & remove lastF
2021-04-28 20:39:06 +08:00
PercyDan54
126056c436
Fix precision loss on exporting legacy replays
2021-04-28 19:27:18 +08:00
Dean Herbert
6cadbd48dc
Merge pull request #12603 from smoogipoo/fix-score-processor-base-score
...
Fix bonus-only maps having only 700K base score
2021-04-28 17:30:58 +09:00
Dean Herbert
71e44a0841
Merge pull request #12609 from peppy/fix-download-button-import-cancel-state
...
Fix import cancellation not correctly being forwarded to import notification
2021-04-28 17:28:59 +09:00
Dan Balasescu
53d93fecd1
Merge branch 'master' into fix-download-button-import-cancel-state
2021-04-28 16:51:31 +09:00
Dean Herbert
74bf4323d1
Merge pull request #12602 from smoogipoo/setting-source-custom-control
...
Add support for custom controls to SettingSourceAttribute
2021-04-28 16:39:17 +09:00
Dean Herbert
e71dbfd730
Add inline comment regarding remaining issues with classic scoring
2021-04-28 16:37:48 +09:00
Dean Herbert
8598a0968f
Update calculations in comments to match new logic
...
Mostly look to be errors that existed before this PR.
Co-authored-by: Endrik <enduslittlecomputer@gmail.com>
2021-04-28 16:29:23 +09:00
Dean Herbert
05e3a73a7d
Fix import cancellation not correctly being forwarded to import notification
2021-04-28 16:09:50 +09:00
Dean Herbert
ac1534cda2
Add test covering existing button actually changing to LocallyAvailable state
2021-04-28 15:54:40 +09:00
smoogipoo
05bd6ee50c
Add back ctor doc
2021-04-28 03:54:42 +09:00
smoogipoo
04454062b7
Fix up xmldoc
2021-04-28 03:52:59 +09:00
smoogipoo
61b7dc1e06
Fix bonus-only maps having 700K base score
2021-04-28 03:42:29 +09:00
smoogipoo
4e3ee77396
Add support for custom controls to SettingSourceAttribute
2021-04-28 02:51:24 +09:00
Dan Balasescu
5fc731967b
Merge pull request #12592 from ekrctb/fix-entry-lifetime
...
Fix Setting DHO's lifetime doesn't update its entry lifetime
2021-04-28 01:38:19 +09:00
Dean Herbert
9ed79ce7c3
Merge pull request #12598 from smoogipoo/fix-score-processor-bonus-calculation
...
Fix bonus score not calculated from the correct statistics
2021-04-28 00:33:09 +09:00
smoogipoo
baa6e845aa
Change to fluent assertions
2021-04-27 22:43:52 +09:00
smoogipoo
1281993f1f
Fix bonus score not calculated from the correct statistics
2021-04-27 22:42:58 +09:00
smoogipoo
3b04aed491
Add failing test
2021-04-27 22:42:58 +09:00
Dean Herbert
5dadfd04e7
Update framework
2021-04-27 22:36:25 +09:00
ekrctb
b87446a577
Simplify HitObjectLifetimeEntry logic a bit
2021-04-27 19:37:01 +09:00
Dean Herbert
2adc751e04
Merge pull request #12585 from LumpBloom7/Reset-DHO-Transforms-method
...
Add method to safely refresh DrawableHitObject transforms
2021-04-27 19:15:12 +09:00
Derrick Timmermans
3ea55314f2
Update osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-04-27 11:29:16 +02:00
ekrctb
003553aba3
Add test of HitObjectLifetimeEntry.KeepAlive behavior
2021-04-27 18:10:44 +09:00
ekrctb
3899e500d3
Adopt framework change of LifetimeEntry
...
Override SetLifetimeStart/SetLifetimeEnd separately to track individual assignment. It is necessary to ensure real lifetime is not lost when lifetime is partially updated.
2021-04-27 17:54:18 +09:00
Dean Herbert
aaf65b64f5
Merge pull request #12589 from Cublibre/admin-notification
...
Send a notification if game is run as admin/root
2021-04-27 15:25:13 +09:00
ekrctb
c9e6ca5378
Use now-public Entry.SetLifetime method
2021-04-27 15:25:05 +09:00
ekrctb
a2c0951d94
Use overriding instead of hiding in HitObjectLifetimeEntry
...
Hidden properties are used when the type is the base class. It caused issues when `DrawableHitObject` logic is factored out to `PoolableDrawableWithLifetime` because it is using the base `LifetimeEntry`, not `HitObjectLifetimeEntry`.
2021-04-27 15:23:33 +09:00
Dean Herbert
dbcb1259e2
Add a note about elevated privileges also breaking integrations
2021-04-27 14:38:19 +09:00
Dean Herbert
2673cd3d99
Remove unnecessary noop action
2021-04-27 14:36:15 +09:00
Dean Herbert
13de571b3c
Rename private method
2021-04-27 14:35:57 +09:00
Dean Herbert
2303d108bb
Simplify false return path
2021-04-27 14:35:14 +09:00
ekrctb
7980d16b4c
Add failing test showing the issue of DHO lifetime
2021-04-27 14:26:12 +09:00
Dan Balasescu
ea3c5aed2f
Merge pull request #12590 from peppy/editor-minor-refactors
...
Fix a couple of inspections in editor code
2021-04-27 14:09:36 +09:00
Dean Herbert
ec1c336b0a
Fix a couple of inspections
2021-04-27 13:23:14 +09:00
Christine Chen
5a3fbef5ac
Use a try-catch, notification activation does nothing
2021-04-27 00:23:08 -04:00
Christine Chen
e0f54f5842
Move load() before LoadComplete()
2021-04-26 22:51:03 -04:00
Christine Chen
a2723f3f57
Perform elevated check asynchronously, use a separate function w/ switch statement
2021-04-26 22:44:22 -04:00
Christine Chen
c3bad1d4c5
Rename AdminChecker to ElevatedPrivilegesChecker, refactor elevated check
2021-04-26 21:05:18 -04:00
Christine Chen
260dd06f47
Move AdminChecker to osu.Desktop.Admin
2021-04-26 20:04:34 -04:00
Christine Chen
9ad30da729
Show a notification if game is run as administrator
2021-04-26 16:41:26 -04:00
Derrick Timmermans
08a232f7fa
Add method to safely refresh DrawableHitObject transforms
2021-04-26 20:08:40 +02:00
Dean Herbert
bec16436b0
Merge pull request #12583 from smoogipoo/fix-score-export
...
Fix exported scores not being compatible with osu-stable
2021-04-26 22:32:18 +09:00
smoogipoo
213ac88a8b
Fix exported scores not being compatible with osu-stable
2021-04-26 20:52:20 +09:00
smoogipoo
6560dc2d1f
Fix exported replays being wrapped in zip packages
2021-04-26 20:46:44 +09:00
Dan Balasescu
47925de7ae
Merge pull request #12500 from ekrctb/drawable-object
...
Factor out pooling and lifetime management logic of DHO to a base class
2021-04-26 19:30:43 +09:00
Dan Balasescu
6d2a5b614c
Merge branch 'master' into drawable-object
2021-04-26 18:33:44 +09:00
Dan Balasescu
72d9cdcdf9
Merge pull request #12580 from peppy/fix-editor-slider-repeat-animation
...
Fix slider repeats and tails still animating with editor hit animations disabled
2021-04-26 17:36:51 +09:00
smoogipoo
1e0ee3cd61
Merge branch 'master' into fix-editor-slider-repeat-animation
2021-04-26 16:45:04 +09:00
Dan Balasescu
0727728771
Merge pull request #12579 from peppy/rename-edit-classes
...
Rename "EditRuleset" and "EditPlayfield" to use full "Editor" keyword
2021-04-26 16:44:35 +09:00
