Dean Herbert
4d5b2477dc
Fix failing song select tack transfer test by using a real track
2023-09-28 15:59:06 +09:00
Dean Herbert
ae31a8fadf
Reduce delay before loading beatmap after selection change at song select
...
This was originally set high because of performance concerns. We have
since improved things quite drastically. Even with a very low debounce
my song select is amazingly smooth.
This is about as low as we can got unless we want chaos when key
repeating left/right arrows (it's not as bad as you think, maybe worth
testing during review and see if it feels more expected?).
Of note, stable has key repeat disabled on left/right arrows and zero
debounce.
Addresses concerns in https://github.com/ppy/osu/discussions/24916 .
2023-09-26 16:21:09 +09:00
Dan Balasescu
81130eacd1
Merge pull request #24897 from peppy/fix-oauth-refresh-no-connection
...
Fix OAuth refresh attempt when no network available causing full logout
2023-09-24 14:06:04 +09:00
Dean Herbert
3c62521e69
Fix OAuth refresh attempt when no network available causing full logout
2023-09-24 10:50:07 +09:00
Salman Ahmed
7d7fc09dbc
Merge pull request #24889 from Fabiano1337/master
...
Fix game crash when using "Bubbles" mod on a beatmap with no hit circles
2023-09-24 03:02:10 +03:00
Salman Ahmed
734ee0e68b
Simplify code
2023-09-24 02:22:50 +03:00
Fabian van Oeffelt
7c40072c47
Get first Spinner,Slider or HitCircle instead of only HitCircle
...
Fixes bug
2023-09-23 13:18:49 +02:00
Salman Ahmed
d18bd2d2ac
Merge pull request #24880 from bdach/flaky-scoreboard-test
...
Fix `TestFriendScore` intermittently failing due to randomness
2023-09-22 02:09:04 +03:00
Bartłomiej Dach
e45d456324
Fix TestFriendScore intermittently failing due to randomness
...
If `createRandomScore()` happened to randomly pick the highest total
score when called with `friend` as the sole argument, that particular
score would not be pink.
`GetScoreByUsername()` would arbitrarily pick the first score for the
user, so in this particular case where a friend had the number 1 score,
the test would wrongly fail.
Fix by checking whether any of the 3 added friend scores have received
the pink colour. Because there is more than 1 friend score in the test,
doing so ensures that at least one of those should eventually become
pink (because, obviously, you can't have two scores at number 1).
2023-09-21 21:12:44 +02:00
Bartłomiej Dach
9301a1907a
Rewrite TestFriendScore assertions to constraint model
...
Allows to clearly see what the failure is:
TearDown : System.TimeoutException : "friend score is pink" timed out: Expected: some item equal to "#FF549A"
But was: < "#FFFFFF", "#7FCC33", "#444444 " >
The #7FCC33 colour is used for the first score on the leaderboard.
2023-09-21 21:05:41 +02:00
Bartłomiej Dach
561f66400a
Merge pull request #24878 from peppy/fix-song-select-shift-delete
...
Fix shift-delete not working at song select
2023-09-21 20:48:42 +02:00
Bartłomiej Dach
d73f06fc89
Add test coverage for delete hotkey
2023-09-21 20:01:59 +02:00
Salman Ahmed
5266cdc722
Add explanatory note
2023-09-21 20:41:10 +03:00
Salman Ahmed
095812c6b8
Merge branch 'master' into fix-song-select-shift-delete
2023-09-21 20:25:43 +03:00
Salman Ahmed
1f3a660443
Merge pull request #24870 from peppy/update-framework
...
Update clocks in line with framework changes
2023-09-21 20:25:08 +03:00
Salman Ahmed
9e4a56d64e
Merge branch 'master' into update-framework
2023-09-21 19:49:20 +03:00
Dean Herbert
f1258a3963
Update framework
2023-09-22 01:26:38 +09:00
Dean Herbert
9af4e75dfc
Disable clipboard export for song select textbox
...
In combination with https://github.com/ppy/osu-framework/pull/5997 ,
closes https://github.com/ppy/osu/issues/24867
2023-09-22 01:24:29 +09:00
Bartłomiej Dach
08ef840370
Merge pull request #24550 from smoogipoo/mania-edit-disable-sv
...
Adjust osu!taiko and osu!mania editors to not visualise velocity changes by default
2023-09-21 09:50:55 +02:00
Bartłomiej Dach
69ed99dfd5
Merge branch 'master' into mania-edit-disable-sv
2023-09-21 09:13:27 +02:00
Bartłomiej Dach
b81e1ce4b2
Merge pull request #24875 from peppy/update-readme
...
General improvements to README
2023-09-21 09:04:49 +02:00
Dean Herbert
8ef0ef09db
Reword release build disclaimer
2023-09-21 14:59:37 +09:00
Dean Herbert
0eab4c5364
Reword sentence with multiple ands
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-09-21 14:47:55 +09:00
Dean Herbert
262916787e
Apply punctuation and terminology fixes
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2023-09-21 13:27:00 +09:00
Dean Herbert
9629f49afb
Update build instructions to be more clear about slnf files and mention workloads
2023-09-21 11:57:10 +09:00
Dean Herbert
fc6abae968
Remove note about dotnet CLI tools not working (less relevant post-EF)
2023-09-21 11:56:49 +09:00
Dean Herbert
c76853c32c
Add mention of new project
2023-09-21 11:56:32 +09:00
Dean Herbert
2954ad7834
Update language across whole readme to read better
2023-09-21 11:56:23 +09:00
Dean Herbert
8a3d412ffc
Remove mention of no-heated-gameplay-mechanics discussions
...
We're kinda at the point we're allowing this now.
2023-09-21 11:38:16 +09:00
Dean Herbert
bf984388b3
Update clocks in line with framework changes
2023-09-20 21:17:08 +09:00
Bartłomiej Dach
f2791d4f3e
Move comment a bit to fix formatting
...
Would otherwise trigger IDE0055, but that isn't resolveable without
an inspection cycle with resharper, so just move in a more sane place.
2023-09-20 12:22:05 +02:00
Bartłomiej Dach
46acd807f7
Merge pull request #24848 from Magnus-Cosmos/fix-slider-length
...
Use correct check for slider path extension
2023-09-20 11:45:39 +02:00
Bartłomiej Dach
28da5baea4
Merge branch 'master' into fix-slider-length
2023-09-20 11:10:01 +02:00
Dean Herbert
cb0226f843
Implement new interface-based speed change visualisation support on mania/taiko
2023-09-20 15:28:13 +09:00
Dean Herbert
41a8239e49
Remvoe null default for mods which can't be null
2023-09-20 15:27:50 +09:00
Dean Herbert
c6cc858967
Change implementation of "show speed changes" to require explicit ruleset support
2023-09-20 15:27:30 +09:00
Dean Herbert
2c38bed944
Merge pull request #24730 from cdwcgt/leaderboard-friend-highlight
...
Highlight friend score in gameplay leaderboards
2023-09-20 14:54:12 +09:00
Dean Herbert
c5397bdbb3
Merge branch 'master' into mania-edit-disable-sv
2023-09-20 14:23:07 +09:00
Dean Herbert
71ac5cfc79
Don't bother binding to friends changes for score display purposes
2023-09-20 14:14:37 +09:00
Dean Herbert
1927b524db
Merge branch 'master' into leaderboard-friend-highlight
2023-09-20 14:14:08 +09:00
Dean Herbert
cd4651ffe3
Merge pull request #24863 from bdach/storyboard-fail
...
Fix issues after storyboard resource lookup refactor
2023-09-20 11:14:15 +09:00
Dean Herbert
ccd5a9986d
Merge pull request #24866 from bdach/AAAAAAAAAAAaaaaaaaaaaaa
2023-09-20 10:22:25 +09:00
Bartłomiej Dach
333b839e0d
Fix broken automatic beatmap download setting migration
2023-09-19 21:38:07 +02:00
Bartłomiej Dach
641e651bf2
Fix DrawableStoryboardVideo attempting to unmap path once too much
...
The `StoryboardResourceLookupStore` cached at storyboard level is
supposed to already be handling that; no need for local logic anymore.
2023-09-19 20:18:33 +02:00
Bartłomiej Dach
ba518e1da8
Fix StoryboardResourceLookupStore dying on failure to unmap path
...
Before the introduction of `StoryboardResourceLookupStore`, missing
files would softly fail by use of null fallbacks. After the
aforementioned class was added, however, the fallbacks would not work
anymore if for whatever reason `GetStoragePathFromStoryboardPath()`
failed to unmap the storyboard asset name to a storage path.
2023-09-19 20:11:16 +02:00
Dean Herbert
aea7f81f1c
Merge pull request #24800 from sw1tchbl4d3r/invalid_bank
...
Default to normal bank if invalid sample bank is specified
2023-09-19 22:28:34 +09:00
Bartłomiej Dach
c4a0ca326e
Replace sample bank fix with more correct fix
...
stable does not treat unknown enum members as `None` / `Auto`, it treats
them as `Normal`:
switch (sampleSet)
{
case SampleSet.Normal:
default:
sample = 0;
break;
case SampleSet.None:
case SampleSet.Soft:
sample = 1;
break;
case SampleSet.Drum:
sample = 2;
break;
}
(from 1531237b63/osu
2023-09-19 13:53:49 +02:00
Bartłomiej Dach
320a9fc171
Replace test with better test
2023-09-19 13:47:46 +02:00
Dean Herbert
ca659c8eda
Merge pull request #24612 from peppy/add-app-category
...
Add application category type to enable game mode on new macOS versions
2023-09-19 20:21:53 +09:00
Bartłomiej Dach
43ae26b8ef
Merge pull request #24809 from peppy/storyboard-resource-lookup-refactor
...
Refactor storyboard resource lookup to be more streamlined
2023-09-19 12:52:02 +02:00
