Mk-56spn
4a6c8785af
Clean up
2022-09-08 11:14:56 +02:00
Mk-56spn
7f08de522d
Fixed
2022-09-08 01:21:03 +02:00
MK56
e250885204
Merge branch 'ppy:master' into Freeze_frame_implementation
2022-09-08 00:10:44 +02:00
Mk-56spn
5a1b2f9a77
Freeze frame testing
2022-09-08 00:05:48 +02:00
Dan Balasescu
85ce1bcea9
Merge pull request #20177 from peppy/fix-target-mod-crash
...
Fix target mod crashing if beatmap is played with a break after all hitobjects
2022-09-07 19:24:19 +09:00
Dean Herbert
b5b66de3c9
Fix target mod crashing if beatmap is played with a break after all hitobjects
...
Closes https://github.com/ppy/osu/issues/20161 .
2022-09-07 17:46:51 +09:00
Dan Balasescu
f8e37af2e0
Merge pull request #20171 from peppy/beatmap-carousel-nrt
...
Fix missing null checks on `selectedBeatmap` fields in `BeatmapCarousel`
2022-09-07 17:15:00 +09:00
Dan Balasescu
264c9bfaf6
Merge pull request #20173 from peppy/test-scene-storyboard-tidy
...
Tidy up `TestSceneStoryboard`
2022-09-07 17:07:19 +09:00
Dean Herbert
68c27522e7
Merge pull request #20158 from smoogipoo/taiko-geki-katu
...
Decode taiko Geki/Katu from legacy scores into `LargeBonus`
2022-09-07 17:06:42 +09:00
Dan Balasescu
edabb0dfe6
Merge pull request #20174 from peppy/fix-storyboard-zero-vector-scale
...
Fix some storyboard sprites still showing with zero `VectorScale`
2022-09-07 16:50:14 +09:00
Dean Herbert
5b758afd09
Merge branch 'master' into taiko-geki-katu
2022-09-07 16:22:47 +09:00
Dean Herbert
b50116e9e4
Add missing null check in BeatmapCarousel tests
2022-09-07 16:22:11 +09:00
Dean Herbert
5b95fdeb92
Merge pull request #18764 from sw1tchbl4d3r/classic_drumrolls
...
Make drum rolls and swells optional in taiko
2022-09-07 16:12:56 +09:00
Dean Herbert
824e68dab3
Fix VectorScale set to 0 still showing some sprites in storyboard
...
This implementation was matching the [framework side implementation of
scale](16d1c2d335/osu.Framework/Graphics/Drawable.cs (L973-L976)https://github.com/ppy/osu/issues/20155 .
2022-09-07 15:39:19 +09:00
Dean Herbert
258b8f015c
Add test coverage of storyboard using zero VectorScale
2022-09-07 15:39:19 +09:00
Dean Herbert
866bc553fe
Tidy up TestSceneStoryboard
2022-09-07 15:38:49 +09:00
Dan Balasescu
dbdb311f79
Merge pull request #20094 from peppy/tourney-fix-team-display-scores
...
Show team scores at the tournament map pool screen
2022-09-07 14:58:14 +09:00
Dan Balasescu
c42ae4be04
Merge pull request #20095 from peppy/fix-bracket-riht-click-no-selection
...
Fix right-clicking a non-selected match in ladder view dismissing context menu
2022-09-07 14:56:23 +09:00
Dan Balasescu
dc71abdf56
Merge pull request #20144 from peppy/fix-notification-overlay-presence
...
Fix completion toasts sometimes not displaying
2022-09-07 14:55:33 +09:00
Dean Herbert
f3bda4e040
Fix weird edge case of nullability in CarouselRoot
...
A bit unfortunately, but it's what we get for having ctor level bindings..
2022-09-07 14:27:25 +09:00
Dean Herbert
83962443e5
Merge pull request #20168 from nekodex/add-textbox-esc-feedback
...
Add audio feedback for Esc/Back clearing text from a FocusedTextBox
2022-09-07 14:19:15 +09:00
Dean Herbert
e18b524f8e
Fix missing null checks on selectedBeatmap fields in BeatmapCarousel
2022-09-07 14:12:35 +09:00
Dean Herbert
241d33d415
Apply NRT to BeatmapCarousel
2022-09-07 14:07:53 +09:00
Jamie Taylor
cb1d886c9c
Add audio feedback for Esc/Back clearing text from a FocusedTextBox
2022-09-07 13:17:04 +09:00
Salman Ahmed
13efa819ae
Merge pull request #19413 from Gramore/feature/EditorDeleteDiff
...
Add ability to delete difficulties from the editor
2022-09-06 19:20:45 +03:00
Salman Ahmed
90207b6032
Merge branch 'master' into feature/EditorDeleteDiff
2022-09-06 18:48:06 +03:00
Dan Balasescu
7c0e99c5a8
Decode Geki/Katu from legacy taiko scores into LargeBonus
2022-09-07 00:12:34 +09:00
Dan Balasescu
6a371eba5f
Fix namespace
2022-09-07 00:12:25 +09:00
Dean Herbert
c2107bd322
Fix test failures due to notifications being forwarded before player finishes loading
2022-09-06 23:36:27 +09:00
Dan Balasescu
2ca63b5030
Add tests for all taiko judgements
2022-09-06 23:26:25 +09:00
Dan Balasescu
a2f8ff825e
Also ignore drum roll strong judgement
2022-09-06 23:26:25 +09:00
Dan Balasescu
604fc0fb97
Merge pull request #20156 from peppy/sb-earliest-alpha-fix-atttempt-two
...
Fix some storyboard elements displaying too late due to incorrect start time allowances
2022-09-06 23:14:43 +09:00
Dean Herbert
db15bd56e8
Invalidate working beatmap cache when calling DeleteDifficultyImmediately rather than in editor code
2022-09-06 18:12:47 +09:00
Dean Herbert
579e7e1f17
Fix deleting a difficulty not updating the beatmap set hash
2022-09-06 18:12:47 +09:00
Dean Herbert
a3de5f808e
Fix typo in LoopStartTime addition
2022-09-06 17:46:03 +09:00
Dean Herbert
9f2ea54e40
Tidy up TestSceneLeadIn constant for loop offset to read better
2022-09-06 17:45:53 +09:00
Dean Herbert
6e52dbb266
Update IsDisplayingToasts to check the flow count directly
2022-09-06 17:30:24 +09:00
Dean Herbert
677708c5e4
Rewrite logic using a list
2022-09-06 16:58:51 +09:00
Dean Herbert
d667f46830
Refactor alpha check to not overwrite sourced overrides with values from later commands
2022-09-06 16:41:32 +09:00
Dean Herbert
fa0a4614f8
Add failing test for second incorrect case of start time handling
2022-09-06 16:40:59 +09:00
Dan Balasescu
792b410c04
Merge branch 'master' into classic_drumrolls
2022-09-06 16:29:45 +09:00
Dean Herbert
bea42d2862
Handle earliest-alpha-start-time logic in StoryboardSprite itself
2022-09-06 16:16:58 +09:00
Dean Herbert
a5e57b083c
Remove EarliestDisplayTime's input to CommandStartTime
2022-09-06 16:16:58 +09:00
Dean Herbert
abf0242686
Add failing test for incorrect start time of storyboard elements
2022-09-06 16:16:58 +09:00
Dean Herbert
9e3228aa65
Fix completion notification not being posted if completion occurs during NotificationOverlay load
2022-09-06 04:07:49 +09:00
Dean Herbert
6296c971f8
Merge pull request #20136 from smoogipoo/fix-cancellation-perf
...
Improve performance when cancelling import with debugger attached
2022-09-05 22:03:50 +09:00
Dean Herbert
510972e3ad
Avoid reference counting by using height calculation for IsPresent instead
...
The reference counting was to guarantee performance (zero allocations)
when the notification overlay was not required, but adds extra
complexity.
Instead, the toast tray now uses its ongoing height calculation as a
metric for presence.
2022-09-05 19:38:09 +09:00
Dean Herbert
0514c96191
Fix incorrect count tracking when notification is manually disposed
2022-09-05 19:26:40 +09:00
Dean Herbert
229e1a8ef7
Fix notification overlay being present when it doesn't need to
2022-09-05 19:13:58 +09:00
Dean Herbert
f754686521
Remove necessity of AlwaysPresent for ProgressUpdate completion posting
2022-09-05 19:13:58 +09:00
