38084 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	464fc02875	Fix some styling issues with the verify screen layout	2021-04-13 19:55:17 +09:00
Dean Herbert	03ba04e8ce	Split out general checks into its own verifier class (and remove static usage)	2021-04-13 19:50:22 +09:00
Naxess	aa5fe2e9fc	Rename BeatmapVerifier -> IBeatmapVerifier	2021-04-13 11:02:01 +02:00
Naxess	304fe5cd34	Add CheckBackground to OsuBeatmapVerifier	2021-04-13 10:41:02 +02:00
Naxess	60c2494b31	Make BeatmapVerifier an interface	2021-04-13 10:40:56 +02:00
Naxess	c8cb4286f6	Add reference for screen bounding box numbers	2021-04-13 10:35:06 +02:00
Naxess	98c25b2e71	Remove unused import	2021-04-13 10:33:08 +02:00
Dean Herbert	b45d7de4ec	Update asserts to use better nunit specifications	2021-04-13 15:04:01 +09:00
Dean Herbert	4837cef095	Use static for playfield centre positioning	2021-04-13 14:44:52 +09:00
Naxess	6d3f9fa9ce	Use is class instead of Equals with template index ... Ensures ordering of `PossibleTemplates` does not affect tests.	2021-04-13 02:29:25 +02:00
Naxess	0bcc39bd36	Remove redundant space	2021-04-13 02:17:35 +02:00
Naxess	8a6dfcfae1	Add CheckOffscreenObjects tests	2021-04-13 01:22:36 +02:00
Naxess	47cf4bcf25	Add CheckBackground tests	2021-04-13 01:22:24 +02:00
Naxess	d8088777ea	Add Equals method to IssueTemplate ... This will be useful in tests.	2021-04-13 01:21:34 +02:00
Naxess	19a154ddf1	Rename checkOrigin -> check ... More consistent with `Issue.ctor`'s "template".	2021-04-12 17:28:12 +02:00
Naxess	bb720c23a0	Remove check ctors and locals	2021-04-12 17:12:37 +02:00
Dean Herbert	62c1812282	Remove redundant parameter naming	2021-04-12 23:37:47 +09:00
Dean Herbert	36bd235021	Move nested classes to bottom of file	2021-04-12 23:36:10 +09:00
Naxess	6d50d01186	Make IssueTemplate.Check readonly	2021-04-12 16:23:05 +02:00
Naxess	caaaba5950	Rename Check -> ICheck	2021-04-12 16:20:53 +02:00
Naxess	008dbc7dd6	Reverse IssueType ordering ... Reversed both in the enum and where it's displayed, so ends up the same in the end.	2021-04-12 15:49:13 +02:00
Naxess	1c69829ad4	Fix Template.Origin -> Check	2021-04-12 15:47:58 +02:00
Naxess	7c4f6d2b62	Rework template usage ... Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.	2021-04-12 15:47:26 +02:00
Naxess	a2fc9c398f	Rename CreateChecker -> CreateBeatmapVerifier	2021-04-12 10:08:30 +02:00
Naxess	65ebdd8f7a	Move check origin from IssueTemplate to Issue ... As a result we can also make check an interface, and need to provide the check itself when constructing an issue.	2021-04-12 10:08:08 +02:00
Dean Herbert	42604afcdc	Add binding for verify mode (and move enum entry to end)	2021-04-12 16:15:27 +09:00
Dean Herbert	8bf85d737c	Change Metadata into a get property	2021-04-12 15:52:29 +09:00
Dean Herbert	78bbc8f5c8	Tidy some remaining code	2021-04-12 15:52:18 +09:00
Dean Herbert	8c31e96cdf	Change some methods to get properties	2021-04-12 15:52:18 +09:00
Dean Herbert	f78239c7f2	Move enums out of nesting	2021-04-12 15:52:18 +09:00
Dean Herbert	3551322f1d	Fix formatting of colour getter	2021-04-12 15:52:18 +09:00
Dean Herbert	257acf9cd8	Colour constants to private	2021-04-12 15:52:18 +09:00
Dean Herbert	136627b9ac	Wrap xmldoc less and make a few fixes	2021-04-12 15:52:18 +09:00
Dean Herbert	1c553b5d48	Checker -> BeatmapVerifier	2021-04-12 15:29:05 +09:00
Dean Herbert	14bd5bdc77	Merge branch 'master' into verify-tab	2021-04-12 15:14:37 +09:00
Dean Herbert	4853ac802c	Merge pull request #12367 from Joehuu/lazy-flashlight ... Add follow delay setting to osu! flashlight mod	2021-04-11 19:07:06 +09:00
Joseph Madamba	a42714540b	Add follow delay setting to osu! flashlight mod	2021-04-10 23:04:15 -07:00
Naxess	dac733cced	Fix field name and accessibility	2021-04-10 15:49:57 +02:00
Naxess	7d40b01722	Remove old todo	2021-04-10 15:18:15 +02:00
Naxess	3289bb0379	Merge Check and BeatmapCheck ... We're probably not going to need GeneralChecks or BeatmapsetChecks. The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.	2021-04-10 14:56:30 +02:00
Naxess	747e0f00dc	Improve table formatting	2021-04-10 13:10:05 +02:00
Naxess	3a4f2e3d7e	Show table even if no issues	2021-04-10 13:09:16 +02:00
Naxess	c995eca029	Remove todo ... Doesn't really matter in the end, as only one checker will run at a time in this case.	2021-04-10 13:05:24 +02:00
Naxess	6d3cf78e4a	Add issue selection ... This mainly helps with keeping track of which issue was clicked, since doing so switches tab.	2021-04-10 13:04:39 +02:00
Naxess	bc4f3351f3	Replace checks with realistic ones	2021-04-10 13:03:16 +02:00
Naxess	b30e41b805	Fix comment; mode -> ruleset	2021-04-10 13:02:36 +02:00
Naxess	d1007ff26a	Move components to more appropriate spot	2021-04-10 13:02:22 +02:00
Naxess	43174b708c	Remove visibility settings ... Can look into this later, not really important for a first iteration.	2021-04-10 12:58:40 +02:00
Dean Herbert	ab49e84d17	Merge pull request #12356 from peppy/update-framework ... Update framework	2021-04-10 03:34:24 +09:00
Dean Herbert	b66ef2fdec	Update framework	2021-04-10 02:14:28 +09:00