Dean Herbert
002cc7261b
Merge pull request #16773 from smoogipoo/fix-spectator-restart-crash
...
Fix crash when gameplay is started while inside multiplayer spectator screen
2022-02-04 19:23:08 +09:00
Dean Herbert
503025b970
Fix completely incorrect and dangerous usage of bindable binding
2022-02-04 19:19:44 +09:00
Dan Balasescu
fa3d1115fa
Remove online api requirement
2022-02-04 19:17:50 +09:00
Dan Balasescu
dd63b1a350
Fix broken spectator playback test scene
2022-02-04 19:12:02 +09:00
Dean Herbert
915d63f6de
Limit safe area bottom override to iOS only
2022-02-04 18:58:29 +09:00
Dean Herbert
6457cf8d9b
Fix weird formatting in TestSceneSafeArea
2022-02-04 18:45:40 +09:00
Dean Herbert
8fc4d0c6f5
Add override edge rule to overflow above home indicator on iOS
2022-02-04 18:20:17 +09:00
Dan Balasescu
d5269ba05b
Merge branch 'fix-spectator-restart-crash' into spectator-state-rework
2022-02-04 17:59:18 +09:00
Dan Balasescu
0473c6c52f
Also handle null SelectedItem for safety
2022-02-04 17:53:51 +09:00
Dan Balasescu
b41655d5b9
Fix crash when gameplay starts while in multi-spectator screen
2022-02-04 17:47:41 +09:00
Dean Herbert
30d2c7ba6a
Add parenthesis to disambiguify conditionals
2022-02-04 17:07:23 +09:00
Dean Herbert
1444df4d50
Add test scene for playing with safe areas
2022-02-04 16:39:10 +09:00
Dean Herbert
52fdf0349f
Add safe area support via ScalingContainer
2022-02-04 16:37:05 +09:00
Dan Balasescu
a289582f7c
Merge pull request #16770 from peppy/update-framework
...
Update framework
2022-02-04 16:32:43 +09:00
Dean Herbert
4728919bca
Update framework
2022-02-04 15:45:27 +09:00
Dean Herbert
180d583304
Merge pull request #16733 from Susko3/android-orientation
...
Lock screen orientation to landscape on mobile phones
2022-02-04 15:39:26 +09:00
Dan Balasescu
63064d682b
Merge pull request #16743 from hlysine/extended-statistics-without-replay
...
Allow statistic items in results screen to display without needing to watch a replay
2022-02-04 15:07:52 +09:00
Dean Herbert
fa7fa151e9
Merge pull request #16754 from bdach/new-difficulty-creation-v3
...
Add ability to create new difficulties from within the editor
2022-02-04 11:47:21 +09:00
Salman Ahmed
bbef12e72c
Refactor ExpandingControlContainer to no longer rely on controls
2022-02-04 05:45:12 +03:00
Dean Herbert
ee1feae806
Remove unnecessary ruleset ordering
...
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
2022-02-04 11:06:18 +09:00
Bartłomiej Dach
6dc0f3fd96
Merge difficulty creation methods into one
...
One of them wasn't really doing much anymore and was more obfuscating
what was actually happening at this point.
2022-02-03 18:14:30 +01:00
Bartłomiej Dach
b7d7e6612e
Merge branch 'master' into new-difficulty-creation-v3
2022-02-03 16:36:18 +01:00
Dan Balasescu
d4ebff6ea1
Add failing test
2022-02-03 23:18:22 +09:00
Susko3
84171962e5
Change name and add xmldoc
2022-02-03 13:55:04 +01:00
Dan Balasescu
f285060148
Fix MultiSpectatorScreen not continuing to results
2022-02-03 21:50:19 +09:00
Susko3
40953751b5
Use ScreenOrientation.FullUser on Android tablets
2022-02-03 13:29:37 +01:00
Dan Balasescu
483977d5c8
Merge branch 'master' into spectator-state-rework
2022-02-03 19:59:07 +09:00
Dean Herbert
bef0a2da21
Remove return type from AddDifficultyToBeatmapSet
...
Also removes a pointless realm encapsulation.
2022-02-03 19:43:43 +09:00
Dean Herbert
ad47649d1c
Make BeatmapModelManager.Save non-virtual
2022-02-03 19:38:53 +09:00
Dean Herbert
b2efce2656
Merge branch 'master' into expandable-controls
2022-02-03 19:23:34 +09:00
Dean Herbert
dbf2a1149c
Merge pull request #16675 from nekodex/songselect-random-sfx
...
Add audio feedback to song select 'random'
2022-02-03 19:20:07 +09:00
Dean Herbert
47d577ec9c
Add back constructor for ruleset compatibility
2022-02-03 19:17:56 +09:00
Dean Herbert
6974c2d255
Remove weird panelIsComplete flag and replace LINQ with simple foreach
2022-02-03 19:00:03 +09:00
Dean Herbert
df9d99f5aa
Merge branch 'master' into extended-statistics-without-replay
2022-02-03 18:59:48 +09:00
Dean Herbert
6d6327d3da
Fix test beatmap loading potentially performing selection before carousel itself is loaded
2022-02-03 18:40:16 +09:00
Henry Lin
a27d0572ed
Add test cases for manual testing
2022-02-03 17:00:40 +08:00
Dean Herbert
e65996efc3
Rename variable to match purpose better
2022-02-03 17:14:38 +09:00
Dean Herbert
137a9a0305
Merge branch 'master' into songselect-random-sfx
2022-02-03 17:14:28 +09:00
Dan Balasescu
46d180eeb5
Merge pull request #16760 from peppy/force-relayout-on-score-mode-change
...
Trigger a re-layout of HUD components when scoring mode is changed
2022-02-03 17:06:38 +09:00
Dan Balasescu
d3e6eac02e
Merge pull request #16762 from peppy/fix-carousel-ruleset-filter-test-local-database
...
Fix `TestSelectingFilteredRuleset` failing under visual tests due to using local database
2022-02-03 16:59:45 +09:00
Dean Herbert
41aa4b8cca
Fix TestSelectingFilteredRuleset failing under visual tests due to using local database
2022-02-03 16:04:05 +09:00
Dan Balasescu
cd806711f8
Merge pull request #16761 from peppy/more-dialog-overlay-wait
...
Wait for `DialogOverlay` load in more tests
2022-02-03 16:01:32 +09:00
Dean Herbert
6355ac6663
Wait for DialogOverlay load in more tests
...
Apparently the previous fix was not enough as this can still be seen
failing
(https://github.com/ppy/osu/runs/5046718623?check_suite_focus=true ).
This change is copying from what other tests use seemingly reliably,
such as `TestScenePerformFromScreen`)
2022-02-03 15:10:08 +09:00
Dean Herbert
c8ce00b26a
Trigger a re-layout of HUD components when scoring mode is changed
...
This is a simple way of fixing the layout of scoring elements
overlapping due to different score display width requirements of
different scoring modes. It will only resolve the case where a user
hasn't customsied the layout of the default skins, but as this is a very
simple / low effort implementation for the most common scenario, I think
it makes sense.
Closes https://github.com/ppy/osu/issues/16067 .
2022-02-03 14:50:41 +09:00
Dean Herbert
867586f7f5
Merge pull request #16758 from smoogipoo/fix-incomplete-requests-offline
...
Fix API requests not completing when offline
2022-02-03 14:34:24 +09:00
Dean Herbert
a69c7a9de6
Split exceptions back out to give better messaging
2022-02-03 14:09:27 +09:00
Dean Herbert
62fa915193
Standardise exception messages for local-user-logged-out flows
2022-02-03 13:58:55 +09:00
Dan Balasescu
d9a43b4c4c
Fix API requests not completing when offline
2022-02-03 13:16:54 +09:00
Henry Lin
aff36d4e16
Refactor populateStatistics to avoid disposing
2022-02-03 11:52:37 +08:00
Dan Balasescu
62537eb4aa
Fix spectator not completing
2022-02-03 12:44:33 +09:00
