Bartłomiej Dach
2c0a5b7ef5
Fix missing tiny droplet not triggering fail with perfect on
...
Stable does this:
46cd3a10af/osu
!/GameplayElements/HitObjectManagerFruits.cs#L98-L102
I'd rather not say what I think about it doing that, since it's likely
to be unpublishable, but to approximate that, just make it so that
only the "default fail condition" is beholden to the weird ebbs
and flows of what the ruleset wants. This appears to fix the problem
case and I'm hoping it doesn't break something else but I'm like 50/50
on it happening anyway at this point. Just gotta add tests add nauseam.
2024-02-14 14:21:48 +01:00
Bartłomiej Dach
f1363dc9e4
Merge pull request #27164 from frenzibyte/comment-mapper-pill
...
Add support for displaying "mapper" badge in comment section
2024-02-14 13:53:50 +01:00
Bartłomiej Dach
3f46e1afc3
Merge branch 'master' into comment-mapper-pill
2024-02-14 13:22:36 +01:00
Bartłomiej Dach
68247fa022
Fix typo in json property name
...
Would cause the mapper badge to never actually be shown in the real
world.
2024-02-14 13:21:37 +01:00
Bartłomiej Dach
8312f92b4e
Use better value for alignment
2024-02-14 12:24:28 +01:00
Bartłomiej Dach
d189fa0f69
Rename flag
2024-02-14 11:53:41 +01:00
Bartłomiej Dach
746f50e738
Merge pull request #27165 from frenzibyte/catch-remove-plate-flipping
...
Remove behaviour of flipping catcher plate on direction change
2024-02-14 10:55:14 +01:00
Bartłomiej Dach
153024e61b
Increase transition durations slightly
...
Maybe slightly better readability. Dunno.
2024-02-14 10:16:10 +01:00
Bartłomiej Dach
6baa099906
Fix broken delay
2024-02-14 10:12:01 +01:00
Bartłomiej Dach
7f76ff1f5d
Merge pull request #27145 from tsunyoku/legacy-relax-replays-key-presses
...
Create key-presses when watching legacy Relax replays
2024-02-14 10:06:06 +01:00
Dan Balasescu
3b8203a3ad
Merge pull request #27167 from smoogipoo/fix-inspection
...
Prefer collection initializer over collection expression syntax
2024-02-14 17:58:40 +09:00
Dan Balasescu
2981ebe3d5
Fix inspection
2024-02-14 17:13:44 +09:00
Bartłomiej Dach
f53bce8ff7
Fix catch health processor allowing fail on tiny droplet
...
Closes https://github.com/ppy/osu/issues/27159 .
In today's episode of "just stable things"...
2024-02-14 09:02:33 +01:00
Bartłomiej Dach
3d8d0f8430
Update test expectations for catch
2024-02-14 08:37:20 +01:00
Salman Ahmed
02de9122d4
Remove behaviour of flipping catcher plate on direction change
2024-02-14 07:17:05 +03:00
Salman Ahmed
c24af5bfeb
Add test coverage
2024-02-14 04:17:55 +03:00
Salman Ahmed
4d3b605e04
Add support for displaying "mapper" badges in comments
2024-02-14 04:17:55 +03:00
Salman Ahmed
72c6134dbf
Include commentable object metadata in comments
2024-02-14 04:16:36 +03:00
Salman Ahmed
c4e358044a
Add API models for comment page metadata
2024-02-14 04:16:36 +03:00
Salman Ahmed
5267e0abf7
Move comment author line to separate component
2024-02-14 04:16:36 +03:00
Salman Ahmed
35649d137c
Ignore soft-deleted beatmaps when trying to present from notification
2024-02-14 02:04:20 +03:00
Salman Ahmed
a96a66bc9e
Add failing test case
2024-02-14 02:04:20 +03:00
Salman Ahmed
9b17020707
Adjust "Floating Fruits" in line with layout changes
2024-02-14 01:34:55 +03:00
Salman Ahmed
62f5251b6e
Rewrite osu!catch playfield layout containers and apply masking around vertical boundaries
2024-02-14 01:34:55 +03:00
Bartłomiej Dach
eae43f5fd9
Consume SoloStatisticsWatcher
updates in toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
14052ae1cc
Implement transient stats display on user toolbar button
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
21b9fb95e2
Move SoloStatisticsWatcher
to OsuGame
...
Doesn't feel like it needs to be in base, and it being in base was
causing problems elsewhere before.
2024-02-13 14:28:24 +01:00
Bartłomiej Dach
da4ebd0681
Refactor SoloStatisticsWatcher
to no longer require explicit subscription callbacks
2024-02-13 13:49:01 +01:00
Bartłomiej Dach
16d893d40c
Fix draining processor failing gameplay on bonus misses and ignore hits
2024-02-13 13:06:19 +01:00
Bartłomiej Dach
d07ea8f5b1
Add failing test coverage for mania
2024-02-13 13:06:19 +01:00
Bartłomiej Dach
441a7b3c2f
Add precautionary taiko test coverage
2024-02-13 13:06:19 +01:00
Bartłomiej Dach
86801aa51d
Add failing test coverage for osu!
2024-02-13 13:06:04 +01:00
Dean Herbert
f7a223f328
Merge pull request #27053 from frenzibyte/unranked-pp-placeholder
...
Add support for displaying "unranked PP" placeholder
2024-02-13 18:59:55 +08:00
Bartłomiej Dach
1eb04c5190
Add failing test coverage for catch
2024-02-13 11:47:38 +01:00
Bartłomiej Dach
22e9c4a3b5
Use private interface rather than weird inheritance
2024-02-13 10:20:06 +01:00
Dan Balasescu
833997bf1d
Merge pull request #27143 from bdach/more-stringent-metadata-checks
...
Use more stringent checks when applying online metadata
2024-02-13 17:10:52 +09:00
James Wilson
5101979ac0
only use LegacyReplayPressHandler
on legacy replays
2024-02-13 00:34:06 +00:00
Dan Balasescu
60e0eea9bc
Merge pull request #27112 from Stoppedpuma/alias-author-creator
...
Add aliases "author" and "mapper" for creator results
2024-02-13 08:35:49 +09:00
Dan Balasescu
d3e005d4a2
Merge pull request #27116 from tsunyoku/only-compute-flashlight-when-necessary
...
Only compute flashlight in osu! difficulty calculations when required
2024-02-13 08:25:59 +09:00
Salman Ahmed
2d65dfbf09
Fix Rider EAP whoopsie
2024-02-12 22:10:36 +03:00
Salman Ahmed
5bebe9fe0d
Add test case for profile scores made on loved beatmaps
2024-02-12 21:33:18 +03:00
Salman Ahmed
4f0f07d55a
Remove placeholder classes and inline everything
2024-02-12 21:30:10 +03:00
tsunyoku
cc733ea809
add inline comment for supposedly backwards ternary
2024-02-12 18:00:05 +00:00
tsunyoku
2a02566283
refactor down
and wasLeft
management into respective PressHandler
classes
2024-02-12 17:45:00 +00:00
Bartłomiej Dach
5d81d83fb2
Merge branch 'master' into alias-author-creator
2024-02-12 18:02:42 +01:00
Bartłomiej Dach
96711eb185
Add test coverage
2024-02-12 18:02:34 +01:00
tsunyoku
581ae2f679
handle key presses when watching legacy relax replays
2024-02-12 12:51:35 +00:00
cdwcgt
1944a12634
allow ModMuted
to ranked when setting adjusted
2024-02-12 21:18:31 +09:00
Bartłomiej Dach
e5e0b0e385
Add test coverage for correct setting of beatmap set status
2024-02-12 12:08:51 +01:00
Bartłomiej Dach
138fea8c38
Only apply set-level metadata after all difficulties have been processed
2024-02-12 12:08:51 +01:00