osu-lazer

Remove unused OsuColor variable

tadatomix · 2025-10-10 02:34:09 +03:00

3d6a3e3eda

Make Graveyard panel colour even brighter

tadatomix · 2025-10-10 02:32:07 +03:00

a0f295d6fe

Change the pool of available Ranked Statuses

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

De4n · 2025-10-08 20:09:06 +03:00

0cc2e4eaa0

Make Graveyard panel brighter

tadatomix · 2025-10-07 23:29:34 +03:00

e4c5fc1906

Fix chevron being too bright in most cases

tadatomix · 2025-10-07 01:21:31 +03:00

03bbbebbbc

Add a test for the new group

tadatomix · 2025-10-07 01:21:01 +03:00

97c95de94a

Make initial work to create a ranked status style

tadatomix · 2025-10-07 01:06:46 +03:00

3dcbcb5f64

Merge pull request #35221 from bdach/adjust-tag-threshold

Adjust display tag threshold to match web

Dean Herbert · 2025-10-06 20:57:26 +09:00

19718c706a

Merge pull request #35222 from peppy/fix-left-hover-not-always

Fix hovering left area in song select not always activating reset action

Bartłomiej Dach · 2025-10-06 12:17:56 +02:00

4b3d2b0c57

Fix hovering left area in song select not always activating reset action

Dean Herbert · 2025-10-06 18:23:33 +09:00

df58dc0ca2

Add failing test scene covering song select left hover action not always activating

Dean Herbert · 2025-10-06 18:21:10 +09:00

d08b5a72b7

Adjust display tag threshold to match web

Follow-up to https://github.com/ppy/osu-web/pull/12381 - tags will glow
green starting from 5 votes rather than 10 to match the new threshold
web-side.

Bartłomiej Dach · 2025-10-06 11:09:54 +02:00

b286f05c78

Merge pull request #35185 from nekodex/matchmaking-more-sfx

Yet more matchmaking SFX work

Dean Herbert · 2025-10-06 18:04:22 +09:00

b3ed7717a8

Delay round increment sound to match animation better

Dean Herbert · 2025-10-06 18:03:53 +09:00

bc7e02c30b

Merge pull request #35184 from bdach/song-select-reselect-group-for-selection-when-moving-left

Expand group that current selection resides in when moving mouse to left side of song select

Dean Herbert · 2025-10-06 17:47:20 +09:00

557df19bf4

Merge branch 'master' into song-select-reselect-group-for-selection-when-moving-left

Dean Herbert · 2025-10-06 16:57:57 +09:00

8a450563fd

Merge pull request #35189 from bdach/catcher-fail-state-on-tiny-droplet-miss

Fix missing tiny droplets not changing catcher animation state to fail

Dean Herbert · 2025-10-06 16:42:10 +09:00

f9a226d68e

Merge pull request #35176 from bdach/local-modified-beatmap-regressions

Fix a few issues regarding incorrect treatment of locally-modified beatmaps

Dean Herbert · 2025-10-06 16:22:09 +09:00

dd846dcc52

Merge pull request #35178 from bdach/song-select-loses-selection-if-convert

Fix selection being changed on re-entering song select when a converted beatmap is selected

Dean Herbert · 2025-10-06 15:53:42 +09:00

71ae1d34cd

Merge pull request #35199 from peppy/editor-timing-panel-current-row-visibility

Adjust colouring to make current row in timing visualisation more obvious

Bartłomiej Dach · 2025-10-06 08:39:05 +02:00

dd8dfc04b3

Update resources

Dean Herbert · 2025-10-06 14:49:42 +09:00

2f6bd6605f

Merge pull request #35188 from bdach/song-select-do-not-flash-wrong-leaderboard

Fix wrong leaderboard flashing briefly when quickly changing beatmaps

Dean Herbert · 2025-10-06 14:43:33 +09:00

e76d1ae619

Merge pull request #35179 from bdach/song-select-scroll-closest-expanded-thing-into-view

Attempt to scroll carousel to nearest expanded panel when the current selection is filtered out

Dean Herbert · 2025-10-06 14:42:54 +09:00

c0a7c97185

Adjust colouring to make current row in timing visualisation more obvious

Dean Herbert · 2025-10-04 16:13:48 +09:00

a2770a8674

Fix missing tiny droplets not changing catcher animation state to fail

Addresses https://github.com/ppy/osu/discussions/35182.

The source as it is would have you believe that this is correct and
intentional but I'm not so sure about that. For one thing, I
cross-checked stable, and sure, missing tiny droplets does change the
state to fail over there. For another, the guard in master at

	https://github.com/ppy/osu/blob/5e642cbce72862b29b117829e7ec90d6d6b0ce1e/osu.Game.Rulesets.Catch/UI/Catcher.cs#L250

is very suspicious, given that it is dead in cause of tiny droplets
because of a preceding guard:

	https://github.com/ppy/osu/blob/5e642cbce72862b29b117829e7ec90d6d6b0ce1e/osu.Game.Rulesets.Catch/UI/Catcher.cs#L227-L228

Looking into blame, the tiny droplet guard originates at
e7f1f0f38b, wherein it looks to have been
aimed at handling *hyperdash* state specifically. Later, the logic has
been moved around and around like five times; at
7069cef9ce, the catcher animation logic
was added *below* the hyperdash-aimed guard without the comment being
updated in any way; 5a5c956ced moved the
logic from `CatcherArea` to `Catcher`, while simultaneously changing
the inline comment to no longer mention hyperdashing; and finally,
1d669cf65e added specific testing of tiny
droplets not changing catcher animation state, which I wager to be
back-engineered from the implementation as-it-was rather than
supported by any actual ground truth.

For additional reference:

- catcher animation logic in stable is at https://github.com/peppy/osu-stable-reference/blob/67795dba3c308e7d0493b296149dcb073ca47ecb/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L411-L463
- hyperdash application logic in stable is at https://github.com/peppy/osu-stable-reference/blob/67795dba3c308e7d0493b296149dcb073ca47ecb/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L165-L171

Bartłomiej Dach · 2025-10-03 14:52:33 +02:00

67041254db

Adjust test to exercise actual desired behaviour

Bartłomiej Dach · 2025-10-03 14:39:48 +02:00

68d5f53cc7

Fix wrong leaderboard flashing briefly when quickly changing beatmaps

Closes https://github.com/ppy/osu/issues/33743.

Bartłomiej Dach · 2025-10-03 12:35:58 +02:00

a30c7f51d0

Code style fixes

Jamie Taylor · 2025-10-03 18:04:55 +09:00

4e90a2aee2

Change 'quick play' button to use the 'daily' sample for now

Jamie Taylor · 2025-10-03 17:17:23 +09:00

e24df0b9d0

Add SFX for round transitions

Jamie Taylor · 2025-10-03 17:16:45 +09:00

27ff2a7d49

Rework StageDisplay SFX

Jamie Taylor · 2025-10-03 17:16:21 +09:00

3cb85f743a

Add SFX for enqueueing and also a looping 'waiting' SFX when in certain matchmaking states

Jamie Taylor · 2025-10-03 17:10:52 +09:00

43878f6d33

Add ducking effect on match found

Jamie Taylor · 2025-10-03 17:05:00 +09:00

60dc2c8876

Expand group that current selection resides in when moving mouse to left side of song select

Closes https://github.com/ppy/osu/issues/33557.

Bartłomiej Dach · 2025-10-03 09:27:05 +02:00

87128453d6

Add failing test scene

Bartłomiej Dach · 2025-10-03 09:24:37 +02:00

ae4e015352

Attempt to scroll carousel to nearest expanded panel when the current selection is filtered out

Addresses https://github.com/ppy/osu/issues/33443, maybe.

I considered adding tests but they'd likely be janky and take a long
time to write, so decided against until there's a demand for it.

Bartłomiej Dach · 2025-10-02 14:28:39 +02:00

007de10e2b

Fix selection being changed on re-entering song select when a converted beatmap is selected

Closes https://github.com/ppy/osu/issues/34062.

The root cause of the issue is that `OnEntering()` calls
`onArrivingAtScreen()`, which calls `ensureGlobalBeatmapValid()`, which
would call `checkBeatmapValidForSelection()` with a `FilterCriteria`
instance retrieved from the `FilterControl`.

The problem with that is at the time that this call chain is happening,
`FilterControl` is not yet loaded, which means in particular that it has
not bound itself to the config bindable, as that happens on
`LoadComplete()`:

	https://github.com/ppy/osu/blob/bff07010d1f9874125baf2918f02c5cf61a5ea60/osu.Game/Screens/SelectV2/FilterControl.cs#L198

To resolve this, retrieve the bindable in `SongSelect` itself, which
ensures it is valid for reading at the time the above call chain
happens.

Bartłomiej Dach · 2025-10-02 13:27:43 +02:00

3d5dc60cfe

Add failing test case

Bartłomiej Dach · 2025-10-02 13:24:24 +02:00

e7076b9582

Do not attempt to retrieve score submission tokens for locally-modified beatmaps

Because it is 99% sure that doing so will fail and spam the user with
"this beatmap doesn't match the online version" notifications, and
because the map status is "locally modified", they should be pretty
aware of that already. This fixes the primary mode of the failure that
https://github.com/ppy/osu/pull/35173 was attempting to hack around.

This will have regressed somewhere around the time that BSS went live,
because at that point the editor stopped resetting online IDs for
beatmaps that got locally modified, making the `beatmapId <= 0` guards
no longer prevent attempts of submission.

Bartłomiej Dach · 2025-10-02 09:16:17 +02:00

2a85f7b7c8

Add failing test coverage for no score submission attempt on known locally modified beatmap

Bartłomiej Dach · 2025-10-02 09:16:17 +02:00

44a1a5ffc7

Do not overwrite "locally modified" beatmap set status when performing online lookups in song select

A relatively recent regression. It's maybe not a huge one, in that it
probably doesn't matter all that much, but it is somewhat important to
keep the "locally modified" status of the set for as long as possible.

One reason for that is that keeping the "locally modified" status will
pull up a dialog when the user attempts to update the beatmap, warning
them that they will lose their local changes - this dialog will not show
if the online lookup flow is allowed to overwrite the map status with
something else.

Bartłomiej Dach · 2025-10-02 09:16:15 +02:00

365cdfd40e

Fix clicking the osu! logo when in the multiplayer submenu opening solo play instead (#35175 )

Bartłomiej Dach · 2025-10-02 16:03:46 +09:00

aad321a0b8

Merge pull request #35154 from smoogipoo/matchmaking-events

Add structure and support for jumping in quick play rooms

Dean Herbert · 2025-10-02 13:57:00 +09:00

2025.1002.0 37a11b5592

Merge pull request #35169 from bdach/song-select-enter-on-filtered-out-carousel-should-start-map

Fix pressing Enter not starting current global beatmap if carousel is fully filtered out

Dean Herbert · 2025-10-01 23:44:01 +09:00

565a2866ea

Merge pull request #35167 from bdach/carousel-panels-consistent-update-button

Use consistent ordering of update button on carousel beatmap panels

Dean Herbert · 2025-10-01 21:59:03 +09:00

c9a6a4887c

Fix pressing Enter not starting current global beatmap if carousel is fully filtered out

Closes https://github.com/ppy/osu/issues/34693.

Bartłomiej Dach · 2025-10-01 14:31:48 +02:00

9b78187d29

Add failing test case

Bartłomiej Dach · 2025-10-01 14:17:16 +02:00

0230a27de6

Use consistent ordering of update button on carousel beatmap panels

Closes https://github.com/ppy/osu/issues/34810.

The reason why I touched it in this direction and not the other is only
because the standalone panel positioning of the button was touched last
in 92ed964627, thus I changed the set
panel to match that.

Bartłomiej Dach · 2025-10-01 13:49:54 +02:00

ccf3151172

Merge pull request #35126 from Joehuu/song-select-silver-terminology

Use silver S/SS terminology when grouping by rank/grade in song select

Bartłomiej Dach · 2025-10-01 13:30:50 +02:00

b980183e98

Refactor spritesheet-based icons to be single-file based (#34976 )

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
Co-authored-by: Dean Herbert <pe@ppy.sh>

Jinkku · 2025-10-01 13:30:06 +02:00

b7d36cffd4

75400 Commits