Bartłomiej Dach
12b7d9e06d
Simplify custom filter criteria retrieval
2021-03-06 12:16:01 +01:00
Bartłomiej Dach
f00089846b
Merge branch 'master' into ruleset-filter-v3
2021-03-06 12:14:53 +01:00
Dean Herbert
b241749119
Merge pull request #11928 from smoogipoo/fix-test-multiplayer-beatmap
2021-03-04 23:43:55 +09:00
Salman Ahmed
132fcda089
Force config sensitivity value to local setting bindable
...
Re-enable the local bindable to update the sensitivity value then change back to whatever state it was in previously.
2021-03-04 17:00:44 +03:00
Salman Ahmed
fe64c3dbd4
Refrain from disabling cursor sensitivity at config-level
2021-03-04 17:00:44 +03:00
Dan Balasescu
5b6018295d
Merge branch 'master' into diffcalc/skill-mods
2021-03-04 13:06:26 +09:00
Bartłomiej Dach
f733d1ec1f
Expose and document query parser and helpers
2021-03-03 22:03:01 +01:00
Bartłomiej Dach
f9148eec20
Refactor filter query parsing helper methods
...
In preparation for exposition as public.
2021-03-03 21:34:14 +01:00
Dan Balasescu
6d4391de15
Merge pull request #11957 from peppy/move-mouse-settings-load-complete
...
Move bindable logic in MouseSettings to LoadComplete
2021-03-03 22:43:24 +09:00
Dean Herbert
534e16237a
Remove unnecessary intial construction of bindable
2021-03-03 20:36:41 +09:00
Dean Herbert
23a46819dc
Merge branch 'master' into multiplayer-confirm-on-exit
2021-03-03 20:35:31 +09:00
Dean Herbert
0f5bce70ad
Split confirmation dialog classes apart
2021-03-03 20:34:37 +09:00
Dan Balasescu
a25b21b98f
Merge pull request #11955 from peppy/fix-multiplayer-beatmap-selection-exiting-game
...
Fix selecting a beatmap at the multiplayer match screen exiting the match
2021-03-03 19:40:28 +09:00
smoogipoo
6affe33fb2
Fix another test scene
2021-03-03 19:40:19 +09:00
smoogipoo
012b48dbe5
Remove explicit public definition
...
Interface members are public by default.
2021-03-03 19:03:45 +09:00
Dean Herbert
002646370c
Move bindable logic in MouseSettings to LoadComplete
2021-03-03 16:47:42 +09:00
Dean Herbert
0ede28da2f
Fix test failures due to missing dependency
2021-03-03 15:24:55 +09:00
Dean Herbert
cb4c3503a0
Confirm exiting a multiplayer match
2021-03-03 14:54:18 +09:00
Dean Herbert
d332fd2414
Handle case where local user tries to change beatmap while not the host
2021-03-03 14:53:47 +09:00
Dean Herbert
7dce9b04fa
Add a more basic ConfirmDialog implementation
2021-03-03 14:50:45 +09:00
Dean Herbert
7c59040082
Re-present even when already the current beatmap
...
This feels better and closer to what a user would expect.
2021-03-03 14:17:07 +09:00
Dean Herbert
fcea900a53
Move main menu (song select) presentation logic to a local implementation
...
Reduces cross-dependencies between OsuGame and MainMenu.
2021-03-03 14:13:51 +09:00
Dean Herbert
36e1fb6da8
Add flow to allow MatchSubScreen to handle beatmap presentation locally
2021-03-03 14:13:51 +09:00
Dean Herbert
6e75ebbb06
Add interface to handle local beatmap presentation logic
2021-03-03 14:13:48 +09:00
Bartłomiej Dach
42c3309d49
Use ruleset criteria in parsing and filtering
2021-03-02 20:11:21 +01:00
Bartłomiej Dach
c375be6b07
Instantiate ruleset criteria
2021-03-02 20:10:03 +01:00
Bartłomiej Dach
14e249a134
Add ruleset interface for extending filter criteria
2021-03-02 20:07:11 +01:00
Bartłomiej Dach
e46543a4a9
Constrain operator parsing better
2021-03-02 19:56:36 +01:00
Bartłomiej Dach
26736d990f
Enable filter parsing extensibility
2021-03-02 19:42:47 +01:00
Bartłomiej Dach
3b125a26a8
Add test coverage
2021-03-02 19:21:03 +01:00
Bartłomiej Dach
40a28367c6
Fix restore-to-default buttons never showing if initially hidden
2021-03-02 18:50:33 +01:00
Dan Balasescu
dc7573f7c7
Merge pull request #11943 from peppy/remove-simple-finalizers
...
Remove easy to remove finalizers
2021-03-02 20:53:09 +09:00
Dan Balasescu
2aae9b6600
Merge branch 'master' into remove-working-beatmap-finalizer
2021-03-02 19:14:16 +09:00
Dan Balasescu
20825b4b78
Merge pull request #11945 from peppy/fix-confine-setting-disable-mode
...
Fix confine mode dropdown becoming visible again after filtering
2021-03-02 19:06:49 +09:00
smoogipoo
30ff0b83c1
Fix test failures due to unpopulated room
2021-03-02 19:06:21 +09:00
Dean Herbert
0300a55447
Update framework
2021-03-02 18:00:50 +09:00
Dean Herbert
6372a0265a
Fix confine mode dropdown becoming visible again after filtering
...
Changes from a hidden to a disabled state, with a tooltip explaining
why.
Closes #11851 .
2021-03-02 17:44:58 +09:00
Dean Herbert
103dd4a6ce
Remove WorkingBeatmap's finalizer
2021-03-02 16:14:43 +09:00
Dean Herbert
c4ba045df1
Add note about finalizers required for audio store clean-up
2021-03-02 16:07:51 +09:00
Dean Herbert
fa95929121
Remove easy to remove finalizers
2021-03-02 16:07:09 +09:00
dependabot-preview[bot]
7829a0636e
Bump Sentry from 3.0.1 to 3.0.7
...
Bumps [Sentry](https://github.com/getsentry/sentry-dotnet ) from 3.0.1 to 3.0.7.
- [Release notes](https://github.com/getsentry/sentry-dotnet/releases )
- [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.0.1...3.0.7 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-02 00:43:47 +00:00
Dean Herbert
22da76c510
Merge pull request #11937 from ppy/dependabot/nuget/SharpCompress-0.28.1
...
Bump SharpCompress from 0.27.1 to 0.28.1
2021-03-02 09:42:53 +09:00
Salman Ahmed
2609b22d53
Replace usage of CurrentModeRank in line with API change
2021-03-01 23:07:25 +03:00
dependabot-preview[bot]
9db37e62d8
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.2 to 5.0.3.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.2...v5.0.3 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-01 20:05:53 +00:00
dependabot-preview[bot]
2d3c3c18d4
Bump SharpCompress from 0.27.1 to 0.28.1
...
Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress ) from 0.27.1 to 0.28.1.
- [Release notes](https://github.com/adamhathcock/sharpcompress/releases )
- [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.27.1...0.28.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-03-01 20:05:35 +00:00
Salman Ahmed
fe54a51b5a
Remove UserRanks object and move to outer country_rank property
2021-03-01 22:42:20 +03:00
smoogipoo
7adb33f40e
Fix beatmap getting nulled due to failing web request
2021-03-01 17:24:54 +09:00
smoogipoo
f7e4cfa4d0
Fix initial room settings not being returned correctly
2021-03-01 17:24:32 +09:00
smoogipoo
97bb217830
Fix test room playlist items not getting ids
2021-03-01 17:24:05 +09:00
Dean Herbert
3bb46cd8cc
Merge pull request #11916 from bdach/restore-default-transform-mutation
...
Fix restore default button potentially mutating transforms during load
2021-02-28 12:40:17 +09:00
Bartłomiej Dach
7e17c5ab71
Trim yet another array copy
2021-02-27 15:46:18 +01:00
Bartłomiej Dach
1e56d2cbba
Make SettingSourceAttribute implement IComparable
2021-02-27 15:30:08 +01:00
Bartłomiej Dach
528de5869e
Fix multiple enumerations when ordering setting sources
...
This was not spotted previously, because the base `Attribute` overrides
`Equals()` to have semantics similar to structs (per-field equality) by
using reflection. That masked the issue when strings were used, and
migrating to `LocalisableString` revealed it, as that struct's
implementation of equality currently uses instance checks.
Whether `LocalisableString.Equals()` is the correct implementation may
still be up for discussion, but allowing multiple enumeration is wrong
anyway, since the underlying enumerables are live (one especially is a
yield iterator, causing new object instances to be allocated).
2021-02-27 14:58:01 +01:00
Bartłomiej Dach
52e81385a6
Fix restore default button mutating transforms during load
2021-02-27 11:39:18 +01:00
Dean Herbert
4fd8501c86
Remove unnecessary using (underlying enumerator change)
2021-02-26 20:03:03 +09:00
Dean Herbert
98d525d1db
Update framework
2021-02-26 19:56:10 +09:00
Dan Balasescu
b1702273c8
Merge pull request #11904 from peppy/editor-centralise-selection-change-handling
...
Centralise cases of performing actions on the current selection
2021-02-26 19:01:30 +09:00
Dan Balasescu
e80db89def
Merge pull request #11903 from peppy/fix-chat-post-error-display
...
Show API human readable error message when chat posting fails
2021-02-26 19:00:17 +09:00
Dan Balasescu
d7f3519bd7
Merge pull request #11907 from peppy/fix-import-from-stable-no-beatmaps-message
...
Fix "failed to import" message showing when importing from a stable install with no beatmaps
2021-02-26 18:45:54 +09:00
Dean Herbert
7e6bd0e995
Fix "failed to import" message showing when importing from a stable install with no beatmaps
2021-02-26 17:30:59 +09:00
Dean Herbert
3e65dfb9e7
Reduce allocation overhead when notification overlay has visible notifications
2021-02-26 17:11:47 +09:00
Dean Herbert
cd1c1bf534
Centralise cases of performing actions on the current selection
...
By moving this to a central location, we can avoid invoking the
EditorChangeHandler when there is no selection made. This helps
alleviate the issue pointed out in
https://github.com/ppy/osu/issues/11901 , but not fix it completely.
2021-02-26 14:15:13 +09:00
Dean Herbert
254f9bb58b
Show API human readable error message when chat posting fails
...
Closes #11902 .
2021-02-26 13:38:00 +09:00
Bartłomiej Dach
d0decc73be
Merge branch 'master' into beatmap-difficulty-cache-nullable
2021-02-25 19:40:38 +01:00
Dean Herbert
a792c3f13c
Merge pull request #11900 from peppy/update-bpm-with-mods
...
Update the displayed BPM at song select with rate adjust mods
2021-02-26 00:25:55 +09:00
smoogipoo
01a4815412
Make labels disappear on null beatmap/no hitobjects
2021-02-25 23:36:02 +09:00
Dan Balasescu
46ea0f44eb
Merge branch 'master' into beatmap-difficulty-cache-nullable
2021-02-25 22:52:15 +09:00
Dan Balasescu
8e12dd98f9
Merge pull request #11897 from peppy/fix-song-select-star-rating-display-zero-flashing
...
Fix the star rating display at song select flashing to zero when changing mods
2021-02-25 22:51:35 +09:00
smoogipoo
c1f27ba938
Merge branch 'master' into fix-song-select-star-rating-display-zero-flashing
2021-02-25 22:13:48 +09:00
smoogipoo
c3eb44137b
Move ValueChanged bind back to load()
2021-02-25 22:09:41 +09:00
smoogipoo
649ce20e35
Fix up super weird and super wrong DI
2021-02-25 22:01:53 +09:00
smoogipoo
b090a82b35
Merge branch 'master' into update-bpm-with-mods
2021-02-25 21:58:54 +09:00
smoogipoo
de417a660d
Make BPM update with changes in mod settings
2021-02-25 21:51:32 +09:00
smoogipoo
98313a98bf
DI mods in parent class and pass them down
2021-02-25 21:48:02 +09:00
Dean Herbert
8004652d27
Merge branch 'master' into optimised-has-flag-checks
2021-02-25 21:24:39 +09:00
Dean Herbert
3802cb29a4
Fix failing tests doing reference comparisons between string and LocalisedString
2021-02-25 17:49:54 +09:00
Dean Herbert
6d1c5979ea
Update framework
2021-02-25 17:28:59 +09:00
Dean Herbert
90e8308716
Merge branch 'master' into localisation-refactor-framework
2021-02-25 17:28:55 +09:00
Dean Herbert
2db4b793d7
Also handle most common BPM display
2021-02-25 17:05:00 +09:00
Dean Herbert
31c52bd585
Update the displayed BPM at song select with rate adjust mods
...
This only covers constant rate rate adjust mods. Mods like wind up/wind
down will need a more complex implementation which we haven't really
planned yet.
2021-02-25 17:00:44 +09:00
Dean Herbert
5fa9bf61b6
Update xmldoc
2021-02-25 16:22:40 +09:00
Dean Herbert
03771ce8ec
Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability
2021-02-25 16:19:01 +09:00
Dean Herbert
9f3ceb99eb
Fix the star rating display at song select flashing to zero when changing mods
...
Due to the use of bindable flow provided by `BeatmapDifficultyCache` in
this usage, the display would briefly flash to zero while difficulty
calculation was still running (as there is no way for a consumer of the
provided bindable to know whether the returned 0 is an actual 0 SR or a
"pending" calculation).
While I hope to fix this by making the bindable flow return nullable
values, I think this particular use case works better with non-bindable
flow so have switched across to that.
2021-02-25 16:05:13 +09:00
smoogipoo
dff1d80f39
Update HasFlag usages to HasFlagFast
2021-02-25 15:38:56 +09:00
Dean Herbert
2c8e62ae35
Fix toolbar not completing enough of layout to propagate hotkeys to buttons before initial display
2021-02-25 14:52:51 +09:00
Dean Herbert
e82eaffaed
Flip order back to original for romanisable strings
2021-02-25 14:14:07 +09:00
Dean Herbert
4cdde42228
Remove unnecessary backing field
2021-02-25 14:08:01 +09:00
Dean Herbert
a362382d38
Add back more correct null checks
2021-02-25 14:06:21 +09:00
Dean Herbert
67773c42ef
Merge pull request #11888 from H2n9/modtimeramp-new-behaviour
2021-02-25 14:01:57 +09:00
Bartłomiej Dach
421b7877d4
Avoid mixing precision across time ramp bindables
...
Bears no functional difference, it's just a bit less of an eyesore.
2021-02-24 19:16:10 +01:00
Ronnie Moir
73d6a3687e
Change rate correction logic to be more explicit
2021-02-24 14:40:56 +00:00
Dan Balasescu
3e2b21a9b4
Merge pull request #11892 from peppy/allow-collection-name-collisions
...
Fix crash on two collections existing with the same name
2021-02-24 23:08:05 +09:00
Dan Balasescu
a7d10630e0
Merge pull request #11893 from peppy/fix-request-queue-reference-holding
...
Fix requests being indefinitely queued when user is offline
2021-02-24 23:07:02 +09:00
Dean Herbert
fa6d797adf
Remove redundant prefix
2021-02-24 20:30:17 +09:00
Dean Herbert
9ed8d902f7
Fix requests being indefinitely queued when user is offline
2021-02-24 19:57:42 +09:00
Dean Herbert
5dc0aefb2b
Cancel request on leaving results screen
2021-02-24 19:54:52 +09:00
Dean Herbert
0c202e0777
Merge branch 'master' into fix-selecting-incompatible-freemods
2021-02-24 19:24:04 +09:00
Dean Herbert
165da32044
Fix dropdown crash on collection name collisions
2021-02-24 18:41:42 +09:00
Dan Balasescu
c0f21c8cbe
Merge branch 'master' into fix-selecting-incompatible-freemods
2021-02-24 15:10:48 +09:00
smoogipoo
0b44d2483b
Make some properties virtual
...
I think they were intended to be this way from the beginning.
2021-02-24 15:03:41 +09:00
