38668 Commits

This Branch

This Branch

All Branches

• Move path type correction

  This is better because `PathControlPointVisualizer` is local to the editor, meaning there is no chance that this could affect gameplay.

  Naxess · 2021-03-24 03:02:19 +01:00
  4ae3eaaac6
• Simplify path type maintenance when dragging
  Naxess · 2021-03-24 02:57:47 +01:00
  0bcd38e661
• Update PointsInSegment when adding/removing points

  There was a bug where if you created a slider, moved the last point, and then added a point such that it became a PerfectCurve, it would fail to recover after becoming a Bezier.
  
  This fixes that.

  Naxess · 2021-03-24 02:56:32 +01:00
  5ee280f941
• Merge branch 'master' into default-fullscreen
  Owen Young · 2021-03-23 19:44:22 -05:00
  c8542d2434
• Changed comment on GetFrameworkConfigDefaults() to be more accurate
  Owen Young · 2021-03-23 19:37:55 -05:00
  437dadc85f
• Fixed formatting issues to be in line with osu coding standards
  Owen Young · 2021-03-23 19:31:16 -05:00
  67a03ebc23
• Added a comment to new method
  Owen Young · 2021-03-23 19:18:32 -05:00
  fbb992fc7e
• Disable relative mode for TournamentGame
  Shivam · 2021-03-23 23:22:17 +01:00
  d17c431faf
• Merge branch 'master' into solo-score-submission
  Dean Herbert · 2021-03-23 21:12:52 +09:00
  217f6083ca
• Merge pull request #12151 from peppy/fail-dummy-api-requests

  Fail all API requests sent to DummyAPIAccess

  Dan Balasescu · 2021-03-23 20:54:04 +09:00
  2021.323.0 bb6e50eb27
• Merge branch 'master' into fail-dummy-api-requests
  Dan Balasescu · 2021-03-23 20:14:56 +09:00
  578128f803
• Merge pull request #12154 from peppy/fix-hitcircle-glow-fade-out

  Fix default skin's glow resetting fade on miss

  Dan Balasescu · 2021-03-23 20:14:51 +09:00
  ade542191a
• Merge pull request #12153 from peppy/fix-appproach-circle-fade-out

  Always fade out approach circles at a HitObject's start time to better match stable

  Dan Balasescu · 2021-03-23 20:04:38 +09:00
  5f956971cc
• Fix default skin's glow resetting fade on miss
  Dean Herbert · 2021-03-23 19:28:08 +09:00
  d10ff615fe
• Always fade out approach circles at a HitObject's start time to better match stable
  Dean Herbert · 2021-03-23 19:19:07 +09:00
  64e85ba995
• Implement SoloPlayer's request construction
  Dean Herbert · 2021-03-23 18:23:25 +09:00
  e649a330a4
• Add flow for allowing gameplay to continue even when an error occurs with token retrieval
  Dean Herbert · 2021-03-23 18:23:25 +09:00
  242b847516
• Move token request construction to LoadAsyncComplete to better allow DI usage
  Dean Herbert · 2021-03-23 18:20:55 +09:00
  3cd8bf2d7f
• Remove all references to "score submission" from Player
  Dean Herbert · 2021-03-23 18:20:55 +09:00
  571124669d
• Update SoloPlayer to derive SubmittingPlayer
  Dean Herbert · 2021-03-23 18:20:55 +09:00
  194b2d05d3
• Further split out a player class which submits to "rooms"
  Dean Herbert · 2021-03-23 18:20:55 +09:00
  12f050264a
• Move score submission logic in general out to its own Player type
  Dean Herbert · 2021-03-23 18:20:55 +09:00
  7045fce555
• Make Player abstract and introduce SoloPlayer
  Dean Herbert · 2021-03-23 18:18:49 +09:00
  6cb14e91c9
• Add submission requests
  Dean Herbert · 2021-03-23 18:18:49 +09:00
  5267fb74c4
• Add return bool to HandleRequest to better trigger failures
  Dean Herbert · 2021-03-23 18:17:29 +09:00
  aeff9bd853
• Avoid firing any kind of failures after success
  Dean Herbert · 2021-03-23 17:50:31 +09:00
  ce452565f4
• Merge pull request #12139 from peppy/fix-editor-spinner-looping-too-long

  Fix spinners playing looping sound too long in the editor

  Dan Balasescu · 2021-03-23 17:44:07 +09:00
  9e38d580ca
• Fail all API requests sent to DummyAPIAccess

  Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.
  
  Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.

  Dean Herbert · 2021-03-23 17:37:45 +09:00
  f5ba746ae5
• Merge pull request #12141 from smoogipoo/perfect-curve-failure-testcase
  Dean Herbert · 2021-03-23 17:23:00 +09:00
  3594c42b79
• Merge branch 'master' into fix-editor-spinner-looping-too-long
  Dan Balasescu · 2021-03-23 16:45:41 +09:00
  3ec3624ac5
• Merge branch 'master' into perfect-curve-failure-testcase
  Dan Balasescu · 2021-03-23 16:44:58 +09:00
  f6ed3c1b1e
• Merge pull request #12136 from peppy/remove-skin-sample-workarounds

  Remove local workarounds to attempt to avoid crashes on skin change

  Dan Balasescu · 2021-03-23 16:44:29 +09:00
  17a28f4f65
• Update difficulty calculator tests with floating point differences
  Dean Herbert · 2021-03-23 15:38:01 +09:00
  08fcdc8ee4
• Merge pull request #12149 from peppy/fix-score-token-data-type

  Fix APIScoreToken's data type not matching server side

  Dan Balasescu · 2021-03-23 14:54:02 +09:00
  d758343a45
• Update framework
  Dean Herbert · 2021-03-23 14:51:22 +09:00
  1171214541
• Merge branch 'master' into remove-skin-sample-workarounds
  Dean Herbert · 2021-03-23 14:51:14 +09:00
  a5842a5485
• Merge pull request #12145 from bdach/mania-auto-hold-note-release

  Remove release delay for hold notes when generating autoplay

  Dan Balasescu · 2021-03-23 14:24:56 +09:00
  5f2c6b8d59
• removed line (?) - tried doing testing to see if it launched in fullscreen (i.e., overriding the method ppy mentioned), but to no avail :(
  Owen Young · 2021-03-23 00:24:33 -05:00
  254b0f5dc3
• Fix second usage
  Dean Herbert · 2021-03-23 14:08:00 +09:00
  9c690f9545
• Fix APIScoreToken's data type not matching server side
  Dean Herbert · 2021-03-23 14:04:47 +09:00
  58c60100b4
• implemented GetFrameworkConfigDefaults for overriding framework default, removed previous code that added a new OsuSetting and modified settings layout.
  Owen Young · 2021-03-22 23:36:55 -05:00
  d9e2c44a34
• removed code from OsuGameBase for fullscreen.....OsuSetting still exists but cannot figure out a way to set it to a default and have it actually work
  Owen Young · 2021-03-22 22:52:16 -05:00
  9f788f5854
• Merge pull request #12148 from Joehuu/fix-deleted-comments-trash-icon

  Fix incorrect trash icon being used on deleted comments counter

  Dean Herbert · 2021-03-23 11:53:14 +09:00
  c89199b38b
• Fix incorrect trash icon being used on deleted comments counter
  Joehu · 2021-03-22 19:32:17 -07:00
  16b3f22caf
• Remove unnecessary null checks and debug code
  Dean Herbert · 2021-03-23 10:38:37 +09:00
  098005393e
• Merge pull request #12144 from bdach/remove-osutk-run-config

  Remove osuTK desktop rider run config

  Dean Herbert · 2021-03-23 10:19:47 +09:00
  d612964ac8
• added code to OsuGameBase to default to fullscreen, but that might not be a good place to put it.
  Owen Young · 2021-03-22 20:17:05 -05:00
  bdcb9451f7
• moved windowmode code to LoadComplete (?)
  Owen Young · 2021-03-22 19:48:52 -05:00
  8ea7271d5c
• Remove release delay for hold notes when generating autoplay

  It was more intended for normal notes anyway (as they would be released
  pretty much instantaneously, if it weren't for the delay).

  Bartłomiej Dach · 2021-03-22 22:45:21 +01:00
  29d4162e4e
• Adjust autoplay generation tests to match expected behaviour
  Bartłomiej Dach · 2021-03-22 22:45:21 +01:00
  d85929d721