65439 Commits

This Branch

This Branch

All Branches

• Make AliveDrawableMap public
  Andrei Zavatski · 2024-01-31 07:54:07 +03:00
  3aefc91967
• Merge pull request #26839 from bdach/fix-judgement-fade
  Dean Herbert · 2024-01-31 09:14:05 +09:00
  012039ff90
• Revert "Move fade more local to avoid fading twice"

  This reverts commit d0421fe206
  and fixes https://github.com/ppy/osu/issues/26801.
  
  https://github.com/ppy/osu/pull/26703#discussion_r1469409667
  was correct in saying that the early fade-out needs to be restored, and
  that's because of the early-return. Legacy judgements that are the
  temporary displayed judgement from new piece should also receive the
  fade-out, and d0421fe206 broke that.

  Bartłomiej Dach · 2024-01-30 22:16:46 +01:00
  c5e118bd10
• Add missing icon.png entry to nuspec

  This is only half of the deployment fix, the other half will be in
  `osu-deploy` (making sure the icon is actually in the staging
  directory).

  Bartłomiej Dach · 2024-01-30 12:05:31 +01:00
  2024.130.2 6931af664e
• Merge pull request #26797 from peppy/update-endpoints

  Update endpoints to final production endpoints

  Bartłomiej Dach · 2024-01-30 11:12:25 +01:00
  2024.130.1 26d3409fca
• Update endpoints to final production endpoints
  Dean Herbert · 2024-01-30 18:40:17 +09:00
  d895a91cd5
• Merge pull request #26781 from frenzibyte/taiko-sv-v2

  Rewrite osu!taiko's time range computation logic to match 1:1 with stable

  Bartłomiej Dach · 2024-01-30 09:16:07 +01:00
  2024.130.0 f5e7697335
• Merge pull request #26788 from EVAST9919/scrolling-alloc

  Reduce allocation overhead in `ScrollingHitObjectContainer`

  Dean Herbert · 2024-01-30 14:06:27 +09:00
  99f4b2c113
• Merge pull request #26790 from EVAST9919/mania-columns-alloc

  Reduce allocation overhead in mania's `ColumnFlow`

  Dean Herbert · 2024-01-30 12:51:38 +09:00
  fc8fdb578a
• Don't use LINQ in ReceivePositionalInputAt
  Andrei Zavatski · 2024-01-30 03:19:27 +03:00
  8e20eed4ef
• Rework Content storage in ColumnFlow
  Andrei Zavatski · 2024-01-30 03:07:37 +03:00
  7dba870518
• Reduce overhead in ScrollingHitObjectContainer
  Andrei Zavatski · 2024-01-30 00:59:31 +03:00
  87f853fcd2
• Merge pull request #26785 from bdach/make-populate-maximum-statistics-public
  Dean Herbert · 2024-01-30 06:40:35 +09:00
  58bcef934b
• Make LegacyScoreDecoder.PopulateMaximumStatistics() public

  For `osu-tools` consumption.

  Bartłomiej Dach · 2024-01-29 21:42:38 +01:00
  6888cda02c
• Merge pull request #26780 from bdach/fix-websocket-very-bad-not-good

  Fix incorrect handling of `StartChatRequest` in websocket chat client

  Dean Herbert · 2024-01-30 05:11:55 +09:00
  b3919bff56
• Merge pull request #26773 from peppy/fix-song-select-osu-logo-position

  Fix osu! logo being mispositioned in song select on very wide resolutions

  Bartłomiej Dach · 2024-01-29 20:39:44 +01:00
  39883cc102
• Merge branch 'master' into fix-song-select-osu-logo-position
  Bartłomiej Dach · 2024-01-29 20:11:52 +01:00
  1fbc92ca7e
• Apply alternative solution

  Fixes the logo flying out of the wrong corner when transitioning from
  song select to gameplay.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-01-29 20:07:27 +01:00
  acc2614090
• Rewrite time range computation logic to be completely based on stable code
  Salman Ahmed · 2024-01-29 21:26:36 +03:00
  959cc7c7d9
• Fix incorrect handling of StartChatRequest in websocket chat client

  Fixes this happening on staging:
  
  	[network] 2024-01-29 17:48:24 [verbose]: WebSocketNotificationsClientConnector connected!
  	[network] 2024-01-29 17:48:24 [verbose]: WebSocketNotificationsClientConnector connect attempt failed: Can't use WaitSafely from inside an async operation.
  
  I'm not sure how I ever allowed that `.WaitSafely()` to be there. It
  did feel rather dangerous but then I must have forgotten and never
  noticed it failing. Which is weird because you'd think that would be
  caught by testing that chat isn't working but I'm pretty sure that I
  tested that chat *was* indeed working.
  
  Anyway now that entire flow is replaced by something that should
  hopefully be somewhat more sane? It has a whole retry flow with logging
  now which should be more robust than what was there previously (failing
  to start to listen to chat events killing the entire websocket
  connection for very little good reason).

  Bartłomiej Dach · 2024-01-29 19:22:40 +01:00
  996ae0ecc1
• Update framework
  Dean Herbert · 2024-01-30 01:06:32 +09:00
  16c06169ed
• Merge pull request #26703 from peppy/smaller-slider-misses

  Adjust slider tick / end defaults again

  Bartłomiej Dach · 2024-01-29 13:51:07 +01:00
  2667cb8b36
• Fix osu! logo being mispositioned in song select on very wide resolutions
  Dean Herbert · 2024-01-29 20:45:51 +09:00
  f2546d72c2
• Merge pull request #26616 from peppy/dont-round-sv
  Dean Herbert · 2024-01-29 20:42:38 +09:00
  811b31386b
• Merge pull request #26698 from EVAST9919/slider-sample-alloc

  Reduce sliding sample allocations in `DrawableSlider`

  Dean Herbert · 2024-01-29 20:37:32 +09:00
  a3199333bb
• Also fix spinner case
  Dean Herbert · 2024-01-29 20:36:59 +09:00
  034f8c0388
• Merge pull request #26772 from peppy/update-framework

  Update framework

  Dean Herbert · 2024-01-29 20:15:01 +09:00
  f1c1d9cb14
• Merge branch 'master' into dont-round-sv
  Bartłomiej Dach · 2024-01-29 11:52:46 +01:00
  11ec8a1cad
• Apply local precision workaround to editor effect section
  Bartłomiej Dach · 2024-01-29 11:52:38 +01:00
  8a11ff1227
• Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score

  Fix score processor no longer applying results when failing in multiplayer match

  Dean Herbert · 2024-01-29 19:51:31 +09:00
  a1fe5eedd5
• Update framework
  Dean Herbert · 2024-01-29 19:45:56 +09:00
  1efdf2ae25
• Revert "Remove dead code" (mostly)

  This reverts commit 6070eac6ee.

  Dean Herbert · 2024-01-29 19:43:40 +09:00
  8341da7586
• Update resources
  Dean Herbert · 2024-01-29 19:33:13 +09:00
  dc28a6b873
• Merge pull request #25480 from peppy/2fa

  Add two factor authentication flow

  Dean Herbert · 2024-01-29 19:14:55 +09:00
  cbbe2f9dc0
• Add loading layer when requesting a code reissue
  Dean Herbert · 2024-01-29 17:54:34 +09:00
  540ff0da5b
• Merge pull request #26770 from peppy/fucking-hitobject-references

  Fix `OsuPlayfield` being retained indefinitely after gameplay

  Bartłomiej Dach · 2024-01-29 09:40:56 +01:00
  4c5dacd559
• Use switch instead of if-else
  Dean Herbert · 2024-01-29 17:18:17 +09:00
  6a469f2cb6
• Fix APIAccess spamming requests while waiting for second factor
  Bartłomiej Dach · 2024-01-29 09:14:30 +01:00
  96811a8874
• Remove no longer relevant changes
  Bartłomiej Dach · 2024-01-29 09:05:03 +01:00
  363fd1d54f
• Merge branch 'master' into 2fa
  Dean Herbert · 2024-01-29 16:57:29 +09:00
  4a2602a775
• Merge pull request #26724 from bdach/decouple-notification-websocket-from-chat

  Decouple notifications websocket handling from chat operations

  Dean Herbert · 2024-01-29 16:57:13 +09:00
  48fc0545c2
• Rename PollingChatClientConnector to better describe usage
  Dean Herbert · 2024-01-29 16:56:28 +09:00
  ef94eff574
• Fix more nullable inspections
  Bartłomiej Dach · 2024-01-29 08:44:27 +01:00
  a41ba7c381
• Mark ResultsScreen.Score as nullable

  Is nullable in playlist results at very least.

  Dean Herbert · 2024-01-29 16:43:26 +09:00
  fb24c66342
• Mark some delegates as static because we can
  Dean Herbert · 2024-01-29 16:16:28 +09:00
  760368709a
• Add safety in ResultsScreen.Exit to ensure HitEvents are not holding references

  This is a catch-all safety disconnecting `ScoreInfo` from `HitObject`s.

  Dean Herbert · 2024-01-29 16:16:17 +09:00
  eb90ee5415
• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Clean up DrawableHitObject events on Dispose

  This is just general safeties to avoid cases where
  components don't correctly unbind events.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  de32e7815b
• r# says hi
  Dean Herbert · 2024-01-29 15:28:14 +09:00
  9c55498058
• Merge pull request #26723 from EVAST9919/progress-bar-improvements

  Reduce allocation overhead of song progress bars

  Dean Herbert · 2024-01-29 02:44:16 +09:00
  8922190055