osu-lazer

Move layout specification outside the GradedCircles class

Andrei Zavatski · 2024-02-04 02:58:15 +03:00

397def9ceb

Merge branch 'master' into results-clean

Andrei Zavatski · 2024-02-04 02:41:12 +03:00

7b2adc857a

Merge pull request #26956 from smoogipoo/update-inspectcode

Update inspectcode to 2023.3.3

Bartłomiej Dach · 2024-02-02 16:26:47 +01:00

ef2e2302d4

Fix multiplayer tests

Dan Balasescu · 2024-02-02 22:34:48 +09:00

50f9c61029

Revert unnecessary changes

Dan Balasescu · 2024-02-02 21:05:50 +09:00

20ae88b0a0

Update R# + fix inspections

Dan Balasescu · 2024-02-02 21:00:28 +09:00

b44f77cee1

Merge pull request #26950 from bdach/2fa-in-registration

Add 2FA verification screen to registration flow

Dan Balasescu · 2024-02-02 17:30:20 +09:00

8c107b4925

Merge pull request #26940 from EVAST9919/playfield-mods-alloc

Reduce allocation overhead in `Playfield`

Dan Balasescu · 2024-02-02 15:45:46 +09:00

108375975d

Add test coverage of full account creation flow

Bartłomiej Dach · 2024-02-02 07:25:07 +01:00

091618db1a

Add 2FA verification screen to registration flow

Bartłomiej Dach · 2024-02-02 07:25:04 +01:00

a00cf87925

Enable NRT in AccountCreationOverlay

Bartłomiej Dach · 2024-02-02 07:24:32 +01:00

45f60b035e

Enable NRT in ScreenWarning

Bartłomiej Dach · 2024-02-02 07:24:32 +01:00

93d34e4115

Make game dependency in ScreenEntry optional to unbreak tests

Bartłomiej Dach · 2024-02-02 07:24:32 +01:00

b58ac7950b

Enable NRT in ScreenEntry

Bartłomiej Dach · 2024-02-02 07:24:32 +01:00

bb6387bea0

Merge pull request #26920 from peppy/2fa-visibility

Give better visibility when the game is pending 2FA

Bartłomiej Dach · 2024-02-02 07:10:45 +01:00

5260b8cae0

Also change icon and tooltip text when pending 2FA

Bartłomiej Dach · 2024-02-02 06:40:56 +01:00

2ff46daf5e

Reduce allocation in Playfield

Andrei Zavatski · 2024-02-02 04:53:48 +03:00

53c5483eba

Show login overlay at main menu when 2FA is required

Dean Herbert · 2024-02-01 21:10:53 +09:00

bf3746daa8

Show "failing" icon on user panel when 2FA prompt is present

This gives the user a chance to know it's required.

Dean Herbert · 2024-02-01 21:10:37 +09:00

563f4a26b1

Merge pull request #26889 from peppy/remove-cachebust-online-image

Fix menu banner not updating as often as we want it to

Dean Herbert · 2024-01-31 22:44:39 +09:00

2024.131.0 7cdedfb6ca

Fix menu banner not updating as often as we want it to

Dean Herbert · 2024-01-31 22:44:24 +09:00

4248593289

Merge pull request #26885 from bdach/slider-end-flip-fail

Fix slider end judgements appearing at incorrect locations when mods that flip playfield are active

Dean Herbert · 2024-01-31 22:39:37 +09:00

89a5be13e2

Revert incorrect end position optimisation

Closes https://github.com/ppy/osu/issues/26867.

Reverts 882f490390
and ce643aa68f.

The applied optimisation may have been valid as long as it was
constrained to `Slider`. But it is not, as `SliderTailCircle` stores a
local copy of the object position. And as the commit message of
ce643aa68f states, this could be bypassed
by some pretty hacky delegation from `SliderTailCircle.Position` to the
slider, but it'd also be pretty hacky because it would make flows like
`PositionBindable` break down.

Long-term solution is to probably remove bindables from hitobjects.

Bartłomiej Dach · 2024-01-31 12:45:42 +01:00

dfea2ade6d

Add failing assertions for head/tail positions after flip

Bartłomiej Dach · 2024-01-31 12:40:03 +01:00

a934556bb8

Increase repeat count for better coverage of flip operations

Bartłomiej Dach · 2024-01-31 12:39:48 +01:00

f927cb5928

Merge pull request #26837 from bdach/2fa-not-verifying-via-link

Fix 2FA verification via link not working correctly

Dean Herbert · 2024-01-31 19:15:33 +09:00

56700d672b

Merge pull request #26876 from peppy/slider-miss-last-longer

Adjust slider tick / end misses to show slightly longer

Bartłomiej Dach · 2024-01-31 10:43:58 +01:00

e7cfbd3c56

Merge branch 'master' into 2fa-not-verifying-via-link

Dean Herbert · 2024-01-31 18:32:55 +09:00

19fe3a15f3

Merge pull request #26834 from bdach/2fa-cancel-crash

Fix crash when logging out during 2FA email verification

Dean Herbert · 2024-01-31 18:32:33 +09:00

edab05672b

Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult"

This reverts commit 1acff746ee, reversing
changes made to 696ecda398.

Dean Herbert · 2024-01-31 17:51:38 +09:00

fbc923b47e

Merge pull request #26870 from smoogipoo/adjust-default-minresult

Adjust default min result of SliderTailHit, remove override

Dean Herbert · 2024-01-31 17:49:58 +09:00

1acff746ee

Adjust slider tick / end misses to show slightly longer

Dean Herbert · 2024-01-31 17:41:26 +09:00

ebf637bd3c

Merge pull request #26871 from peppy/show-better-expired-message

Show a better message when score submission fails due to system clock being set wrong

Dean Herbert · 2024-01-31 17:32:18 +09:00

696ecda398

Show a better message when score submission fails due to system clock being set wrong

Dean Herbert · 2024-01-31 16:52:50 +09:00

a7f9f50ce5

Update framework

Dean Herbert · 2024-01-31 16:12:46 +09:00

3f527081bd

Adjust default min result of SliderTailHit, remove override

Dan Balasescu · 2024-01-31 16:12:05 +09:00

9b1bbe5f48

Merge pull request #26839 from bdach/fix-judgement-fade

Dean Herbert · 2024-01-31 09:14:05 +09:00

012039ff90

Revert "Move fade more local to avoid fading twice"

This reverts commit d0421fe206
and fixes https://github.com/ppy/osu/issues/26801.

https://github.com/ppy/osu/pull/26703#discussion_r1469409667
was correct in saying that the early fade-out needs to be restored, and
that's because of the early-return. Legacy judgements that are the
temporary displayed judgement from new piece should also receive the
fade-out, and d0421fe206 broke that.

Bartłomiej Dach · 2024-01-30 22:16:46 +01:00

c5e118bd10

Fix 2FA verification via link not working correctly

Closes https://github.com/ppy/osu/issues/26835.

I must have not re-tested this correctly after all the refactors...

Basically the issue is that the websocket connection would only come
online when the API state changed to full `Online`. In particular
the connector would not attempt to connect when the API state was
`RequiresSecondFactorAuth`, giving the link-based flow no chance to
actually work.

The change in `WebSocketNotificationsClientConnector` is relevant in
that queueing requests does nothing before the API state changes to full
`Online`. It also cleans up things a bit code-wise so... win?

And yes, this means that the _other_ `PersistentEndpointClientConnector`
implementations (i.e. SignalR connectors) will also come online earlier
after this. Based on previous discussions
(https://github.com/ppy/osu/pull/25480#discussion_r1395566545) I think
this is fine, but if it is _not_ fine, then it can be fixed by exposing
a virtual that lets a connector to decide when to come alive, I guess.

Bartłomiej Dach · 2024-01-30 21:49:06 +01:00

4126dcbe28

Fix broken locking in OAuth

Closes https://github.com/ppy/osu/issues/26824... I think?

Can be reproduced via something like

diff --git a/osu.Game/Online/API/OAuth.cs b/osu.Game/Online/API/OAuth.cs
index 485274f349..e6e93ab4c7 100644
--- a/osu.Game/Online/API/OAuth.cs
+++ b/osu.Game/Online/API/OAuth.cs
@@ -151,6 +151,11 @@ internal string RequestAccessToken()
         {
             if (!ensureAccessToken()) return null;

+            for (int i = 0; i < 10000; ++i)
+            {
+                _ = Token.Value.AccessToken;
+            }
+
             return Token.Value.AccessToken;
         }

The cause is `SecondFactorAuthForm` calling `Logout()`, which calls
`OAuth.Clear()`, _while_ the `APIAccess` connect loop is checking if
`authentication.HasValidAccessToken` is true, which happens to
internally check `Token.Value.AccessToken`, which the clearing of
tokens can brutally interrupt.

Bartłomiej Dach · 2024-01-30 21:05:23 +01:00

000ddc14ac

Add missing icon.png entry to nuspec

This is only half of the deployment fix, the other half will be in
`osu-deploy` (making sure the icon is actually in the staging
directory).

Bartłomiej Dach · 2024-01-30 12:05:31 +01:00

2024.130.2 6931af664e

Merge pull request #26797 from peppy/update-endpoints

Update endpoints to final production endpoints

Bartłomiej Dach · 2024-01-30 11:12:25 +01:00

2024.130.1 26d3409fca

Update endpoints to final production endpoints

Dean Herbert · 2024-01-30 18:40:17 +09:00

d895a91cd5

Merge pull request #26781 from frenzibyte/taiko-sv-v2

Rewrite osu!taiko's time range computation logic to match 1:1 with stable

Bartłomiej Dach · 2024-01-30 09:16:07 +01:00

2024.130.0 f5e7697335

Merge pull request #26788 from EVAST9919/scrolling-alloc

Reduce allocation overhead in `ScrollingHitObjectContainer`

Dean Herbert · 2024-01-30 14:06:27 +09:00

99f4b2c113

Merge pull request #26790 from EVAST9919/mania-columns-alloc

Reduce allocation overhead in mania's `ColumnFlow`

Dean Herbert · 2024-01-30 12:51:38 +09:00

fc8fdb578a

Don't use LINQ in ReceivePositionalInputAt

Andrei Zavatski · 2024-01-30 03:19:27 +03:00

8e20eed4ef

Rework Content storage in ColumnFlow

Andrei Zavatski · 2024-01-30 03:07:37 +03:00

7dba870518

Reduce overhead in ScrollingHitObjectContainer

Andrei Zavatski · 2024-01-30 00:59:31 +03:00

87f853fcd2

Merge pull request #26785 from bdach/make-populate-maximum-statistics-public

Dean Herbert · 2024-01-30 06:40:35 +09:00

58bcef934b

65483 Commits