324 Commits

Author	SHA1	Message	Date
Dean Herbert	3ea7588a91	Update continuation usages to use GetCompletedResult	2022-01-06 22:53:07 +09:00
Dean Herbert	73b40e6833	Replace usage of .Result with .WaitSafelyForResult	2022-01-04 11:51:41 +09:00
Dean Herbert	5b3a154431	Fix potential errors thrown during beatmap leaderboard display due to incorrect beatmap reference ... Specifically, the global `BeatmapInfo` is referenced inside the web request's success callback, and used to attempt population via methods which expect non-null beatmap inputs. Closes #16211.	2021-12-22 17:24:48 +09:00
Dean Herbert	1eed2436e6	Clean up unused resolved properties	2021-12-03 18:49:49 +09:00
Dean Herbert	183b95cbc2	Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus ... This variable is used at more than just a set level.	2021-11-24 18:42:49 +09:00
Dean Herbert	2dd721f760	Fix incorrect CancellationToken being used for inner check during leaderboard updates	2021-11-16 17:41:16 +09:00
Dean Herbert	6a098a8634	Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface	2021-11-12 17:46:24 +09:00
Dean Herbert	54f72d68ca	Revert weird event flow in model manager/importers	2021-11-05 19:12:49 +09:00
Dean Herbert	3f030cebf4	Remove local score copying in GetScoresRequest to allow APIScoreInfo.Beatmap to be APIBeatmap	2021-10-29 14:14:25 +09:00
Dean Herbert	853cf6feaa	Rename last remaining BeatmapInfo Beatmap usage	2021-10-04 17:35:53 +09:00
Dean Herbert	ec61c3c5ee	Rename all remaining cases	2021-10-03 00:55:29 +09:00
smoogipoo	88fc53200e	Refactor	2021-09-01 15:41:52 +09:00
smoogipoo	fee94236de	Fix update-thread pauses	2021-08-31 21:36:31 +09:00
smoogipoo	e19d81c88c	Fix potential incorrect ordering	2021-08-30 19:41:44 +09:00
smoogipoo	4ebb11472d	Update Leaderboard to reorder scores based on scoring mode	2021-08-30 19:34:34 +09:00
Lucas A	1f942d15f8	Localise scoreboard	2021-08-16 13:38:57 +02:00
Dean Herbert	83402a70db	Fix potential null ref when no beatmap is selected	2021-06-14 15:06:24 +09:00
Dean Herbert	f8b09b7c81	Avoid refresh if score is not related to current display	2021-06-14 14:28:14 +09:00
Dean Herbert	fc442713bb	Debounce schedule at base class	2021-06-14 14:26:40 +09:00
Dean Herbert	8dd48d48f6	Add support for song select leaderboard to handle newly imported scores	2021-06-14 14:20:23 +09:00
smoogipoo	8cf26979fb	Allow null user score	2020-08-31 20:16:28 +09:00
smoogipoo	ed74c39b55	Move UserTopScoreContainer into base leaderboard	2020-08-31 19:54:22 +09:00
Dean Herbert	052ad79fc6	Convert dangerous events to IBindables	2020-05-19 16:44:22 +09:00
smoogipoo	61c269b17b	Leaderboard should not change the model	2020-01-06 17:32:24 +09:00
smoogipoo	4a7f5f98df	Cleanup methods/events	2020-01-06 17:20:09 +09:00
Willy Tu	27163a5133	Removed unnecessary code for deleting individual local score.	2019-12-18 21:04:10 -08:00
Willy Tu	b67f986058	Fix CodeFactor issues	2019-12-18 19:26:35 -08:00
Willy Tu	531ac16743	Update Scoreboard Refresh Method for deleting individual scores	2019-12-18 19:22:42 -08:00
wltu	4646524bf9	Remove unnecessary library	2019-12-17 13:18:20 -08:00
wltu	8aeef3f59a	Added refresh scoreboard upon deleting local score and formatted the code	2019-12-17 12:56:30 -08:00
Willy Tu	bef9637fdf	Implemented delete local score individually. Currently does not refresh the score screen after the delete is compelete.	2019-12-16 19:25:28 -08:00
Dean Herbert	f0d49d0cdf	Decouple APILegacyScoreInfo from ScoreInfo	2019-12-03 15:31:11 +09:00
Ganendra Afrasya	8da15f6897	Fix all score are highlighted on local scope	2019-11-01 23:19:15 +07:00
Ganendra Afrasya	ce3b34a768	Fix UserTopScoreContainer is also tinted	2019-11-01 23:00:55 +07:00
smoogipoo	94d3bcc612	Fix top score not being selectable	2019-09-19 20:47:33 +09:00
Dean Herbert	36d0695e5c	Add spacing	2019-09-19 15:44:05 +09:00
Dean Herbert	033c68a428	Fade in score, not container	2019-09-19 15:44:00 +09:00
Dean Herbert	2b6c9aeb26	Move top score container to more local namespace	2019-09-19 15:38:40 +09:00
Dean Herbert	098e89cb66	Improve state reset flow	2019-09-19 15:23:33 +09:00
Dean Herbert	4967ffd8e5	Move inside leaderboard	2019-09-19 14:52:31 +09:00
Dean Herbert	2e0a85c2f6	Merge remote-tracking branch 'upstream/master' into songselect-best-user-score	2019-09-19 12:57:30 +09:00
iiSaLMaN	a1c580f27e	Create "none selected" placeholder state	2019-09-05 05:56:21 +03:00
Dean Herbert	75cb0d093b	Use description correctly ... Required for localisation	2019-08-12 16:10:48 +09:00
Andrei Zavatski	94ed03548d	Hide top score at every leaderboard change	2019-07-22 18:34:31 +03:00
Dean Herbert	8c54708582	Merge branch 'master' into songselect-best-user-score	2019-07-22 22:34:11 +09:00
Dean Herbert	e76b3e2b40	User property instead of method	2019-07-21 10:42:40 +09:00
iiSaLMaN	842417cf42	Check if selected scope requires API	2019-07-21 03:07:27 +03:00
Andrei Zavatski	963e025bb8	Make it works and some layout adjustments	2019-07-14 14:03:14 +03:00
Dean Herbert	ebc0e50295	Simplify conditions	2019-07-07 13:21:41 +09:00
Joseph Madamba	7c0e3a50b6	Merge branch 'master' into fix-unranked-map-lb-placeholder	2019-07-06 12:09:28 -07:00
Joehu	1534b75d27	Fix ci errors	2019-07-04 21:39:21 -07:00
Joehu	e8168037f9	Fix unranked beatmap leaderboards showing "no records" placeholder	2019-07-04 21:19:51 -07:00
naoey	1dab363be3	Require supporter for filtering mods on online leaderboards	2019-07-05 08:42:44 +05:30
naoey	98a242cc37	Merge remote-tracking branch 'ppy/master' into leaderboard-mod-filter	2019-07-05 08:38:33 +05:30
Joehu	5f6544eebf	Fix beatmap leaderboards requiring supporter when signed out	2019-07-04 12:05:07 -07:00
naoey	f04adb7192	Apply mods filter to local scores too	2019-07-04 22:38:33 +05:30
naoey	99606a018b	Merge remote-tracking branch 'upstream/master' into leaderboard-mod-filter	2019-07-03 19:35:08 +05:30
naoey	4ba60ed089	Apply currently selected mods to filter leaderboard scores ... Modifies GetScoresRequest to build query string locally instead of using WebRequest.AddParameter since it doesn't support array parameters	2019-07-03 17:04:20 +05:30
naoey	ccae4ce95e	Fix local beatmap leaderboard displaying scores from all game modes	2019-07-03 14:39:11 +05:30
Ferdinand Bachmann	d431ca4efc	BeatmapLeaderboard: use OrderByDescending instead of negation ... (suggested by peppy)	2019-04-07 13:26:35 +02:00
theFerdi265	cb3532e7d4	BeatmapLeaderboard: fix local scores not being sorted	2019-04-06 00:53:02 +02:00
Dean Herbert	f0114d776d	Use interface to access API ... Allows for better testability.	2019-03-13 12:58:18 +09:00
Dean Herbert	798bc1306b	Merge remote-tracking branch 'upstream/master' into m2307-master ... # Conflicts: # osu.Game/Screens/Select/SongSelect.cs	2019-03-01 10:08:35 +09:00
Dean Herbert	42be7857d1	Use expression body for property get/set where possible	2019-02-28 13:58:19 +09:00
smoogipoo	d8c55bc729	Adjust namespaces	2019-02-21 19:05:52 +09:00
Dean Herbert	8617aaa2a7	Update licence header (and remove year)	2019-01-24 17:43:03 +09:00
Microgolf	097062caf7	Addresses requested changes	2019-01-08 17:57:03 +01:00
Matthias Coenraerds	3879348ee4	Implement clear scores on beatmap	2019-01-04 20:23:06 +01:00
Dean Herbert	787e65c3c5	Reduce generic-ness	2018-12-22 15:20:35 +09:00
smoogipoo	e657f13c15	Separate out Leaderboard into BeatmapLeaderboard	2018-12-22 14:44:36 +09:00
smoogipoo	b1c5b43767	Fix post-rebase errors	2018-11-30 18:46:47 +09:00
smoogipoo	10ed09521c	Add leaderboard display for local scores	2018-11-30 18:40:53 +09:00
Dean Herbert	831cd3ed59	ScoreInfo scoreInfo -> ScoreInfo score	2018-11-30 15:18:52 +09:00
smoogipoo	219929eb47	Score -> ScoreInfo	2018-11-28 18:33:01 +09:00
smoogipoo	09b79d736b	Remove unused usings	2018-11-28 16:33:42 +09:00
smoogipoo	5fd6e6ca77	Re-namespacing	2018-11-28 16:12:57 +09:00
Dean Herbert	6cd69b794d	Fix leaderboard accessing drawables in a possibly invalid state	2018-11-22 19:08:46 +09:00
smoogipoo	f27bd3ef3e	OpenTK -> osuTK	2018-11-20 17:14:59 +09:00
ekrctb	68980fc477	Adjust usage of Handle(Non)PositionalInput to follow framework update	2018-10-02 14:45:33 +09:00
ekrctb	99fc04c8af	Change signature to new event handler	2018-10-02 12:02:47 +09:00
smoogipoo	a8f156584b	Update framework with positional/non-positional changes	2018-09-26 14:01:15 +09:00
Dean Herbert	03084aa04b	Revert async changes	2018-08-31 07:07:10 +09:00
smoogipoo	1b279d383f	Use GetAsync on all textures	2018-08-27 17:26:44 +09:00
Dean Herbert	0f37758314	Update framework	2018-07-21 16:21:53 +09:00
Dean Herbert	bbb11a4066	Fix regression in drawable rank first display	2018-07-13 19:53:29 +09:00
smoogipoo	0a67e5a274	Fix some possible null reference exceptions	2018-07-09 17:09:17 +09:00
Dan Balasescu	118366303c	Merge branch 'master' into fix-leaderboard-placeholder	2018-07-02 17:17:40 +09:00
smoogipoo	4070c1a888	Merge remote-tracking branch 'origin/master' into non-null-ruleset ... # Conflicts: # osu.Game/Screens/Select/FilterControl.cs	2018-07-02 15:05:34 +09:00
Dean Herbert	2c597874bf	Fix leaderboard showing placeholder briefly when entering song select	2018-07-01 18:17:02 +09:00
Dean Herbert	06bd3d4815	Use IBindable where possible	2018-06-29 20:28:28 +09:00
Dean Herbert	9fce4eaccf	Merge branch 'master' into di-backed-ruleset	2018-06-29 19:33:12 +09:00
Dean Herbert	a377e87bf6	Add missing licence headers	2018-06-28 17:34:04 +09:00
Dean Herbert	c44a81bdf5	Add word wrap support	2018-06-28 13:04:39 +09:00
Joehu	8518fce4a9	Fix osu!supporter naming	2018-06-27 17:57:55 -07:00
Dean Herbert	4bcc05a7fc	Remove null checks on ruleset ... Add a default ruleset to `OsuTestCase` to cover testing scenarios.	2018-06-26 18:24:34 +09:00
Dean Herbert	4dd12cedad	Fix review issues	2018-06-26 17:01:40 +09:00
Dean Herbert	13480feb4f	Remove error logging ... Already logged to network.log with ample detail.	2018-06-26 16:38:19 +09:00
Dean Herbert	388ca5d572	Move leaderboard update scheduling to a more central method	2018-06-26 16:33:22 +09:00
Dean Herbert	b0a1b25983	Privatise game ruleset and access via DI ... Also decouples the bindable at SongSelect, where it is debounced in line with the carousel being updated.	2018-06-26 16:32:32 +09:00
DrabWeb	a7bab14b30	Add tooltip to ScoreComponentLabel.	2018-06-03 22:26:30 -03:00