Dean Herbert
b432885e5f
Tidy up ordering of SettingsToolboxGroup
2022-05-06 19:39:09 +09:00
Dean Herbert
59add66632
Remove unnecessary autosize workaround (was fixed long ago)
2022-05-06 19:39:00 +09:00
Dean Herbert
949e30c4b4
Remove auto-expansion of individual toolbox groups when parent expanding container expands
2022-05-06 19:36:41 +09:00
Bartłomiej Dach
08fd0ea086
Fix click-to-return container still handling hover when inactive
2022-05-06 12:28:53 +02:00
Dean Herbert
c6bc6be128
Fix toolbox expand being interrupted by gaps between groups
2022-05-06 19:06:40 +09:00
Dean Herbert
daed42513e
Fix outdated test asserts
2022-05-06 18:44:25 +09:00
Bartłomiej Dach
8f217d1e97
Add failing test case for broken hover behaviour
2022-05-06 11:37:50 +02:00
Dean Herbert
69592722f8
Highlight distance snap grid rings that are close to the current time value
2022-05-06 18:30:46 +09:00
Dan Balasescu
09139ef9f4
Merge pull request #18116 from peppy/guest-is-system-user
...
Mark `GuestUser` as system user via `Id` for now
2022-05-06 18:13:03 +09:00
Dean Herbert
118e58888b
Rename incorrectly named variable (radius is not diameter)
2022-05-06 17:51:51 +09:00
Dean Herbert
319867f73c
Mark GuestUser as system user via Id for now
...
Should resolve https://github.com/ppy/osu/issues/18105 .
Checking through usages, it doesn't immediately look like this will
regress any other scenarios.
2022-05-06 17:37:46 +09:00
Dean Herbert
37cbc79283
Fix clamping logic to always clamp to the last displayed tick
2022-05-06 17:09:38 +09:00
Dean Herbert
684fef7f8c
Fix MaxIntervals incorrectly factoring distance spacing multipiler into snap calculation
2022-05-06 17:09:02 +09:00
Dean Herbert
c7e7aa5962
Don't draw distance snap grid on the start time of the next object
2022-05-06 17:05:52 +09:00
Bartłomiej Dach
f5026bbbeb
Bind to button's activation delay directly
2022-05-06 10:04:36 +02:00
Bartłomiej Dach
f39fcee41b
Remove commented-out code
2022-05-06 10:04:00 +02:00
Dean Herbert
246479bf34
Fix snap extent not working correctly on sliders (and providing incorrect time values)
2022-05-06 15:54:37 +09:00
Dean Herbert
32b40bdabf
Rename DistanceBetweenTick to be plural
2022-05-06 15:45:36 +09:00
Dean Herbert
060461a431
Add test coverage of multiplayer gameplay exit flow
2022-05-06 15:22:22 +09:00
Dean Herbert
78959a6e05
Add animation to denote a dangerous player exit
2022-05-06 15:02:22 +09:00
Dean Herbert
1c4aa12585
Rename non-descript Button nested class
2022-05-06 14:45:53 +09:00
Dean Herbert
c38e97c9ec
Add full xmldoc to HoldToConfirmContainer
2022-05-06 14:45:53 +09:00
Dean Herbert
a11771c11b
Better encapsulate exposed bindables of HoldToConfirmContainer
2022-05-06 14:45:53 +09:00
Dean Herbert
be960eb092
Move dangerous hold specification to base class
2022-05-06 14:34:31 +09:00
Dean Herbert
0d8e42b941
Merge branch 'master' into exit-multiplayer-is-dangerous
2022-05-06 14:25:18 +09:00
Dean Herbert
35e307672b
Merge pull request #18110 from jai-x/new-chat-min-max-height
...
Clamp maximum and minimum height the chat overlay can be resized to
2022-05-06 12:43:58 +09:00
Jai Sharma
7ffe3b132f
Use BindableFloat in chat height tests
2022-05-05 23:13:43 +01:00
Jai Sharma
0974de8fb0
Use BindableFloat for chat height
2022-05-05 23:13:32 +01:00
Jai Sharma
16a6c11bc8
Clamp maximum and minimum height the chat overlay can be resized to
2022-05-05 21:40:37 +01:00
Bartłomiej Dach
a2ab79620a
Update song select exit via click test to match new expectations
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
d296f78dfe
Replace references to old mod select classes in multiplayer match screen test
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
ecc2805099
Replace references to old mod select classes in match song select test
...
Also note the change from `songSelect.ChildrenOfType<>()...` to
`this.ChildrenOfType<>()...` - because the new design is registered at
game-level, the mod select is not a child of the song select screen
anymore.
2022-05-05 22:16:57 +02:00
Bartłomiej Dach
199bdb8e7d
Replace reference to old mod select in multiplayer test
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
17c19063f7
Fix user dim test scene accumulating no fail instances in SelectedMods
...
The old design was apparently somehow tolerant of multiple instances of
the same mod in `SelectedMods`, but the new one is not.
Fix the test, because appending to a list of mods that was getting
modified by previous tests is generally not how tests should be
written.
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
34cf4c6a38
Fix mod overlay not closing on toggle hotkey
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
8f65e0e60f
Add failing test coverage for toggling mod overlay with hotkey
2022-05-05 22:16:56 +02:00
Bartłomiej Dach
0caea77176
Fix mod selects not hiding when their owner screens exit
2022-05-05 22:16:55 +02:00
Bartłomiej Dach
fdb21fedab
Implement IOverlayManager in ScreenTestScene
2022-05-05 22:16:55 +02:00
Bartłomiej Dach
a56eab2c47
Extract interface for overlay management
2022-05-05 22:16:55 +02:00
Bartłomiej Dach
66473972da
Use new user mod select design in multiplayer lobby
2022-05-05 22:16:55 +02:00
Bartłomiej Dach
4eefbd5bc2
Use new free mod select design in room creation flow
2022-05-05 22:16:54 +02:00
Bartłomiej Dach
ac08498f35
Use plum colour scheme in multiplayer to match rest of multiplayer screens
2022-05-05 22:16:54 +02:00
Bartłomiej Dach
1744d7e4f0
Fix new mod select overlay dimming itself
2022-05-05 22:16:54 +02:00
Bartłomiej Dach
407db7ff9d
Replace old mod select overlay with new design
2022-05-05 22:16:54 +02:00
Dean Herbert
e2895ea145
Merge pull request #18108 from bdach/mod-overlay/customisation-auto-show-bug
...
Close new design's mod customisation area on escape press before exiting
2022-05-06 04:21:08 +09:00
Huo Yaoyuan
701ddade47
Revert editorconfig changes from framework
2022-05-06 01:32:37 +08:00
Huo Yaoyuan
30ffc7b23f
Remove dotnet-format
2022-05-06 01:28:30 +08:00
Huo Yaoyuan
aafb363a34
Only enable EnforceCodeStyleInBuild in CI
2022-05-06 01:24:19 +08:00
Bartłomiej Dach
79e1b93b30
Close customisation area on escape press before exiting
2022-05-05 19:17:36 +02:00
Bartłomiej Dach
8002726c9c
Add test coverage for dismissing customisation area with Escape
2022-05-05 19:17:36 +02:00
