Dean Herbert
9ff6b3fcd3
Merge branch 'master' into editor-save-local-score-management
2023-07-06 12:28:44 +09:00
Bartłomiej Dach
a87a631c50
Merge branch 'master' into taiko-hitsounding-final-attempt
2023-07-05 22:15:32 +02:00
Bartłomiej Dach
afc0c4f3c2
Merge pull request #24088 from peppy/taiko-hitsounding-drum-sample-player
...
Move all remaining osu!taiko sample playback logic out of `DrawableHitObject`s
2023-07-05 21:57:49 +02:00
Dean Herbert
8f61f5e4c6
Cache Playfield for the sake of tests
...
I'm open to an alternative. Name it.
2023-07-05 18:44:27 +09:00
Dean Herbert
289f916cd7
Remove outdated TODO
2023-07-05 18:44:27 +09:00
Dean Herbert
759cd5aec7
Warm up pool with argon-specific drum samples
2023-07-05 18:44:27 +09:00
Dean Herbert
f086908831
Don't attempt to play drum samples when rewinding
2023-07-05 18:44:27 +09:00
Dean Herbert
16f1a7694d
Add time-based flourish support
2023-07-05 18:44:27 +09:00
Dean Herbert
c72ebcfd53
Fix skin fallback not working as expected
2023-07-05 18:44:27 +09:00
Dean Herbert
010262c764
Change strong hit sample handling to be user input based, not hit object based
2023-07-05 18:44:27 +09:00
Dean Herbert
a9587fd1aa
Move strong hit handling to DrumSamplePlayer and separte trigger sources
2023-07-05 18:44:27 +09:00
Dean Herbert
27af07b74b
Add basic implementation of argon osu!taiko hitsounds (volume / flourish / strong)
2023-07-05 18:44:27 +09:00
Dean Herbert
beed390031
Add balance adjust to base implementation of DrumSampleTriggerSource
2023-07-05 18:44:27 +09:00
Dean Herbert
ae86fc736a
Add argon-specific DrumSamplePlayer
2023-07-05 18:44:27 +09:00
Dean Herbert
f54eb8d7fa
Move DrumSamplePlayer to be a skinnable component
2023-07-05 18:44:27 +09:00
Dean Herbert
9a7bf1bedd
Fix reversed order of sample return
2023-07-05 18:44:01 +09:00
Dean Herbert
3b9d7af9ee
Fix taiko hit overlay animation timing not accounting for timing section start time
2023-07-05 17:25:31 +09:00
Dean Herbert
1629024111
ILegacyScoreProcessor -> ILegacyScoreSimulator
2023-07-04 17:32:54 +09:00
Dean Herbert
d74b1e148d
Make ScoreInfo.BeatmapInfo nullable
2023-07-04 14:50:34 +09:00
Dean Herbert
571dbf5ab8
Adjust logic to avoid creating List<> each playback
2023-06-30 15:42:58 +09:00
Dean Herbert
c98abf1723
More correctly handle StrongNestedHitObjects
2023-06-30 15:38:17 +09:00
Dean Herbert
e87cf6d256
Move all remaining osu!taiko sample playback logic out of DrawableHitObjects
2023-06-30 15:21:34 +09:00
Dan Balasescu
c6ad184d94
Move Ruleset method to ILegacyRuleset interface
2023-06-29 17:24:37 +09:00
Dan Balasescu
09bc8e45de
Refactoring
2023-06-28 16:14:32 +09:00
Dan Balasescu
5f350aa66f
Fix float division
...
Firstly, this is intended to be a float division.
Secondly, dividing integers by 0 results in an exception, but dividing
non-zero floats by 0 results in +/- infinity which will be clamped to
the upper range.
In particular, this occurs when the beatmap has 1 hitobject (0 drain
length).
2023-06-27 17:14:35 +09:00
Natelytle
7ee910195c
Merge remote-tracking branch 'osumaster/master' into taikostatacc
2023-06-26 12:36:34 -04:00
Dan Balasescu
a9c65d200a
Initial conversion of scores
2023-06-26 22:19:01 +09:00
Dan Balasescu
e1d723a2cc
Merge branch 'master' into diffcalc-total-scorev1
2023-06-26 14:32:14 +09:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update
2023-06-24 18:47:52 +02:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Dean Herbert
df5b389629
Manual fixes to reduce warnings to zero
2023-06-24 01:52:53 +09:00
Dan Balasescu
06565871d6
Add flag to disable computing legacy scoring values
2023-06-24 01:03:18 +09:00
Dean Herbert
0ab0c52ad5
Automated pass
2023-06-24 01:00:03 +09:00
Dan Balasescu
87447f41d0
Fix incorrect calculation of difficulty
2023-06-24 00:58:45 +09:00
Dan Balasescu
bfa449e47a
Adjust attribute data
2023-06-19 21:38:13 +09:00
Dan Balasescu
0844a21a51
Merge branch 'master' into diffcalc-total-scorev1
2023-06-15 19:33:29 +09:00
Dan Balasescu
aa644832dc
Add ScoreV1 calculation for TaikoRuleset
2023-06-13 19:28:46 +09:00
Dean Herbert
b986d1cee1
Rename variables to give more context
2023-06-12 14:18:26 +09:00
Xinnoh
0c42aa7f3b
lower kiai pulse brightness
2023-06-09 22:51:45 -07:00
Xinnoh
7bf73463f1
reduce argon kiai flashing
2023-06-09 22:46:07 -07:00
Bartłomiej Dach
7acd186a3d
Revert to previous bound in drum roll tick generation
...
While `EndTime + tickSpacing` _was_ closer to what stable was using, it
could cause undesirable edge cases wherein a tick would be spawned
outside of the drum roll's duration
(see https://github.com/ppy/osu/pull/23768/files#r1222073027 ).
For this reason, stick with the old code for now, as it is not as
susceptible to that sort of breakage.
2023-06-08 09:56:39 +02:00
Bartłomiej Dach
b6a1377955
Merge branch 'master' into fix-editor-drum-roll
2023-06-08 09:55:10 +02:00
Salman Ahmed
62cb6a98ca
Remove redundant nullable suppression directives
2023-06-07 08:20:41 +03:00
Dean Herbert
56758afeed
Add note about lastTickHittable requirement
2023-06-06 17:01:52 +09:00
Dean Herbert
3db080fad2
Fix osu!taiko drum rolls not getting correct tick rate after placement in the editor
2023-06-06 16:54:33 +09:00
Dean Herbert
b096e03a57
Fix ticks being created after the end of drum rolls in osu!taiko editor
...
Closes https://github.com/ppy/osu/issues/23135 .
2023-06-06 16:31:59 +09:00
Dean Herbert
a18a2e48f7
Colour argon osu!taiko explosions based on the object hit
2023-06-06 15:49:03 +09:00
Dan Balasescu
e402c6d2b4
Write max combo attribute from base class
2023-06-02 21:53:25 +09:00
Dean Herbert
985604fab5
Return StatisticItems rather than StatisticRows from ruleset
...
There were no usages of more than one column being provided per row, so
it seemed like unnecessarily complexity. I'm currently trying to reduce
complexity so we can improve the layout of the results screen, which
currently has up to three levels of nested `GridContainer`s.
Of note, I can't add backwards compatibility because the method
signature has not changed in `Ruleset` (only the return type). If we do
want to keep compatibility with other rulesets, we could designate a new
name for the updated method.
2023-06-01 14:35:15 +09:00
Dan Balasescu
fee3d43596
Merge branch 'master' into scorev2
2023-05-23 19:07:54 +09:00
