Bartłomiej Dach
3291f15dcc
Mention GetForWrite()
as another alternative to Context
accesses
2021-07-04 12:08:15 +02:00
Bartłomiej Dach
b89521314f
Mention alternatives to Context
when not on update thread in xmldoc
2021-07-04 12:07:34 +02:00
Dean Herbert
3ec7dc3bb9
Update tests in line with thread safety check
2021-07-04 17:59:39 +09:00
Dean Herbert
567e9f33a9
Fix thread safety of realm Refresh
operation
...
Due to the lack of locking, there was a chance the the update thread
`context` was retrieved just before the `flushContexts` call, followed
by `.Refresh()` being run while the blocking behaviour was invoked.
This can be seen in test failures such as
https://ci.appveyor.com/project/peppy/osu/builds/39859786/tests .
As an aside, I tried multiple different methods to avoid `lock()` on the
update thread but they felt flaky. The overhead of lock when there's no
contention is reportedly around 30-50ns, so likely not of concern. We
can address it at a later point if it becomes one.
2021-07-04 16:24:43 +09:00
Bartłomiej Dach
fbe3b447e5
Merge branch 'master' into linkify-metadata
2021-07-03 15:51:08 +02:00
Bartłomiej Dach
6fb8ed4d07
Trim no longer used constant
2021-07-03 15:47:47 +02:00
Bartłomiej Dach
7dae93ad66
Remove unused using directives
2021-07-03 15:23:26 +02:00
Bartłomiej Dach
16d08df5e2
Remove mention of direct from xmldoc
2021-07-03 15:22:03 +02:00
Dan Balasescu
ace57a9ee9
Merge pull request #13727 from peppy/update-disclaimer
...
Update disclaimer
2021-07-02 21:08:43 +09:00
Dan Balasescu
5a7706edee
Merge pull request #13726 from nekodex/notch-tick-sfx
...
Add audio feedback for changing volume
2021-07-02 21:08:31 +09:00
Dean Herbert
6e31c781bb
Merge pull request #13382 from ribbanya/clamp-skin-scale
...
Fix skin elements flipping when scaled below zero
2021-07-02 20:50:47 +09:00
Dan Balasescu
4d85df6bbc
Merge branch 'master' into notch-tick-sfx
2021-07-02 20:38:30 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
...
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
Dean Herbert
8847915c6a
Update framework
2021-07-02 18:51:14 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
...
Submit scores on player exit
2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block
2021-07-02 18:19:46 +09:00
Dean Herbert
f37e5bdab8
Merge pull request #13742 from aitani9/skin-editor-flipping-reflect
...
Make flipping in the skin editor reflect across the axes of the selection box
2021-07-02 18:19:04 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls
...
Fix some incorrectly invoked `async` calls
2021-07-02 18:10:30 +09:00
Dean Herbert
362816492f
Move to more friendly namespace
2021-07-02 18:09:16 +09:00
Dean Herbert
1bbf578dfe
Merge pull request #13714 from bdach/colour-picker
...
Add osu!-styled colour picker control
2021-07-02 18:05:19 +09:00
Dean Herbert
eacf867073
Move shared types into their own classes
2021-07-02 18:05:00 +09:00
Dean Herbert
ecb4982281
Add missing blank lines
2021-07-02 17:51:54 +09:00
Henry Lin
6a0c5b54c3
Fix obsolete message in Mod.Ranked
2021-07-02 15:55:25 +08:00
Dean Herbert
35f7966922
Merge conditionals in line with other case of same logic
2021-07-02 15:55:36 +09:00
Dean Herbert
63d2ac66d2
Fix one more instance of incorrect playback/frequency set order
2021-07-02 15:52:20 +09:00
Jamie Taylor
910fe3e9f8
Center pitch randomisation around base pitch
2021-07-02 15:51:23 +09:00
Dean Herbert
bd6664d541
Add note about intentional downward pitch, against expectations
2021-07-02 15:48:16 +09:00
Dean Herbert
13254d51fc
Remove usage of bool
for initial playback
...
Also refactors the whole method to generally clean things up. One more
important fix is setting the frequency on the channel before starting
playback, so avoid the frequency potentially being adjusted after the
playback is already started.
2021-07-02 15:48:13 +09:00
Dean Herbert
69b1347730
Tidy up weird bind logic
2021-07-02 15:29:51 +09:00
Dean Herbert
9814c24741
Merge branch 'master' into notch-tick-sfx
2021-07-02 15:27:28 +09:00
Dean Herbert
f2d9d78455
Fix some incorrectly invoked async
calls
2021-07-02 14:43:48 +09:00
Dean Herbert
f689e788c9
Avoid using game-wide beatmap during score submission
2021-07-02 14:24:27 +09:00
Dean Herbert
0396a03bbc
Rename Mod.Ranked
back to avoid breaking ruleset API
2021-07-02 12:50:58 +09:00
Dean Herbert
62c125d7a2
Tidy up font formatting methods
2021-07-02 12:21:28 +09:00
Dean Herbert
f0727a63be
Reduce usable width
2021-07-02 12:18:52 +09:00
Dean Herbert
a1eaf39645
Slightly change wording to hopefully read better
2021-07-02 12:15:16 +09:00
Bartłomiej Dach
083e463afd
Use alternative hue slider nub design
2021-07-02 01:03:02 +02:00
Bartłomiej Dach
434c048d87
Merge branch 'master' into colour-picker
2021-07-02 01:03:00 +02:00
aitani9
9b0fa6d3fc
Make flipping reflect across the axes of the selection box
2021-07-01 15:38:38 -07:00
Bartłomiej Dach
6c07f6fecf
Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.7' into update-dependencies
2021-07-01 19:17:00 +02:00
Bartłomiej Dach
326a46fa84
Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.7' into update-dependencies
2021-07-01 19:16:23 +02:00
Bartłomiej Dach
7f6d6edc46
Merge remote-tracking branch 'upstream/dependabot/nuget/ppy.LocalisationAnalyser-2021.614.0' into update-dependencies
2021-07-01 19:16:16 +02:00
Bartłomiej Dach
8a581fcf7e
Merge remote-tracking branch 'upstream/dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.7' into update-dependencies
2021-07-01 19:16:11 +02:00
Bartłomiej Dach
c34ecc7492
Merge remote-tracking branch 'upstream/dependabot/nuget/Humanizer-2.11.10' into update-dependencies
2021-07-01 19:15:58 +02:00
Bartłomiej Dach
e6b9bcb90c
Merge remote-tracking branch 'upstream/dependabot/nuget/HtmlAgilityPack-1.11.34' into update-dependencies
2021-07-01 19:14:27 +02:00
Bartłomiej Dach
503bf092c9
Merge remote-tracking branch 'upstream/dependabot/nuget/SharpCompress-0.28.3' into update-dependencies
2021-07-01 19:14:09 +02:00
Bartłomiej Dach
6f859d66f8
Merge remote-tracking branch 'upstream/dependabot/nuget/Sentry-3.6.0' into update-dependencies
2021-07-01 19:13:15 +02:00
dependabot[bot]
d0ae946cb6
Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack
...
Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore ) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 17:02:38 +00:00
dependabot[bot]
f6234864cc
Bump Microsoft.AspNetCore.SignalR.Client from 5.0.6 to 5.0.7
...
Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore ) from 5.0.6 to 5.0.7.
- [Release notes](https://github.com/dotnet/aspnetcore/releases )
- [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.6...v5.0.7 )
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.SignalR.Client
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 17:02:33 +00:00
dependabot[bot]
fb2d08b9ee
Bump ppy.LocalisationAnalyser from 2021.608.0 to 2021.614.0
...
Bumps [ppy.LocalisationAnalyser](https://github.com/ppy/osu-localisation-analyser ) from 2021.608.0 to 2021.614.0.
- [Release notes](https://github.com/ppy/osu-localisation-analyser/releases )
- [Commits](https://github.com/ppy/osu-localisation-analyser/compare/2021.608.0...2021.614.0 )
---
updated-dependencies:
- dependency-name: ppy.LocalisationAnalyser
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 17:02:29 +00:00