58147 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into bmm-cleanup-2
  Bartłomiej Dach · 2022-06-16 13:33:20 +02:00
  c90edf49a7
• Merge pull request #18733 from peppy/bmm-cleanup

  More model importer clean-ups (delete `BeatmapModelManager`)

  Bartłomiej Dach · 2022-06-16 13:32:55 +02:00
  6df4b16a89
• Merge branch 'bmm-cleanup' into bmm-cleanup-2
  Dean Herbert · 2022-06-16 19:48:54 +09:00
  d48fbdb439
• Add back missing notification flow
  Dean Herbert · 2022-06-16 19:48:18 +09:00
  e66ccfd980
• Update filename to match new class name
  Dean Herbert · 2022-06-16 19:41:14 +09:00
  448eee051a
• Remove unused GetWorkingBetamap method
  Dean Herbert · 2022-06-16 19:08:59 +09:00
  3860f0b3e5
• Reimplement missing methods
  Dean Herbert · 2022-06-16 19:05:25 +09:00
  ce3d3a967c
• Fix invalid method reference in comment

  `BeatmapModelManager.Save()` was moved to `BeatmapManager`, not to
  `BeatmapImporter`.

  Bartłomiej Dach · 2022-06-16 12:01:53 +02:00
  a635664a86
• Remove local realm fields in manager classes
  Dean Herbert · 2022-06-16 18:56:53 +09:00
  72c5b9009d
• Remove RealmArchiveModelManager from hierarchy
  Dean Herbert · 2022-06-16 18:53:13 +09:00
  f3984d98e6
• Remove pointless override in test implementation
  Dean Herbert · 2022-06-16 18:27:16 +09:00
  8a5755ca52
• Move and adjust implementation regions to restore sanity
  Dean Herbert · 2022-06-16 18:26:13 +09:00
  04e4c5ef88
• Rename Score/Skin ModelManager classes to Importer for now
  Dean Herbert · 2022-06-16 18:11:50 +09:00
  4d9e3d1982
• Combine BeatmapManager and BeatmapModelManager into one class
  Dean Herbert · 2022-06-16 18:07:04 +09:00
  1f3e1b2d97
• Move file extensions specification to common class
  Dean Herbert · 2022-06-16 18:00:27 +09:00
  8ea3042435
• Update usages of BeatmapModelManager which only require importing to use BeatmapImporter
  Dean Herbert · 2022-06-16 17:59:24 +09:00
  84dba36cf5
• Consolidate remaining methods in BeatmapModelManager
  Dean Herbert · 2022-06-16 17:59:24 +09:00
  4c372539a1
• Convert NotificationOverlay to NRT
  Dean Herbert · 2022-06-16 17:28:08 +09:00
  251923c106
• Tidy up DI and binding logic
  Dean Herbert · 2022-06-16 17:26:43 +09:00
  6b30ee0950
• Merge pull request #18715 from bdach/ruleset-mod-hardening

  Add several protections when creating game-global available mods

  Dean Herbert · 2022-06-16 17:18:49 +09:00
  953ca8c2dd
• Move database backup creation to async thread where possible
  Dean Herbert · 2022-06-16 17:01:17 +09:00
  4526f8c07d
• Don't backup collection database

  This is no longer required due to recent changes which mean the
  collection database will retain beatmap references even if they aren't
  loaded locally (see https://github.com/ppy/osu/pull/18619).

  Dean Herbert · 2022-06-16 16:48:53 +09:00
  17dbb599d1
• Ensure reading of existing databases when making backups doesn't create a file
  Dean Herbert · 2022-06-16 16:48:06 +09:00
  739a696467
• Fix unsafe sample playback in GameplaySampleTriggerSource

  Resolves https://github.com/ppy/osu/issues/18727.
  
  Added delay from `Schedule` should be minimal as it is always called
  from the `Update` thread (input propagation) anyway.

  Dean Herbert · 2022-06-16 16:04:57 +09:00
  ec53d87c30
• Merge pull request #18720 from bdach/twemoji-flags

  Update flag sizes after switch to twemoji assets

  Dean Herbert · 2022-06-16 15:55:05 +09:00
  1c3cc985bc
• Fix Disclaimer screen handling user change events after initial display

  Unnecessary overhead, but also should resolve a production hard crash.

  Dean Herbert · 2022-06-16 15:40:20 +09:00
  89533fa33d
• Merge branch 'master' into twemoji-flags
  Dean Herbert · 2022-06-16 15:06:49 +09:00
  0c9f4fc8eb
• Update resources
  Dean Herbert · 2022-06-16 15:06:34 +09:00
  ac554ca51f
• Merge pull request #18723 from smoogipoo/ci-template-tests

  Run template tests on CI

  Dean Herbert · 2022-06-16 15:04:54 +09:00
  e778c90930
• Run template tests on CI
  Dan Balasescu · 2022-06-16 13:47:30 +09:00
  88376da2cf
• Update flag sizes after switch to twemoji assets

  The old flags used a size of 150x100, while the new assets based on
  twemoji use a size of 150x108. Update existing usages to match this new
  aspect ratio better.

  Bartłomiej Dach · 2022-06-15 21:45:47 +02:00
  f88c568c8d
• Use FileInfo as current bindable type
  Salman Ahmed · 2022-06-15 19:29:09 +03:00
  2c35b1404b
• Revert virtual current bindable
  Salman Ahmed · 2022-06-15 19:28:43 +03:00
  5d74d92fcf
• Fix potential null reference
  Salman Ahmed · 2022-06-15 18:53:49 +03:00
  e7dcbddbeb
• Ensure AvailableMods.Value is never null
  Bartłomiej Dach · 2022-06-15 17:40:16 +02:00
  1acbb87aa6
• Fix template projects returning null mods from GetModsFor()
  Bartłomiej Dach · 2022-06-15 17:40:16 +02:00
  6ee1c35c8f
• Fill out GetModsFor() xmldoc and annotate items as non-null
  Bartłomiej Dach · 2022-06-15 17:40:15 +02:00
  30382b0445
• Add protection against arbitrary exceptions from GetModsFor()
  Bartłomiej Dach · 2022-06-15 17:31:46 +02:00
  e74b563b91
• Add test coverage for API-incompatible rulesets wrt mods
  Bartłomiej Dach · 2022-06-15 17:31:46 +02:00
  665ef5fdcc
• Add protection against rulesets returning null mods
  Bartłomiej Dach · 2022-06-15 17:31:46 +02:00
  6e5e506fb4
• Add test coverage for ignoring null mods returned by rulesets
  Bartłomiej Dach · 2022-06-15 17:31:46 +02:00
  0418d70056
• Ensure notification is displayed after first-run setup is hidden
  Salman Ahmed · 2022-06-15 18:13:24 +03:00
  387c54c252
• Use notification processing mode logic instead
  Salman Ahmed · 2022-06-15 18:13:24 +03:00
  026bad7fc4
• Decouple LabelledFileChooser from LabelledTextBoxWithPopover
  Salman Ahmed · 2022-06-15 17:45:31 +03:00
  1ff070f5ff
• Merge pull request #18712 from peppy/importer-clean-up-part-2

  More clean-up work on realm/beatmap import flow

  Bartłomiej Dach · 2022-06-15 16:14:41 +02:00
  c9cb4250bb
• Move remaining realm classes out of Stores namespace
  Dean Herbert · 2022-06-15 21:56:00 +09:00
  f23ddfe6cc
• Move BeatmapImporter to correct namespace
  Dean Herbert · 2022-06-15 21:47:52 +09:00
  23d7667f39
• Remove unnecessary ShouldDeleteArchive override (already done in base implementation)
  Dean Herbert · 2022-06-15 21:47:52 +09:00
  9edc4fc181
• Merge pull request #18702 from nekodex/new-dialog-sfx

  Add new dialog popup SFX

  Dean Herbert · 2022-06-15 21:46:04 +09:00
  2022.615.0 4d5f82ccd3
• Merge branch 'master' into new-dialog-sfx
  Dean Herbert · 2022-06-15 19:47:00 +09:00
  7571ab6c63