osu-lazer

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

To correctly end a mania hold note, `endHold()` needs to be called. This
was not happening in a very specific scenario:

- The hold note's head is not hit
- The user pressed the column's key within the hold note's tail's window,
  but does so to hit the next object (a note in proximity to the hold note's tail).
- The hit policy forces a miss on the hold note, but `endHold()` is not called
- `CheckForResult` is not called after this point due to `Judged` being `true`.

Closes #21311.

Dean Herbert · 2022-11-22 16:15:34 +09:00

57723107dd

Add "Component" prefix to lookup naming

Dean Herbert · 2022-11-09 17:46:43 +09:00

1aa0e40f2f

Rename ISkinComponent to ISkinLookup

Dean Herbert · 2022-11-09 17:46:43 +09:00

c908969d9b

Fix hold note disappear instantly

ekrctb · 2022-10-25 19:16:23 +09:00

92ab39f5c2

Implement hold "sliding" samples in osu!mania

Dean Herbert · 2022-10-11 16:31:37 +09:00

f060e6a780

Remove manual binding of nested objects in DrawableManiaHitObject

This is now handled by `Column` itself. Leaving the logic here as well
will cause a circular bindable flow and stack overflow.

Dean Herbert · 2022-10-07 18:25:55 +09:00

52ad766f86

Fix mania hold note head disappears

ekrctb · 2022-10-06 19:46:10 +09:00

ea4dbc8c0f

Fix tests

ekrctb · 2022-10-04 16:10:18 +09:00

15d159a97e

Remove code that is not needed anymore

ekrctb · 2022-10-04 15:17:14 +09:00

2aa4d21c75

Clamp LifetimeStart of HitObject's to their judgement windows

sw1tchbl4d3 · 2022-09-27 16:54:24 +02:00

0cffbb7562

Rename const

Dan Balasescu · 2022-08-09 13:20:20 +09:00

a52fa8eb8b

Adjust visuals of osu!mania barlines to be less present

Roughly matches the new design. Metrics adjusted to fit with the existing design.

Closes #19611 maybe?

Dean Herbert · 2022-08-08 17:39:14 +09:00

1f4b87d233

Change bindable properties in all HitObjects to be lazily initialised

Salman Ahmed · 2022-07-19 05:39:10 +03:00

1051009827

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Merge pull request #15255 from goodtrailer/node-samples-ilist

Change IHasRepeats.NodeSamples to IList from List

Dean Herbert · 2021-10-28 14:24:26 +09:00

5c7623e68e

Apply batch fixing of built-in types using var

Dean Herbert · 2021-10-27 13:04:41 +09:00

6944151486

Change IHasRepeats.NodeSamples to IList from List

goodtrailer · 2021-10-23 01:59:07 -07:00

4440b9ca11

Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo

Dean Herbert · 2021-10-01 16:55:50 +09:00

a92d499d7a

Update with keybinding changes

smoogipoo · 2021-09-16 18:26:12 +09:00

f9d5abff8a

Fix notes not updating snap colour on application

Bartłomiej Dach · 2021-09-12 18:18:55 +02:00

922fa96d41

Split out separate component

Dean Herbert · 2021-08-25 16:56:44 +09:00

6aa894e55e

Fix hold notes handling all input ever

Dean Herbert · 2021-08-24 19:08:04 +09:00

6252b8aa42

Fix mania hitobjects not appearing early enough

smoogipoo · 2021-07-16 19:33:34 +09:00

05234d6c30

Remove lifetime override of DrawableManiaHitObject

The `AlwaysAlive` logic is now in all DHOs and it is now not necessary (and potentially conflicting).

ekrctb · 2021-06-17 10:15:24 +09:00

a4f362dca6

Fix DrawableHoldNote retaining hit states through applications

smoogipoo · 2021-05-12 17:07:42 +09:00

f992b59b4f

Fix base.OnLoadComplete() not being called

smoogipoo · 2021-05-12 17:06:44 +09:00

1af3bbf400

Fix crashes

smoogipoo · 2021-05-12 16:40:46 +09:00

4e7551d50e

Initial implementation of DHO pooling

smoogipoo · 2021-05-12 16:35:05 +09:00

5692cecaa4

Fix mania crashing on playing samples after skin change

smoogipoo · 2021-05-11 16:21:21 +09:00

713c169332

Tidy up implementation in DrawableNote

Dean Herbert · 2021-05-01 20:39:10 +09:00

db815f7930

Replace BeatDivisorFinder with GetClosestBeatDivisor

Justus Franklin Tumacder · 2021-05-01 11:57:47 +08:00

fdf8c12947

Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap

Justus Franklin Tumacder · 2021-05-01 11:20:28 +08:00

ecb053b0de

Add visual tests for timing based note coloring

Justus Franklin Tumacder · 2021-04-27 19:02:57 +08:00

c4d28110d6

Add concurrent objects check

Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`.

We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.