76 Commits

• Rename ClampToPlayField
  Drison64 · 2022-09-21 17:14:02 +02:00
  86a09ad2cf
• Fixed tests failing
  Drison64 · 2022-09-20 19:45:39 +02:00
  a4fae37013
• Clamped JuiceStream to Playfield, but broke few tests
  Drison64 · 2022-09-20 19:13:40 +02:00
  6b1cd1bce3
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use latest slider velocity for juice stream velocity computation.

  This fixes one-frame glitch in editor when slider velocity is changed.

  ekrctb · 2022-05-08 22:36:33 +09:00
  670922c8e5
• Change IHasRepeats.NodeSamples to IList from List
  goodtrailer · 2021-10-23 01:59:07 -07:00
  4440b9ca11
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Update usages of DifficultyPointAt
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  071c56e90b
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Allow serialization of catch hit objects
  ekrctb · 2021-07-06 15:32:32 +09:00
  ae1b1cbec9
• Revert "Remove X setter from CatchHitObject"

  This reverts commit 7cbbd74d

  ekrctb · 2020-12-14 13:18:14 +09:00
  d96399ea42
• Remove X setter from CatchHitObject
  ekrctb · 2020-12-14 11:38:07 +09:00
  7cbbd74df2
• Replace CatchHitObject.X usage to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:14 +09:00
  96f3e0dad8
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc
• Fix slider samples being overwritten by the last node
  smoogipoo · 2020-10-09 20:50:09 +09:00
  696e3d53af
• Standardize osu!catch coordinate system

  There were two coordinate systems used:
  - 0..512 (used in osu!stable)
  - 0..1 (relative coordinate)
  
  This commit replaces the usage of
  the relative coordinate system to
  the coordinate system of 0..512.

  ekrctb · 2020-07-02 00:21:45 +09:00
  3278a1d7d8
• Merge branch 'master' into move-setter-to-duration
  Dan Balasescu · 2020-06-01 15:55:48 +09:00
  64d1b4b11b
• Move sett from EndTime to Duration
  Dean Herbert · 2020-05-27 12:37:44 +09:00
  b8e0a6f127
• Split out IHasPath from IHasCurve to better define hitobjects
  Dean Herbert · 2020-05-26 17:44:47 +09:00
  6b5b215299
• Actually use the cancellation token
  smoogipoo · 2020-05-15 18:17:39 +09:00
  4719fcc291
• Add cancellation token support to CreateNestedHitObjects()
  smoogipoo · 2020-05-15 18:07:41 +09:00
  98125102a7
• Merge pull request #8201 from peppy/fix-hyperdash-test

  Fix hyperdash test having a zero-length juice stream

  Dan Balasescu · 2020-03-11 13:46:59 +09:00
  cd5f0d6e96
• Don't play samples on catching a tiny droplet
  Dean Herbert · 2020-03-10 18:05:44 +09:00
  14192c069f
• Fix hyperdash test having a zero-length juice stream
  Dean Herbert · 2020-03-10 17:49:51 +09:00
  5329b222f6
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Update inspectcode version and fix new issues
  Dean Herbert · 2020-02-15 11:54:29 +09:00
  bb541f5ae4
• Throw NotSupportedException instead
  Dean Herbert · 2020-02-06 13:16:32 +09:00
  daf5fa9da4
• Make EndTime and RepeatCount settable
  Dean Herbert · 2020-02-05 17:52:51 +09:00
  cd6902a312
• Don't reuse the same control point references
  smoogipoo · 2019-12-16 15:27:54 +09:00
  a554ca728b
• Refactor hitobjects to remove default control point
  smoogipoo · 2019-12-09 17:48:27 +09:00
  fa1468325e
• Fix nested hitobjects not updating
  smoogipoo · 2019-12-06 20:53:40 +09:00
  b9d12e5fe4
• Use auto property.
  Huo Yaoyuan · 2019-11-12 19:53:25 +08:00
  bbeab6fa76
• Make hitobject samples a bindable list
  smoogipoo · 2019-11-08 14:04:57 +09:00
  6fc1be64c2
• Fix skinning support for combobreak
  Dean Herbert · 2019-06-30 21:58:30 +09:00
  60ea3d4e1a
• Apply more missed cases
  Dean Herbert · 2019-04-01 12:44:46 +09:00
  c39c37a18d
• Add xmldoc and clarify struct variables
  Dean Herbert · 2019-03-11 14:36:29 +09:00
  489153579a
• Add extensive commenting about LegacyLastTick usage
  Dean Herbert · 2019-03-08 20:12:48 +09:00
  165a353a83
• Fix legacy tick handling
  Dean Herbert · 2019-03-08 19:57:30 +09:00
  355705f0a5
• Merge branch 'master' into catch-slider-conversion-tweak
  Dean Herbert · 2019-01-31 19:27:08 +09:00
  a5c1ef03f9
• reduce code duplication / allocations
  ekrctb · 2019-01-26 16:16:49 +09:00
  ea48d6a88a
• Use integer count for tiny droplet generation
  ekrctb · 2019-01-26 16:14:37 +09:00
  1a5a238752
• Fix juice stream generates tiny droplet at tick time
  ekrctb · 2019-01-25 18:11:27 +09:00
  3375096f1d
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Fix catch slider conversion for last droplets
  ekrctb · 2019-01-21 18:05:55 +09:00
  67ea3beeb4
• Make Path.Distance a property again
  smoogipoo · 2018-11-12 14:07:48 +09:00
  3aba462e52
• Instantiate a new path rather than setting properties on it

  # Conflicts:
  #	osu.Game.Rulesets.Catch/Beatmaps/CatchBeatmapConverter.cs
  #	osu.Game.Rulesets.Catch/Objects/JuiceStream.cs
  #	osu.Game.Rulesets.Osu/Beatmaps/OsuBeatmapConverter.cs
  #	osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/SliderPath.cs

  smoogipoo · 2018-11-12 13:50:19 +09:00
  54ab256c8e
• Merge remote-tracking branch 'origin/master' into fix-slider-samples

  # Conflicts:
  #	osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
  #	osu.Game/Rulesets/Objects/Legacy/Catch/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Mania/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Osu/ConvertHitObjectParser.cs
  #	osu.Game/Rulesets/Objects/Legacy/Taiko/ConvertHitObjectParser.cs

  smoogipoo · 2018-11-05 16:38:28 +09:00
  a4caaf56ef
• ControlPoint -> PathControlPoint

  Also Curve -> Path.

  Dean Herbert · 2018-11-01 03:56:51 +09:00
  bb2f8deb18