Dean Herbert
980f6cf18e
Make CarouselItem sealed and remove BeatmapCarouselItem concept
...
Less abstraction is better. As far as I can tell, we don't need a custom
model for this. If there's any tracking to be done, it should be done
within `BeatmapCarousel`'s implementation (or a filter).
2025-01-23 18:48:44 +09:00
Dean Herbert
c67c0a7fc0
Move Selected status to drawables
...
Basically, I don't want bindables in `CarouselItem`. It means there
needs to be a bind-unbind process on pooling. By moving these to the
drawable and just updating every frame, we can simplify things a lot.
2025-01-23 18:48:43 +09:00
Bartłomiej Dach
beaadfa1fa
Merge pull request #31632 from peppy/beatmap-carousel-v2-cleanups
...
Initial carousel additions in preparation for selection logic
2025-01-23 10:43:12 +01:00
Dan Balasescu
6dbf466009
Fix incorrect exception handling
...
In particular, when the exception is:
`AggregateException { AggregateException { HubException } }`,
then the existing code will only unwrap the first aggregate exception.
The overlay's code was copied from the extension so both have been
adjusted here.
2025-01-23 18:32:19 +09:00
Dan Balasescu
f2d8ea2997
Fix incorrect continuation
2025-01-23 18:25:55 +09:00
Bartłomiej Dach
b4e8a17f03
Roll back windows build image to 2019 on android build job
...
Per workaround suggested in
https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501 .
Applying this now as my hopes for a swift resolution without changes on
our side are slim to none (read thread linked above in full to learn
why).
2025-01-23 10:12:30 +01:00
Dan Balasescu
a198b0830a
Add comment indicating RoomManager shouldn't exist
2025-01-23 17:18:01 +09:00
Dan Balasescu
7c38089c75
Rename methods
2025-01-23 16:27:38 +09:00
Dan Balasescu
9a623257f5
Adjust + fix tests
2025-01-23 16:27:38 +09:00
Dean Herbert
ded1d9f019
displayedCarouselItems -> carouselItems
2025-01-23 15:58:35 +09:00
Dean Herbert
d526835627
Only show loading when doing a user triggered filter
2025-01-23 15:51:54 +09:00
Dean Herbert
6ac2dbc818
Reorder carousel methods into logical regions
2025-01-23 15:50:57 +09:00
Dean Herbert
8657576210
Show selection defaults in test scene (and make prettier)
2025-01-23 15:50:40 +09:00
Layendan
f673d16a1f
Fix formatting
2025-01-22 11:42:11 -07:00
Dean Herbert
bf23c67603
Merge pull request #31509 from bdach/local-metadata-cache-corruption
...
Refetch local metadata cache if corruption is detected
2025-01-23 02:43:14 +09:00
tsunyoku
753e9ef7c7
Keep old behaviour of double.PositiveInfinity being the default for Interval
2025-01-22 13:26:12 +00:00
tsunyoku
2c0d6b14c8
Fix incorrect namespace
2025-01-22 13:24:30 +00:00
Dan Balasescu
02369baec4
Join/Leave rooms via multiplayer server
...
Relevant functionality has been removed from `RoomManager` in the
process.
2025-01-22 21:44:45 +09:00
Dan Balasescu
11e84f325c
Merge pull request #31616 from bdach/fix-new-combo-button-crash
...
Fix crash from new combo colour selector when there are no combo colours present
2025-01-22 20:48:02 +09:00
Bartłomiej Dach
3da220b8f6
Fix crash from new combo colour selector when there are no combo colours present
...
Closes https://github.com/ppy/osu/issues/31615 .
2025-01-22 11:39:32 +01:00
Dean Herbert
218720bca5
Merge pull request #31588 from minetoblend/feature/paste-snapped
...
Snap to beat divisor when pasting hitobjects in editor
2025-01-22 18:38:12 +09:00
Dean Herbert
c94b8bf051
Apply NRT to new class
2025-01-22 18:36:13 +09:00
Dean Herbert
6ceb348cf6
Adjust code again to avoid weird throw mishandling
2025-01-22 18:24:01 +09:00
Dan Balasescu
63e6b0e050
Merge pull request #31603 from peppy/input-amendments
...
Tidy up various input handling anomalies
2025-01-22 18:05:06 +09:00
Bartłomiej Dach
2623d8dcac
Merge pull request #31604 from peppy/fix-song-select-right-click-handling
...
Fix song select right click handling
2025-01-22 10:00:03 +01:00
Dan Balasescu
631ae90130
Merge pull request #31613 from peppy/friend-notifications-bug-less
...
Make friend notifications less prominent
2025-01-22 17:34:23 +09:00
Dean Herbert
26ef23c9a9
Remove outdated ef related catch-when usage
2025-01-22 17:04:30 +09:00
Dean Herbert
910c0022e3
Adjust code style slightly
2025-01-22 17:03:01 +09:00
Dean Herbert
9e023340b0
Mark friend notifications as non-important
2025-01-22 16:41:27 +09:00
Dean Herbert
4cf4b8c73d
Switch IsImportant to init property isntead of virtual
2025-01-22 16:41:26 +09:00
Dean Herbert
fde2b22bbc
Add transient flag for notifications which shouldn't linger in history
2025-01-22 16:41:26 +09:00
Layendan
2a5a2738e1
Add context menu to open in browser to rooms
2025-01-21 12:45:23 -07:00
tsunyoku
14c68bcc58
Replace weird IntervalGroupedHitObjects inheritance layer
2025-01-21 15:58:33 +00:00
tsunyoku
1c4bc6dffd
Revert Precision.DefinitelyBigger usage
2025-01-21 15:01:32 +00:00
tsunyoku
764b0001ef
Fix typo in ColourEvaluator
2025-01-21 14:56:51 +00:00
tsunyoku
e0882d2a53
Make rescale a static method
2025-01-21 14:33:40 +00:00
tsunyoku
20a76d832d
Rename rhythm preprocessing objects to be clearer with intent
2025-01-21 14:29:07 +00:00
tsunyoku
ef8867704a
Add xmldoc to explain IHasInterval.Interval
2025-01-21 14:28:15 +00:00
tsunyoku
b8c79d58a7
Refactor StaminaEvaluator
2025-01-21 14:25:28 +00:00
tsunyoku
9919179b0b
Format ReadingEvaluator
2025-01-21 14:24:46 +00:00
tsunyoku
dbe36887f6
Refactor ColourEvaluator
2025-01-21 14:24:27 +00:00
tsunyoku
fa20bc6631
Remove EffectiveBPMPreprocessor
2025-01-21 14:24:04 +00:00
Dean Herbert
459847cb80
Perform client side validation that the selected beatmap and ruleset have valid online IDs
...
This is local to playlists, since in multiplayer the validation is
already provided by `osu-server-spectator`.
2025-01-21 19:51:55 +09:00
Salman Alshamrani
b63d94101c
Reapply "Fix triangles judgement mispositioned on a miss"
...
This reverts commit 6ec718304e4df307d8ae3598de96585ff836a99e.
2025-01-21 05:45:37 -05:00
Dan Balasescu
001d9cacf2
Configure awaiters
2025-01-21 19:31:51 +09:00
Marvin Schürz
cc7c549468
Add test scene for clipboard snapping
2025-01-21 11:02:41 +01:00
Salman Alshamrani
6ec718304e
Revert "Fix triangles judgement mispositioned on a miss"
...
This reverts commit e5713e52392066a1430ebce460d07d8af01ad29f.
2025-01-21 04:58:27 -05:00
Dan Balasescu
8f8246278a
Merge pull request #31527 from bdach/spectator-list-ready
...
Show spectating users during gameplay
2025-01-21 18:54:11 +09:00
Dean Herbert
f88102610d
Add tooltips explaining multiplayer mod selection buttons
2025-01-21 18:35:59 +09:00
Bartłomiej Dach
0265a29000
Move bindings to LoadComplete()
2025-01-21 10:02:16 +01:00
