schiavoanto
ed044d5b85
Fix proposal for #29736
2024-09-06 22:58:18 +02:00
Bartłomiej Dach
9f834ca1a2
Silence beatmap retrieval failures from results screen favourite button
...
As reported (very poorly) in
https://github.com/ppy/osu/pull/28991#issuecomment-2331854970 .
I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
2024-09-06 10:29:23 +02:00
Bartłomiej Dach
28d0a24555
Fix the fix
...
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546 , but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
Layendan
59ba48bc81
Fix crash if favourite button api request fails
2024-08-19 07:58:20 -07:00
Bartłomiej Dach
7693d4c039
Merge branch 'master' into master
2024-08-19 14:30:20 +02:00
Joseph Madamba
c3600467bf
Make collection button test less broken
2024-08-15 11:49:15 -07:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
...
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Layendan
19a4cef113
update var names and test logic
2024-08-01 02:52:41 -07:00
Layendan
36bd83bb80
Update collection state when users add/remove from collection
2024-07-30 15:22:41 -07:00
Joseph Madamba
bc25e5d706
Remove unnecessary depth and padding set
2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a
Merge remote-tracking branch 'upstream/master' into pr/28991
2024-07-27 19:09:02 -07:00
Joseph Madamba
334f5fda2d
Remove direct margin set in popover that was causing positioning offset
2024-07-27 19:02:57 -07:00
Joseph Madamba
04b15d0d38
Remove unnecessary ReceivePositionalInputAt
...
Results is not even using the new footer.
2024-07-27 19:02:43 -07:00
Joseph Madamba
b4ca07300a
Use same size button for everything
2024-07-27 18:43:54 -07:00
Joseph Madamba
b5ff2dab43
Move some properties/bindables around
2024-07-27 18:42:49 -07:00
Joseph Madamba
aed2b3c7c6
Inherit GrayButton instead
...
Also fixes hover highlight.
2024-07-27 18:42:49 -07:00
Bartłomiej Dach
09a1fd2cd1
Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button
...
Fix daily challenge not showing a replay button in results screen
2024-07-26 08:03:17 +02:00
Salman Ahmed
c558dfdf13
Reset download state when score is changed
2024-07-26 05:11:54 +03:00
Bartłomiej Dach
8dbd4d70ff
Fix crash when toggling extended statistics visibility during results load
...
Closes https://github.com/ppy/osu/issues/29066 .
Initially I fixed this at where the assert is right now:
9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333)
2024-07-25 11:45:17 +02:00
Salman Ahmed
615f07d54c
Fix results screen fetching more scores twice
2024-07-25 09:16:09 +03:00
Salman Ahmed
dad8e28446
Fix replay download button not added when no score is selected initially
2024-07-25 07:40:17 +03:00
Layendan
6a4872faa8
Remove nullable disable
2024-07-21 23:56:47 -07:00
Layendan
6bb562db14
Fix collection popover
2024-07-22 12:22:52 +09:00
Layendan
e4cccb5e31
Fix lint errors
2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests
2024-07-22 12:22:51 +09:00
Layendan
c16b7c5c70
Update favorite button
2024-07-22 12:22:51 +09:00
Layendan
3296beb003
Added collection button to result screen
2024-07-22 12:22:50 +09:00
Layendan
0bc14ba646
Add favourite button to results screen
2024-07-17 12:45:20 -07:00
Dean Herbert
5350945340
Update HasFlag usages
2024-07-03 00:19:04 +09:00
Joppe27
47f89b8969
Clamp X value to avoid excessive balance shift
2024-06-13 18:06:19 +02:00
Bartłomiej Dach
ee9144c3bd
Apply NRT to results statistics displays
2024-05-14 15:21:12 +02:00
Bartłomiej Dach
414f023817
Apply NRT to RankText
2024-05-14 15:21:05 +02:00
Bartłomiej Dach
b937b94bd2
Apply NRT to RankBadge
2024-05-14 15:20:56 +02:00
Bartłomiej Dach
ced1c79490
Apply NRT to AccuracyCircle
2024-05-14 15:20:47 +02:00
Bartłomiej Dach
e7721b073c
Apply NRT to ContractedPanelTopContent
2024-05-14 15:20:36 +02:00
Bartłomiej Dach
8e16b57d09
Apply NRT to SimpleStatisticTable
2024-05-14 15:20:26 +02:00
Bartłomiej Dach
237ae8b46a
Apply NRT to SimpleStatisticsItem
2024-05-14 15:20:17 +02:00
Bartłomiej Dach
2f2257f6ce
Apply NRT to PerformanceBreakdownChart
2024-05-14 15:20:07 +02:00
Bartłomiej Dach
77a7f475ee
Apply NRT to ScorePanel
2024-05-14 15:19:58 +02:00
Bartłomiej Dach
10a8e84046
Apply NRT to StatisticsPanel
2024-05-14 15:19:46 +02:00
Bartłomiej Dach
cb49147d1e
Apply NRT to ScorePanelList
2024-05-14 15:19:43 +02:00
Dan Balasescu
459f97891d
Merge pull request #27994 from bdach/timing-distribution-graph-only-basic
...
Do not show non-basic results in timing distribution graph
2024-04-26 01:36:16 +09:00
Bartłomiej Dach
b250a924b1
Do not show non-basic results in timing distribution graph
...
Closes https://github.com/ppy/osu/issues/24274 .
Bit of an ad-hoc resolution but maybe fine? This basically proposes to
bypass the problem described in the issue by just not showing tick hits
at all on the distribution graph.
2024-04-25 11:20:07 +02:00
Bartłomiej Dach
da953b34a7
Apply nullability annotations to ResultsScreen & inheritors
2024-04-25 10:58:28 +02:00
Dean Herbert
4cffc39dff
Don't require hold for quick exit at results screen
2024-04-20 04:53:31 +08:00
Dean Herbert
f92833b588
Add ability to quick exit from results screen
2024-04-18 12:02:49 +08:00
Bartłomiej Dach
7c4c8ee75c
Fix stable scores showing with faded out pp display due to classic mod presence
2024-04-15 11:53:05 +02:00
Bartłomiej Dach
e06df34a1c
Apply partial fade on pp display on results screen when score will not give pp
2024-03-29 11:16:31 +01:00
Bartłomiej Dach
3d8fdc52a4
Merge pull request #27501 from turbedi/throw_helper
...
Use ThrowHelper methods in more places
2024-03-07 11:36:21 +01:00
Joseph Madamba
c36232bc02
Fix results screen accuracy circle not showing correctly for failed S with no flair
2024-03-07 00:10:30 -08:00
