Salman Ahmed
6b8de2a10b
Add test coverage for excluded cases in score submission
2021-07-11 03:35:35 +03:00
Salman Ahmed
07ede7a147
Disallow custom rulesets from score submission
2021-07-11 03:34:57 +03:00
Salman Ahmed
a1f3adc320
Add simple test cases
2021-07-10 19:56:44 +03:00
Salman Ahmed
c44558e3c8
Add back LoadComplete override
2021-07-10 17:57:52 +03:00
Bartłomiej Dach
236e8019cc
Merge pull request #13840 from peppy/fix-run-from-screen-test-failures
...
Ensure run-from-screen song select reaches correct point in execution
2021-07-10 14:13:21 +02:00
Bartłomiej Dach
08cd17435c
Merge branch 'master' into fix-run-from-screen-test-failures
2021-07-10 13:37:20 +02:00
Bartłomiej Dach
94406d77de
Merge pull request #13838 from peppy/fix-access-denied-test-failures
...
Fix test failures due to logger pollution
2021-07-10 13:36:33 +02:00
Bartłomiej Dach
1bd5b1a8b9
Merge branch 'master' into fix-access-denied-test-failures
2021-07-10 13:00:27 +02:00
Gagah Pangeran Rosfatiputra
e4f13e311e
override add auto link in text flow container
2021-07-10 17:58:00 +07:00
Gagah Pangeran Rosfatiputra
45ff28f83b
add autolink constructor
2021-07-10 17:57:33 +07:00
Gagah Pangeran Rosfatiputra
5cd11a02ba
add autolink test
2021-07-10 17:56:37 +07:00
Dean Herbert
c64fe06bf6
Merge pull request #13828 from ekrctb/catch-editor-selection-confine
...
Don't move selected objects outside the playfield in catch editor
2021-07-10 19:30:32 +09:00
Bartłomiej Dach
e10b7867c1
Rewrite method again to hopefully help readability
2021-07-10 12:13:36 +02:00
Bartłomiej Dach
b705213ea9
Update test to match expectations after refactor
2021-07-10 11:44:32 +02:00
Bartłomiej Dach
6f89f8e572
Merge branch 'master' into da-mod-refactor
2021-07-10 11:41:54 +02:00
Bartłomiej Dach
c5011865fc
Invert strangely negated condition
2021-07-10 11:23:38 +02:00
Bartłomiej Dach
494089e402
Fix up English in comment
2021-07-10 11:22:54 +02:00
Bartłomiej Dach
e8005e3bfb
Merge pull request #13841 from peppy/update-song-progress-keyboard-handling
...
Move handling of replay seek operations out of progress bar
2021-07-10 11:17:40 +02:00
Dean Herbert
a9250a0d98
Limit update notifications to once per startup
...
This logic was intentionally designed to continue to prompt the user to
update if they haven't, but that seems pretty anti-user. The change will
stop the update prompts from showing more than once per game startup,
unless manually invoked by the user a second time.
Closes https://github.com/ppy/osu/issues/13821 .
2021-07-09 18:23:30 +09:00
Dean Herbert
6ae631b03a
Remove previous seek testing logic from common test scene
2021-07-09 16:52:03 +09:00
ekrctb
995ef953c6
Modify comment
2021-07-09 15:13:54 +09:00
Dean Herbert
9083b28114
Add test coverage of seeking and pausing
2021-07-09 14:47:11 +09:00
Dean Herbert
6a5f0e8237
Move handling of replay seek operations out of progress bar
...
This is in order to avoid using the now obsoleted property
`SliderBar.AllowKeyboardInputWhenNotHovered`
(see https://github.com/ppy/osu-framework/pull/4579 ).
2021-07-09 14:28:59 +09:00
Dean Herbert
741062a6da
Simplify bindable update methods
2021-07-09 13:58:44 +09:00
Dean Herbert
e0277763d0
Refactor DifficultyAdjustSettingsControl to help with readability
2021-07-09 13:50:07 +09:00
Dean Herbert
51bd83b3f4
Update override matching test to match expectations
2021-07-09 13:30:14 +09:00
Dean Herbert
f9cd7f10d8
Allow null values for ReadCurrentFromDifficulty
...
As long as this isn't a constructor parameter it feels best to
gracefully handle omission. Realistically having it in the ctor is the
best move, but it doesn't feel great in line with the other parameters
passed in via object initalisers.
2021-07-09 13:26:01 +09:00
Dean Herbert
90326f8864
Standardise variables
2021-07-09 13:24:26 +09:00
Dean Herbert
df4bd86cfc
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:18:49 +09:00
Dean Herbert
f3b68a4fbf
Fix storage wrapping logic setting logger too early in startup sequence
2021-07-09 13:17:25 +09:00
ekrctb
7e14679606
Expand the selection movement limiting code with detailed comments
2021-07-09 12:58:08 +09:00
Dean Herbert
9786e1a932
Ensure run-from-screen song select reaches correct point in execution
...
Fixes issues as seen at
https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true . Song
select may take a few frames to perform initial selection as there is a
bit of internal async logic. This ensures that the beatmap has been
updated before continuing with test execution.
2021-07-09 12:36:56 +09:00
Dean Herbert
887035c12e
Fix migration target having left over files potentially causing test failures
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050324 .
2021-07-09 12:21:25 +09:00
Dean Herbert
9f7c6adb58
Fix test failures due to logger pollution
...
As seen at
https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307 . I
can't confirm that this will fix the issue but it looks like the only
plausible reason. I have confirmed that the logging is not coming from
the local (first logging is guaranteed to be after `SetupForRun`).
2021-07-09 12:15:30 +09:00
Dean Herbert
dbfeea9880
Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile
...
Change profile section expansion button to use dropdown sounds
2021-07-09 11:58:48 +09:00
Jamie Taylor
2eb12a59b7
Rename function to be more accurate
2021-07-09 11:16:47 +09:00
Salman Ahmed
0223c569df
Remove no longer necessary method definitions
2021-07-09 00:49:05 +03:00
Salman Ahmed
a7be632770
Improve documentation
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-07-09 00:39:09 +03:00
StanR
02298c2cf4
Fix incorrect curve, move total hits factor into a separate variable for clarity
2021-07-09 00:06:05 +03:00
Bartłomiej Dach
bd3f8b78cc
Merge pull request #13827 from peppy/fix-mod-select-cross-talk
...
Fix cross talk between `ModSelectOverlay`s
2021-07-08 20:31:55 +02:00
Bartłomiej Dach
3e21eeb7c2
Merge branch 'master' into fix-mod-select-cross-talk
2021-07-08 19:53:50 +02:00
Dean Herbert
1c7854b846
Merge pull request #13830 from nekodex/volume-control-switching-sound
...
Add sound for switching between volume controls
2021-07-09 01:03:36 +09:00
Salman Ahmed
f5166d8dd5
Merge branch 'master' into consume-bindable-current-factory
2021-07-08 18:13:48 +03:00
Dean Herbert
b7803b889e
Rename control class to be more descriptive
2021-07-08 20:37:38 +09:00
Jamie Taylor
8746ef0ba9
Avoid double playback of sample
2021-07-08 20:36:25 +09:00
Jamie Taylor
546f55d341
Change profile section expansion to use dropdown sounds
2021-07-08 20:23:11 +09:00
Jamie Taylor
93eb385dd4
Add sound for switching between volume controls
2021-07-08 20:01:39 +09:00
ekrctb
c937c45360
Don't move selected objects outside the playfield in catch editor
2021-07-08 18:49:32 +09:00
Dean Herbert
7153983dd4
Add test coverage
2021-07-08 18:29:54 +09:00
Dean Herbert
af270cccc4
Fix cross talk between ModSelectOverlays
2021-07-08 17:59:04 +09:00
