2700 Commits

• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Add localisation usage to BeatmapStatistic and revert ShowDetailsMappedBy
  diquoks · 2025-06-21 21:01:48 +03:00
  cad4382350
• Fix drawable hold notes continuing to show hit lighting with No Release mod and classic skin

  Closes https://github.com/ppy/osu/issues/33751.

  Bartłomiej Dach · 2025-06-18 17:59:54 +02:00
  176a85763c
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Make CheckConcurrentObjects.Run virtual

  And let implementers copy-paste common code.

  Derrick Timmermans · 2025-05-26 10:59:57 +02:00
  0495a03607
• Rename ConcurrentCondition to ConcurrencyPrecondition

  Better describes the intent of the method.

  Derrick Timmermans · 2025-05-26 10:59:17 +02:00
  257767b311
• Flip equality in CheckManiaConcurrentObjects

  Bad copy and paste.

  Derrick Timmermans · 2025-05-25 14:35:59 +02:00
  53340fe4b7
• Make CheckConcurrentObject ruleset specific
  Derrick Timmermans · 2025-05-25 14:19:23 +02:00
  0065696248
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Merge branch 'master' into perfect-feat
  Krystian Ptach-Żurakowski · 2025-05-09 13:47:58 +02:00
  7b86a3519b
• Rename mod setting

  Just feels better?

  Bartłomiej Dach · 2025-05-08 07:47:24 +02:00
  1e61abde74
• Merge branch 'master' into perfect-feat
  fredzio2006 · 2025-05-07 21:58:29 +02:00
  9748073037
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Added blank line
  fredzio2006 · 2025-05-02 04:35:29 +02:00
  843c48c4f8
• Only allow perfect hits in mania option for Perfect Mod
  fredzio2006 · 2025-05-02 03:54:32 +02:00
  930267a8d0
• Fix column not handling input in gaps correctly
  Salman Alshamrani · 2025-04-30 03:59:41 +03:00
  1579543bbe
• Make column spacing lookups easy to use
  Salman Alshamrani · 2025-04-30 03:59:41 +03:00
  d63f9533b1
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-04-28 13:11:22 +02:00
  4ad86685e0
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Merge branch 'master' into freestyle-mods
  Bartłomiej Dach · 2025-04-23 13:49:32 +02:00
  6da4e09717
• Minor fix to the description text
  Shavixinio · 2025-04-22 19:49:34 +02:00
  3b2382ceb0
• Remove no longer relevant comments
  Dan Balasescu · 2025-04-17 18:25:01 +09:00
  5bda93aac6
• Adjust property name
  Dan Balasescu · 2025-04-14 19:34:33 +09:00
  35ee4b6f24
• Rename new property to better explain visual-only usage
  Dean Herbert · 2025-04-14 18:38:04 +09:00
  f05a50f4e1
• Introduce numeric value in beatmap hit count statistics
  Salman Alshamrani · 2025-04-12 00:14:53 +09:00
  85556e0c3e
• Shorten beatmap hit statistics names
  Salman Alshamrani · 2025-04-11 02:33:57 +09:00
  1dbcbbde15
• Merge branch 'master' into freestyle-mods
  Dan Balasescu · 2025-04-08 19:57:28 +09:00
  1c060f986c
• Fix editor setup screen sliders not having correct keyboard steps

  Closes https://github.com/ppy/osu/issues/32691.
  
  Fixes some extra cases of failure that aren't pointed out in the issue.

  Dean Herbert · 2025-04-08 14:45:43 +09:00
  f2088496c5
• Remove obsoleted ScrollTime setting
  Dean Herbert · 2025-04-04 19:46:15 +09:00
  9cdb3fe6ae
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Disallow mania cover mod
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  cf8a7cbbe8
• Allow specifying mod compatibility with freestyle
  Dan Balasescu · 2025-04-04 16:49:23 +09:00
  ef0cf5143d
• Remove unreachable code
  Dan Balasescu · 2025-04-04 10:47:40 +09:00
  db2366b736
• Simplify filter logic
  Bartłomiej Dach · 2025-04-02 09:59:44 +02:00
  446b26c1e6
• Fixed the filter empty condition
  iamnotcoding · 2025-03-31 20:27:22 +09:00
  8e3d05cbb0
• Made key with equal operator intersect with other filters and removed unnecessary value range check
  iamnotcoding · 2025-03-31 20:26:31 +09:00
  9761a64d52
• Added the "!:" option for NotEqual operator
  iamnotcoding · 2025-03-31 18:39:02 +09:00
  e2bdb70daa
• Made it use only one has variable and deleted key exclude function for now
  iamnotcoding · 2025-03-31 18:32:51 +09:00
  e6f3c5351c
• Changed code quality issues
  iamnotcoding · 2025-03-31 17:48:56 +09:00
  80879319bb
• Made it able to include or exclude multiple key mods by comma separated values
  iamnotcoding · 2025-03-30 17:47:33 +09:00
  acffe31e41
• Merge pull request #32357 from Nunolin/mania-invert-end-notes

  Remove end note conversion in mania invert mod (causing unwanted jacks)

  Dan Balasescu · 2025-03-13 21:54:00 +09:00
  01828931a2
• Merge pull request #32344 from frenzibyte/mania-judgement-position-fix

  Improve handling for top-anchored judgement positions in osu!mania

  Dean Herbert · 2025-03-13 12:48:44 +09:00
  02579dc0a4
• Remove end note conversion in mania invert mod
  Nuno · 2025-03-13 01:02:34 +00:00
  a075a5641a
• Merge branch 'master' into mania-bring-back-touch-controls
  Dean Herbert · 2025-03-12 18:42:39 +09:00
  007198fd98
• Remove unused thing
  Dean Herbert · 2025-03-12 18:36:02 +09:00
  92d374a5bb
• Fix weird implementation of layout validation
  Dean Herbert · 2025-03-12 18:34:33 +09:00
  70693c8bb8
• Improve handling for top-anchored judgement positions in osu!mania
  Salman Alshamrani · 2025-03-12 03:05:10 -04:00
  5a5246a407
• Fix touch input area not handling settings changes
  Salman Alshamrani · 2025-03-11 09:17:19 -04:00
  b3ea63598e
• Apply suggested renames
  Salman Alshamrani · 2025-03-11 09:06:01 -04:00
  b64e69d581