Dean Herbert
4da2dca339
Apply the default SampleControlPoint if not externally provided
...
This is mostly to handle tests for now, as generally this should be
provided by an external source in all other cases.
2021-08-30 17:21:07 +09:00
Dean Herbert
2115d6f93e
Add test coverage of legacy sample point recreation
2021-08-30 17:14:53 +09:00
Dean Herbert
d35c4da906
Add new control point to legacy regeneration logic
2021-08-30 17:14:53 +09:00
Dean Herbert
6ee4a6526c
Don't block sample points from still being added to ControlPointInfo
2021-08-30 17:14:53 +09:00
Dean Herbert
6fd24a5d92
Remove redundant null coalesce
2021-08-30 17:14:53 +09:00
Dean Herbert
ccacf56dd8
Move to legacy namespace
2021-08-30 17:14:53 +09:00
Dean Herbert
7257aae7f2
Move samples to LegacyControlPointInfo
2021-08-30 17:14:53 +09:00
Dean Herbert
da7a871afa
Update inline comment to point to new variable location
...
Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>
2021-08-30 16:27:24 +09:00
Dean Herbert
678386f5c4
Fix missed null coalesce
2021-08-30 16:05:56 +09:00
Dean Herbert
fa2bf42188
Update tooltip implementations
2021-08-30 16:05:00 +09:00
Dean Herbert
f64efdc4a9
Merge branch 'update-extension-usages' into update-framework
2021-08-30 16:00:09 +09:00
Dean Herbert
58a052ea1f
Update framework
2021-08-30 16:00:07 +09:00
Dan Balasescu
6b3cc81e19
Merge pull request #14486 from peppy/taiko-drum-refacor
...
Create a base component to handle gameplay sample triggering
2021-08-30 15:47:21 +09:00
Dean Herbert
6a6dac609c
Fix instability of taiko double conversion
...
Until now, the taiko speed multiplier was potentially applied more than
once if conversion was run multiple times.
2021-08-30 15:30:18 +09:00
Dean Herbert
4adfe9a6dc
Add test coverage of double-convert stability
2021-08-30 15:30:04 +09:00
Dean Herbert
ee49305cad
Move taiko legacy speed multiplier to osu.Game project
...
Allows it to be used in local case in `LegacyBeatmapEncoder`.
2021-08-30 15:13:31 +09:00
Joseph Madamba
7bb2269eba
Add overlay closing behavior test
2021-08-29 22:27:56 -07:00
Dean Herbert
4dd60e3299
Merge branch 'master' into taiko-drum-refacor
2021-08-30 14:12:52 +09:00
Dan Balasescu
7be825f470
Merge pull request #14488 from frenzibyte/multi-spectator-player-leaving
...
Gray out and stop player instances who quit during multi-spectator sessions
2021-08-30 12:04:19 +09:00
Salman Ahmed
6dc11543ad
Handle (null?) PP in PerformanceTable
2021-08-29 17:20:33 +03:00
Salman Ahmed
6aaef7b0be
Handle null PP during score set in TopScoreStatisticsSection
...
Supersedes #14562
Closes #14541
2021-08-29 17:19:17 +03:00
Salman Ahmed
8f3416d853
Assert PP not null when showPerformancePoints is true
2021-08-29 16:03:39 +03:00
Salman Ahmed
e374ef163d
Update localisable formattable extensions usages inline with framework change
2021-08-29 15:00:28 +03:00
Joseph Madamba
9a5445bded
Fix overlays closing when clicking any empty area of the toolbar instead
2021-08-28 22:25:13 -07:00
Joseph Madamba
38912bfc16
Fix floating overlays not closing when clicking some empty area of the toolbar
2021-08-28 20:38:35 -07:00
Bartłomiej Dach
2efe82a18d
Remove popover container from manual input manager test scene
2021-08-28 20:20:42 +02:00
Bartłomiej Dach
d9db1ecee9
Remove game-global popover container
2021-08-28 20:05:59 +02:00
Bartłomiej Dach
fcc3e57d5d
Move overlay colour provider up to editor screen
2021-08-28 20:05:58 +02:00
Bartłomiej Dach
e94d96f250
Add local popover container to editor screens
2021-08-28 20:05:58 +02:00
Bartłomiej Dach
7457480b50
Add local popover container to lounge subscreen
2021-08-28 20:05:58 +02:00
Bartłomiej Dach
7122f48568
Merge pull request #14552 from frenzibyte/fix-test-visibility-regression
...
Fix editor screen test scenes not updated to show their screens
2021-08-28 19:55:44 +02:00
Salman Ahmed
eb90cedc9b
Fix editor screen test scenes not updated to show their screens
2021-08-28 20:09:35 +03:00
Dean Herbert
6f03f7a6a6
Merge pull request #14534 from peppy/fix-tournament-startup-crash
...
Fix tournament client crashing at startup when osu!(stalble) is at ranking screen
2021-08-28 17:44:01 +09:00
Bartłomiej Dach
d37df6afec
Fix test failing after BDL -> [Test] change
2021-08-28 09:45:00 +02:00
Dean Herbert
b008a86d8c
Remove unused using statement
2021-08-28 16:35:54 +09:00
Dean Herbert
6ef096001e
Fix several cases of incorrect handling of CurrentMatch nullability
2021-08-28 16:24:36 +09:00
Dean Herbert
303c70791d
Add more failing test coverage for null CurrentMatch
2021-08-28 16:24:36 +09:00
Dean Herbert
e9b97f7937
Fix tournament crashing when osu!(stable) is at ranking screen at startup
2021-08-28 14:28:33 +09:00
Dean Herbert
7fbeb9ecc7
Add failing test coverage for tournament startup states
2021-08-28 14:28:30 +09:00
Salman Ahmed
589f2863ca
Move incompatibility tooltip logic to local player mod select overlays
...
This one turned out to be a bit more involved, due to tooltips being
shared and having the potential of being used somewhere where it
shouldn't be, due to the same content type matching.
That's the reason I've defined a protected `TargetContentType`, to be
able to separate "local player mod tooltips" and regular mod tooltips
apart.
Definitely unsure about the solution, but that's as far as I can think
of right now.
2021-08-28 02:38:46 +03:00
Salman Ahmed
e527bfd4bf
Move incompatibility icon logic to local player mod select overlays
2021-08-28 02:37:46 +03:00
Salman Ahmed
69f5705ca0
Merge pull request #14526 from peppy/update-framework
...
Update framework
2021-08-28 01:42:50 +03:00
Dean Herbert
681a87d4ec
Update framework
2021-08-28 07:08:06 +09:00
Dean Herbert
804ca88d63
Update framework
2021-08-27 19:52:45 +09:00
Salman Ahmed
378734a7f8
Separate solo spectator player and "exit on restart" logic to own class
2021-08-27 13:24:37 +03:00
Salman Ahmed
1650fbb8be
Add failing test steps
2021-08-27 13:24:37 +03:00
Dean Herbert
2bfb9d5478
Merge pull request #14512 from nekodex/lobby-sounds
...
Add sounds for some lobby events
2021-08-27 19:21:11 +09:00
Salman Ahmed
b7a0316194
Shorten test player count to 4 for less steps
2021-08-27 13:14:56 +03:00
Dean Herbert
97f27897b1
Add test coverage of mass multiplayer event firing
2021-08-27 18:57:35 +09:00
Dean Herbert
2b06dacd0e
Change debounce back to using scheduler
...
Should better allow for adjusting in the future, as well.
2021-08-27 18:57:19 +09:00
