Dean Herbert
|
29fed0c4a3
|
Avoid setting the source clock until gameplay is ready to start
Without this change, the audio track may audibly seek during load
proceedings.
|
2022-08-23 18:34:17 +09:00 |
|
Dean Herbert
|
ec61a94dc9
|
Merge branch 'master' into no-gameplay-clock-gameplay-offset
|
2022-08-23 17:36:06 +09:00 |
|
Dean Herbert
|
489e172a76
|
Simplify track start/stop/paused tracking
|
2022-08-22 19:43:18 +09:00 |
|
Dean Herbert
|
058d67f8e8
|
Merge pull request #19695 from naoei/ruleset-localization
Change most ruleset-accessible string types to Localisable strings
|
2022-08-22 16:13:23 +09:00 |
|
Dean Herbert
|
e6b669db8e
|
Elaborate with example of GameplayClockContainer managing its own Stop state
|
2022-08-22 14:14:44 +09:00 |
|
Dean Herbert
|
af2e82d7d5
|
Move operation of setting GameplayClockContainer.StartTime to Reset call
|
2022-08-22 14:11:06 +09:00 |
|
Nao
|
189a407cb1
|
Merge branch 'master' into ruleset-localization
|
2022-08-20 21:39:10 -04:00 |
|
Dean Herbert
|
8566e93c72
|
Guard against SubmittingPlayer potentially getting stuck waiting on request forever
|
2022-08-20 17:19:17 +09:00 |
|
Dean Herbert
|
7bf318541c
|
Reword comment to hopefully read better
|
2022-08-19 20:57:55 +09:00 |
|
Dean Herbert
|
3f0da14065
|
Delay start operation by one frame to allow children to see initial start time
|
2022-08-19 17:39:51 +09:00 |
|
Dean Herbert
|
3eb1cda6aa
|
Reorganise call order of Start / Reset to make more sense
|
2022-08-19 01:46:36 +09:00 |
|
Dean Herbert
|
1d774f3f12
|
Remove redundant ProcessFrame calls
Of note, I'm not sure whether the `IsPaused` check was meaningful, but
it's not reimplemented in the new `FramedBeatmapClock`.
|
2022-08-19 01:39:02 +09:00 |
|
Dean Herbert
|
7bc96431a7
|
Remove unnecessary virtual spec from GameplayClockContainer.Seek
|
2022-08-19 01:39:01 +09:00 |
|
Dean Herbert
|
43879633db
|
Ensure setting a StartTime on a GameplayClockContainer always resets to the new time
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
343efa1d11
|
Split OffsetCorrectionClock out of MasterGameplayClockContainer
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
2c6fd1ec6e
|
Fix `GameplayClockContainer potentially resetting external seeks
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
6003afafc7
|
Use FramedBeatmapClock in GameplayClockContainer
|
2022-08-18 18:54:10 +09:00 |
|
Dean Herbert
|
9735728cf6
|
Reverse conditionals to better define intent in addSourceClockAdjustments
|
2022-08-18 15:08:09 +09:00 |
|
Dean Herbert
|
20256aad11
|
Merge branch 'master' into no-gameplay-clock
|
2022-08-17 15:21:20 +09:00 |
|
Dean Herbert
|
63819648df
|
Fix up flow of actual skip operation
|
2022-08-16 14:40:02 +09:00 |
|
Dean Herbert
|
9a1a7bae89
|
Make test actually test things
|
2022-08-16 14:40:02 +09:00 |
|
Dean Herbert
|
6761f869f9
|
Modify flow to avoid weird bindable and value resetting
|
2022-08-16 14:17:35 +09:00 |
|
Dean Herbert
|
c9baadcf88
|
Merge branch 'master' into improve_retry_behaviour
|
2022-08-16 13:06:04 +09:00 |
|
Dean Herbert
|
61a8873266
|
Ensure GameplayClockContainer's FramedClock is always non-null
|
2022-08-15 20:22:36 +09:00 |
|
Dean Herbert
|
1696a905ba
|
Reduce exposed properties in GameplayClockContainer
|
2022-08-15 20:22:36 +09:00 |
|
Dean Herbert
|
704568ae3b
|
Remove remaining usage of GameplayClock
|
2022-08-15 20:22:36 +09:00 |
|
Dean Herbert
|
27569e2ed5
|
Remove FrameStableClock (and redirect usages to FrameStabilityContainer)
|
2022-08-15 19:19:19 +09:00 |
|
Dean Herbert
|
cc982d374c
|
Cache self rather than GameplayClock
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
c5f8529d20
|
Mark unused methods as NotImplemented for safety
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
f81c7644b4
|
Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
c8764cb333
|
Move all usage of GameplayClock to IGameplayClock
|
2022-08-15 18:30:53 +09:00 |
|
Dean Herbert
|
6d78218142
|
Update usages of GameplayClockContainer.GameplayClock to access properties directly
|
2022-08-15 18:08:49 +09:00 |
|
Dean Herbert
|
224f3eaa84
|
Make GameplayClockContainer non-abstract and use in MultiSpectatorPlayer
|
2022-08-15 18:08:49 +09:00 |
|
Dean Herbert
|
623e90a7b2
|
Fix div-by-zero in SongProgress when no object duration could be calculated
|
2022-08-15 15:05:35 +09:00 |
|
naoei
|
8cb2e11766
|
Change most ruleset-accessible string types to Localisable strings
|
2022-08-10 15:51:11 -04:00 |
|
Dean Herbert
|
a5081826b7
|
Handle cancellation at more points during Player initialisation
As discussed in discord, this will help avoid null references during
cancellation which can otherwise be quite confusing to debug.
|
2022-08-09 23:25:19 +09:00 |
|
BlauFx
|
0afa3a5ec8
|
Fix xml doc
|
2022-08-08 21:20:09 +02:00 |
|
BlauFx
|
f6e65cf1af
|
Improve implementation
|
2022-08-08 20:53:05 +02:00 |
|
BlauFx
|
fac2596eee
|
Change type from BindableBool to IBindable<bool>
|
2022-08-08 13:38:52 +02:00 |
|
BlauFx
|
cd68134565
|
Call skip method directly
|
2022-08-08 13:10:28 +02:00 |
|
BlauFx
|
bb344e064f
|
Add xml docs
|
2022-08-07 13:31:26 +02:00 |
|
BlauFx
|
09230304a4
|
Improve implementation
|
2022-08-07 13:20:29 +02:00 |
|
BlauFx
|
bd43a9e96e
|
Add missing type specification
|
2022-08-06 18:49:07 +02:00 |
|
BlauFx
|
fa6d55b5b5
|
Remove redundant lambda signature parentheses
|
2022-08-06 18:47:11 +02:00 |
|
BlauFx
|
0d418559bc
|
Skip song intro only in case of a quick restart
|
2022-08-06 17:02:45 +02:00 |
|
BlauFx
|
e411a2d187
|
Revert reduced wait time commit
|
2022-08-06 15:12:36 +02:00 |
|
BlauFx
|
445f921756
|
Move IsSkippable event into load method
|
2022-08-05 23:21:03 +02:00 |
|
BlauFx
|
d8d7423698
|
Reduce "wait time" in case restarting the map
|
2022-08-05 23:04:43 +02:00 |
|
BlauFx
|
99e07aa09a
|
Skip intro if the map gets restarted
|
2022-08-05 23:01:52 +02:00 |
|
BlauFx
|
6717f0606c
|
Add property to SkipOverlay
|
2022-08-05 23:00:37 +02:00 |
|