948 Commits

• fix near-zero length sliders n stuff being placeable
  OliBomby · 2023-12-19 21:20:21 +01:00
  ec578e1d9f
• Fix handling of combo offset without new combo, and incorrect lazer tests
  Dan Balasescu · 2023-11-24 09:46:06 +09:00
  10e16e4b04
• Merge branch 'master' into fix-combo-handling
  Dan Balasescu · 2023-11-23 16:22:01 +09:00
  7bc2d6e6cd
• Fix combo/combo colouring issues around spinners
  Dan Balasescu · 2023-11-23 13:54:05 +09:00
  7998204cfe
• Merge pull request #25415 from Poyo-SSB-forks/unify-ur

  Change unstable rate calculation to account for rate-change mods

  Dan Balasescu · 2023-11-23 09:53:28 +09:00
  30309cdf11
• Fix first object after break not starting a new combo
  Dan Balasescu · 2023-11-22 17:22:48 +09:00
  cb4568c4a1
• Improve commenting around IHasCombo interfaces

  Following discusion with smoogi IRL.

  Dean Herbert · 2023-11-22 10:44:29 +09:00
  04640b6fb0
• Use better fallback

  Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.

  Poyo · 2023-11-21 15:18:04 -08:00
  0cf925dadf
• Add ToString on PathType for better test output
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  4b2d8aa6a6
• Fix incorrect parsing of BSpline curve types
  Dean Herbert · 2023-11-21 15:38:12 +09:00
  3d094f84ad
• Adjust casing of curve type menu items

  The "Perfect curve" one in particular... fixes test failures, as some
  tests were relying on this particular casing. But the new version feels
  more correct anyway, so it's whatever.

  Bartłomiej Dach · 2023-11-20 15:42:55 +09:00
  8e39dbbff1
• Fix incorrect legacy conversion when B-splines are used
  Bartłomiej Dach · 2023-11-20 15:08:58 +09:00
  6d7d826b8b
• Use static BEZIER instead of allocating new every time
  Bartłomiej Dach · 2023-11-20 13:35:07 +09:00
  80a3225bb2
• Remove pattern matching syntax usage in switch

  Also throw on unknown types.

  Bartłomiej Dach · 2023-11-20 13:34:01 +09:00
  487326a4c7
• Decrease redundancy of equality implementations
  Bartłomiej Dach · 2023-11-20 12:28:20 +09:00
  7820c8ce4d
• Change switchexpr to standard switch statement
  Bartłomiej Dach · 2023-11-20 12:26:45 +09:00
  25c1a90047
• Move static instances / construction methods closer together
  Bartłomiej Dach · 2023-11-20 12:26:43 +09:00
  577cb9994c
• Use rate fallback in DrawableHitObject
  Poyo · 2023-11-18 12:09:37 -08:00
  d9cd546377
• Allow GameplayRate to be nullable and assert before use
  Poyo · 2023-11-15 17:00:35 -08:00
  a73c870712
• Fix control point hover text and context menu
  cs · 2023-11-15 07:45:09 +01:00
  520642975b
• Use soft-cast to access IGameplayClock
  Poyo · 2023-11-14 13:51:55 -08:00
  f5e1734de9
• Fix code style/quality issues
  cs · 2023-11-13 08:25:27 +01:00
  fa976a5aa0
• Allow gameplayClock to be null
  Poyo · 2023-11-12 13:29:40 -08:00
  f794d4dc83
• Use IGameplayClock for rate
  Poyo · 2023-11-12 12:14:19 -08:00
  e67725f5d6
• CI Fixup
  cs · 2023-11-11 15:02:06 +01:00
  54b8244a18
• Add free-hand drawing of sliders to the editor
  cs · 2023-11-11 13:33:25 +01:00
  3f85aa79c5
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Calculate unstable rate using rate-adjusted offsets
  Poyo · 2023-11-10 19:57:44 -08:00
  064857c40b
• Merge pull request #25185 from bdach/minimum-sample-volume
  Dean Herbert · 2023-10-24 22:04:43 +09:00
  34505b3933
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Fix fudge not being applied
  Dean Herbert · 2023-10-20 20:18:14 +09:00
  906b700aca
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Merge branch 'master' into legacy-tick-test-coverage
  Dan Balasescu · 2023-10-18 15:21:31 +09:00
  939b55020c
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Move validation to DHO.ApplyResult()
  Dan Balasescu · 2023-10-10 21:42:37 +09:00
  a1a46e58fc
• Add better commenting around legacy last tick edge case
  Dean Herbert · 2023-10-04 13:45:26 +09:00
  cfb18e18c0
• Document remaining pieces of LastTick and add back legacy prefix for generation flow
  Dean Herbert · 2023-09-29 16:58:17 +09:00
  62bcb62842
• Move LegacyLastTickOffset specification to generation code and stop passing everywhere
  Dean Herbert · 2023-09-29 14:32:29 +09:00
  81485c548c
• Merge branch 'master' into fix-slider-length
  Bartłomiej Dach · 2023-09-20 11:10:01 +02:00
  28da5baea4
• Merge pull request #24800 from sw1tchbl4d3r/invalid_bank

  Default to normal bank if invalid sample bank is specified

  Dean Herbert · 2023-09-19 22:28:34 +09:00
  aea7f81f1c
• Replace sample bank fix with more correct fix

  stable does not treat unknown enum members as `None` / `Auto`, it treats
  them as `Normal`:
  
      switch (sampleSet)
      {
          case SampleSet.Normal:
          default:
              sample = 0;
              break;
          case SampleSet.None:
          case SampleSet.Soft:
              sample = 1;
              break;
          case SampleSet.Drum:
              sample = 2;
              break;
      }
  
      (from https://github.com/peppy/osu-stable-reference/blob/1531237b63392e82c003c712faa028406073aa8f/osu!/Audio/AudioEngine.cs#L1158-L1171).

  Bartłomiej Dach · 2023-09-19 13:53:49 +02:00
  c4a0ca326e
• Check if path lists are empty
  Magnus-Cosmos · 2023-09-19 02:28:28 -04:00
  73db68a49a
• Fix slider path calculations for edge cases
  Magnus-Cosmos · 2023-09-19 01:31:26 -04:00
  a9b45c6fdc
• Fix extension check using control points instead of path points
  Magnus-Cosmos · 2023-09-18 11:40:00 -04:00
  83584519e6
• Make not extension method
  Dean Herbert · 2023-09-15 18:13:04 +09:00
  56cc2b62f0
• Move to extension method and throw on non-legacy ruleset
  Dean Herbert · 2023-09-15 17:38:34 +09:00
  0031da76ff
• Default to none bank if invalid samplebank is specified
  sw1tchbl4d3 · 2023-09-13 12:44:00 +02:00
  5b2af7f264
• Make rounding error even less precise

  Basically matching the old code more closely to avoid too much precision
  from doing math in a slightly different way.

  Dean Herbert · 2023-09-12 18:41:09 +09:00
  4ecc4632aa
• Remove all usage of LegacyDifficultyControlPoint
  Dean Herbert · 2023-09-07 17:41:57 +09:00
  b34a36f6ce
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28