Dean Herbert
9840a07eaf
Fix osu!mania hold notes playing a sound at their tail in the editor
...
Closes #29584 .
2024-08-27 14:06:02 +09:00
Nathan Du
1eb10e029c
Rewrite no release mod
...
Per the request of spaceman_atlas, the No Release mod is rewritten to
avoid modifications to DrawableHoldNoteTail. The approach is based
on that of the Strict Tracking mod for the osu!(standard) ruleset,
injecting the mod behavior by replacing the normal hold note with
the mod's variant. The variant inherits most bevaior from the normal
hold note, but when creating nested hitobjects, it creates its own
hold note tail variant instead, which in turn is used to instantiate
the mod's variant of DrawableHoldNoteTail with a new behavior.
The time a judgement is awarded is changed from the end of its
Perfect window to the time of the tail itself.
2024-07-01 20:29:30 +08:00
Dan Balasescu
9415fe4446
Add mania hold note body + combo break judgement
2023-10-09 09:47:00 +09:00
Dan Balasescu
c60f13dd92
Remove mania hold note ticks
2023-08-31 17:30:27 +09:00
ekrctb
11e1b22bf5
Move MaximumJudgementOffset to HitObject
...
We want to access this property for computing lifetime
2023-01-19 21:23:55 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
goodtrailer
4440b9ca11
Change IHasRepeats.NodeSamples to IList from List
2021-10-23 01:59:07 -07:00
Dean Herbert
a92d499d7a
Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
2021-10-01 16:55:50 +09:00
smoogipoo
5692cecaa4
Initial implementation of DHO pooling
2021-05-12 16:35:05 +09:00
smoogipoo
583760100a
Implement mania invert mod
2020-08-18 01:40:55 +09:00
Dean Herbert
cbd563e80b
Rename to IHasDuration
2020-05-27 12:38:39 +09:00
smoogipoo
4719fcc291
Actually use the cancellation token
2020-05-15 18:17:39 +09:00
smoogipoo
98125102a7
Add cancellation token support to CreateNestedHitObjects()
2020-05-15 18:07:41 +09:00
smoogipoo
6da0872ae5
Use the last node sample for the tail note
2020-04-22 09:06:04 +09:00
smoogipoo
d957614fc9
Cleanup handling of mania samples
2020-04-22 09:06:04 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Dean Herbert
cd6902a312
Make EndTime and RepeatCount settable
2020-02-05 17:52:51 +09:00
Dean Herbert
51bf600ea7
Use empty hitwindows instead of null
2019-10-09 19:08:31 +09:00
Dean Herbert
f925e781a9
Refactor HitWindows for legibility
2019-09-06 15:24:14 +09:00
smoogipoo
f3656475de
Return null hitwindows for non-time-based objects
2019-09-02 16:10:30 +09:00
Dean Herbert
0788a7e9f1
Merge branch 'master' into more-inspections
2019-02-28 14:32:57 +09:00
Dean Herbert
42be7857d1
Use expression body for property get/set where possible
2019-02-28 13:58:19 +09:00
Dean Herbert
26d53d06a9
Fix remaining issues
2019-02-28 13:31:40 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
smoogipoo
74a79bfcfa
Fix hold note head/tails not being nested hitobjects
2018-08-16 10:45:06 +09:00
smoogipoo
3a7488767c
Make HitObject not store the judgement
2018-08-06 11:50:18 +09:00
smoogipoo
2a4994e5ce
Make hitobjects only have one judgement + result
2018-08-03 15:38:48 +09:00
smoogipoo
807794d512
Make Rulesets.Mania use the new judgement result structure
2018-08-02 20:36:54 +09:00
smoogipoo
cd70e5e30b
Migrate Rulesets.Mania to the new judgement system
2018-08-02 16:44:01 +09:00
smoogipoo
43cdbec0a3
Fix hold note hitwindow lenience
2018-05-17 13:59:04 +09:00
smoogipoo
0cdd39b8b8
Add todo because TailNote shouldn't hardcore lenience
2018-05-11 15:32:13 +09:00
Dean Herbert
32a74f95a5
Normalize all the line endings
2018-04-13 18:26:38 +09:00
Aergwyn
ae1adfd2f2
remove unnecessary empty lines
...
codefactor.io \(o.o)/
also one unnecessary semicolon
2018-01-12 19:30:34 +01:00
Dean Herbert
37d393bca0
Update licence headers
2018-01-05 20:21:19 +09:00
smoogipoo
6a29f6020a
Make HitObjects construct nested hit objects
2017-12-22 21:42:54 +09:00
smoogipoo
ac1d27e925
Fix possible nullref exceptions
2017-12-21 23:02:46 +09:00
smoogipoo
cb7e192aff
Determine SampleInfo defaults in DrawableHitObject
2017-12-21 16:02:33 +09:00
smoogipooo
e8efdcf188
Make tick explosions white and lower scale.
2017-09-11 14:37:34 +09:00
smoogipooo
3026675f35
Add explosions.
2017-09-11 13:44:39 +09:00
Dean Herbert
fce580d717
Reshuffle namespaces
2017-07-26 13:22:46 +09:00
Dean Herbert
476526714d
Merge branch 'master' into mania-judgements
2017-05-29 21:31:48 +09:00
smoogipooo
e529ced131
Fix mania-specific beatmaps not setting samples correctly.
2017-05-29 16:18:01 +09:00
Dan Balasescu
0327adcba8
Update HoldNote.cs
2017-05-29 15:35:50 +09:00
smoogipooo
44f1d906ea
Store tick count locally, remove HoldNote TickCount.
2017-05-29 14:47:51 +09:00
smoogipooo
ab5e1bfc89
Add basic score calculations.
2017-05-26 19:56:50 +09:00
smoogipooo
47e1b7b389
Fix tick construction loop.
2017-05-26 16:28:39 +09:00
smoogipooo
c2d3b6c05a
Remove late initialization of head + tail, keep them updated with start time and end time.
2017-05-26 15:53:49 +09:00
smoogipooo
946cd4bfa3
General cleanup + more xmldocs.
2017-05-24 21:57:38 +09:00
smoogipooo
21cdee02f3
Get tickSpacing from beatmap.
2017-05-24 21:24:33 +09:00
smoogipooo
dcf879687d
Implement basic hold note + tick input.
2017-05-24 20:45:01 +09:00
