9126 Commits

• Simplify skin bindable flow

  Now, nothing touches the configuration apart from `OsuGame`, making
  everything else flow better and avoid weird cyclic set bugs.
  
  Closes https://github.com/ppy/osu/issues/20234.

  Dean Herbert · 2022-09-12 19:51:50 +09:00
  f31deaef7c
• Merge pull request #20259 from peppy/fix-changelog-crash

  Fix potential crash when opening changelog overlay if entry has no URL

  Dan Balasescu · 2022-09-12 19:47:21 +09:00
  5bd0be14ed
• Merge pull request #19066 from andy840119/remove-the-nullable-disable-in-the-ruleset

  Remove the nullable disable annotation in the ruleset class

  Dean Herbert · 2022-09-12 19:07:23 +09:00
  cb6d02ec3a
• Fix flinging a notification not correctly running Close
  Dean Herbert · 2022-09-12 19:00:03 +09:00
  d92e000fe6
• Don't play fling animation when activating a notification
  Dean Herbert · 2022-09-12 18:57:18 +09:00
  4ee3e8f087
• Fix potential crash when opening changelog overlay if entry has no URL
  Dean Herbert · 2022-09-12 17:51:15 +09:00
  58c1ea0321
• Don't trigger fling animation when Close is triggered by non-user action
  Dean Herbert · 2022-09-12 16:54:25 +09:00
  d561fcb126
• Use padding instead of FillFlow.Spacing to avoid artifact during animation
  Dean Herbert · 2022-09-12 16:46:45 +09:00
  5a02e1e713
• Make bounding box shrink faster to allow for rapid flinging
  Dean Herbert · 2022-09-12 16:39:46 +09:00
  a506178571
• Merge branch 'master' into mods-effect-displays
  Dan Balasescu · 2022-09-12 16:35:28 +09:00
  bcbc867694
• Merge branch 'master' into notification-dismiss
  Dean Herbert · 2022-09-12 16:27:41 +09:00
  931049aec1
• Fix being able to drag after already closing a notification
  Dean Herbert · 2022-09-12 16:25:32 +09:00
  bd3673baa9
• Merge branch 'master' into notification-fling
  Dean Herbert · 2022-09-12 16:19:36 +09:00
  8e6b2796eb
• Adjust movement to look less sudden when snapping back to Y=0
  Dean Herbert · 2022-09-12 15:37:48 +09:00
  2476cf8fb3
• Fix dragged state not being exposed correctly
  Dean Herbert · 2022-09-12 15:21:01 +09:00
  e06a0f7300
• Hide notification read light when in a toast state

  Also adds test coverage of read state and light.

  Dean Herbert · 2022-09-12 15:17:45 +09:00
  92beb6cbe7
• Move update icon to background to avoid colour collission with progress spinner
  Dean Herbert · 2022-09-12 14:58:46 +09:00
  60b0b909a5
• Disallow forwarding during a drag operation
  Dean Herbert · 2022-09-11 22:05:44 +09:00
  9ef23c79ce
• Ensure drag position is reset when transferred to tray
  Dean Herbert · 2022-09-11 22:03:29 +09:00
  a56cadcf90
• Disallow flinging when not in toast state
  Dean Herbert · 2022-09-11 21:47:45 +09:00
  b5a2f7003e
• Add basic fling-to-dismiss support
  Dean Herbert · 2022-09-11 21:32:22 +09:00
  d6f90e3b9f
• Rewrite DMD
  ansel · 2022-09-10 23:23:04 +03:00
  324a3723a5
• Expose counter to inheritors
  ansel · 2022-09-10 23:20:28 +03:00
  3f93ec8538
• Make effect display have a built-in counter
  ansel · 2022-09-10 23:18:48 +03:00
  667854b034
• Add test coverage of clicking close button to dismiss
  Dean Herbert · 2022-09-10 15:18:32 +09:00
  a9094c6b03
• Allow dismissing notifications without performing action using middle / right click
  Dean Herbert · 2022-09-10 15:10:37 +09:00
  efe3b1aa7b
• Remove generic and add default implementation for CalculateEffect
  ansel · 2022-09-10 08:34:29 +03:00
  b056cac10a
• Property should accept the nullable state.
  andy840119 · 2022-09-10 10:46:40 +08:00
  1398a7e11e
• Fix markdown container not rendering certain text correctly
  Salman Ahmed · 2022-09-10 02:55:20 +03:00
  5e4e3dfc2c
• Update IsDisplayingToasts to check the flow count directly
  Dean Herbert · 2022-09-06 17:30:24 +09:00
  6e52dbb266
• Fix completion notification not being posted if completion occurs during NotificationOverlay load
  Dean Herbert · 2022-09-06 04:07:49 +09:00
  9e3228aa65
• Avoid reference counting by using height calculation for IsPresent instead

  The reference counting was to guarantee performance (zero allocations)
  when the notification overlay was not required, but adds extra
  complexity.
  
  Instead, the toast tray now uses its ongoing height calculation as a
  metric for presence.

  Dean Herbert · 2022-09-05 19:38:09 +09:00
  510972e3ad
• Fix incorrect count tracking when notification is manually disposed
  Dean Herbert · 2022-09-05 19:26:40 +09:00
  0514c96191
• Fix notification overlay being present when it doesn't need to
  Dean Herbert · 2022-09-05 19:13:58 +09:00
  229e1a8ef7
• Remove necessity of AlwaysPresent for ProgressUpdate completion posting
  Dean Herbert · 2022-09-05 19:13:58 +09:00
  f754686521
• Centralise ability to fetch all toast tray notifications (including animating ones)
  Dean Herbert · 2022-09-05 18:42:20 +09:00
  0d4ee6bd80
• Fix completion notifications not always showing as toasts
  Dean Herbert · 2022-09-05 18:39:11 +09:00
  eca7b8f988
• Set all progress notifications to non-important
  Dean Herbert · 2022-09-05 18:29:35 +09:00
  4fa6707bf0
• Update new usages of Remove / RemoveInternal
  Dean Herbert · 2022-09-01 23:05:34 +09:00
  7eaa4c5ccd
• Merge branch 'master' into remove-dispose-updates
  Dean Herbert · 2022-09-01 23:03:19 +09:00
  6a35b233e5
• Merge branch 'master' into toast-notification-tray
  Dan Balasescu · 2022-08-31 16:07:11 +09:00
  afe2862df4
• Merge pull request #20030 from peppy/notification-design-update

  Update notification overlay design

  Dan Balasescu · 2022-08-31 16:06:59 +09:00
  ccc08b816c
• Update ProgressNotification font spec to match other notifications
  Dean Herbert · 2022-08-31 12:49:28 +09:00
  8b9ccc66b7
• Adjust dismiss button background colour to avoid conflict with background
  Dean Herbert · 2022-08-31 12:48:30 +09:00
  85442fe032
• Fix unread count potentially missing notifications in a transforming state
  Dean Herbert · 2022-08-31 12:46:43 +09:00
  7c72c6b43f
• Mark toasts as read when closing the overlay for added safety

  I'm not sure how the read status will play out going forward so I'm just
  adding this to keep things conforming for now.

  Dean Herbert · 2022-08-31 12:46:04 +09:00
  0558dae917
• Fix remaining test failures by strengthening PlayerLoader tests

  - Click using `TriggerClick` as notifications move around quite a bit.
  - Ensure any notifications from a previous test method are cleaned up.

  Dean Herbert · 2022-08-31 01:40:30 +09:00
  9eb615f942
• Update remaining test expectations with new behaviour
  Dean Herbert · 2022-08-31 00:57:30 +09:00
  31a9980686
• Remove notification blocking behaviour of first run setup
  Dean Herbert · 2022-08-31 00:57:18 +09:00
  a62ba9e0d9
• Improve forwarding flow to not use piling delegates
  Dean Herbert · 2022-08-31 00:40:53 +09:00
  ed11b1ba6f