8043 Commits

• Merge branch 'master' into mass-nrt
  Dean Herbert · 2023-06-24 09:59:15 +09:00
  2bda63c2c8
• Fix a couple of remaining issues
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  58e6b3782b
• Apply required nullability changes
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  3585c3f1d5
• Merge branch 'master' into tournament-chatcolor
  Salman Ahmed · 2023-06-23 22:23:33 +03:00
  c5771912db
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Merge branch 'master' into no-confirmation-on-update-restart
  Dean Herbert · 2023-06-23 15:33:01 +09:00
  1dc7c05c12
• Add test coverage of confirm-for-operations
  Dean Herbert · 2023-06-23 15:30:21 +09:00
  a76037b643
• Expose all notifications from INotificationOverlay

  Also fixes `HasOngoingOperations` not actually working.

  Dean Herbert · 2023-06-23 15:19:21 +09:00
  7fa07805b0
• Rename ExitConfirmOverlay to be more explicit about purpose
  Dean Herbert · 2023-06-23 14:46:38 +09:00
  6df617d536
• Move confirmation bypass implementation to MainMenu to allow for more correct logic
  Dean Herbert · 2023-06-23 14:42:56 +09:00
  11a97e1bb8
• Rename test helpers
  Bartłomiej Dach · 2023-06-22 23:10:16 +02:00
  2c1c20e0a7
• Rename and xmldoc members
  Bartłomiej Dach · 2023-06-22 23:00:52 +02:00
  786deec296
• add test for comment when logging in and out
  Liam DeVoe · 2023-06-21 02:17:51 -04:00
  6de7328fef
• fix cancel test for new button layout
  Liam DeVoe · 2023-06-21 02:15:02 -04:00
  dd4f271158
• Fix errors in tests due to mismatching NRT annotations
  Bartłomiej Dach · 2023-06-20 21:57:32 +02:00
  2f77675fe7
• Update test expectations
  Dean Herbert · 2023-06-20 21:02:34 +09:00
  92e89c7df7
• Use IGameplayClock to ensure our clock source is correct
  Dean Herbert · 2023-06-20 20:47:56 +09:00
  04dad6c6e8
• update CommentEditor test components
  Liam DeVoe · 2023-06-19 22:08:45 -04:00
  343052410b
• Merge branch 'master' into hud/kc-skinnable
  Ruki · 2023-06-18 18:30:44 +02:00
  9c6c6bf1ea
• Switch search box to initially unfocused

  Done primarily to keep mod hotkeys working without any behavioural
  changes when mod select is opened.

  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  75300ca229
• Merge branch 'master' into add-mod-search-option
  Bartłomiej Dach · 2023-06-18 15:06:21 +02:00
  9ba4bf5fb7
• Add failing test case for mod preset filtering not working after ruleset change
  Bartłomiej Dach · 2023-06-18 14:51:16 +02:00
  0b6c0592e4
• Reword/rename some stuff in test
  Bartłomiej Dach · 2023-06-18 14:24:35 +02:00
  b9156b1df3
• Do not use ?? true pattern

  Universally disliked. `!= false` is preferred.

  Bartłomiej Dach · 2023-06-18 14:19:38 +02:00
  76f509a1db
• Fix utterly broken test

  - Was on wrong ruleset, so the mod/free mod sets did literally nothing
  - `assertHasFreeModButton` had a param that did nothing
  - Was checking `MatchingFilter` rather than `Visible`

  Bartłomiej Dach · 2023-06-18 14:16:38 +02:00
  9758e5f840
• Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change

  See https://github.com/ppy/osu-framework/pull/5834

  Dean Herbert · 2023-06-18 20:57:32 +09:00
  eb31fdecee
• Fix beatmap info length tooltip not showing actual drain length
  Joseph Madamba · 2023-06-17 15:00:32 -07:00
  9ae864c219
• test: fix KeyCounterController not provided as a dependency
  tsrk · 2023-06-16 19:00:09 +02:00
  61101335cc
• test: change hideTarget drawable and testing logic

  Doesn't change what it needs to test conceptually

  tsrk · 2023-06-16 17:24:40 +02:00
  f9321a24d9
• Merge branch 'master' into hud/kc-skinnable
  Ruki · 2023-06-15 15:48:43 +02:00
  aba8219d06
• test: move back key counter tests in ctor
  tsrk · 2023-06-15 12:02:30 +02:00
  7e70598773
• Add failing test case
  Salman Ahmed · 2023-06-15 11:21:52 +03:00
  b9543f4fdd
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-14 22:19:45 +02:00
  42b740a175
• refactor: decouple Trigger logic from KeyCounterDisplay

  This allows to keep a coeherent state regardless of the progress of the play

  tsrk · 2023-06-14 21:13:35 +02:00
  c637fddf73
• test: remove hard usages of KeyCounterDisplay
  tsrk · 2023-06-14 13:25:24 +02:00
  758831b983
• fix test
  cdwcgt · 2023-06-14 01:32:27 +09:00
  51451bd53e
• allow custom username color for chatLine

  user's color (e.g. green for NAT) will be ignore

  cdwcgt · 2023-06-12 22:07:36 +09:00
  430938fbb2
• Merge branch 'master' into add-mod-search-option
  Cootz · 2023-06-12 13:09:09 +03:00
  aece548db1
• Add test to known time
  Dean Herbert · 2023-06-12 16:43:28 +09:00
  062fd58602
• Add ability to change background colour in song progress test scene
  Dean Herbert · 2023-06-12 16:22:40 +09:00
  c9f9569e4a
• Merge branch 'master' into add-mod-search-option
  Cootz · 2023-06-09 16:27:18 +03:00
  036479dd9d
• Apply NRT in MemoryCachingComponent test-only subclasses
  Bartłomiej Dach · 2023-06-09 13:48:42 +02:00
  58507291b9
• Merge branch 'master' into beat-divisor-better-defaults
  Bartłomiej Dach · 2023-06-08 20:35:03 +02:00
  4b3b22f046
• Update tests in line with new behaviour
  Dean Herbert · 2023-06-09 02:28:38 +09:00
  0875fc6233
• Merge pull request #23808 from peppy/working-beatmap-get-background

  Refactor `IWorkingBeatmap.Background` to `GetBackground()`

  Bartłomiej Dach · 2023-06-08 12:23:07 +02:00
  281aae91ec
• Refactor IWorkingBeatmap.Background to GetBackground()
  Dean Herbert · 2023-06-08 16:19:32 +09:00
  a842f79ad4
• Merge branch 'master' into fix-section-container-scroll-attempt-2
  Bartłomiej Dach · 2023-06-08 09:19:26 +02:00
  b3ce7f7b43
• Cover clamping to max beat divisor in test
  Bartłomiej Dach · 2023-06-07 23:38:06 +02:00
  35e41d816a
• Merge branch 'master' into beat-snap-divisor-hotkeys
  Bartłomiej Dach · 2023-06-07 23:38:03 +02:00
  9b665d2e1a